rubocop-minitest 0.20.1 → 0.22.0

data/docs/modules/ROOT/pages/index.adoc

@@ -1,5 +0,0 @@
-= RuboCop Minitest
-
-A https://github.com/rubocop/rubocop[RuboCop] extension focused on enforcing Minitest best practices and coding conventions.
-
-It's based on the community-driven https://minitest.rubystyle.guide[Minitest style guide].

data/docs/modules/ROOT/pages/installation.adoc

@@ -1,15 +0,0 @@
-= Installation
-
-Just install the `rubocop-minitest` gem
-
-[source,sh]
-----
-gem install rubocop-minitest
-----
-
-or if you use bundler put this in your `Gemfile`
-
-[source,ruby]
-----
-gem 'rubocop-minitest', require: false
-----

data/docs/modules/ROOT/pages/usage.adoc

@@ -1,32 +0,0 @@
-= Usage
-
-You need to tell RuboCop to load the Minitest extension. There are three
-ways to do this:
-
-== RuboCop configuration file
-
-Put this into your `.rubocop.yml`.
-
-[source,yaml]
-----
-require: rubocop-minitest
-----
-
-Now you can run `rubocop` and it will automatically load the RuboCop Minitest
-cops together with the standard cops.
-
-== Command line
-
-[source,sh]
-----
-rubocop --require rubocop-minitest
-----
-
-== Rake task
-
-[source,ruby]
-----
-RuboCop::RakeTask.new do |task|
-  task.requires << 'rubocop-minitest'
-end
-----

data/legacy-docs/cops.md

@@ -1,23 +0,0 @@
-<!-- START_COP_LIST -->
-#### Department [Minitest](cops_minitest.md)
-
-* [Minitest/AssertEmpty](cops_minitest.md#minitestassertempty)
-* [Minitest/AssertEmptyLiteral](cops_minitest.md#minitestassertemptyliteral)
-* [Minitest/AssertEqual](cops_minitest.md#minitestassertequal)
-* [Minitest/AssertIncludes](cops_minitest.md#minitestassertincludes)
-* [Minitest/AssertInstanceOf](cops_minitest.md#minitestassertinstanceof)
-* [Minitest/AssertMatch](cops_minitest.md#minitestassertmatch)
-* [Minitest/AssertNil](cops_minitest.md#minitestassertnil)
-* [Minitest/AssertRespondTo](cops_minitest.md#minitestassertrespondto)
-* [Minitest/AssertTruthy](cops_minitest.md#minitestasserttruthy)
-* [Minitest/GlobalExpectations](cops_minitest.md#minitestglobalexpectations)
-* [Minitest/RefuteEmpty](cops_minitest.md#minitestrefuteempty)
-* [Minitest/RefuteEqual](cops_minitest.md#minitestrefuteequal)
-* [Minitest/RefuteFalse](cops_minitest.md#minitestrefutefalse)
-* [Minitest/RefuteIncludes](cops_minitest.md#minitestrefuteincludes)
-* [Minitest/RefuteInstanceOf](cops_minitest.md#minitestrefuteinstanceof)
-* [Minitest/RefuteMatch](cops_minitest.md#minitestrefutematch)
-* [Minitest/RefuteNil](cops_minitest.md#minitestrefutenil)
-* [Minitest/RefuteRespondTo](cops_minitest.md#minitestrefuterespondto)
-
-<!-- END_COP_LIST -->

data/legacy-docs/cops_minitest.md

@@ -1,448 +0,0 @@
-# Minitest
-
-## Minitest/AssertEmpty
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.2 | -
-
-This cop enforces the test to use `assert_empty`
-instead of using `assert(object.empty?)`.
-
-### Examples
-
-```ruby
-# bad
-assert(object.empty?)
-assert(object.empty?, 'message')
-
-# good
-assert_empty(object)
-assert_empty(object, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-empty](https://github.com/rubocop/minitest-style-guide#assert-empty)
-
-## Minitest/AssertEmptyLiteral
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | No | 0.5 | -
-
-This cop enforces the test to use `assert_empty`
-instead of using `assert([], object)`.
-
-### Examples
-
-```ruby
-# bad
-assert([], object)
-assert({}, object)
-
-# good
-assert_empty(object)
-```
-
-## Minitest/AssertEqual
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.4 | -
-
-This cop enforces the use of `assert_equal(expected, actual)`
-over `assert(expected == actual)`.
-
-### Examples
-
-```ruby
-# bad
-assert("rubocop-minitest" == actual)
-
-# good
-assert_equal("rubocop-minitest", actual)
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-equal-arguments-order](https://github.com/rubocop/minitest-style-guide#assert-equal-arguments-order)
-
-## Minitest/AssertIncludes
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.2 | -
-
-This cop enforces the test to use `assert_includes`
-instead of using `assert(collection.include?(object))`.
-
-### Examples
-
-```ruby
-# bad
-assert(collection.include?(object))
-assert(collection.include?(object), 'message')
-
-# good
-assert_includes(collection, object)
-assert_includes(collection, object, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-includes](https://github.com/rubocop/minitest-style-guide#assert-includes)
-
-## Minitest/AssertInstanceOf
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.4 | -
-
-This cop enforces the test to use `assert_instance_of(Class, object)`
-over `assert(object.instance_of?(Class))`.
-
-### Examples
-
-```ruby
-# bad
-assert(object.instance_of?(Class))
-assert(object.instance_of?(Class), 'message')
-
-# good
-assert_instance_of(Class, object)
-assert_instance_of(Class, object, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-instance-of](https://github.com/rubocop/minitest-style-guide#assert-instance-of)
-
-## Minitest/AssertMatch
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.6 | -
-
-This cop enforces the test to use `assert_match`
-instead of using `assert(matcher.match(string))`.
-
-### Examples
-
-```ruby
-# bad
-assert(matcher.match(string))
-assert(matcher.match(string), 'message')
-
-# good
-assert_match(regex, string)
-assert_match(matcher, string, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-match](https://github.com/rubocop/minitest-style-guide#assert-match)
-
-## Minitest/AssertNil
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.1 | -
-
-This cop enforces the test to use `assert_nil`
-instead of using `assert_equal(nil, something)`.
-
-### Examples
-
-```ruby
-# bad
-assert_equal(nil, actual)
-assert_equal(nil, actual, 'message')
-
-# good
-assert_nil(actual)
-assert_nil(actual, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-nil](https://github.com/rubocop/minitest-style-guide#assert-nil)
-
-## Minitest/AssertRespondTo
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.3 | -
-
-This cop enforces the use of `assert_respond_to(object, :do_something)`
-over `assert(object.respond_to?(:do_something))`.
-
-### Examples
-
-```ruby
-# bad
-assert(object.respond_to?(:do_something))
-assert(object.respond_to?(:do_something), 'message')
-assert(respond_to?(:do_something))
-
-# good
-assert_respond_to(object, :do_something)
-assert_respond_to(object, :do_something, 'message')
-assert_respond_to(self, :do_something)
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-responds-to-method](https://github.com/rubocop/minitest-style-guide#assert-responds-to-method)
-
-## Minitest/AssertTruthy
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.2 | -
-
-This cop enforces the test to use `assert(actual)`
-instead of using `assert_equal(true, actual)`.
-
-### Examples
-
-```ruby
-# bad
-assert_equal(true, actual)
-assert_equal(true, actual, 'message')
-
-# good
-assert(actual)
-assert(actual, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#assert-truthy](https://github.com/rubocop/minitest-style-guide#assert-truthy)
-
-## Minitest/GlobalExpectations
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.7 | -
-
-This cop checks for deprecated global expectations
-and autocorrects them to use expect format.
-
-### Examples
-
-```ruby
-# bad
-musts.must_equal expected_musts
-wonts.wont_match expected_wonts
-musts.must_raise TypeError
-
-# good
-_(musts).must_equal expected_musts
-_(wonts).wont_match expected_wonts
-_ { musts }.must_raise TypeError
-```
-
-## Minitest/RefuteEmpty
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.3 | -
-
-This cop enforces to use `refute_empty` instead of
-using `refute(object.empty?)`.
-
-### Examples
-
-```ruby
-# bad
-refute(object.empty?)
-refute(object.empty?, 'message')
-
-# good
-refute_empty(object)
-refute_empty(object, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-empty](https://github.com/rubocop/minitest-style-guide#refute-empty)
-
-## Minitest/RefuteEqual
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.3 | -
-
-This cop enforces the use of `refute_equal(expected, object)`
-over `assert_equal(expected != actual)` or `assert(! expected == actual)`.
-
-### Examples
-
-```ruby
-# bad
-assert("rubocop-minitest" != actual)
-assert(! "rubocop-minitest" == actual)
-
-# good
-refute_equal("rubocop-minitest", actual)
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-equal](https://github.com/rubocop/minitest-style-guide#refute-equal)
-
-## Minitest/RefuteFalse
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.3 | -
-
-This cop enforces the use of `refute(object)`
-over `assert_equal(false, object)`.
-
-### Examples
-
-```ruby
-# bad
-assert_equal(false, actual)
-assert_equal(false, actual, 'message')
-
-assert(!test)
-assert(!test, 'message')
-
-# good
-refute(actual)
-refute(actual, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-false](https://github.com/rubocop/minitest-style-guide#refute-false)
-
-## Minitest/RefuteIncludes
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.3 | -
-
-This cop enforces the test to use `refute_includes`
-instead of using `refute(collection.include?(object))`.
-
-### Examples
-
-```ruby
-# bad
-refute(collection.include?(object))
-refute(collection.include?(object), 'message')
-
-# good
-refute_includes(collection, object)
-refute_includes(collection, object, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-includes](https://github.com/rubocop/minitest-style-guide#refute-includes)
-
-## Minitest/RefuteInstanceOf
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.4 | -
-
-This cop enforces the use of `refute_instance_of(Class, object)`
-over `refute(object.instance_of?(Class))`.
-
-### Examples
-
-```ruby
-# bad
-refute(object.instance_of?(Class))
-refute(object.instance_of?(Class), 'message')
-
-# good
-refute_instance_of(Class, object)
-refute_instance_of(Class, object, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-instance-of](https://github.com/rubocop/minitest-style-guide#refute-instance-of)
-
-## Minitest/RefuteMatch
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.6 | -
-
-This cop enforces the test to use `refute_match`
-instead of using `refute(matcher.match(string))`.
-
-### Examples
-
-```ruby
-# bad
-refute(matcher.match(string))
-refute(matcher.match(string), 'message')
-
-# good
-refute_match(matcher, string)
-refute_match(matcher, string, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-match](https://github.com/rubocop/minitest-style-guide#refute-match)
-
-## Minitest/RefuteNil
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.2 | -
-
-This cop enforces the test to use `refute_nil`
-instead of using `refute_equal(nil, something)`.
-
-### Examples
-
-```ruby
-# bad
-refute_equal(nil, actual)
-refute_equal(nil, actual, 'message')
-
-# good
-refute_nil(actual)
-refute_nil(actual, 'message')
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-nil](https://github.com/rubocop/minitest-style-guide#refute-nil)
-
-## Minitest/RefuteRespondTo
-
-Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
---- | --- | --- | --- | ---
-Enabled | Yes | Yes  | 0.4 | -
-
-This cop enforces the test to use `refute_respond_to(object, :do_something)`
-over `refute(object.respond_to?(:do_something))`.
-
-### Examples
-
-```ruby
-# bad
-refute(object.respond_to?(:do_something))
-refute(object.respond_to?(:do_something), 'message')
-refute(respond_to?(:do_something))
-
-# good
-refute_respond_to(object, :do_something)
-refute_respond_to(object, :do_something, 'message')
-refute_respond_to(self, :do_something)
-```
-
-### References
-
-* [https://github.com/rubocop/minitest-style-guide#refute-respond-to](https://github.com/rubocop/minitest-style-guide#refute-respond-to)

data/legacy-docs/index.md

@@ -1 +0,0 @@
-A [RuboCop](https://github.com/rubocop/rubocop) extension focused on enforcing Minitest best practices and coding conventions.

data/legacy-docs/installation.md

@@ -1,11 +0,0 @@
-Just install the `rubocop-minitest` gem
-
-```sh
-gem install rubocop-minitest
-```
-
-or if you use bundler put this in your `Gemfile`
-
-```ruby
-gem 'rubocop-minitest'
-```

data/legacy-docs/usage.md

@@ -1,27 +0,0 @@
-You need to tell RuboCop to load the Minitest extension. There are three
-ways to do this:
-
-### RuboCop configuration file
-
-Put this into your `.rubocop.yml`.
-
-```yaml
-require: rubocop-minitest
-```
-
-Now you can run `rubocop` and it will automatically load the RuboCop Minitest
-cops together with the standard cops.
-
-### Command line
-
-```sh
-rubocop --require rubocop-minitest
-```
-
-### Rake task
-
-```ruby
-RuboCop::RakeTask.new do |task|
-  task.requires << 'rubocop-minitest'
-end
-```

data/mkdocs.yml

@@ -1,13 +0,0 @@
-site_name: "A RuboCop extension focused on enforcing Minitest best practices and coding conventions."
-repo_url: https://github.com/rubocop/rubocop-minitest
-edit_uri: edit/master/legacy-docs/
-copyright: "Copyright © 2022 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO, and RuboCop contributors"
-docs_dir: legacy-docs
-pages:
-  - Home: index.md
-  - Installation: installation.md
-  - Usage: usage.md
-  - Cops: cops.md
-  - Cops Documentation:
-      - Minitest Cops: cops_minitest.md
-theme: readthedocs

data/readthedocs.yml

@@ -1,5 +0,0 @@
-build:
-    image: stable
-
-formats:
-    - htmlzip

data/relnotes/v0.1.0.md

@@ -1,7 +0,0 @@
-### New features
-
-* Create RuboCop Minitest gem. ([@koic][])
-* [#6](https://github.com/rubocop/rubocop-minitest/pull/6): Add new `Minitest/AssertNil` cop. ([@duduribeiro ][])
-
-[@koic]: https://github.com/koic
-[@duduribeiro]: https://github.com/duduribeiro

data/relnotes/v0.10.0.md

@@ -1,21 +0,0 @@
-### New features
-
-* [#92](https://github.com/rubocop/rubocop-minitest/pull/92): Add new `Minitest/LiteralAsActualArgument` cop. ([@fatkodima][], [@tsmmark][])
-* [#95](https://github.com/rubocop/rubocop-minitest/pull/95): Add new `Minitest/AssertionInLifecycleHook` cop. ([@fatkodima][])
-* [#91](https://github.com/rubocop/rubocop-minitest/pull/91): Add new `Minitest/AssertInDelta` and `Minitest/RefuteInDelta` cops. ([@fatkodima][])
-* [#89](https://github.com/rubocop/rubocop-minitest/pull/89): Add new `Minitest/TestMethodName` cop. ([@fatkodima][])
-* [#83](https://github.com/rubocop/rubocop-minitest/pull/83): New cops `AssertPathExists` and `RefutePathExists` check for use of `assert_path_exists`/`refute_path_exists` instead of `assert(File.exist?(path))`/`refute(File.exist?(path))`. ([@fatkodima][])
-* [#88](https://github.com/rubocop/rubocop-minitest/pull/88): Add new `Minitest/MultipleAssertions` cop. ([@fatkodima][])
-* [#87](https://github.com/rubocop/rubocop-minitest/pull/87): Add new `Minitest/AssertSilent` cop. ([@fatkodima][])
-* [#96](https://github.com/rubocop/rubocop-minitest/pull/96): Add new `Minitest/UnspecifiedException` cop. ([@fatkodima][])
-* [#98](https://github.com/rubocop/rubocop-minitest/pull/98): Add new `Minitest/AssertOutput` cop. ([@fatkodima][])
-* [#84](https://github.com/rubocop/rubocop-minitest/pull/84): New cops `AssertKindOf` and `RefuteKindOf` check for use of `assert_kind_of`/`refute_kind_of` instead of `assert(foo.kind_of?(Class))`/`refute(foo.kind_of?(Class))`. ([@fatkodima][])
-* [#85](https://github.com/rubocop/rubocop-minitest/pull/85): Add autocorrect to `Rails/AssertEmptyLiteral` cop. ([@fatkodima][])
-
-### Changes
-
-* [#104](https://github.com/rubocop/rubocop-minitest/pull/104): Require RuboCop 0.87 or higher. ([@koic][])
-
-[@fatkodima]: https://github.com/fatkodima
-[@tsmmark]: https://github.com/tsmmark
-[@koic]: https://github.com/koic

data/relnotes/v0.10.1.md

@@ -1,5 +0,0 @@
-### Bug fixes
-
-* [#106](https://github.com/rubocop/rubocop-minitest/issues/106): Fix an error for `Minitest/AssertOutput` when using gvar at top level. ([@koic][])
-
-[@koic]: https://github.com/koic

data/relnotes/v0.10.2.md

@@ -1,5 +0,0 @@
-### Bug fixes
-
-* [#113](https://github.com/rubocop/rubocop-minitest/issues/113): This PR fixes an error for `Minitest/AssertEqual` and some cops when using `assert` with block argument. ([@koic][])
-
-[@koic]: https://github.com/koic

data/relnotes/v0.10.3.md

@@ -1,5 +0,0 @@
-### Bug fixes
-
-* [#115](https://github.com/rubocop/rubocop-minitest/issues/115): Fix a false positive for `Minitest/TestMethodName` for when defining test method has an argument, and test method without assertion methods. ([@koic][])
-
-[@koic]: https://github.com/koic

data/relnotes/v0.11.0.md

@@ -1,16 +0,0 @@
-### New features
-
-* [#117](https://github.com/rubocop/rubocop-minitest/issues/117): Add new cop `Minitest/AssertWithExpectedArgument` to check for unintended usages of `assert` instead of `assert_equal`. ([@cstyles][])
-
-### Bug fixes
-
-* [#122](https://github.com/rubocop/rubocop-minitest/pull/122): Fix `Minitest/TestMethodName` for tests with multiple assertions. ([@ghiculescu][])
-
-### Changes
-
-* [#118](https://github.com/rubocop/rubocop-minitest/pull/118): **(BREAKING)** Fix `Minitest/AssertEmptyLiteral` by making it check for `assert_equal([], array)` instead of `assert([], array)`. ([@cstyles][])
-* [#125](https://github.com/rubocop/rubocop-minitest/pull/125): Require RuboCop 0.90 or higher. ([@koic][])
-
-[@cstyles]: https://github.com/cstyles
-[@ghiculescu]: https://github.com/ghiculescu
-[@koic]: https://github.com/koic

data/relnotes/v0.11.1.md

@@ -1,5 +0,0 @@
-### Changes
-
-* [#126](https://github.com/rubocop/rubocop-minitest/issues/126): Mark `Minitest/AssertWithExpectedArgument` as unsafe. ([@koic][])
-
-[@koic]: https://github.com/koic

data/relnotes/v0.12.0.md

@@ -1,10 +0,0 @@
-### New features
-
-* [#124](https://github.com/rubocop/rubocop-minitest/pull/124): Add new `Minitest/NoAssertions` cop. ([@ghiculescu][])
-
-### Changes
-
-* [#129](https://github.com/rubocop/rubocop-minitest/pull/129): **(Compatibility)** Drop Ruby 2.4 support. ([@koic][])
-
-[@ghiculescu]: https://github.com/ghiculescu
-[@koic]: https://github.com/koic

data/relnotes/v0.12.1.md

@@ -1,5 +0,0 @@
-### Bug fixes
-
-* [#131](https://github.com/rubocop/rubocop-minitest/issues/131): Fix an error for `Minitest/MultipleAssertions` and fixes a false positive for `test` block. ([@koic][])
-
-[@koic]: https://github.com/koic

data/relnotes/v0.13.0.md

@@ -1,5 +0,0 @@
-### New features
-
-* [#136](https://github.com/rubocop/rubocop-minitest/pull/136): Support Active Support's `test` method for `Minitest/MultipleAssertions` and `Minitest/NoAssertions` cops. ([@koic][])
-
-[@koic]: https://github.com/koic