rubocop-minitest 0.20.0 → 0.20.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c35365ef5838d4a75f01181865e860ecb774a73288a310ffe2bfec21b6c6001
-  data.tar.gz: ccbdb0bb831bcebec0cde35263bf90063e400a25d97bccb9facf3edbc0bbd23a
+  metadata.gz: d780d9c08b215f247a19ffc039d8385b58f63037585c882e3b760cdbe511ae14
+  data.tar.gz: 1ea02089d0b9a3511cbc19a3222f3c55e86a3c17d05bdc05291281df8115500a
 SHA512:
-  metadata.gz: 0a85bb1c4f0226eb025cdf18ae72757403ea71b422b19291e80bf696c95735cb2ddd3f61f921ad01c04c88ef731aa3e39d68141ac8971315e5933575cab6ec8c
-  data.tar.gz: b449004eb3a26c8996490d5e5008e784f10660edba75e99a7b3d5ef317d6c4585757aee59e7c95fb7100d892a2769c88bf26f42ac96684488945a5e9ee775155
+  metadata.gz: 241d069163e52ba35fc4edb2c96d3f7fca6a32fa84ced1feee2abf777d42561503b309371444b81da318c3f07bce469a89e12fc2f6d0295372c3249c41db1ff1
+  data.tar.gz: 76ec782b3a226848f6676266dfbd1f06dc0cf2bbd999f01f9c46096def25cfe188c7dddb95ca93ab737812ef6eae81fd8401872b8a243344e1903c50143a699c

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master (unreleased)
 
+## 0.20.1 (2022-06-13)
+
+### Bug fixes
+
+* [#175](https://github.com/rubocop/rubocop-minitest/pull/175): Fix raise error when using assert with block. ([@ippachi][])
+
 ## 0.20.0 (2022-05-29)
 
 ### New features
@@ -314,3 +320,4 @@
 [@gi]: https://github.com/gi
 [@ignacio-chiazzo]: https://github.com/ignacio-chiazzo
 [@gjtorikian]: https://github.com/gjtorikian
+[@ippachi]: https://github.com/ippachi

data/docs/modules/ROOT/pages/cops_minitest.adoc

@@ -619,7 +619,7 @@ and autocorrects them to use expect format.
 
 === Examples
 
-==== EnforcedStyle: _
+==== EnforcedStyle: any (default)
 
 [source,ruby]
 ----
@@ -628,6 +628,11 @@ musts.must_equal expected_musts
 wonts.wont_match expected_wonts
 musts.must_raise TypeError
 
+# good
+_(musts).must_equal expected_musts
+_(wonts).wont_match expected_wonts
+_ { musts }.must_raise TypeError
+
 expect(musts).must_equal expected_musts
 expect(wonts).wont_match expected_wonts
 expect { musts }.must_raise TypeError
@@ -635,14 +640,9 @@ expect { musts }.must_raise TypeError
 value(musts).must_equal expected_musts
 value(wonts).wont_match expected_wonts
 value { musts }.must_raise TypeError
-
-# good
-_(musts).must_equal expected_musts
-_(wonts).wont_match expected_wonts
-_ { musts }.must_raise TypeError
 ----
 
-==== EnforcedStyle: any (default)
+==== EnforcedStyle: _
 
 [source,ruby]
 ----
@@ -651,11 +651,6 @@ musts.must_equal expected_musts
 wonts.wont_match expected_wonts
 musts.must_raise TypeError
 
-# good
-_(musts).must_equal expected_musts
-_(wonts).wont_match expected_wonts
-_ { musts }.must_raise TypeError
-
 expect(musts).must_equal expected_musts
 expect(wonts).wont_match expected_wonts
 expect { musts }.must_raise TypeError
@@ -663,6 +658,11 @@ expect { musts }.must_raise TypeError
 value(musts).must_equal expected_musts
 value(wonts).wont_match expected_wonts
 value { musts }.must_raise TypeError
+
+# good
+_(musts).must_equal expected_musts
+_(wonts).wont_match expected_wonts
+_ { musts }.must_raise TypeError
 ----
 
 ==== EnforcedStyle: expect

data/lib/rubocop/cop/minitest/global_expectations.rb

@@ -6,12 +6,17 @@ module RuboCop
       # Checks for deprecated global expectations
       # and autocorrects them to use expect format.
       #
-      # @example EnforcedStyle: _
+      # @example EnforcedStyle: any (default)
       #   # bad
       #   musts.must_equal expected_musts
       #   wonts.wont_match expected_wonts
       #   musts.must_raise TypeError
       #
+      #   # good
+      #   _(musts).must_equal expected_musts
+      #   _(wonts).wont_match expected_wonts
+      #   _ { musts }.must_raise TypeError
+      #
       #   expect(musts).must_equal expected_musts
       #   expect(wonts).wont_match expected_wonts
       #   expect { musts }.must_raise TypeError
@@ -20,22 +25,12 @@ module RuboCop
       #   value(wonts).wont_match expected_wonts
       #   value { musts }.must_raise TypeError
       #
-      #   # good
-      #   _(musts).must_equal expected_musts
-      #   _(wonts).wont_match expected_wonts
-      #   _ { musts }.must_raise TypeError
-      #
-      # @example EnforcedStyle: any (default)
+      # @example EnforcedStyle: _
       #   # bad
       #   musts.must_equal expected_musts
       #   wonts.wont_match expected_wonts
       #   musts.must_raise TypeError
       #
-      #   # good
-      #   _(musts).must_equal expected_musts
-      #   _(wonts).wont_match expected_wonts
-      #   _ { musts }.must_raise TypeError
-      #
       #   expect(musts).must_equal expected_musts
       #   expect(wonts).wont_match expected_wonts
       #   expect { musts }.must_raise TypeError
@@ -44,6 +39,11 @@ module RuboCop
       #   value(wonts).wont_match expected_wonts
       #   value { musts }.must_raise TypeError
       #
+      #   # good
+      #   _(musts).must_equal expected_musts
+      #   _(wonts).wont_match expected_wonts
+      #   _ { musts }.must_raise TypeError
+      #
       # @example EnforcedStyle: expect
       #   # bad
       #   musts.must_equal expected_musts

data/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb

@@ -13,8 +13,9 @@ module RuboCop
 
           first_argument = arguments.first
 
+          return unless first_argument
           return if first_argument.block_type? || first_argument.numblock_type?
-          return unless first_argument.respond_to?(:predicate_method?) && first_argument.predicate_method?
+          return unless predicate_method?(first_argument)
           return unless first_argument.arguments.count.zero?
 
           add_offense(node, message: offense_message(arguments)) do |corrector|
@@ -38,6 +39,10 @@ module RuboCop
           peel_redundant_parentheses_from(arguments.first.children)
         end
 
+        def predicate_method?(first_argument)
+          first_argument.respond_to?(:predicate_method?) && first_argument.predicate_method?
+        end
+
         def offense_message(arguments)
           message_argument = arguments.last if arguments.first != arguments.last
 

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.20.0'
+      STRING = '0.20.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/relnotes/v0.20.1.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#175](https://github.com/rubocop/rubocop-minitest/pull/175): Fix raise error when using assert with block. ([@ippachi][])
+
+[@ippachi]: https://github.com/ippachi

data/tasks/cut_release.rake

@@ -39,7 +39,7 @@ namespace :cut_release do
 
     File.open('docs/antora.yml', 'w') do |f|
       f << antora_metadata.sub(
-        "version: 'master'",
+        'version: ~',
         "version: '#{version_sans_patch(new_version)}'"
       )
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.20.0
+  version: 0.20.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-05-28 00:00:00.000000000 Z
+date: 2022-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -167,6 +167,7 @@ files:
 - relnotes/v0.2.0.md
 - relnotes/v0.2.1.md
 - relnotes/v0.20.0.md
+- relnotes/v0.20.1.md
 - relnotes/v0.3.0.md
 - relnotes/v0.4.0.md
 - relnotes/v0.4.1.md