rubocop-minitest 0.2.0 → 0.5.0

data/lib/rubocop/minitest/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Minitest
-    VERSION = '0.2.0'
+    VERSION = '0.5.0'
   end
 end

data/manual/cops.md

@@ -2,9 +2,19 @@
 #### Department [Minitest](cops_minitest.md)
 
 * [Minitest/AssertEmpty](cops_minitest.md#minitestassertempty)
+* [Minitest/AssertEmptyLiteral](cops_minitest.md#minitestassertemptyliteral)
+* [Minitest/AssertEqual](cops_minitest.md#minitestassertequal)
 * [Minitest/AssertIncludes](cops_minitest.md#minitestassertincludes)
+* [Minitest/AssertInstanceOf](cops_minitest.md#minitestassertinstanceof)
 * [Minitest/AssertNil](cops_minitest.md#minitestassertnil)
+* [Minitest/AssertRespondTo](cops_minitest.md#minitestassertrespondto)
 * [Minitest/AssertTruthy](cops_minitest.md#minitestasserttruthy)
+* [Minitest/RefuteEmpty](cops_minitest.md#minitestrefuteempty)
+* [Minitest/RefuteEqual](cops_minitest.md#minitestrefuteequal)
+* [Minitest/RefuteFalse](cops_minitest.md#minitestrefutefalse)
+* [Minitest/RefuteIncludes](cops_minitest.md#minitestrefuteincludes)
+* [Minitest/RefuteInstanceOf](cops_minitest.md#minitestrefuteinstanceof)
 * [Minitest/RefuteNil](cops_minitest.md#minitestrefutenil)
+* [Minitest/RefuteRespondTo](cops_minitest.md#minitestrefuterespondto)
 
 <!-- END_COP_LIST -->

data/manual/cops_minitest.md

@@ -6,56 +6,126 @@ Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChan
 --- | --- | --- | --- | ---
 Enabled | Yes | Yes  | 0.2 | -
 
-Check if your test uses `assert_empty` instead of `assert(actual.empty?)`.
+This cop enforces the test to use `assert_empty`
+instead of using `assert(object.empty?)`.
 
 ### Examples
 
 ```ruby
 # bad
-assert(actual.empty?)
-assert(actual.empty?, 'the message')
+assert(object.empty?)
+assert(object.empty?, 'the message')
 
 # good
-assert_empty(actual)
-assert_empty(actual, 'the message')
+assert_empty(object)
+assert_empty(object, 'the message')
 ```
 
 ### References
 
 * [https://github.com/rubocop-hq/minitest-style-guide#assert-empty](https://github.com/rubocop-hq/minitest-style-guide#assert-empty)
 
+## Minitest/AssertEmptyLiteral
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | No | 0.5 | -
+
+This cop enforces the test to use `assert_empty`
+instead of using `assert([], object)`.
+
+### Examples
+
+```ruby
+# bad
+assert([], object)
+assert({}, object)
+
+# good
+assert_empty(object)
+```
+
+## Minitest/AssertEqual
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.4 | -
+
+This cop enforces the use of `assert_equal(expected, actual)`
+over `assert(expected == actual)`.
+
+### Examples
+
+```ruby
+# bad
+assert("rubocop-minitest" == actual)
+
+# good
+assert_equal("rubocop-minitest", actual)
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#assert-equal-arguments-order](https://github.com/rubocop-hq/minitest-style-guide#assert-equal-arguments-order)
+
 ## Minitest/AssertIncludes
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 --- | --- | --- | --- | ---
 Enabled | Yes | Yes  | 0.2 | -
 
-Check if your test uses `assert_includes`
-instead of `assert(collection.includes?(actual))`.
+This cop enforces the test to use `assert_includes`
+instead of using `assert(collection.include?(object))`.
 
 ### Examples
 
 ```ruby
 # bad
-assert(collection.includes?(actual))
-assert(collection.includes?(actual), 'the message')
+assert(collection.include?(object))
+assert(collection.include?(object), 'the message')
 
 # good
-assert_includes(collection, actual)
-assert_includes(collection, actual, 'the message')
+assert_includes(collection, object)
+assert_includes(collection, object, 'the message')
 ```
 
 ### References
 
 * [https://github.com/rubocop-hq/minitest-style-guide#assert-includes](https://github.com/rubocop-hq/minitest-style-guide#assert-includes)
 
+## Minitest/AssertInstanceOf
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.4 | -
+
+This cop enforces the test to use `assert_instance_of(Class, object)`
+over `assert(object.instance_of?(Class))`.
+
+### Examples
+
+```ruby
+# bad
+assert(object.instance_of?(Class))
+assert(object.instance_of?(Class), 'the message')
+
+# good
+assert_instance_of(Class, object)
+assert_instance_of(Class, object, 'the message')
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#assert-instance-of](https://github.com/rubocop-hq/minitest-style-guide#assert-instance-of)
+
 ## Minitest/AssertNil
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 --- | --- | --- | --- | ---
 Enabled | Yes | Yes  | 0.1 | -
 
-Check if your test uses `assert_nil` instead of `assert_equal(nil, something)`.
+This cop enforces the test to use `assert_nil`
+instead of using `assert_equal(nil, something)`.
 
 ### Examples
 
@@ -73,14 +143,41 @@ assert_nil(actual, 'the message')
 
 * [https://github.com/rubocop-hq/minitest-style-guide#assert-nil](https://github.com/rubocop-hq/minitest-style-guide#assert-nil)
 
+## Minitest/AssertRespondTo
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.3 | -
+
+This cop enforces the use of `assert_respond_to(object, :some_method)`
+over `assert(object.respond_to?(:some_method))`.
+
+### Examples
+
+```ruby
+# bad
+assert(object.respond_to?(:some_method))
+assert(object.respond_to?(:some_method), 'the message')
+assert(respond_to?(:some_method))
+
+# good
+assert_respond_to(object, :some_method)
+assert_respond_to(object, :some_method, 'the message')
+assert_respond_to(self, some_method)
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#assert-responds-to-method](https://github.com/rubocop-hq/minitest-style-guide#assert-responds-to-method)
+
 ## Minitest/AssertTruthy
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 --- | --- | --- | --- | ---
 Enabled | Yes | Yes  | 0.2 | -
 
-Check if your test uses `assert(actual)`
-instead of `assert_equal(true, actual)`.
+This cop enforces the test to use `assert(actual)`
+instead of using `assert_equal(true, actual)`.
 
 ### Examples
 
@@ -98,13 +195,138 @@ assert(actual, 'the message')
 
 * [https://github.com/rubocop-hq/minitest-style-guide#assert-truthy](https://github.com/rubocop-hq/minitest-style-guide#assert-truthy)
 
+## Minitest/RefuteEmpty
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.3 | -
+
+This cop enforces to use `refute_empty` instead of
+using `refute(object.empty?)`.
+
+### Examples
+
+```ruby
+# bad
+refute(object.empty?)
+refute(object.empty?, 'the message')
+
+# good
+refute_empty(object)
+refute_empty(object, 'the message')
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#refute-empty](https://github.com/rubocop-hq/minitest-style-guide#refute-empty)
+
+## Minitest/RefuteEqual
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.3 | -
+
+This cop enforces the use of `refute_equal(expected, object)`
+over `assert_equal(expected != actual)` or `assert(! expected == actual)`.
+
+### Examples
+
+```ruby
+# bad
+assert("rubocop-minitest" != actual)
+assert(! "rubocop-minitest" == actual)
+
+# good
+refute_equal("rubocop-minitest", actual)
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#refute-equal](https://github.com/rubocop-hq/minitest-style-guide#refute-equal)
+
+## Minitest/RefuteFalse
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.3 | -
+
+This cop enforces the use of `refute(object)`
+over `assert_equal(false, object)`.
+
+### Examples
+
+```ruby
+# bad
+assert_equal(false, actual)
+assert_equal(false, actual, 'the message')
+
+# good
+refute(actual)
+refute(actual, 'the message')
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#refute-false](https://github.com/rubocop-hq/minitest-style-guide#refute-false)
+
+## Minitest/RefuteIncludes
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.3 | -
+
+This cop enforces the test to use `refute_includes`
+instead of using `refute(collection.include?(object))`.
+
+### Examples
+
+```ruby
+# bad
+refute(collection.include?(object))
+refute(collection.include?(object), 'the message')
+
+# good
+refute_includes(collection, object)
+refute_includes(collection, object, 'the message')
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#refute-includes](https://github.com/rubocop-hq/minitest-style-guide#refute-includes)
+
+## Minitest/RefuteInstanceOf
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.4 | -
+
+This cop enforces the use of `refute_instance_of(Class, object)`
+over `refute(object.instance_of?(Class))`.
+
+### Examples
+
+```ruby
+# bad
+refute(object.instance_of?(Class))
+refute(object.instance_of?(Class), 'the message')
+
+# good
+refute_instance_of(Class, object)
+refute_instance_of(Class, object, 'the message')
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#refute-instance-of](https://github.com/rubocop-hq/minitest-style-guide#refute-instance-of)
+
 ## Minitest/RefuteNil
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 --- | --- | --- | --- | ---
 Enabled | Yes | Yes  | 0.2 | -
 
-Check if your test uses `refute_nil` instead of `refute_equal(nil, something)`.
+This cop enforces the test to use `refute_nil`
+instead of using `refute_equal(nil, something)`.
 
 ### Examples
 
@@ -121,3 +343,30 @@ refute_nil(actual, 'the message')
 ### References
 
 * [https://github.com/rubocop-hq/minitest-style-guide#refute-nil](https://github.com/rubocop-hq/minitest-style-guide#refute-nil)
+
+## Minitest/RefuteRespondTo
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.4 | -
+
+This cop enforces the test to use `refute_respond_to(object, :some_method)`
+over `refute(object.respond_to?(:some_method))`.
+
+### Examples
+
+```ruby
+# bad
+refute(object.respond_to?(:some_method))
+refute(object.respond_to?(:some_method), 'the message')
+refute(respond_to?(:some_method))
+
+# good
+refute_respond_to(object, :some_method)
+refute_respond_to(object, :some_method, 'the message')
+refute_respond_to(self, :some_method)
+```
+
+### References
+
+* [https://github.com/rubocop-hq/minitest-style-guide#refute-respond-to](https://github.com/rubocop-hq/minitest-style-guide#refute-respond-to)

data/relnotes/v0.1.0.md

@@ -0,0 +1,7 @@
+### New features
+
+* Create RuboCop Minitest gem. ([@koic][])
+* [#6](https://github.com/rubocop-hq/rubocop-minitest/pull/6): Add new `Minitest/AssertNil` cop. ([@duduribeiro ][])
+
+[@koic]: https://github.com/koic
+[@duduribeiro]: https://github.com/duduribeiro

data/relnotes/v0.2.0.md

@@ -0,0 +1,9 @@
+### New features
+
+* [#11](https://github.com/rubocop-hq/rubocop-minitest/pull/11): Add new `Minitest/RefuteNil` cop. ([@tejasbubane ][])
+* [#8](https://github.com/rubocop-hq/rubocop-minitest/pull/8): Add new `Minitest/AssertTruthy` cop. ([@abhaynikam ][])
+* [#9](https://github.com/rubocop-hq/rubocop-minitest/pull/9): Add new `Minitest/AssertIncludes` cop. ([@abhaynikam ][])
+* [#10](https://github.com/rubocop-hq/rubocop-minitest/pull/10): Add new `Minitest/AssertEmpty` cop. ([@abhaynikam ][])
+
+[@tejasbubane]: https://github.com/tejasbubane
+[@abhaynikam]: https://github.com/abhaynikam

data/relnotes/v0.2.1.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+ * [#13](https://github.com/rubocop-hq/rubocop-minitest/issues/13): Fix the execution target specified in `Include` parameter. ([@koic][])
+
+ [@koic]: https://github.com/koic

data/relnotes/v0.3.0.md

@@ -0,0 +1,16 @@
+## 0.3.0 (2019-10-13)
+
+### New features
+
+* [#15](https://github.com/rubocop-hq/rubocop-minitest/pull/15): Add new `Minitest/RefuteIncludes` cop. ([@abhaynikam][])
+* [#18](https://github.com/rubocop-hq/rubocop-minitest/pull/18): Add new `Minitest/RefuteFalse` cop. ([@duduribeiro][])
+* [#20](https://github.com/rubocop-hq/rubocop-minitest/pull/20): Add new `Minitest/RefuteEmpty` cop. ([@abhaynikam][])
+* [#21](https://github.com/rubocop-hq/rubocop-minitest/pull/21): Add new `Minitest/RefuteEqual` cop. ([@duduribeiro][])
+* [#27](https://github.com/rubocop-hq/rubocop-minitest/pull/27): Add new `Minitest/AssertRespondTo` cop. ([@duduribeiro][])
+
+### Bug fixes
+
+* [#19](https://github.com/rubocop-hq/rubocop-minitest/pull/19): Fix a false negative for `Minitest/AssertIncludes` when using `include` method in arguments of `assert` method. ([@abhaynikam][])
+
+[@abhaynikam]: https://github.com/abhaynikam
+[@duduribeiro]: https://github.com/duduribeiro

data/relnotes/v0.4.0.md

@@ -0,0 +1,14 @@
+### New features
+
+* [#29](https://github.com/rubocop-hq/rubocop-minitest/pull/29): Add new `Minitest/RefuteRespondTo` cop.  ([@herwinw][])
+* [#31](https://github.com/rubocop-hq/rubocop-minitest/pull/31): Add new `Minitest/AssertEqual` cop. ([@herwinw][])
+* [#34](https://github.com/rubocop-hq/rubocop-minitest/pull/34): Add new `Minitest/AssertInstanceOf` cop. ([@abhaynikam][])
+* [#35](https://github.com/rubocop-hq/rubocop-minitest/pull/35): Add new `Minitest/RefuteInstanceOf` cop. ([@abhaynikam][])
+
+### Bug fixes
+
+* [#25](https://github.com/rubocop-hq/rubocop-minitest/issues/25): Add `Enabled: true` to `Minitest` department config to suppress `Warning: Minitest does not support Enabled parameter`. ([@koic][])
+
+[@herwinw]: https://github.com/herwinw
+[@abhaynikam]: https://github.com/abhaynikam
+[@koic]: https://github.com/koic

data/relnotes/v0.4.1.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#39](https://github.com/rubocop-hq/rubocop-minitest/issues/39): Fix an incorrect autocorrect for `Minitest/AssertRespondTo` and `Minitest/RefuteRespondTo` when using assertion method calling `respond_to` with receiver omitted. ([@koic][])
+
+[@koic]: https://github.com/koic

data/relnotes/v0.5.0.md

@@ -0,0 +1,5 @@
+### New features
+
+* [#32](https://github.com/rubocop-hq/rubocop-minitest/issues/32): Add new `Minitest/AssertEmptyLiteral` cop. ([@tejasbubane][])
+
+[@tejasbubane]: https://github.com/tejasbubane