rubocop-minitest 0.17.2 → 0.19.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b59e5fd9ae4f6ad15bcc96b2e615eb8aa132b653cfe99c62eb8874186b88d38
-  data.tar.gz: 710f664f0704ffd649d4741729d6c6c5cab86222c8b79540c553160ff30a0d68
+  metadata.gz: 75689600fc3dd6dc4fe96f80dc7c7e8a3b26e59978a15334f58c12421279873f
+  data.tar.gz: afad72a5c22682e4c79fffae91c7f49d25f08d925ed001bec887f8624ad1a391
 SHA512:
-  metadata.gz: 727cc013e57b69f43d5796e37d62521ed7880dfc961ef59f5df0cd1a48d2a2bb8a7f6be5698efa0b9021f01097065f4d09ada983c0e36e3455ed3f36af94954b
-  data.tar.gz: f3b1f390ff8a682c5866871ad83887c7cd891eb307261bfeb46aee8d44ff1ed081945d7daa279035cebb2730c0d797ce0514758907a81b08a74a712766ec293d
+  metadata.gz: 7c3c53d4f3e5915a39babb33862bc7ee9a1aef01e76fa680581723631c6a101a04af01f15fa33047c01f2dd57b99d44ac3da99f66bf5f06b8923e07f5c03f986
+  data.tar.gz: 649292ccae1c3a021f9c72399b03f3b38bf223c78e492e7ec93a5c030a73c920c3e1b7cae305d21b3942a68fe57d5451105e184fd20166f9820878bf077decc1

data/.github/workflows/linting.yml

@@ -0,0 +1,15 @@
+name: Linting
+on:
+  - pull_request
+jobs:
+  yamllint:
+    name: Yamllint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Yamllint
+        uses: karancode/yamllint-github-action@master
+        with:
+          yamllint_comment: true
+        env:
+          GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/.github/workflows/spell_checking.yml

@@ -10,7 +10,7 @@ jobs:
       matrix:
         python-version: [3.8]
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v2
         with:
@@ -26,7 +26,7 @@ jobs:
     name: Check spelling of all files in commit with misspell
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Install
         run: wget -O - -q https://git.io/misspell | sh -s -- -b .
       - name: Misspell

data/.rubocop.yml

@@ -55,13 +55,13 @@ Layout/ClassStructure:
       - prepend
       - extend
   ExpectedOrder:
-      - module_inclusion
-      - constants
-      - public_class_methods
-      - initializer
-      - instance_methods
-      - protected_methods
-      - private_methods
+    - module_inclusion
+    - constants
+    - public_class_methods
+    - initializer
+    - instance_methods
+    - protected_methods
+    - private_methods
 
 # Trailing white space is meaningful in code examples
 Layout/TrailingWhitespace:

data/.yamllint.yml

@@ -0,0 +1,9 @@
+extends: default
+
+rules:
+  comments:
+    min-spaces-from-content: 1
+  document-start: disable
+  line-length: disable
+  truthy:
+    check-keys: false

data/CHANGELOG.md

@@ -2,6 +2,28 @@
 
 ## master (unreleased)
 
+## 0.19.1 (2022-04-10)
+
+### Bug fixes
+
+* [#167](https://github.com/rubocop/rubocop-minitest/pull/167): Fix potential for valid Ruby code to be unparsable in `Minitest/DuplicateTestRun` cop. ([@gjtorikian][])
+
+## 0.19.0 (2022-04-05)
+
+### New features
+
+* [#164](https://github.com/rubocop/rubocop-minitest/pull/164): Add new `Minitest/DuplicateTestRun` cop. ([@ignacio-chiazzo][])
+
+## 0.18.0 (2022-03-13)
+
+### New features
+
+* [#161](https://github.com/rubocop/rubocop-minitest/pull/161): Add new `Minitest/AssertPredicate` and `Minitest/RefutePredicate` cops. ([@koic][])
+
+### Changes
+
+* [#162](https://github.com/rubocop/rubocop-minitest/pull/162): Make `Minitest/AssertNil` (`Minitest/RefuteNil`) aware of `assert_predicate(obj, :nil?)` (`refute_predicate(obj, :nil?)`). ([@koic][])
+
 ## 0.17.2 (2022-02-12)
 
 ### Bug fixes
@@ -276,3 +298,5 @@
 [@cstyles]: https://github.com/cstyles
 [@ghiculescu]: https://github.com/ghiculescu
 [@gi]: https://github.com/gi
+[@ignacio-chiazzo]: https://github.com/ignacio-chiazzo
+[@gjtorikian]: https://github.com/gjtorikian

data/config/default.yml

@@ -28,17 +28,6 @@ Minitest/AssertInDelta:
   Enabled: 'pending'
   VersionAdded: '0.10'
 
-Minitest/AssertionInLifecycleHook:
-  Description: 'This cop checks for usage of assertions in lifecycle hooks.'
-  Enabled: 'pending'
-  VersionAdded: '0.10'
-
-Minitest/AssertMatch:
-  Description: 'This cop enforces the test to use `assert_match` instead of using `assert(matcher.match(object))`.'
-  StyleGuide: 'https://minitest.rubystyle.guide#assert-match'
-  Enabled: true
-  VersionAdded: '0.6'
-
 Minitest/AssertIncludes:
   Description: 'This cop enforces the test to use `assert_includes` instead of using `assert(collection.include?(object))`.'
   StyleGuide: 'https://minitest.rubystyle.guide#assert-includes'
@@ -57,6 +46,12 @@ Minitest/AssertKindOf:
   Enabled: 'pending'
   VersionAdded: '0.10'
 
+Minitest/AssertMatch:
+  Description: 'This cop enforces the test to use `assert_match` instead of using `assert(matcher.match(object))`.'
+  StyleGuide: 'https://minitest.rubystyle.guide#assert-match'
+  Enabled: true
+  VersionAdded: '0.6'
+
 Minitest/AssertNil:
   Description: 'This cop enforces the test to use `assert_nil` instead of using `assert_equal(nil, something)` or `assert(something.nil?)`.'
   StyleGuide: 'https://minitest.rubystyle.guide#assert-nil'
@@ -75,6 +70,12 @@ Minitest/AssertPathExists:
   Enabled: 'pending'
   VersionAdded: '0.10'
 
+Minitest/AssertPredicate:
+  Description: 'This cop enforces the test to use `assert_predicate` instead of using `assert(obj.a_predicate_method?)`.'
+  StyleGuide: 'https://minitest.rubystyle.guide/#assert-predicate'
+  Enabled: pending
+  VersionAdded: '0.18'
+
 Minitest/AssertRespondTo:
   Description: 'This cop enforces the test to use `assert_respond_to(object, :do_something)` over `assert(object.respond_to?(:do_something))`.'
   StyleGuide: 'https://minitest.rubystyle.guide#assert-responds-to-method'
@@ -99,6 +100,16 @@ Minitest/AssertWithExpectedArgument:
   Safe: false
   VersionAdded: '0.11'
 
+Minitest/AssertionInLifecycleHook:
+  Description: 'This cop checks for usage of assertions in lifecycle hooks.'
+  Enabled: 'pending'
+  VersionAdded: '0.10'
+
+Minitest/DuplicateTestRun:
+  Description: 'This cop detects duplicate test runs caused by one test class inheriting from another.'
+  Enabled: pending
+  VersionAdded: '0.19'
+
 Minitest/GlobalExpectations:
   Description: 'This cop checks for deprecated global expectations.'
   StyleGuide: 'https://minitest.rubystyle.guide#global-expectations'
@@ -164,12 +175,6 @@ Minitest/RefuteIncludes:
   Enabled: true
   VersionAdded: '0.3'
 
-Minitest/RefuteMatch:
-  Description: 'This cop enforces the test to use `refute_match` instead of using `refute(matcher.match(object))`.'
-  StyleGuide: 'https://minitest.rubystyle.guide#refute-match'
-  Enabled: true
-  VersionAdded: '0.6'
-
 Minitest/RefuteInstanceOf:
   Description: 'This cop enforces the test to use `refute_instance_of(Class, object)` over `refute(object.instance_of?(Class))`.'
   StyleGuide: 'https://minitest.rubystyle.guide#refute-instance-of'
@@ -182,6 +187,12 @@ Minitest/RefuteKindOf:
   Enabled: 'pending'
   VersionAdded: '0.10'
 
+Minitest/RefuteMatch:
+  Description: 'This cop enforces the test to use `refute_match` instead of using `refute(matcher.match(object))`.'
+  StyleGuide: 'https://minitest.rubystyle.guide#refute-match'
+  Enabled: true
+  VersionAdded: '0.6'
+
 Minitest/RefuteNil:
   Description: 'This cop enforces the test to use `refute_nil` instead of using `refute_equal(nil, something)` or `refute(something.nil?)`.'
   StyleGuide: 'https://minitest.rubystyle.guide#refute-nil'
@@ -194,6 +205,12 @@ Minitest/RefutePathExists:
   Enabled: 'pending'
   VersionAdded: '0.10'
 
+Minitest/RefutePredicate:
+  Description: 'This cop enforces the test to use `refute_predicate` instead of using `refute(obj.a_predicate_method?)`.'
+  StyleGuide: 'https://minitest.rubystyle.guide/#refute-predicate'
+  Enabled: pending
+  VersionAdded: '0.18'
+
 Minitest/RefuteRespondTo:
   Description: 'This cop enforces the test to use `refute_respond_to(object, :do_something)` over `refute(object.respond_to?(:do_something))`.'
   StyleGuide: 'https://minitest.rubystyle.guide#refute-respond-to'

data/docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop-minitest
 title: RuboCop Minitest
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: '0.17'
+version: '0.19'
 nav:
-- modules/ROOT/nav.adoc
+  - modules/ROOT/nav.adoc

data/docs/modules/ROOT/pages/cops.adoc

@@ -24,11 +24,13 @@ based on the https://minitest.rubystyle.guide/[Minitest Style Guide].
 * xref:cops_minitest.adoc#minitestassertnil[Minitest/AssertNil]
 * xref:cops_minitest.adoc#minitestassertoutput[Minitest/AssertOutput]
 * xref:cops_minitest.adoc#minitestassertpathexists[Minitest/AssertPathExists]
+* xref:cops_minitest.adoc#minitestassertpredicate[Minitest/AssertPredicate]
 * xref:cops_minitest.adoc#minitestassertrespondto[Minitest/AssertRespondTo]
 * xref:cops_minitest.adoc#minitestassertsilent[Minitest/AssertSilent]
 * xref:cops_minitest.adoc#minitestasserttruthy[Minitest/AssertTruthy]
 * xref:cops_minitest.adoc#minitestassertwithexpectedargument[Minitest/AssertWithExpectedArgument]
 * xref:cops_minitest.adoc#minitestassertioninlifecyclehook[Minitest/AssertionInLifecycleHook]
+* xref:cops_minitest.adoc#minitestduplicatetestrun[Minitest/DuplicateTestRun]
 * xref:cops_minitest.adoc#minitestglobalexpectations[Minitest/GlobalExpectations]
 * xref:cops_minitest.adoc#minitestliteralasactualargument[Minitest/LiteralAsActualArgument]
 * xref:cops_minitest.adoc#minitestmultipleassertions[Minitest/MultipleAssertions]
@@ -43,6 +45,7 @@ based on the https://minitest.rubystyle.guide/[Minitest Style Guide].
 * xref:cops_minitest.adoc#minitestrefutematch[Minitest/RefuteMatch]
 * xref:cops_minitest.adoc#minitestrefutenil[Minitest/RefuteNil]
 * xref:cops_minitest.adoc#minitestrefutepathexists[Minitest/RefutePathExists]
+* xref:cops_minitest.adoc#minitestrefutepredicate[Minitest/RefutePredicate]
 * xref:cops_minitest.adoc#minitestrefuterespondto[Minitest/RefuteRespondTo]
 * xref:cops_minitest.adoc#minitesttestmethodname[Minitest/TestMethodName]
 * xref:cops_minitest.adoc#minitestunreachableassertion[Minitest/UnreachableAssertion]

data/docs/modules/ROOT/pages/cops_minitest.adoc

@@ -262,7 +262,7 @@ assert_match(matcher, string, 'message')
 |===
 
 This cop enforces the test to use `assert_nil` instead of using
-`assert_equal(nil, something)` or `assert(something.nil?)`.
+`assert_equal(nil, something)`, `assert(something.nil?)`, or `assert_predicate(something, :nil?)`.
 
 === Examples
 
@@ -273,6 +273,8 @@ assert_equal(nil, actual)
 assert_equal(nil, actual, 'message')
 assert(object.nil?)
 assert(object.nil?, 'message')
+assert_predicate(object, :nil?)
+assert_predicate(object, :nil?, 'message')
 
 # good
 assert_nil(actual)
@@ -347,6 +349,38 @@ assert_path_exists(path, 'message')
 
 * https://minitest.rubystyle.guide/#assert-path-exists
 
+== Minitest/AssertPredicate
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| Yes
+| 0.18
+| -
+|===
+
+This cop enforces the test to use `assert_predicate`
+instead of using `assert(obj.a_predicate_method?)`.
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+assert(obj.one?)
+assert(obj.one?, 'message')
+
+# good
+assert_predicate(obj, :one?)
+assert_predicate(obj, :one?, 'message')
+----
+
+=== References
+
+* https://minitest.rubystyle.guide/#assert-predicate
+
 == Minitest/AssertRespondTo
 
 |===
@@ -510,6 +544,63 @@ class FooTest < Minitest::Test
 end
 ----
 
+== Minitest/DuplicateTestRun
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| No
+| 0.19
+| -
+|===
+
+If a Minitest class inherits from another class,
+it will also inherit its methods causing Minitest to run the parent's tests methods twice.
+
+This cop detects when there are two tests classes, one inherits from the other, and both have tests methods.
+This cop will add an offence to the Child class in such a case.
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+class ParentTest < Minitest::Test
+  def test_parent # it will run this test twice.
+  end
+end
+
+class ChildTest < ParentTest
+  def test_child
+  end
+end
+
+# good
+class ParentTest < Minitest::Test
+  def test_parent
+  end
+end
+
+class ChildTest < Minitest::Test
+  def test_child
+  end
+end
+
+# good
+class ParentTest < Minitest::Test
+end
+
+class ChildTest
+  def test_child
+  end
+
+  def test_parent
+  end
+end
+----
+
 == Minitest/GlobalExpectations
 
 |===
@@ -1025,7 +1116,7 @@ refute_match(matcher, string, 'message')
 |===
 
 This cop enforces the test to use `refute_nil` instead of using
-`refute_equal(nil, something)` or `refute(something.nil?)`.
+`refute_equal(nil, something)`, `refute(something.nil?)`, or `refute_predicate(something, :nil?)`.
 
 === Examples
 
@@ -1036,6 +1127,8 @@ refute_equal(nil, actual)
 refute_equal(nil, actual, 'message')
 refute(actual.nil?)
 refute(actual.nil?, 'message')
+refute_predicate(object, :nil?)
+refute_predicate(object, :nil?, 'message')
 
 # good
 refute_nil(actual)
@@ -1078,6 +1171,38 @@ refute_path_exists(path, 'message')
 
 * https://minitest.rubystyle.guide/#refute-path-exists
 
+== Minitest/RefutePredicate
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| Yes
+| 0.18
+| -
+|===
+
+This cop enforces the test to use `refute_predicate`
+instead of using `refute(obj.a_predicate_method?)`.
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+refute(obj.one?)
+refute(obj.one?, 'message')
+
+# good
+refute_predicate(obj, :one?)
+refute_predicate(obj, :one?, 'message')
+----
+
+=== References
+
+* https://minitest.rubystyle.guide/#refute-predicate
+
 == Minitest/RefuteRespondTo
 
 |===

data/lib/rubocop/cop/minitest/assert_empty_literal.rb

@@ -18,8 +18,7 @@ module RuboCop
         include ArgumentRangeHelper
         extend AutoCorrector
 
-        MSG = 'Prefer using `assert_empty(%<arguments>s)` over ' \
-              '`assert_equal(%<literal>s, %<arguments>s)`.'
+        MSG = 'Prefer using `assert_empty(%<arguments>s)`.'
         RESTRICT_ON_SEND = %i[assert_equal].freeze
 
         def_node_matcher :assert_equal_with_empty_literal, <<~PATTERN

data/lib/rubocop/cop/minitest/assert_nil.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Minitest
       # This cop enforces the test to use `assert_nil` instead of using
-      # `assert_equal(nil, something)` or `assert(something.nil?)`.
+      # `assert_equal(nil, something)`, `assert(something.nil?)`, or `assert_predicate(something, :nil?)`.
       #
       # @example
       #   # bad
@@ -12,6 +12,8 @@ module RuboCop
       #   assert_equal(nil, actual, 'message')
       #   assert(object.nil?)
       #   assert(object.nil?, 'message')
+      #   assert_predicate(object, :nil?)
+      #   assert_predicate(object, :nil?, 'message')
       #
       #   # good
       #   assert_nil(actual)
@@ -23,12 +25,13 @@ module RuboCop
         extend AutoCorrector
 
         ASSERTION_TYPE = 'assert'
-        RESTRICT_ON_SEND = %i[assert_equal assert].freeze
+        RESTRICT_ON_SEND = %i[assert assert_equal assert_predicate].freeze
 
         def_node_matcher :nil_assertion, <<~PATTERN
           {
             (send nil? :assert_equal nil $_ $...)
             (send nil? :assert (send $_ :nil?) $...)
+            (send nil? :assert_predicate $_ (sym :nil?) $...)
           }
         PATTERN
 

data/lib/rubocop/cop/minitest/assert_path_exists.rb

@@ -18,7 +18,7 @@ module RuboCop
       class AssertPathExists < Base
         extend AutoCorrector
 
-        MSG = 'Prefer using `%<good_method>s` over `%<bad_method>s`.'
+        MSG = 'Prefer using `%<good_method>s`.'
         RESTRICT_ON_SEND = %i[assert].freeze
 
         def_node_matcher :assert_file_exists, <<~PATTERN
@@ -32,7 +32,7 @@ module RuboCop
           assert_file_exists(node) do |path, failure_message|
             failure_message = failure_message.first
             good_method = build_good_method(path, failure_message)
-            message = format(MSG, good_method: good_method, bad_method: node.source)
+            message = format(MSG, good_method: good_method)
 
             add_offense(node, message: message) do |corrector|
               corrector.replace(node, good_method)

data/lib/rubocop/cop/minitest/assert_predicate.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # This cop enforces the test to use `assert_predicate`
+      # instead of using `assert(obj.a_predicate_method?)`.
+      #
+      # @example
+      #   # bad
+      #   assert(obj.one?)
+      #   assert(obj.one?, 'message')
+      #
+      #   # good
+      #   assert_predicate(obj, :one?)
+      #   assert_predicate(obj, :one?, 'message')
+      #
+      class AssertPredicate < Base
+        include ArgumentRangeHelper
+        include PredicateAssertionHandleable
+        extend AutoCorrector
+
+        MSG = 'Prefer using `assert_predicate(%<new_arguments>s)`.'
+        RESTRICT_ON_SEND = %i[assert].freeze
+
+        private
+
+        def assertion_type
+          'assert'
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest/assert_silent.rb

@@ -16,7 +16,7 @@ module RuboCop
       class AssertSilent < Base
         extend AutoCorrector
 
-        MSG = 'Prefer using `assert_silent` over `assert_output("", "")`.'
+        MSG = 'Prefer using `assert_silent`.'
 
         def_node_matcher :assert_silent_candidate?, <<~PATTERN
           (block

data/lib/rubocop/cop/minitest/assert_truthy.rb

@@ -19,8 +19,7 @@ module RuboCop
         include ArgumentRangeHelper
         extend AutoCorrector
 
-        MSG = 'Prefer using `assert(%<arguments>s)` over ' \
-              '`assert_equal(true, %<arguments>s)`.'
+        MSG = 'Prefer using `assert(%<arguments>s)`.'
         RESTRICT_ON_SEND = %i[assert_equal].freeze
 
         def_node_matcher :assert_equal_with_truthy, <<~PATTERN

data/lib/rubocop/cop/minitest/duplicate_test_run.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # If a Minitest class inherits from another class,
+      # it will also inherit its methods causing Minitest to run the parent's tests methods twice.
+      #
+      # This cop detects when there are two tests classes, one inherits from the other, and both have tests methods.
+      # This cop will add an offence to the Child class in such a case.
+      #
+      # @example
+      #   # bad
+      #   class ParentTest < Minitest::Test
+      #     def test_parent # it will run this test twice.
+      #     end
+      #   end
+      #
+      #   class ChildTest < ParentTest
+      #     def test_child
+      #     end
+      #   end
+      #
+      #
+      #   # good
+      #   class ParentTest < Minitest::Test
+      #     def test_parent
+      #     end
+      #   end
+      #
+      #   class ChildTest < Minitest::Test
+      #     def test_child
+      #     end
+      #   end
+      #
+      #   # good
+      #   class ParentTest < Minitest::Test
+      #   end
+      #
+      #   class ChildTest
+      #     def test_child
+      #     end
+      #
+      #     def test_parent
+      #     end
+      #   end
+      #
+      class DuplicateTestRun < Base
+        include MinitestExplorationHelpers
+
+        MSG = "Subclasses with test methods causes the parent' tests to run them twice."
+
+        def on_class(class_node)
+          return unless test_class?(class_node)
+          return unless test_methods?(class_node)
+          return unless parent_class_has_test_methods?(class_node)
+
+          message = format(MSG)
+          add_offense(class_node, message: message)
+        end
+
+        private
+
+        def parent_class_has_test_methods?(class_node)
+          parent_class = class_node.parent_class
+
+          return false unless (class_node_parent = class_node.parent)
+
+          parent_class_node = class_node_parent.each_child_node(:class).detect do |klass|
+            klass.identifier == parent_class
+          end
+
+          return false unless parent_class_node
+
+          test_methods?(parent_class_node)
+        end
+
+        def test_methods?(class_node)
+          test_cases(class_node).size.positive?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest/refute_equal.rb

@@ -18,20 +18,19 @@ module RuboCop
         include ArgumentRangeHelper
         extend AutoCorrector
 
-        MSG = 'Prefer using `refute_equal(%<preferred>s)` over ' \
-              '`assert(%<over>s)`.'
+        MSG = 'Prefer using `refute_equal(%<preferred>s)`.'
         RESTRICT_ON_SEND = %i[assert].freeze
 
         def_node_matcher :assert_not_equal, <<~PATTERN
-          (send nil? :assert ${(send $_ :!= $_) (send (send $_ :! ) :== $_) } $... )
+          (send nil? :assert {(send $_ :!= $_) (send (send $_ :! ) :== $_) } $... )
         PATTERN
 
         def on_send(node)
-          preferred, over = process_not_equal(node)
-          return unless preferred && over
+          preferred = process_not_equal(node)
+          return unless preferred
 
-          assert_not_equal(node) do |_, expected, actual|
-            message = format(MSG, preferred: preferred, over: over)
+          assert_not_equal(node) do |expected, actual|
+            message = format(MSG, preferred: preferred)
 
             add_offense(node, message: message) do |corrector|
               corrector.replace(node.loc.selector, 'refute_equal')
@@ -54,11 +53,10 @@ module RuboCop
         end
 
         def process_not_equal(node)
-          assert_not_equal(node) do |over, first_arg, second_arg, rest_args|
+          assert_not_equal(node) do |first_arg, second_arg, rest_args|
             custom_message = rest_args.first
-            preferred = preferred_usage(first_arg, second_arg, custom_message)
-            over = original_usage(over.source, custom_message&.source)
-            return [preferred, over]
+
+            preferred_usage(first_arg, second_arg, custom_message)
           end
         end
       end

data/lib/rubocop/cop/minitest/refute_false.rb

@@ -22,8 +22,8 @@ module RuboCop
         include ArgumentRangeHelper
         extend AutoCorrector
 
-        MSG_FOR_ASSERT_EQUAL = 'Prefer using `refute(%<arguments>s)` over `assert_equal(false, %<arguments>s)`.'
-        MSG_FOR_ASSERT = 'Prefer using `refute(%<arguments>s)` over `assert(!%<arguments>s)`.'
+        MSG_FOR_ASSERT_EQUAL = 'Prefer using `refute(%<arguments>s)`.'
+        MSG_FOR_ASSERT = 'Prefer using `refute(%<arguments>s)`.'
         RESTRICT_ON_SEND = %i[assert_equal assert].freeze
 
         def_node_matcher :assert_equal_with_false, <<~PATTERN

data/lib/rubocop/cop/minitest/refute_nil.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Minitest
       # This cop enforces the test to use `refute_nil` instead of using
-      # `refute_equal(nil, something)` or `refute(something.nil?)`.
+      # `refute_equal(nil, something)`, `refute(something.nil?)`, or `refute_predicate(something, :nil?)`.
       #
       # @example
       #   # bad
@@ -12,6 +12,8 @@ module RuboCop
       #   refute_equal(nil, actual, 'message')
       #   refute(actual.nil?)
       #   refute(actual.nil?, 'message')
+      #   refute_predicate(object, :nil?)
+      #   refute_predicate(object, :nil?, 'message')
       #
       #   # good
       #   refute_nil(actual)
@@ -23,12 +25,13 @@ module RuboCop
         extend AutoCorrector
 
         ASSERTION_TYPE = 'refute'
-        RESTRICT_ON_SEND = %i[refute_equal refute].freeze
+        RESTRICT_ON_SEND = %i[refute refute_equal refute_predicate].freeze
 
         def_node_matcher :nil_refutation, <<~PATTERN
           {
             (send nil? :refute_equal nil $_ $...)
             (send nil? :refute (send $_ :nil?) $...)
+            (send nil? :refute_predicate $_ (sym :nil?) $...)
           }
         PATTERN
 

data/lib/rubocop/cop/minitest/refute_path_exists.rb

@@ -18,7 +18,7 @@ module RuboCop
       class RefutePathExists < Base
         extend AutoCorrector
 
-        MSG = 'Prefer using `%<good_method>s` over `%<bad_method>s`.'
+        MSG = 'Prefer using `%<good_method>s`.'
         RESTRICT_ON_SEND = %i[refute].freeze
 
         def_node_matcher :refute_file_exists, <<~PATTERN
@@ -32,7 +32,7 @@ module RuboCop
           refute_file_exists(node) do |path, failure_message|
             failure_message = failure_message.first
             good_method = build_good_method(path, failure_message)
-            message = format(MSG, good_method: good_method, bad_method: node.source)
+            message = format(MSG, good_method: good_method)
 
             add_offense(node, message: message) do |corrector|
               corrector.replace(node, good_method)

data/lib/rubocop/cop/minitest/refute_predicate.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # This cop enforces the test to use `refute_predicate`
+      # instead of using `refute(obj.a_predicate_method?)`.
+      #
+      # @example
+      #   # bad
+      #   refute(obj.one?)
+      #   refute(obj.one?, 'message')
+      #
+      #   # good
+      #   refute_predicate(obj, :one?)
+      #   refute_predicate(obj, :one?, 'message')
+      #
+      class RefutePredicate < Base
+        include ArgumentRangeHelper
+        include PredicateAssertionHandleable
+        extend AutoCorrector
+
+        MSG = 'Prefer using `refute_predicate(%<new_arguments>s)`.'
+        RESTRICT_ON_SEND = %i[refute].freeze
+
+        private
+
+        def assertion_type
+          'refute'
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest_cops.rb

@@ -5,10 +5,12 @@ require_relative 'mixin/in_delta_mixin'
 require_relative 'mixin/minitest_cop_rule'
 require_relative 'mixin/minitest_exploration_helpers'
 require_relative 'mixin/nil_assertion_handleable'
+require_relative 'mixin/predicate_assertion_handleable'
 require_relative 'minitest/assert_empty'
 require_relative 'minitest/assert_empty_literal'
 require_relative 'minitest/assert_equal'
 require_relative 'minitest/assert_in_delta'
+require_relative 'minitest/assert_predicate'
 require_relative 'minitest/assert_with_expected_argument'
 require_relative 'minitest/assertion_in_lifecycle_hook'
 require_relative 'minitest/assert_kind_of'
@@ -21,6 +23,7 @@ require_relative 'minitest/assert_path_exists'
 require_relative 'minitest/assert_respond_to'
 require_relative 'minitest/assert_silent'
 require_relative 'minitest/assert_truthy'
+require_relative 'minitest/duplicate_test_run'
 require_relative 'minitest/global_expectations'
 require_relative 'minitest/literal_as_actual_argument'
 require_relative 'minitest/multiple_assertions'
@@ -35,6 +38,7 @@ require_relative 'minitest/refute_includes'
 require_relative 'minitest/refute_match'
 require_relative 'minitest/refute_instance_of'
 require_relative 'minitest/refute_path_exists'
+require_relative 'minitest/refute_predicate'
 require_relative 'minitest/refute_respond_to'
 require_relative 'minitest/test_method_name'
 require_relative 'minitest/unreachable_assertion'

data/lib/rubocop/cop/mixin/in_delta_mixin.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     # Common functionality for `AssertInDelta` and `RefuteInDelta` cops.
     module InDeltaMixin
-      MSG = 'Prefer using `%<good_method>s` over `%<bad_method>s`.'
+      MSG = 'Prefer using `%<good_method>s`.'
 
       def on_send(node)
         equal_floats_call(node) do |expected, actual, message|
@@ -12,7 +12,7 @@ module RuboCop
           good_method = build_good_method(expected, actual, message)
 
           if expected.float_type? || actual.float_type?
-            message = format(MSG, good_method: good_method, bad_method: node.source)
+            message = format(MSG, good_method: good_method)
 
             add_offense(node, message: message) do |corrector|
               corrector.replace(node, good_method)

data/lib/rubocop/cop/mixin/minitest_cop_rule.rb

@@ -28,8 +28,7 @@ module RuboCop
           include ArgumentRangeHelper
           extend AutoCorrector
 
-          MSG = 'Prefer using `#{preferred_method}(%<new_arguments>s)` over ' \
-                '`#{assertion_method}(%<original_arguments>s)`.'
+          MSG = 'Prefer using `#{preferred_method}(%<new_arguments>s)`.'
           RESTRICT_ON_SEND = %i[#{assertion_method}].freeze
 
           def on_send(node)
@@ -70,12 +69,9 @@ module RuboCop
               message_argument&.source
             ].flatten.compact.join(', ')
 
-            original_arguments = arguments.map(&:source).join(', ')
-
             format(
               MSG,
-              new_arguments: new_arguments,
-              original_arguments: original_arguments
+              new_arguments: new_arguments
             )
           end
 

data/lib/rubocop/cop/mixin/nil_assertion_handleable.rb

@@ -5,7 +5,7 @@ module RuboCop
     module Minitest
       # Common functionality for `AssertNil` and `RefuteNil` cops.
       module NilAssertionHandleable
-        MSG = 'Prefer using `%<assertion_type>s_nil(%<preferred_args>s)` over `%<method>s(%<current_args>s)`.'
+        MSG = 'Prefer using `%<assertion_type>s_nil(%<preferred_args>s)`.'
 
         private
 
@@ -22,23 +22,18 @@ module RuboCop
           message_source = message&.source
 
           preferred_args = [actual.source, message_source].compact
-          current_args = if comparison_assertion_method?(node)
-                           ['nil', preferred_args].join(', ')
-                         else
-                           ["#{actual.source}.nil?", message_source].compact.join(', ')
-                         end
 
           format(
             MSG,
             assertion_type: assertion_type,
             preferred_args: preferred_args.join(', '),
-            method: node.method_name, current_args: current_args
+            method: node.method_name
           )
         end
 
         def autocorrect(corrector, node, actual)
           corrector.replace(node.loc.selector, :"#{assertion_type}_nil")
-          if comparison_assertion_method?(node)
+          if comparison_or_predicate_assertion_method?(node)
             corrector.replace(first_and_second_arguments_range(node), actual.source)
           else
             corrector.remove(node.first_argument.loc.dot)
@@ -46,8 +41,8 @@ module RuboCop
           end
         end
 
-        def comparison_assertion_method?(node)
-          node.method?(:"#{assertion_type}_equal")
+        def comparison_or_predicate_assertion_method?(node)
+          node.method?(:"#{assertion_type}_equal") || node.method?(:"#{assertion_type}_predicate")
         end
       end
     end

data/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # Common functionality for `Minitest/AssertPredicate` and `Minitest/RefutePredicate` cops.
+      module PredicateAssertionHandleable
+        MSG = 'Prefer using `%<assertion_type>s_predicate(%<new_arguments>s)`.'
+        RESTRICT_ON_SEND = %i[assert].freeze
+
+        def on_send(node)
+          return unless (arguments = peel_redundant_parentheses_from(node.arguments))
+          return unless arguments.first.respond_to?(:predicate_method?) && arguments.first.predicate_method?
+          return unless arguments.first.arguments.count.zero?
+
+          add_offense(node, message: offense_message(arguments)) do |corrector|
+            autocorrect(corrector, node, arguments)
+          end
+        end
+
+        def autocorrect(corrector, node, arguments)
+          corrector.replace(node.loc.selector, "#{assertion_type}_predicate")
+
+          new_arguments = new_arguments(arguments).join(', ')
+
+          corrector.replace(first_argument_range(node), new_arguments)
+        end
+
+        private
+
+        def peel_redundant_parentheses_from(arguments)
+          return arguments unless arguments.first&.begin_type?
+
+          peel_redundant_parentheses_from(arguments.first.children)
+        end
+
+        def offense_message(arguments)
+          message_argument = arguments.last if arguments.first != arguments.last
+
+          new_arguments = [
+            new_arguments(arguments),
+            message_argument&.source
+          ].flatten.compact.join(', ')
+
+          format(MSG, assertion_type: assertion_type, new_arguments: new_arguments)
+        end
+
+        def new_arguments(arguments)
+          receiver = correct_receiver(arguments.first.receiver)
+          method_name = arguments.first.method_name
+
+          [receiver, ":#{method_name}"]
+        end
+
+        def correct_receiver(receiver)
+          receiver ? receiver.source : 'self'
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/minitest/assert_offense.rb

@@ -22,7 +22,7 @@ module RuboCop
     #     class FooTest < Minitest::Test
     #       def test_do_something
     #         assert_equal(nil, somestuff)
-    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)` over `assert_equal(nil, somestuff)`.
+    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
     #       end
     #     end
     #   RUBY
@@ -36,7 +36,7 @@ module RuboCop
     #     class FooTest < Minitest::Test
     #       def test_do_something
     #         assert_equal(nil, somestuff)
-    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)` over `assert_equal(nil, somestuff)`.
+    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
     #       end
     #     end
     #   RUBY
@@ -64,7 +64,7 @@ module RuboCop
     #     class FooTest < Minitest::Test
     #       def test_do_something
     #         assert_equal(nil, somestuff)
-    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)` over `assert_equal(nil, somestuff)`.
+    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
     #       end
     #     end
     #   RUBY

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.17.2'
+      STRING = '0.19.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/mkdocs.yml

@@ -4,10 +4,10 @@ edit_uri: edit/master/legacy-docs/
 copyright: "Copyright © 2022 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO, and RuboCop contributors"
 docs_dir: legacy-docs
 pages:
-- Home: index.md
-- Installation: installation.md
-- Usage: usage.md
-- Cops: cops.md
-- Cops Documentation:
-    - Minitest Cops: cops_minitest.md
+  - Home: index.md
+  - Installation: installation.md
+  - Usage: usage.md
+  - Cops: cops.md
+  - Cops Documentation:
+      - Minitest Cops: cops_minitest.md
 theme: readthedocs

data/relnotes/v0.18.0.md

@@ -0,0 +1,9 @@
+### New features
+
+* [#161](https://github.com/rubocop/rubocop-minitest/pull/161): Add new `Minitest/AssertPredicate` and `Minitest/RefutePredicate` cops. ([@koic][])
+
+### Changes
+
+* [#162](https://github.com/rubocop/rubocop-minitest/pull/162): Make `Minitest/AssertNil` (`Minitest/RefuteNil`) aware of `assert_predicate(obj, :nil?)` (`refute_predicate(obj, :nil?)`). ([@koic][])
+
+[@koic]: https://github.com/koic

data/relnotes/v0.19.0.md

@@ -0,0 +1,5 @@
+### New features
+
+* [#164](https://github.com/rubocop/rubocop-minitest/pull/164): Add new `Minitest/DuplicateTestRun` cop. ([@ignacio-chiazzo][])
+
+[@ignacio-chiazzo]: https://github.com/ignacio-chiazzo

data/relnotes/v0.19.1.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#167](https://github.com/rubocop/rubocop-minitest/pull/167): Fix potential for valid Ruby code to be unparsable in `Minitest/DuplicateTestRun` cop. ([@gjtorikian][])
+
+[@gjtorikian]: https://github.com/gjtorikian

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.17.2
+  version: 0.19.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-02-12 00:00:00.000000000 Z
+date: 2022-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -60,10 +60,12 @@ files:
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/PULL_REQUEST_TEMPLATE.md"
+- ".github/workflows/linting.yml"
 - ".github/workflows/spell_checking.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
+- ".yamllint.yml"
 - ".yardopts"
 - CHANGELOG.md
 - CONTRIBUTING.md
@@ -100,11 +102,13 @@ files:
 - lib/rubocop/cop/minitest/assert_nil.rb
 - lib/rubocop/cop/minitest/assert_output.rb
 - lib/rubocop/cop/minitest/assert_path_exists.rb
+- lib/rubocop/cop/minitest/assert_predicate.rb
 - lib/rubocop/cop/minitest/assert_respond_to.rb
 - lib/rubocop/cop/minitest/assert_silent.rb
 - lib/rubocop/cop/minitest/assert_truthy.rb
 - lib/rubocop/cop/minitest/assert_with_expected_argument.rb
 - lib/rubocop/cop/minitest/assertion_in_lifecycle_hook.rb
+- lib/rubocop/cop/minitest/duplicate_test_run.rb
 - lib/rubocop/cop/minitest/global_expectations.rb
 - lib/rubocop/cop/minitest/literal_as_actual_argument.rb
 - lib/rubocop/cop/minitest/multiple_assertions.rb
@@ -119,6 +123,7 @@ files:
 - lib/rubocop/cop/minitest/refute_match.rb
 - lib/rubocop/cop/minitest/refute_nil.rb
 - lib/rubocop/cop/minitest/refute_path_exists.rb
+- lib/rubocop/cop/minitest/refute_predicate.rb
 - lib/rubocop/cop/minitest/refute_respond_to.rb
 - lib/rubocop/cop/minitest/test_method_name.rb
 - lib/rubocop/cop/minitest/unreachable_assertion.rb
@@ -129,6 +134,7 @@ files:
 - lib/rubocop/cop/mixin/minitest_cop_rule.rb
 - lib/rubocop/cop/mixin/minitest_exploration_helpers.rb
 - lib/rubocop/cop/mixin/nil_assertion_handleable.rb
+- lib/rubocop/cop/mixin/predicate_assertion_handleable.rb
 - lib/rubocop/minitest.rb
 - lib/rubocop/minitest/assert_offense.rb
 - lib/rubocop/minitest/inject.rb
@@ -154,6 +160,9 @@ files:
 - relnotes/v0.17.0.md
 - relnotes/v0.17.1.md
 - relnotes/v0.17.2.md
+- relnotes/v0.18.0.md
+- relnotes/v0.19.0.md
+- relnotes/v0.19.1.md
 - relnotes/v0.2.0.md
 - relnotes/v0.2.1.md
 - relnotes/v0.3.0.md
@@ -180,7 +189,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.17
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.19
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
 post_install_message: