rubocop-minify 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '049d556f390def41fa201dedd271537d50e8cc52089a88390265099294b98d06'
-  data.tar.gz: d5456061700c24de435649ae2a13887c30b8390f50de47667a560e44c56c4873
+  metadata.gz: a0856e38071b562aec5905568ea2d4ecb07890678c749378b49798fa45eea92b
+  data.tar.gz: db8ed663094783d77a821394738845cc02d7726ec95fa1eaadadaaede7cd62ce
 SHA512:
-  metadata.gz: 7587a7837c4f11f0edc58d071367b039cd0c51ec9f54e4f1e4dbc84d23dcf7881228bc43714757663f08a7e0e87fec85e77d2c4ac64e6182a683957dd1344da7
-  data.tar.gz: c20b028278b3b49797bbaeaee9b460a5df1105dbfaad073dbda4fc4298bb3746d42da6847fce9ba1b46d0da82aa0b2da0d69e5ac3d827fe906a22ae65b50b0c6
+  metadata.gz: d3bb891186c07997815d98ddef30112aa00c3ec8233a228f18adfdfc86cc87557011ebcf540914673587e7fae73eecc94192ae7dcec97af664b1cbabc2a8cc7d
+  data.tar.gz: 3a35673417b24364098359e05ee0e580aba2f1ed1714261d41cbee2d42103e21f64fc597224fbabc017f1d57593757b36af57ddbf9573f034072ca8a261d0f85

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.1.2 (2026-10-18)
+
+- Works with Herb 0.10 (`herb >= 0.10`, was `>= 0.11`), so adding rubocop-minify doesn't upgrade Herb under gems that need 0.10, such as reactionview 0.3.
+
+## 0.1.1 (2026-10-18)
+
+- Names activerecord-minimizer's keep list still generates (`config/ar_minimizer_keep.txt`, `KeepList`) are left alone, by the cop and by `minify-erb`: a bare `name` everywhere, `Model#name` once every model with that attribute is listed. With the rewrites done and the rest in the keep list, both report nothing, so they can run as checks.
+
 ## 0.1.0 (2026-10-18)
 
 First release.

data/README.md

@@ -51,11 +51,18 @@ RuboCop doesn't read ERB, so `minify-erb` does the same rewrite on the Ruby
 inside each tag (parsed with Herb). Without `--fix` it lists the calls; it
 exits non-zero while any are left, for CI.
 
+Once the calls are rewritten and the rest are in the keep list, both report
+nothing: keep the cop in `.rubocop.yml` and `minify-erb app` in CI, and new
+code that calls a removed method is caught before it runs.
+
 ## What it won't rewrite
 
+Names in activerecord-minimizer's keep list (`config/ar_minimizer_keep.txt`)
+are still generated, so their calls are left alone: a bare `name` everywhere,
+`Model#name` once every model with that attribute is listed.
+
 Receivers aren't typed, so the cop only rewrites what can't mean something
-else, and reports the rest for you to fix by hand or add to the keep list
-(`config/ar_minimizer_keep.txt`):
+else, and reports the rest for you to fix by hand or add to the keep list:
 
 * Names the app also defines (`def featured?` in a presenter, `delegate`,
   `attr_reader`, `alias_method`, ...), scanned from `app/` and `lib/`
@@ -79,11 +86,12 @@ Minify/AttributeMethods:
   DefinitionPaths:
     - "app/**/*.rb"
     - "lib/**/*.rb"
+  KeepList: config/ar_minimizer_keep.txt
 ```
 
-## On golf-buddy
+## On Japan Voyage
 
 191 models: 130 calls in Ruby (app, lib, test, db) and 21 templates rewritten
 automatically; 11 names left for the keep list, all of them names some other
-class defines too. The test suite gives the same results in strict mode
-afterwards.
+class defines too. After that the cop and `minify-erb` report nothing, and
+the test suite gives the same results in strict mode.

data/config/default.yml

@@ -12,3 +12,6 @@ Minify/AttributeMethods:
   DefinitionPaths:
     - "app/**/*.rb"
     - "lib/**/*.rb"
+  # activerecord-minimizer's keep list: names strict mode still generates
+  # (on every model that has them) are left alone.
+  KeepList: config/ar_minimizer_keep.txt

data/lib/rubocop/cop/minify/attribute_methods.rb

@@ -22,7 +22,8 @@ module RuboCop
         def on_new_investigation
           rewrite = RubocopMinify.rewrite_for(config.base_dir_for_path_parameters,
             manifest: cop_config.fetch("Manifest", "config/ar_minimizer.json"),
-            definition_paths: Array(cop_config.fetch("DefinitionPaths", ["app/**/*.rb", "lib/**/*.rb"])))
+            definition_paths: Array(cop_config.fetch("DefinitionPaths", ["app/**/*.rb", "lib/**/*.rb"])),
+            keep_list: cop_config.fetch("KeepList", "config/ar_minimizer_keep.txt"))
           return unless rewrite
 
           source = processed_source.raw_source

data/lib/rubocop_minify/rewrite.rb

@@ -30,10 +30,12 @@ module RubocopMinify
 
     # defined: { method name => "path:line" } of hand-written methods.
     # views: the source is template code (self is a view, never a record).
-    def initialize(index, defined: {}, views: false)
+    # kept: names the keep list still generates (see RubocopMinify.kept_names).
+    def initialize(index, defined: {}, views: false, kept: Set.new)
       @index = index
       @defined = defined
       @views = views
+      @kept = kept
     end
 
     def edits(source)
@@ -112,7 +114,7 @@ module RubocopMinify
     def call_edit(node, cond)
       name = node.name.to_s
       entry = @index[name] or return
-      return if node.block || core?(name)
+      return if @kept.include?(name) || node.block || core?(name)
       return if node.arguments && !entry.args # the generated method takes none: something else
 
       receiver = node.receiver
@@ -182,6 +184,7 @@ module RubocopMinify
     def callback_edit(sym)
       name = sym.unescaped
       entry = @index[name] or return
+      return if @kept.include?(name)
       case self_coverage(entry)
       when :all then nil
       when :some then return report_symbol(sym, "#{name} is removed by strict mode from #{models(entry)}, but not every class this code runs in has it")
@@ -200,7 +203,7 @@ module RubocopMinify
     end
 
     def report_symbol(sym, message)
-      @edits << edit(sym, nil, message) if @index[sym.unescaped] && !core?(sym.unescaped)
+      @edits << edit(sym, nil, message) if @index[sym.unescaped] && !core?(sym.unescaped) && !@kept.include?(sym.unescaped)
     end
 
     # On every record too (readonly?, frozen?, ...) when ActiveRecord is loaded.

data/lib/rubocop_minify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubocopMinify
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

data/lib/rubocop_minify.rb

@@ -9,17 +9,35 @@ module RubocopMinify
 
   # One Rewrite per app root and settings: reading the manifest and scanning
   # the app for definitions happens once per process.
-  def self.rewrite_for(root, manifest:, definition_paths:, views: false)
+  def self.rewrite_for(root, manifest:, definition_paths:, views: false, keep_list: "config/ar_minimizer_keep.txt")
     @rewrites ||= {}
-    @rewrites[[root, manifest, definition_paths, views]] ||= begin
+    @rewrites[[root, manifest, definition_paths, views, keep_list]] ||= begin
       path = File.expand_path(manifest, root)
       if File.exist?(path)
         require "ar_minimizer"
-        Rewrite.new(ArMinimizer::Manifest.load(path), defined: definitions(root, definition_paths), views: views)
+        index = ArMinimizer::Manifest.load(path)
+        Rewrite.new(index, defined: definitions(root, definition_paths), views: views,
+          kept: kept_names(index, File.expand_path(keep_list, root)))
       end
     end
   end
 
+  # Names strict mode still generates on every model that has them, from
+  # activerecord-minimizer's keep list: a bare "name" keeps it everywhere,
+  # "Model#name" only there (the name counts once every model with that
+  # attribute is listed). Calls of those names are left alone.
+  def self.kept_names(index, path)
+    return Set.new unless File.exist?(path)
+
+    bare, scoped = ArMinimizer::Slim.parse_keep_file(File.read(path)).partition { !it.include?("#") }
+    kept = Set.new(bare)
+    scoped.map { it.split("#", 2) }.group_by(&:last).each do |name, pairs|
+      entry = index[name]
+      kept << name if entry && (entry.classes - pairs.map(&:first)).empty?
+    end
+    kept
+  end
+
   def self.definitions(root, paths)
     @definitions ||= {}
     @definitions[[root, paths]] ||= Definitions.scan(root, paths)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minify
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Sampo Kuokkanen
@@ -29,14 +29,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: lint_roller
   requirement: !ruby/object:Gem::Requirement