rubocop-migration 0.5.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbff8f4529cdd09c24ce68ad16df3b477c1f119b5a32db64c73707cce19892dc
-  data.tar.gz: 60b99f9b640c1bc9ee49dbb2b307054acba949169baa2e6790739d118dd4df5f
+  metadata.gz: '0022087bc8e99cf2bc4e2f3baedb7b2b0ad587ff426f9bcd340646553662c866'
+  data.tar.gz: ce12e03910ea987ce6a38b809e30e62a37ce22faf0d9ab6c48c0fb4d3b482e5c
 SHA512:
-  metadata.gz: 1097e91bc1d36afd3b918ec28dc34865b753445cb128e7dabe0e2ddddef9781ed14ec419b54335090b32427ae5fb18317706567fd6a76345575688c76a1d0186
-  data.tar.gz: 21afd86377559669b4561024b03e9d28f5edde8dbbbc7a03b129c4c274beda7dac40be702a164444e92e370411ab31a488be8c68db711526d24e73c6d1aafdba
+  metadata.gz: 536056846d52490c2fdebbedafb3e4db06704a3f18bb6c1bcf7fbcb9f85e19bc3385f0911fb9358a26bbf4e2c0d56338fd5790821b7881297c51dd73fb9c3356
+  data.tar.gz: 6c4b6f308b59b2cfcf50cde30072d848f5c5656cba79f0b2248b02a5ef2daf169d9f76d92090ac6e18284f4803a20bd38c80258fc3693254e0a1c9051fbf8114

data/.rubocop.yml

@@ -1,9 +1,11 @@
-require:
-  - rubocop/cop/internal_affairs
+plugins:
+  - rubocop-internal_affairs
   - rubocop-migration
+  - rubocop-rspec
   - rubocop-performance
   - rubocop-rake
-  - rubocop-rspec
+
+require:
   - sevencop
 
 AllCops:

data/Gemfile.lock

@@ -1,103 +1,107 @@
 PATH
   remote: .
   specs:
-    rubocop-migration (0.5.1)
+    rubocop-migration (0.7.0)
       activesupport
-      rubocop (>= 1.34)
+      lint_roller (>= 1.1)
+      rubocop (>= 1.72.1)
       rubocop-rails (>= 2.24)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3)
+    activesupport (7.1.5.1)
       base64
+      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
       mutex_m
+      securerandom (>= 0.3)
       tzinfo (~> 2.0)
-    ast (2.4.2)
+    ast (2.4.3)
     base64 (0.2.0)
-    bigdecimal (3.1.6)
-    concurrent-ruby (1.2.3)
-    connection_pool (2.4.1)
-    diff-lcs (1.5.0)
-    drb (2.2.0)
-      ruby2_keywords
-    i18n (1.14.1)
+    benchmark (0.4.0)
+    bigdecimal (3.1.9)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.0)
+    diff-lcs (1.6.1)
+    drb (2.2.1)
+    i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.7.1)
-    language_server-protocol (3.17.0.3)
-    minitest (5.21.2)
-    mutex_m (0.2.0)
-    parallel (1.24.0)
-    parser (3.3.0.5)
+    json (2.10.2)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    logger (1.7.0)
+    minitest (5.25.5)
+    mutex_m (0.3.0)
+    parallel (1.26.3)
+    parser (3.3.7.4)
       ast (~> 2.4.1)
       racc
-    racc (1.7.3)
-    rack (3.0.10)
+    prism (1.4.0)
+    racc (1.8.1)
+    rack (3.1.12)
     rainbow (3.1.1)
-    rake (13.1.0)
-    regexp_parser (2.9.0)
-    rexml (3.2.6)
-    rspec (3.12.0)
-      rspec-core (~> 3.12.0)
-      rspec-expectations (~> 3.12.0)
-      rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.2)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.3)
+    rake (13.2.1)
+    regexp_parser (2.10.0)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.3)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.6)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-support (3.12.1)
-    rubocop (1.63.4)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.2)
+    rubocop (1.75.2)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.2)
-      parser (>= 3.3.0.4)
-    rubocop-capybara (2.20.0)
-      rubocop (~> 1.41)
-    rubocop-factory_bot (2.25.1)
-      rubocop (~> 1.41)
-    rubocop-performance (1.20.2)
-      rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-rails (2.24.1)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.44.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-performance (1.25.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.31.0)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.33.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rake (0.6.0)
-      rubocop (~> 1.0)
-    rubocop-rspec (2.29.2)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-      rubocop-rspec_rails (~> 2.28)
-    rubocop-rspec_rails (2.28.3)
-      rubocop (~> 1.40)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.5.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     ruby-progressbar (1.13.0)
-    ruby2_keywords (0.0.5)
-    sevencop (0.35.1)
+    securerandom (0.3.2)
+    sevencop (0.47.0)
       activesupport
       rubocop
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.5.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
 
 PLATFORMS
   ruby

data/README.md

@@ -2,7 +2,7 @@
 
 [![ci](https://github.com/r7kamura/rubocop-migration/actions/workflows/ci.yml/badge.svg)](https://github.com/r7kamura/rubocop-migration/actions/workflows/ci.yml)
 
-RuboCop extension focused on ActiveRecord migration.
+RuboCop plugin for ActiveRecord migration.
 
 ## Usage
 
@@ -13,11 +13,11 @@ Install `rubocop-migration` gem:
 gem 'rubocop-migration', require: false
 ```
 
-then require `rubocop-migration` and enable the cops you want to use in your .rubocop.yml:
+then add `rubocop-migration` to plugins section:
 
 ```yaml
 # .rubocop.yml
-require:
+plugins:
   - rubocop-migration
 
 Migration/AddCheckConstraint:

data/data/reserved_words_mysql.txt

@@ -11,7 +11,6 @@ algorithm
 all
 alter
 always
-analyse
 analyze
 and
 any
@@ -23,6 +22,7 @@ asensitive
 at
 attribute
 authentication
+auto
 auto_increment
 autoextend_size
 avg
@@ -30,6 +30,7 @@ avg_row_length
 backup
 before
 begin
+bernoulli
 between
 bigint
 binary
@@ -42,6 +43,7 @@ boolean
 both
 btree
 buckets
+bulk
 by
 byte
 cache
@@ -128,7 +130,6 @@ delay_key_write
 delayed
 delete
 dense_rank
-des_key_file
 desc
 describe
 description
@@ -211,6 +212,7 @@ full
 fulltext
 function
 general
+generate
 generated
 geomcollection
 geometry
@@ -227,6 +229,7 @@ group_replication
 grouping
 groups
 gtid_only
+gtids
 handler
 hash
 having
@@ -267,6 +270,7 @@ int3
 int4
 int8
 integer
+intersect
 interval
 into
 invisible
@@ -314,6 +318,7 @@ localtimestamp
 lock
 locked
 locks
+log
 logfile
 logs
 long
@@ -321,6 +326,7 @@ longblob
 longtext
 loop
 low_priority
+manual
 master
 master_auto_position
 master_bind
@@ -335,7 +341,6 @@ master_password
 master_port
 master_public_key_path
 master_retry_count
-master_server_id
 master_ssl
 master_ssl_ca
 master_ssl_capath
@@ -435,6 +440,8 @@ over
 owner
 pack_keys
 page
+parallel
+parse_tree
 parser
 partial
 partition
@@ -469,6 +476,7 @@ profile
 profiles
 proxy
 purge
+qualify
 quarter
 query
 quick
@@ -484,7 +492,6 @@ rebuild
 recover
 recursive
 redo_buffer_size
-redofile
 redundant
 reference
 references
@@ -497,7 +504,6 @@ relay_thread
 relaylog
 release
 reload
-remote
 remove
 rename
 reorganize
@@ -546,6 +552,7 @@ row_format
 row_number
 rows
 rtree
+s3
 savepoint
 schedule
 schema
@@ -617,7 +624,6 @@ sql_after_mts_gaps
 sql_before_gtids
 sql_big_result
 sql_buffer_result
-sql_cache
 sql_calc_found_rows
 sql_no_cache
 sql_small_result
@@ -662,6 +668,7 @@ table
 table_checksum
 table_name
 tables
+tablesample
 tablespace
 temporary
 temptable
@@ -705,6 +712,7 @@ unsigned
 until
 update
 upgrade
+url
 usage
 use
 use_frm

data/lib/rubocop/cop/migration/add_check_constraint.rb

@@ -49,6 +49,7 @@ module RuboCop
             autocorrect(corrector, node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/add_column_with_default_value.rb

@@ -56,6 +56,7 @@ module RuboCop
             )
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/add_foreign_key.rb

@@ -51,6 +51,7 @@ module RuboCop
             autocorrect(corrector, node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/add_index_columns_count.rb

@@ -36,6 +36,7 @@ module RuboCop
             message: "Keep unique index columns count less than #{max_columns_count}."
           )
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/add_index_concurrently.rb

@@ -61,6 +61,7 @@ module RuboCop
             end
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/add_index_duplicate.rb

@@ -9,7 +9,7 @@ module RuboCop
       # Avoid adding duplicate indexes.
       #
       # @safety
-      #   This cop tries to find existing indexes from db/schema.rb, but it cannnot be found.
+      #   This cop tries to find existing indexes from db/schema.rb, but it cannot be found.
       #
       # @example
       #   # bad
@@ -39,6 +39,7 @@ module RuboCop
 
           add_offense(node)
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/batch_in_batches.rb

@@ -61,6 +61,7 @@ module RuboCop
             autocorrect(corrector, node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/batch_in_transaction.rb

@@ -58,6 +58,7 @@ module RuboCop
             autocorrect(corrector, node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/batch_with_throttling.rb

@@ -53,6 +53,7 @@ module RuboCop
             autocorrect(corrector, node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/change_column.rb

@@ -76,6 +76,7 @@ module RuboCop
 
           add_offense(node)
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/change_column_null.rb

@@ -52,6 +52,7 @@ module RuboCop
             autocorrect(corrector, node)
           end
         end
+        alias on_csend on_send
 
         private
 
@@ -144,7 +145,7 @@ module RuboCop
           node.first_argument.value.to_s
         end
 
-        # @parm node [RuboCop::AST::SendNode]
+        # @param node [RuboCop::AST::SendNode]
         # @return [String]
         def find_table_name_from_change_column_null(node)
           node.first_argument.value.to_s

data/lib/rubocop/cop/migration/create_table_force.rb

@@ -43,6 +43,7 @@ module RuboCop
             autocorrect(corrector, option_node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/jsonb.rb

@@ -39,6 +39,7 @@ module RuboCop
             corrector.replace(json_range, 'jsonb')
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/remove_column.rb

@@ -10,6 +10,9 @@ module RuboCop
       #
       # Active Record caches database columns at runtime, so if you drop a column, it can cause exceptions until your app reboots.
       #
+      # Note that since this cop goes to read arbitrary model files,
+      # false negatives occur in situations where RuboCop's cache is being used.
+      #
       # @safety
       #   The logic to check if it is included in `ignored_columns` may fail.
       #
@@ -48,6 +51,7 @@ module RuboCop
 
           add_offense(node)
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/rename_column.rb

@@ -56,6 +56,7 @@ module RuboCop
 
           add_offense(node)
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/rename_table.rb

@@ -54,6 +54,7 @@ module RuboCop
 
           add_offense(node)
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/migration/reserved_word_mysql.rb

@@ -19,7 +19,7 @@ module RuboCop
 
         MSG = 'Avoid using MySQL reserved words as identifiers.'
 
-        # Obtained from https://dev.mysql.com/doc/refman/8.0/en/keywords.html.
+        # Obtained from https://dev.mysql.com/doc/refman/8.4/en/keywords.html.
         PATH_TO_RESERVED_WORDS_FILE = File.expand_path(
           '../../../../data/reserved_words_mysql.txt',
           __dir__
@@ -54,6 +54,7 @@ module RuboCop
             add_offense(identifier_node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/migration/plugin.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require 'lint_roller'
+
+module RuboCop
+  module Migration
+    class Plugin < ::LintRoller::Plugin
+      def about
+        ::LintRoller::About.new(
+          description: 'RuboCop plugin for ActiveRecord migration.',
+          homepage: 'https://github.com/r7kamura/rubocop-migration',
+          name: 'rubocop-migration',
+          version: VERSION
+        )
+      end
+
+      def rules(_context)
+        ::LintRoller::Rules.new(
+          config_format: :rubocop,
+          type: :path,
+          value: "#{__dir__}/../../../config/default.yml"
+        )
+      end
+
+      def supported?(context)
+        context.engine == :rubocop
+      end
+    end
+  end
+end

data/lib/rubocop/migration/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-module Rubocop
+module RuboCop
   module Migration
-    VERSION = '0.5.1'
+    VERSION = '0.7.0'
   end
 end

data/lib/rubocop/migration.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require_relative 'migration/cop_concerns'
-require_relative 'migration/rubocop_extension'
+require_relative 'migration/plugin'
 require_relative 'migration/version'
 
 require_relative 'cop/migration/add_check_constraint'

data/rubocop-migration.gemspec

@@ -4,11 +4,11 @@ require_relative 'lib/rubocop/migration/version'
 
 Gem::Specification.new do |spec|
   spec.name = 'rubocop-migration'
-  spec.version = Rubocop::Migration::VERSION
+  spec.version = RuboCop::Migration::VERSION
   spec.authors = ['Ryo Nakamura']
   spec.email = ['r7kamura@gmail.com']
 
-  spec.summary = 'RuboCop extension focused on ActiveRecord migration.'
+  spec.summary = 'RuboCop plugin for ActiveRecord migration.'
   spec.homepage = 'https://github.com/r7kamura/rubocop-migration'
   spec.license = 'MIT'
   spec.required_ruby_version = '>= 2.7'
@@ -16,6 +16,7 @@ Gem::Specification.new do |spec|
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = spec.homepage
   spec.metadata['changelog_uri'] = "#{spec.homepage}/releases"
+  spec.metadata['default_lint_roller_plugin'] = 'RuboCop::Migration::Plugin'
 
   spec.files = Dir.chdir(__dir__) do
     `git ls-files -z`.split("\x0").reject do |f|
@@ -27,6 +28,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'activesupport'
-  spec.add_dependency 'rubocop', '>= 1.34'
+  spec.add_dependency 'lint_roller', '>= 1.1'
+  spec.add_dependency 'rubocop', '>= 1.72.1'
   spec.add_dependency 'rubocop-rails', '>= 2.24'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-migration
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-05-03 00:00:00.000000000 Z
+date: 2025-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -24,20 +24,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.34'
+        version: 1.72.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.34'
+        version: 1.72.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -92,7 +106,7 @@ files:
 - lib/rubocop/migration/cop_concerns/batch_processing.rb
 - lib/rubocop/migration/cop_concerns/column_type_method.rb
 - lib/rubocop/migration/cop_concerns/disable_ddl_transaction.rb
-- lib/rubocop/migration/rubocop_extension.rb
+- lib/rubocop/migration/plugin.rb
 - lib/rubocop/migration/version.rb
 - rubocop-migration.gemspec
 homepage: https://github.com/r7kamura/rubocop-migration
@@ -102,6 +116,7 @@ metadata:
   homepage_uri: https://github.com/r7kamura/rubocop-migration
   source_code_uri: https://github.com/r7kamura/rubocop-migration
   changelog_uri: https://github.com/r7kamura/rubocop-migration/releases
+  default_lint_roller_plugin: RuboCop::Migration::Plugin
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -120,5 +135,5 @@ requirements: []
 rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
-summary: RuboCop extension focused on ActiveRecord migration.
+summary: RuboCop plugin for ActiveRecord migration.
 test_files: []

data/lib/rubocop/migration/rubocop_extension.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-require 'rubocop'
-
-require_relative 'config_loader'
-
-RuboCop::ConfigLoader.instance_variable_set(
-  :@default_configuration,
-  RuboCop::Migration::ConfigLoader.call(
-    path: File.expand_path(
-      '../../../config/default.yml',
-      __dir__
-    )
-  )
-)