rubocop-migration 0.4.0 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 819776e7d688a0d112d1ad7ecc2994125de7bfa7e4b8fe27105f21d2a8061565
-  data.tar.gz: fa2c6bfce21e4dd4ad206e6fb049162ee25b016bc2be01c22782d3dc0871e255
+  metadata.gz: 18f0c1b4fa8be61ca159b11acf5593b9343c4696156171acb9ba5774c422dfab
+  data.tar.gz: 7fd0e0b48fc9d98d1ba4a307a1bb41fbd8068240710954c0bf69e3aedb0c5d9c
 SHA512:
-  metadata.gz: b9fecf517eab16cd9f6c16e302d7a392c0b263a75c164b53a99337b017d4416894fde4eac40874ca53e4fa61c77783f4ef5cbde64007b5388dc6ceefd79d644d
-  data.tar.gz: da06bac2b33c7018964708c0aec62808262e14478b09ff2af0303f6ce00034a57d2331a64ed9fd973ec34012525ec7051b362c71843cbf23f27e17d6f30d5248
+  metadata.gz: '090d29334bcef597b4b9a13f63b9b79494ef0190f458814ea01abeb8d0d48a374b58a60619f06b85737d258ebda0065647f91e96cb98601e0dd53a4847e494ea'
+  data.tar.gz: f7992c9b8468c881508f5aaa091187c75f432368ba0f2e7c4db014fe81f233524c1536b184c067efdab12933ad0a3e0278f5ff3425120d29dc713d8b1478e6ad

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-migration (0.4.0)
+    rubocop-migration (0.4.2)
       activesupport
       rubocop (>= 1.34)
       rubocop-rails
@@ -9,22 +9,22 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.4)
+    activesupport (7.0.6)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
     ast (2.4.2)
-    concurrent-ruby (1.1.10)
+    concurrent-ruby (1.2.2)
     diff-lcs (1.5.0)
-    i18n (1.12.0)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     json (2.6.2)
-    minitest (5.16.3)
+    minitest (5.18.1)
     parallel (1.22.1)
     parser (3.1.2.1)
       ast (~> 2.4.1)
-    rack (3.0.0)
+    rack (3.0.8)
     rainbow (3.1.1)
     rake (13.0.6)
     regexp_parser (2.6.0)
@@ -57,7 +57,7 @@ GEM
     rubocop-performance (1.15.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.17.0)
+    rubocop-rails (2.20.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
@@ -68,7 +68,7 @@ GEM
     ruby-progressbar (1.11.0)
     sevencop (0.21.0)
       rubocop
-    tzinfo (2.0.5)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.3.0)
 

data/README.md

@@ -1,6 +1,6 @@
 # rubocop-migration
 
-[![test](https://github.com/r7kamura/rubocop-migration/actions/workflows/test.yml/badge.svg)](https://github.com/r7kamura/rubocop-migration/actions/workflows/test.yml)
+[![ci](https://github.com/r7kamura/rubocop-migration/actions/workflows/ci.yml/badge.svg)](https://github.com/r7kamura/rubocop-migration/actions/workflows/ci.yml)
 
 RuboCop extension focused on ActiveRecord migration.
 
@@ -21,7 +21,7 @@ require:
   - rubocop-migration
 
 Migration/AddCheckConstraint:
-  Enabled: false
+  Enabled: true
 ```
 
 Note that all cops are `Enabled: false` by default.

data/lib/rubocop/cop/migration/add_index_concurrently.rb

@@ -30,9 +30,12 @@ module RuboCop
         extend AutoCorrector
 
         include ::RuboCop::Migration::CopConcerns::DisableDdlTransaction
+        include RangeHelp
 
         MSG = 'Use `algorithm: :concurrently` on adding indexes to existing tables in PostgreSQL.'
 
+        MESSAGE_FOR_DUPLICATED_DISABLE_DDL_TRANSACTION = 'Remove duplicated `disable_ddl_transaction!`.'
+
         RESTRICT_ON_SEND = %i[
           add_index
           index
@@ -41,10 +44,21 @@ module RuboCop
         # @param node [RuboCop::AST::SendNode]
         # @return [void]
         def on_send(node)
-          return unless bad?(node)
+          if add_index_without_concurrency?(node)
+            add_offense(node) do |corrector|
+              autocorrect(corrector, node)
+            end
+          end
 
-          add_offense(node) do |corrector|
-            autocorrect(corrector, node)
+          duplicated_disable_ddl_transactions_from(node).each do |disable_ddl_transactions_node|
+            add_offense(node, message: MESSAGE_FOR_DUPLICATED_DISABLE_DDL_TRANSACTION) do |corrector|
+              corrector.remove(
+                range_with_surrounding_space(
+                  disable_ddl_transactions_node.source_range,
+                  side: :left
+                )
+              )
+            end
           end
         end
 
@@ -116,6 +130,17 @@ module RuboCop
           )
         PATTERN
 
+        # @param node [RuboCop::AST::SendNode]
+        # @return [Boolean]
+        def add_index_without_concurrency?(node)
+          case node.method_name
+          when :add_index
+            add_index?(node) && !add_index_concurrently?(node)
+          when :index
+            index?(node) && in_change_table?(node) && !index_concurrently?(node)
+          end
+        end
+
         # @param corrector [RuboCop::Cop::Corrector]
         # @param node [RuboCop::AST::SendNode]
         # @return [void]
@@ -128,14 +153,9 @@ module RuboCop
         end
 
         # @param node [RuboCop::AST::SendNode]
-        # @return [Boolean]
-        def bad?(node)
-          case node.method_name
-          when :add_index
-            add_index?(node) && !add_index_concurrently?(node)
-          when :index
-            index?(node) && in_change_table?(node) && !index_concurrently?(node)
-          end
+        # @return [Array<RuboCop::AST::SendNode>]
+        def duplicated_disable_ddl_transactions_from(node)
+          disable_ddl_transactions_from(node)[1..] || []
         end
 
         # @param node [RuboCop::AST::SendNode]

data/lib/rubocop/cop/migration/remove_column.rb

@@ -135,15 +135,18 @@ module RuboCop
         # @param node [RuboCop::AST::SendNode]
         # @return [String, nil]
         def find_table_name_from(node)
-          node.arguments[0].value&.to_s
+          table_name_node = node.arguments[0]
+          table_name_node.value&.to_s if table_name_node.respond_to?(:value)
         end
 
+        # @note This method returns `true` if the table name cannot be determined.
         # @param node [RuboCop::AST::SendNode]
         # @return [Boolean]
         def ignored?(node)
-          find_ignored_column_names_from(
-            find_table_name_from(node)
-          ).include?(
+          table_name = find_table_name_from(node)
+          return true unless table_name
+
+          find_ignored_column_names_from(table_name).include?(
             find_column_name_from(node)
           )
         end

data/lib/rubocop/migration/cop_concerns/disable_ddl_transaction.rb

@@ -24,6 +24,15 @@ module RuboCop
 
         private
 
+        # @param node [RuboCop::AST::SendNode]
+        # @return [Array<RuboCop::AST::SendNode>]
+        def disable_ddl_transactions_from(node)
+          node.each_ancestor(:def).first&.left_siblings&.select do |sibling|
+            sibling.is_a?(::RuboCop::AST::SendNode) &&
+              disable_ddl_transaction?(sibling)
+          end || []
+        end
+
         # @param corrector [RuboCop::Cop::Corrector]
         # @param node [RuboCop::AST::SendNode]
         # @return [void]
@@ -40,10 +49,7 @@ module RuboCop
         # @param node [RuboCop::AST::SendNode]
         # @return [Boolean]
         def within_disable_ddl_transaction?(node)
-          node.each_ancestor(:def).first&.left_siblings&.any? do |sibling|
-            sibling.is_a?(::RuboCop::AST::SendNode) &&
-              disable_ddl_transaction?(sibling)
-          end
+          !disable_ddl_transactions_from(node).empty?
         end
       end
     end

data/lib/rubocop/migration/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Migration
-    VERSION = '0.4.0'
+    VERSION = '0.4.2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-migration
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.2
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-10-22 00:00:00.000000000 Z
+date: 2023-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -117,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: RuboCop extension focused on ActiveRecord migration.