rubocop-mable 0.1.5 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b59a5fc99bec56362c41b540f37058dabfc1e16b3ac9bb6db72c64f5f16495f
-  data.tar.gz: 60135942aab111fa27f46225f839edbcca834e97e37737cc303774496c1febfc
+  metadata.gz: 1bca068bb2c89a375fbda2d37300873f3898e3a0028a84549c17c69e61494f63
+  data.tar.gz: 98f533099ff194d28041160f5cd8a62dba9672f849740509f9d8a18b180def76
 SHA512:
-  metadata.gz: 97a1ae86f7a089288e6444b50ac1eccfb5e04457c4155b5bab6f34c0a8388ff36528e9f0dba95130c574525af2eca8d0cf8a72ab09c7b249d7054b05985a2ce4
-  data.tar.gz: f527513322bef9827c28b64100e3eae9c413ec559b77b049579cc4683923b54a4ed2756159cdb289d2370c49957bc144d78efc06c9964f6acc628c28035ca581
+  metadata.gz: 68f10a6d3425f42cd7eb4953f17fffcafcaf9b421a62d9fd0197ca61c3bfca4bb38184dfa582582277c7236d2340f46efb68d6efe4264c184bf63be2c9e10c8a
+  data.tar.gz: ce9903db8493da5a29030517c4f0a4a76e1c9491e80e9957f6659ee7fea6dc02f1d65e999b4acaaa401c57ed43c4fc3b41aabe1fbc248056cc3640e34a4b18d6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-mable (0.1.5)
+    rubocop-mable (0.1.8)
       rubocop
 
 GEM
@@ -10,18 +10,20 @@ GEM
     ast (2.4.2)
     coderay (1.1.3)
     diff-lcs (1.5.0)
-    json (2.6.2)
+    json (2.7.2)
+    language_server-protocol (3.17.0.3)
     method_source (1.0.0)
-    parallel (1.22.1)
-    parser (3.1.2.0)
+    parallel (1.26.3)
+    parser (3.3.5.0)
       ast (~> 2.4.1)
+      racc
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    racc (1.8.1)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.5.0)
-    rexml (3.2.5)
+    regexp_parser (2.9.2)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
       rspec-expectations (~> 3.11.0)
@@ -35,24 +37,24 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
-    rubocop (1.31.2)
+    rubocop (1.67.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.18.0, < 2.0)
+      regexp_parser (>= 2.4, < 3.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.19.1)
-      parser (>= 3.1.1.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.32.3)
+      parser (>= 3.3.1.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
     rubocop-rspec (2.12.1)
       rubocop (~> 1.31)
-    ruby-progressbar (1.11.0)
-    unicode-display_width (2.2.0)
+    ruby-progressbar (1.13.0)
+    unicode-display_width (2.6.0)
 
 PLATFORMS
   arm64-darwin-21

data/README.md

@@ -37,8 +37,17 @@ Enabled: true
 Description: 'Avoid hardcoding factory bot database IDs, instead, dynamically test for the ID'
 VersionAdded: '0.1.1'
 
+Mable/UsingDeprecatedFFClient:
+  Description: "Using deprecated FeatureFlags::Client use FeatureFlags::Repo instead"
+  Enabled: true
+  SafeAutoCorrect: true
+  VersionAdded: "0.1.8"
 ```
 
+## TODO
+
+- No interpolating SQL use santitize instead
+
 ## Installation
 
 Install the gem and add to the application's Gemfile by executing:

data/config/default.yml

@@ -28,3 +28,9 @@ Mable/NoWardenInGraphQL:
   Enabled: true
   SafeAutoCorrect: false
   VersionAdded: "0.1.5"
+
+Mable/UsingDeprecatedFFClient:
+  Description: "Using deprecated FeatureFlags::Client use FeatureFlags::Repo instead"
+  Enabled: true
+  SafeAutoCorrect: true
+  VersionAdded: "0.1.8"

data/lib/rubocop/cop/mable/no_post_in_graph_ql.rb

@@ -35,6 +35,10 @@ module RuboCop
                   (pair (sym :variables) _)? # Optional :variables pair
                 )
               )
+              (pair # Optional as: :json
+                (sym :as)
+                (sym :json)
+              )?
             )
           )
         PATTERN

data/lib/rubocop/cop/mable/using_deprecated_ff_client.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Mable
+      # We are in the process of transitioning out the old FeatureFlags::Client and
+      # want people to be using FeatureFlags::Repo
+      #
+      # @example
+      #
+      #   # bad
+      #   FeatureFlags::Client.get_feature_flag("test", uuid: user.id)
+      #
+      #   # good
+      #   FeatureFlags::Repo.get_feature_flag("test", uuid: user.id)
+      #
+      class UsingDeprecatedFFClient < Base
+        extend AutoCorrector
+
+        MSG = 'FeatureFlags::Client is deprecated, please use FeatureFlags::Repo'
+
+        def_node_matcher :deprecated_ff_client?, <<~PATTERN
+          `(const (const nil? :FeatureFlags) :Client)
+        PATTERN
+
+        def on_send(node)
+          expression = deprecated_ff_client?(node)
+          return unless expression
+
+          add_offense(node) do |corrector|
+            replacement = node.source.sub('FeatureFlags::Client', 'FeatureFlags::Repo')
+            corrector.replace(node, replacement)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/mable_cops.rb

@@ -5,3 +5,4 @@ require_relative 'mable/hardcoded_database_factory_bot_id'
 require_relative 'mable/no_post_in_graph_ql'
 require_relative 'mable/no_safety_assured'
 require_relative 'mable/no_warden_in_graph_ql'
+require_relative 'mable/using_deprecated_ff_client'

data/lib/rubocop/mable/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Mable
-    VERSION = '0.1.5'
+    VERSION = '0.1.8'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-mable
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.8
 platform: ruby
 authors:
 - Mable Engineers
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-05 00:00:00.000000000 Z
+date: 2024-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -62,6 +62,7 @@ files:
 - lib/rubocop/cop/mable/no_post_in_graph_ql.rb
 - lib/rubocop/cop/mable/no_safety_assured.rb
 - lib/rubocop/cop/mable/no_warden_in_graph_ql.rb
+- lib/rubocop/cop/mable/using_deprecated_ff_client.rb
 - lib/rubocop/cop/mable_cops.rb
 - lib/rubocop/mable.rb
 - lib/rubocop/mable/inject.rb