rubocop-mable 0.1.4 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11f4a0980ecdeb9bd5423be381dd7a644af6c9d6b88588ea3c19142103d07f15
-  data.tar.gz: 9b7b498e693680865f1c195913feb385c6d125cee1ad92869aaa327b1f6d8e69
+  metadata.gz: 5c6836a4902321048de028d906072325dcb6072573fe27c0e1800a6e35ec0b2e
+  data.tar.gz: eabeca443fa5ed0d1aca35175ccbd4e7e08ce364f5ff85a4f84a88c4d2916955
 SHA512:
-  metadata.gz: 8bd1daf2d6d0e8e11ae71e6a0827c43b3a2e4f2600ad37e5fad6836189eb0ad23bd11db73872a52a07035b944d0cded9bd1d1159bf5bfac9b3fdcfec3a12cc06
-  data.tar.gz: 765c60614e41af4a95e45c2136ab5464b68d2ecb5d21ebebab6e3b0dfa2f93737756f659db49893eee21c0bedd35e722fd97350ac853db6373ffff58bc144be0
+  metadata.gz: ce306a1ba5e7ac0fe0dea200fa063d7baebca9cc970a4913c2a0fdaa3efc60a97a3dc31bce104b2f202bbaefdc3de257eeb2e00f97e3d0fc71f41bf3c5f89ced
+  data.tar.gz: a81fc0e7bdc6449dd3a14f17c594d6c609beed466c292cfd2ac9a927f3083a3e8391ecaca5ba66bf008c4e75c695870ce1ed4ab50b247f88cc48693aedb9608d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-mable (0.1.4)
+    rubocop-mable (0.1.6)
       rubocop
 
 GEM

data/README.md

@@ -6,6 +6,12 @@ Mable's custom Rubocop cops
 
 ```
 
+Mable/NoWardenInGraphQL:
+  Description: "No Warden in graphQL use helper method instead see - Mable/NoPostInGraphQL"
+  Enabled: true
+  SafeAutoCorrect: false
+  VersionAdded: "0.1.5"
+
 Mable/NoPostInGraphQL:
 Description: "Use graphQL helper method instead of use rails/rack request stack"
 Enabled: true
@@ -33,6 +39,10 @@ VersionAdded: '0.1.1'
 
 ```
 
+## TODO
+
+- No interpolating SQL use santitize instead
+
 ## Installation
 
 Install the gem and add to the application's Gemfile by executing:

data/config/default.yml

@@ -22,3 +22,9 @@ Mable/NoPostInGraphQL:
   AllowedGraphQLPaths:
     - "/graphql"
     - "graphql_path"
+
+Mable/NoWardenInGraphQL:
+  Description: "No Warden in graphQL use helper method instead see - Mable/NoPostInGraphQL"
+  Enabled: true
+  SafeAutoCorrect: false
+  VersionAdded: "0.1.5"

data/lib/rubocop/cop/mable/no_post_in_graph_ql.rb

@@ -35,6 +35,10 @@ module RuboCop
                   (pair (sym :variables) _)? # Optional :variables pair
                 )
               )
+              (pair # Optional as: :json
+                (sym :as)
+                (sym :json)
+              )?
             )
           )
         PATTERN

data/lib/rubocop/cop/mable/no_warden_in_graph_ql.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Mable
+      # This cop checks for the usage of Warden::Test::Helpers and related
+      # methods within GraphQL specs. It disallows the use of Warden.test_mode!,
+      # login_as, and user.reload.
+      #
+      # @safety
+      #   Unsafe as requires graphql helper method to replace
+      #
+      # @example
+      #   # bad
+      #   Warden.test_mode!
+      #   login_as(user)
+      #   user.reload
+      #   include Warden::Test::Helpers
+      #
+      #   # good
+      #   # Use graphql helper method
+      class NoWardenInGraphQL < Base
+        include RangeHelp
+        extend AutoCorrector
+
+        MSG = 'Do not use `%<method>s` in GraphQL specs. Use graphql helper method instead.'
+
+        RESTRICT_ON_SEND = %i[test_mode! login_as reload].freeze
+        RESTRICT_ON_INCLUDE = %i[Warden::Test::Helpers].freeze
+
+        def_node_search :rspec_describe_graphql?, <<~PATTERN
+          (block
+            (send (const nil? :RSpec) :describe
+              (const { (const nil? {:Graphql :Queries :Mutations}) } _)
+              ...)
+            ...)
+        PATTERN
+
+        def_node_matcher :user_reload?, <<~PATTERN
+          (send
+            (send _ :user) :reload)
+        PATTERN
+
+        def on_send(node)
+          return unless in_graphql?(node) && bad_method?(node)
+
+          method_name = node.method_name
+          add_offense(node, message: format(MSG, method: method_name)) do |corrector|
+            correct_offense(corrector, node)
+          end
+        end
+
+        def on_const(node)
+          return unless in_graphql?(node) && bad_include?(node)
+
+          add_offense(node, message: format(MSG, method: 'include Warden::Test::Helpers')) do |corrector|
+            correct_offense(corrector, node)
+          end
+        end
+
+        private
+
+        def in_graphql?(node)
+          node.each_ancestor(:block).any? do |ancestor|
+            rspec_describe_graphql?(ancestor)
+          end
+        end
+
+        def bad_method?(node)
+          if node.method_name == :reload
+            user_reload?(node)
+          else
+            RESTRICT_ON_SEND.include?(node.method_name)
+          end
+        end
+
+        def bad_include?(node)
+          RESTRICT_ON_INCLUDE.include?(node.const_name.to_sym)
+        end
+
+        def correct_offense(corrector, node)
+          if node.send_type? && bad_method?(node)
+            corrector.remove(range_with_comments_and_lines(node))
+          elsif node.const_type? && node.const_name == 'Warden::Test::Helpers'
+            corrector.remove(range_with_comments_and_lines(node.parent))
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/mable_cops.rb

@@ -4,3 +4,4 @@ require_relative 'mable/graph_ql_helper_specs'
 require_relative 'mable/hardcoded_database_factory_bot_id'
 require_relative 'mable/no_post_in_graph_ql'
 require_relative 'mable/no_safety_assured'
+require_relative 'mable/no_warden_in_graph_ql'

data/lib/rubocop/mable/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Mable
-    VERSION = '0.1.4'
+    VERSION = '0.1.6'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-mable
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.6
 platform: ruby
 authors:
 - Mable Engineers
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-05 00:00:00.000000000 Z
+date: 2024-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -61,6 +61,7 @@ files:
 - lib/rubocop/cop/mable/hardcoded_database_factory_bot_id.rb
 - lib/rubocop/cop/mable/no_post_in_graph_ql.rb
 - lib/rubocop/cop/mable/no_safety_assured.rb
+- lib/rubocop/cop/mable/no_warden_in_graph_ql.rb
 - lib/rubocop/cop/mable_cops.rb
 - lib/rubocop/mable.rb
 - lib/rubocop/mable/inject.rb