rubocop-legion 0.1.9 → 0.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88034e8168ad8e5634a580f3a07ca2f030bd46be31b6c9607dbc64a28935bcd0
-  data.tar.gz: 353647b902a3271fe17809769674778b528eb3e97dda8704934addf80b69b397
+  metadata.gz: ab19d4bce0d274768b632aa0579aa8997cb503befa24d4d613442f4cc894cb09
+  data.tar.gz: 85caebdfc215b98b74febd7b59c09c90fc6574e36f9dd2c126c866ca43138cde
 SHA512:
-  metadata.gz: 0b7d05703e9bd6762628d25f082a738fba9972f66eda2b650ab5e3c0dace6b3569df16c754f935f8f62caf861eaf3984018c3a4f3f73de01cc0871fcf91cfebd
-  data.tar.gz: d598e5090c4ba1242ec371fd2d3b935412f9fe8c4e24fe907a9e18bd6052999568bed0c252a983559e4b33e1c0502a724e02df5244db46b98c5cdad899f62e93
+  metadata.gz: 93425642d48e67c4897e9466b34394aa88b43048435c0841d0c6b1c05a6eee4ce022fd3211757ed6a3de084b5f154dea614a764e763b92a845be779cc717a0b9
+  data.tar.gz: e45f70a81e9e658b90e984a5561e027d88044450831c0a714d31f96a231e3933662128d167b60666624d3631077672898f8e5a50627c77e267423b00f9fb32f2

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## [0.1.11] - 2026-08-04
+
+### Added
+- New cop `Legion/Framework/NoUnusedArgDisable` (universal): bans `# rubocop:disable`/`:todo`/`:enable Lint/UnusedMethodArgument`. An unused kwarg is a real offense, not something to hide — autocorrect removes the directive so it resurfaces and must be fixed properly (drop the arg, or `**` → `**opts` and read `opts[:key]`). Single-cop directives autocorrect; multi-cop directives are flagged without autocorrect. `# rubocop:disable all` is out of scope.
+
+### Fixed
+- `Legion/Framework/NoUnderscorePrefixedKwargs` now autocorrects an unused splat (`**_opts`, `**_rest`, `**_`) to `**` (nameless accept-and-ignore) instead of `**opts`. The underscore signals the splat is unused; rewriting to a named `**opts` produced a named-but-unused splat that falsely claims the body reads `opts`. `**opts` is correct only when the body actually reads it.
+
+## [0.1.10] - 2026-07-31
+
+### Fixed
+- `Legion/Llm/TaxonomyEnum` no longer over-matches: `:type` is only validated when it appears alongside `:tier` or `:circuit_state` in the same hash (taxonomy context). Previously any `{ type: :string }` or schema hash triggered a false positive.
+- Added `Legion/Llm` department to `config/default.yml` — all four cops (`TaxonomyEnum`, `SettingsAccessPath`, `NoLoopDo`, `RescueLogLevel`) were loaded but never registered in the config, causing consumer repos to report "unrecognized cop" when referencing `Legion/Llm/TaxonomyEnum`.
+- `TaxonomyEnum` is now Include-scoped to `lib/legion/llm/**/*.rb` and `lib/legion/extensions/llm/**/*.rb` so it only runs on LLM routing code.
+
 ## [0.1.8] - 2026-06-16
 
 ### Added

data/config/default.yml

@@ -340,11 +340,17 @@ Legion/Extension/DefinitionCallMismatched:
 # Legion/Framework — N×N routing guard cops (Phase 6 enforcement)
 
 Legion/Framework/NoUnderscorePrefixedKwargs:
-  Description: 'Ban underscore-prefixed kwargs and `**_rest` splats. Use plain kwarg, defaulted kwarg, or `**opts`.'
+  Description: 'Ban underscore-prefixed kwargs and `**_rest` splats. Use plain kwarg, defaulted kwarg, `**opts`, or `**`.'
   Enabled: true
   Severity: warning
   VersionAdded: '0.1.8'
 
+Legion/Framework/NoUnusedArgDisable:
+  Description: 'Ban `# rubocop:disable Lint/UnusedMethodArgument`. Drop the arg or use `**opts`.'
+  Enabled: true
+  Severity: warning
+  VersionAdded: '0.1.11'
+
 Legion/Framework/NoInlineSettingDefaults:
   Description: 'Flag `Legion::Settings[...] || <literal>` and shadow-default patterns. Defaults belong in `settings.rb`.'
   Enabled: true
@@ -363,3 +369,38 @@ Legion/Framework/NoShapeDuckTyping:
   Severity: convention
   VersionAdded: '0.1.8'
   Safe: false
+
+# Legion/Llm — cops specific to legion-llm and lex-llm-* provider pipelines
+
+Legion/Llm:
+  Enabled: true
+  Include:
+    - 'lib/legion/llm/**/*.rb'
+    - 'lib/legion/extensions/llm/**/*.rb'
+
+Legion/Llm/TaxonomyEnum:
+  Description: 'Validate :tier, :type, and :circuit_state literals against LegionIO taxonomy enums.'
+  Enabled: true
+  Severity: convention
+  VersionAdded: '0.1.9'
+  Include:
+    - 'lib/legion/llm/**/*.rb'
+    - 'lib/legion/extensions/llm/**/*.rb'
+
+Legion/Llm/SettingsAccessPath:
+  Description: 'Use `Legion::Settings.dig(...)` instead of `Legion::Settings.loader.settings[...][...]`.'
+  Enabled: true
+  Severity: convention
+  VersionAdded: '0.1.9'
+
+Legion/Llm/NoLoopDo:
+  Description: 'Ban `loop do` — use bounded iteration (`N.times`, `each`, or `while` with explicit bound).'
+  Enabled: true
+  Severity: warning
+  VersionAdded: '0.1.9'
+
+Legion/Llm/RescueLogLevel:
+  Description: 'Minimum log level for `handle_exception` in rescue blocks is `:warn`.'
+  Enabled: true
+  Severity: warning
+  VersionAdded: '0.1.9'

data/lib/rubocop/cop/legion/framework/no_underscore_prefixed_kwargs.rb

@@ -18,15 +18,16 @@ module RuboCop
         #   # good
         #   def foo(bar:); end
         #   def foo(bar: nil); end
-        #   def foo(**opts); end
+        #   def foo(**); end       # unused passthrough
+        #   def foo(**opts); end   # only when the body reads `opts`
         class NoUnderscorePrefixedKwargs < Base
           extend AutoCorrector
 
           MSG_KWARG = 'Underscore-prefixed kwarg `%<name>s` is not allowed. ' \
                       'Use plain kwarg (required), defaulted kwarg (optional), ' \
                       'or `**opts` for passthrough.'
-          MSG_SPLAT = 'Underscore-prefixed kwarg splat `%<name>s` is not allowed. ' \
-                      'Use `**opts` for passthrough.'
+          MSG_SPLAT = 'Underscore-prefixed splat `%<name>s` means unused — use `**` to ' \
+                      'accept-and-ignore, or `**opts` only if the body reads `opts`.'
 
           def on_def(node)
             check_params(node)
@@ -70,7 +71,7 @@ module RuboCop
             return unless name.to_s.start_with?('_')
 
             add_offense(arg, message: format(MSG_SPLAT, name: name)) do |corrector|
-              corrector.replace(arg.source_range, '**opts')
+              corrector.replace(arg.source_range, '**')
             end
           end
 

data/lib/rubocop/cop/legion/framework/no_unused_arg_disable.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Legion
+      module Framework
+        # Bans disabling `Lint/UnusedMethodArgument` with an inline directive.
+        # An unused kwarg is a real offense, not something to hide — a `**` /
+        # `**opts` splat already swallows extras, so the arg should be dropped;
+        # if it is genuinely optional, change `**` to `**opts` and read
+        # `opts[:key]`. RuboCop's own `RedundantCopDisableDirective` never flags
+        # this because the offense is genuine, so the directive stays invisible.
+        #
+        # Autocorrect removes the directive so the real `Lint/UnusedMethodArgument`
+        # offense resurfaces and must be fixed properly. It never edits the method
+        # signature — dropping a load-bearing public kwarg is a human decision.
+        #
+        # A blanket "disable all" directive is intentionally out of scope; only
+        # directives that name `Lint/UnusedMethodArgument` explicitly are flagged.
+        #
+        # @example
+        #   # bad — a disable directive naming Lint/UnusedMethodArgument on the def
+        #   def foo(bar:, unused:)
+        #   end
+        #
+        #   # good — drop the unused arg (a splat already swallows it)
+        #   def foo(bar:, **)
+        #   end
+        #
+        #   # good — keep it and actually read it
+        #   def foo(bar:, **opts)
+        #     opts[:unused]
+        #   end
+        class NoUnusedArgDisable < Base
+          include RangeHelp
+          extend AutoCorrector
+
+          MSG = 'Do not disable `Lint/UnusedMethodArgument`. Drop the unused arg ' \
+                '(a `**`/`**opts` splat already swallows it) or change `**` to ' \
+                '`**opts` and read `opts[:key]`.'
+
+          TARGET = 'Lint/UnusedMethodArgument'
+
+          # Matches a disable / todo / enable directive and captures the cop list.
+          DIRECTIVE = /#\s*rubocop:(?:disable|todo|enable)\s+(?<cops>[^#]+)/
+
+          def on_new_investigation
+            processed_source.comments.each do |comment|
+              match = DIRECTIVE.match(comment.text)
+              next unless match
+
+              cops = match[:cops].split(',').map(&:strip)
+              next unless cops.include?(TARGET)
+
+              register(comment, cops)
+            end
+          end
+
+          private
+
+          def register(comment, cops)
+            add_offense(comment) do |corrector|
+              # Only autocorrect the unambiguous single-cop case; leave multi-cop
+              # directives to a human so we never strip an unrelated disable.
+              corrector.remove(removal_range(comment)) if cops == [TARGET]
+            end
+          end
+
+          # Trailing directive (`code # rubocop:disable ...`) → strip the comment
+          # and the whitespace before it. Standalone directive line → strip the
+          # whole line including its newline.
+          def removal_range(comment)
+            range = comment.source_range
+            line_range = range.source_line
+            leading = line_range[0...range.column]
+
+            if leading.strip.empty?
+              range_by_whole_lines(range, include_final_newline: true)
+            else
+              range.with(begin_pos: range.begin_pos - trailing_ws(leading))
+            end
+          end
+
+          def trailing_ws(leading)
+            leading.length - leading.rstrip.length
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/legion/llm/taxonomy_enum.rb

@@ -8,6 +8,11 @@ module RuboCop
         # Flags `:tier`, `:type`, and `:circuit_state` literals that are not in
         # the known-valid sets, catching typos at lint time.
         #
+        # `:tier` and `:circuit_state` are domain-specific keys and are always
+        # validated. `:type` is only validated when it appears in a hash that
+        # also contains `:tier` or `:circuit_state`, since `:type` alone is too
+        # common in non-taxonomy contexts.
+        #
         # Valid values (from Inventory::DEFAULT_PROVIDER_TIERS and the SSOT design):
         #   tier:          :local, :fleet, :cloud, :frontier, :direct
         #   type:          :inference, :embedding, :moderation, :rerank, :image
@@ -17,15 +22,24 @@ module RuboCop
         #   # bad  (typo)
         #   { tier: :fronteir }
         #   health[:circuit_state] = :half_opened
+        #   { tier: :cloud, type: :inferencing }
         #
         #   # good
         #   { tier: :frontier }
         #   health[:circuit_state] = :half_open
+        #   { tier: :cloud, type: :inference }
+        #
+        #   # ignored (`:type` alone, no taxonomy context)
+        #   { type: :string }
+        #   { type: :integer }
         class TaxonomyEnum < Base
           VALID_TIERS          = %i[local fleet cloud frontier direct].freeze
           VALID_TYPES          = %i[inference embedding moderation rerank image].freeze
           VALID_CIRCUIT_STATES = %i[closed open half_open].freeze
 
+          TAXONOMY_KEYS = %i[tier type circuit_state].freeze
+          CONTEXT_KEYS  = %i[tier circuit_state].freeze
+
           MSG_TIER    = 'Unknown tier `%<val>s`. Valid: %<valid>s.'
           MSG_TYPE    = 'Unknown type `%<val>s`. Valid: %<valid>s.'
           MSG_CIRCUIT = 'Unknown circuit_state `%<val>s`. Valid: %<valid>s.'
@@ -38,7 +52,6 @@ module RuboCop
           end
 
           def on_send(node)
-            # health[:circuit_state] = :bad_value
             return unless node.method_name == :[]=
             return unless node.arguments.size == 2
 
@@ -54,22 +67,34 @@ module RuboCop
             val = val_node.value
             case key
             when :tier
-              unless VALID_TIERS.include?(val)
-                add_offense(parent_node,
-                            message: format(MSG_TIER, val: val, valid: VALID_TIERS.join(', ')))
-              end
+              return if VALID_TIERS.include?(val)
+
+              add_offense(parent_node,
+                          message: format(MSG_TIER, val: val, valid: VALID_TIERS.join(', ')))
             when :type
-              unless VALID_TYPES.include?(val)
-                add_offense(parent_node,
-                            message: format(MSG_TYPE, val: val, valid: VALID_TYPES.join(', ')))
-              end
+              return if VALID_TYPES.include?(val)
+              return unless taxonomy_context?(parent_node)
+
+              add_offense(parent_node,
+                          message: format(MSG_TYPE, val: val, valid: VALID_TYPES.join(', ')))
             when :circuit_state
-              unless VALID_CIRCUIT_STATES.include?(val)
-                msg = format(MSG_CIRCUIT, val: val, valid: VALID_CIRCUIT_STATES.join(', '))
-                add_offense(parent_node, message: msg)
-              end
+              return if VALID_CIRCUIT_STATES.include?(val)
+
+              add_offense(parent_node,
+                          message: format(MSG_CIRCUIT, val: val, valid: VALID_CIRCUIT_STATES.join(', ')))
             end
           end
+
+          def taxonomy_context?(pair_node)
+            hash_node = pair_node.parent
+            return false unless hash_node&.hash_type?
+
+            sibling_keys = hash_node.pairs.filter_map do |pair|
+              pair.key.value if pair.key.sym_type?
+            end
+
+            sibling_keys.intersect?(CONTEXT_KEYS)
+          end
         end
       end
     end

data/lib/rubocop/legion/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Legion
-    VERSION = '0.1.9'
+    VERSION = '0.1.11'
   end
 end

data/lib/rubocop-legion.rb

@@ -45,6 +45,7 @@ require 'rubocop/cop/legion/framework/cache_time_coercion'
 require 'rubocop/cop/legion/framework/api_string_keys'
 require 'rubocop/cop/legion/framework/mutex_nested_sync'
 require 'rubocop/cop/legion/framework/no_underscore_prefixed_kwargs'
+require 'rubocop/cop/legion/framework/no_unused_arg_disable'
 require 'rubocop/cop/legion/framework/no_inline_setting_defaults'
 require 'rubocop/cop/legion/framework/no_direct_dispatch'
 require 'rubocop/cop/legion/framework/no_shape_duck_typing'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-legion
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.11
 platform: ruby
 authors:
 - Esity
@@ -148,6 +148,7 @@ files:
 - lib/rubocop/cop/legion/framework/no_inline_setting_defaults.rb
 - lib/rubocop/cop/legion/framework/no_shape_duck_typing.rb
 - lib/rubocop/cop/legion/framework/no_underscore_prefixed_kwargs.rb
+- lib/rubocop/cop/legion/framework/no_unused_arg_disable.rb
 - lib/rubocop/cop/legion/framework/sinatra_host_auth.rb
 - lib/rubocop/cop/legion/framework/thor_reserved_run.rb
 - lib/rubocop/cop/legion/helper_migration/defined_transport_guard.rb