rubocop-legion 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95a23a8136fd63ac2b841d9a8812c04f261854fac9e752f40e9817f3e8288fc0
-  data.tar.gz: 4512d622e170d83a4fb5d1911d6f91d12130157bdd4adbbd422d8aca5e401649
+  metadata.gz: 1d2c3a1967dcc9bd66a2c806d2b471b59594d51ae9fec7c2c3eaad9946898932
+  data.tar.gz: cdd7fcb62b6b0ff1eb17d595aa6a7b76259fdefa7ae5ecd6d6b1306f98e817c1
 SHA512:
-  metadata.gz: febd09cfcb352235365fead149fc2679fec7a4f7c2836ca9f85c06a9e2fc25a3bdb4a6e3914ef79cfc3f636acba681c9d84cdf3b22945be6e43bd8b276a01bd7
-  data.tar.gz: efe2d65b67d0bfa191d0db52d894e87f1cec09c14f0a1bab8a286bc496ad67d1bac8ea98e856dff89c16fe61c0793c766e2ef0711867eae5d746d8b5953c3841
+  metadata.gz: 0515bb7d5ea06e80069a937b9899e23bf281366660d718cd707460b0ed63a9955ed4ff531f6e592c9b203ea090bda1ba620d5d80fbb4b758dab3b91f9190dc71
+  data.tar.gz: 673910f539a627bd4697e1bfd86ee8c8b0f9644d257090fafcad43907bd080af80be71e961340e53be6077251dd8dd302b957fcb8d74a4418be228b3f6fd175c

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## [0.1.2] - 2026-03-29
+
+### Added
+- New cop `Legion/HelperMigration/LoggingGuard`: flags unnecessary `respond_to?(:log_warn)` etc. and `defined?(Legion::Logging)` guards
+
+## [0.1.1] - 2026-03-29
+
+### Fixed
+- BareRescue auto-corrector no longer corrupts inline rescue modifiers (`foo rescue nil`)
+- NoCapture removed auto-correct to prevent correction loop with Lint/UselessAssignment
+- SilentCapture skips `_`-prefixed variables (Ruby unused variable convention)
+
+### Changed
+- HelperMigration cops scoped to `lib/legion/extensions/**/*.rb` (lex-* gems only)
+- Extension cops scoped to `lib/legion/extensions/**/*.rb` with spec exclusion
+- ApiStringKeys scoped to `lib/legion/extensions/**/*.rb` (Faraday responses use string keys)
+
 ## [0.1.0] - 2026-03-29
 
 ### Added

data/config/default.yml

@@ -3,7 +3,7 @@
 Legion/HelperMigration:
   Enabled: true
   Include:
-    - 'lib/**/*.rb'
+    - 'lib/legion/extensions/**/*.rb'
   Exclude:
     - 'spec/**/*'
 
@@ -43,6 +43,12 @@ Legion/HelperMigration/DirectCrypt:
   Severity: warning
   VersionAdded: '0.1'
 
+Legion/HelperMigration/LoggingGuard:
+  Description: 'Remove unnecessary `respond_to?(:log_warn)` or `defined?(Legion::Logging)` guards.'
+  Enabled: true
+  Severity: convention
+  VersionAdded: '0.1.2'
+
 # Legion/ConstantSafety — prevent namespace resolution bugs inside module Legion
 
 Legion/ConstantSafety:
@@ -163,7 +169,7 @@ Legion/Framework/ApiStringKeys:
   Severity: warning
   VersionAdded: '0.1'
   Include:
-    - 'lib/**/*.rb'
+    - 'lib/legion/extensions/**/*.rb'
   Exclude:
     - 'spec/**/*'
 
@@ -171,6 +177,10 @@ Legion/Framework/ApiStringKeys:
 
 Legion/Extension:
   Enabled: true
+  Include:
+    - 'lib/legion/extensions/**/*.rb'
+  Exclude:
+    - 'spec/**/*'
 
 Legion/Extension/ActorSingularModule:
   Description: 'Use `module Actor` (singular). Framework discovers actors in `Actor`, not `Actors`.'

data/lib/rubocop/cop/legion/helper_migration/logging_guard.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Legion
+      module HelperMigration
+        # Detects unnecessary guard checks around logging that are no longer
+        # needed. The `log` helper is always available in extensions via
+        # `Helpers::Lex`.
+        #
+        # Catches two patterns:
+        # 1. `respond_to?` checks for old logging methods or `log`
+        # 2. `defined?(Legion::Logging)` guards
+        #
+        # @example
+        #   # bad
+        #   log.warn(msg) if respond_to?(:log_warn, true)
+        #   log.info(msg) if respond_to?(:log)
+        #   Legion::Logging.info(msg) if defined?(Legion::Logging)
+        #
+        #   # good
+        #   log.warn(msg)
+        #   log.info(msg)
+        class LoggingGuard < RuboCop::Cop::Base
+          MSG_RESPOND_TO = '`respond_to?(:%<method>s)` guard is unnecessary. ' \
+                           '`log` is always available via `Helpers::Lex`.'
+          MSG_DEFINED = '`defined?(Legion::Logging)` guard is unnecessary. ' \
+                        '`Legion::Logging` is always loaded in the framework.'
+
+          OLD_METHODS = %i[log log_info log_warn log_error log_debug log_fatal].to_set.freeze
+
+          RESTRICT_ON_SEND = %i[respond_to?].freeze
+
+          # respond_to?(:log_warn) or respond_to?(:log_warn, true)
+          # @!method old_logging_respond_to?(node)
+          def_node_matcher :old_logging_respond_to?, <<~PATTERN
+            (send nil? :respond_to? (sym $_) ...)
+          PATTERN
+
+          def on_send(node)
+            old_logging_respond_to?(node) do |method_name|
+              next unless OLD_METHODS.include?(method_name)
+
+              add_offense(node, message: format(MSG_RESPOND_TO, method: method_name))
+            end
+          end
+
+          # defined? is a keyword, not a send — handle via on_defined? callback
+          def on_defined?(node)
+            return false unless legion_logging_defined?(node)
+
+            add_offense(node, message: MSG_DEFINED)
+          end
+
+          private
+
+          def legion_logging_defined?(node)
+            child = node.children.first
+            return false unless child&.const_type?
+
+            # Match Legion::Logging — (const (const nil :Legion) :Logging)
+            parent_const = child.children.first
+            parent_const&.const_type? &&
+              parent_const.children == [nil, :Legion] &&
+              child.children.last == :Logging
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/legion/rescue_logging/bare_rescue.rb

@@ -29,11 +29,22 @@ module RuboCop
 
           def on_resbody(node)
             return unless node.exceptions.empty? && node.exception_variable.nil?
+            return if rescue_modifier?(node)
 
             add_offense(node, severity: :warning) do |corrector|
               corrector.insert_after(node.loc.keyword, ' => e')
             end
           end
+
+          private
+
+          def rescue_modifier?(node)
+            rescue_node = node.parent
+            return false unless rescue_node&.rescue_type?
+
+            body = rescue_node.children.first
+            body && body.source_range.line == node.loc.keyword.line
+          end
         end
       end
     end

data/lib/rubocop/cop/legion/rescue_logging/no_capture.rb

@@ -23,21 +23,27 @@ module RuboCop
         #     log.error(e.message)
         #   end
         class NoCapture < RuboCop::Cop::Base
-          extend AutoCorrector
-
           MSG = 'Exception class specified but not captured. ' \
                 'Use `rescue %<classes>s => e` and log the exception.'
 
           def on_resbody(node)
             return if node.exceptions.empty? || !node.exception_variable.nil?
+            return if rescue_modifier?(node)
 
             classes = node.exceptions.map(&:source).join(', ')
             message = format(MSG, classes: classes)
 
-            add_offense(node, message: message, severity: :convention) do |corrector|
-              last_exception = node.exceptions.last
-              corrector.insert_after(last_exception, ' => e')
-            end
+            add_offense(node, message: message, severity: :convention)
+          end
+
+          private
+
+          def rescue_modifier?(node)
+            rescue_node = node.parent
+            return false unless rescue_node&.rescue_type?
+
+            body = rescue_node.children.first
+            body && body.source_range.line == node.loc.keyword.line
           end
         end
       end

data/lib/rubocop/cop/legion/rescue_logging/silent_capture.rb

@@ -32,6 +32,8 @@ module RuboCop
             return unless node.exception_variable
 
             var_name = variable_name(node.exception_variable)
+            return if var_name.to_s.start_with?('_')
+
             body = node.body
 
             return if body && (references_variable?(body, var_name) || contains_raise?(body))

data/lib/rubocop/legion/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Legion
-    VERSION = '0.1.0'
+    VERSION = '0.1.2'
   end
 end

data/lib/rubocop-legion.rb

@@ -13,6 +13,7 @@ require 'rubocop/cop/legion/helper_migration/direct_json'
 require 'rubocop/cop/legion/helper_migration/direct_cache'
 require 'rubocop/cop/legion/helper_migration/direct_local_cache'
 require 'rubocop/cop/legion/helper_migration/direct_crypt'
+require 'rubocop/cop/legion/helper_migration/logging_guard'
 
 # Legion/ConstantSafety
 require 'rubocop/cop/legion/constant_safety/bare_data_define'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-legion
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Esity
@@ -110,6 +110,7 @@ files:
 - lib/rubocop/cop/legion/helper_migration/direct_json.rb
 - lib/rubocop/cop/legion/helper_migration/direct_local_cache.rb
 - lib/rubocop/cop/legion/helper_migration/direct_logging.rb
+- lib/rubocop/cop/legion/helper_migration/logging_guard.rb
 - lib/rubocop/cop/legion/helper_migration/old_logging_methods.rb
 - lib/rubocop/cop/legion/rescue_logging/bare_rescue.rb
 - lib/rubocop/cop/legion/rescue_logging/no_capture.rb