rubocop-katalyst 1.1.4 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 813965be9e6b107ca9f01c57d01ca5674c9cafeac976d5ea4841e374afeb61e7
-  data.tar.gz: 4ab544fdbe2d16323f93f6a3cd1064d770ac05bf036edf0db0d46de0b1f3dcb4
+  metadata.gz: e750b4c719c39526276ce85557d2fa953130f440d113619f1348a8cf98fde5f1
+  data.tar.gz: 3263ad867d1e322185d4e8cbcf2f56bc893f0eed2a368debadac7cecf6391b32
 SHA512:
-  metadata.gz: 5968dbc4666e584a9b23f72ef608061888a4d274fe4bbc43f27c7649692189aa3ad7e86db9a34eb437d26f5ce489f21c08327c1d9623d6efce11678a0223183b
-  data.tar.gz: d346e2ac72baee66528414a9acb67db148a81841016c09919e66fec51997b6ca1811ec75bbf00fbb77a0956d5c6542c9e1a488f655a27bb5f23e1c267bc5d26d
+  metadata.gz: 25886809eb3a08a17ad02e206fbadc8cbf8d7b86f7e5f5dc0ba4b2a96c769958602999d668a43e3b181c912b41777c828364562bcde69623b79f52c0beb0d181
+  data.tar.gz: 4670dea507d6782b16d1198bcf12a3fcb00eacb60457a1b6a69b8bb9eb7c6ef31a316786110059fe10bd313e58e92332a53a26f8e4aed1435e9e59a7e931a4be

data/config/default.yml

@@ -1,9 +1,12 @@
 # Configuration for all cops and global extension configuration
 require:
+  - rubocop-capybara
+  - rubocop-factory_bot
   - rubocop-performance
   - rubocop-rails
   - rubocop-rake
   - rubocop-rspec
+  - rubocop-rspec_rails
 
 inherit_mode:
   merge:
@@ -24,12 +27,17 @@ inherit_from:
 
 AllCops:
   Exclude:
-    - ".git/**/*"
-    - "node_modules/**/*"
-    - Dockerfile
-    - docker-compose.yml
-  NewCops: disable # review new cops for styleguide before including
-  TargetRubyVersion: 2.7
+    - .git/**/*
+    - node_modules/**/*
+    - vendor/bundle/**/*
+  NewCops: enable
+  TargetRubyVersion: 3.3
+
+Capybara:
+  Enabled: true
+
+FactoryBot:
+  Enabled: true
 
 Performance:
   Enabled: true
@@ -42,3 +50,6 @@ Rake:
 
 RSpec:
   Enabled: true
+
+RSpecRails:
+  Enabled: true

data/config/rubocop-bundler.yml

@@ -1,2 +1,5 @@
 # Bundler configuration overrides
 # https://docs.rubocop.org/rubocop/1.5/cops_bundler.html
+
+Bundler/OrderedGems:
+  Enabled: true

data/config/rubocop-rails.yml

@@ -53,6 +53,14 @@ Rails/TimeZone:
   Reference: 'https://danilenko.org/2012/7/6/rails_timezones'
   Enabled: false
 
+Rails/UnknownEnv:
+  Environments:
+    - production
+    - staging
+    - development
+    - test
+  Enabled: true
+
 Rails/Validation:
   Description: 'Use validates :attribute, hash of validations.'
   Enabled: false

data/config/rubocop-rspec.yml

@@ -22,6 +22,9 @@ RSpec/MultipleExpectations:
     - spec/features/**/*
     - spec/system/**/*
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/RepeatedExample:
   Exclude:
     - spec/policies/**/*

data/lib/rubocop/katalyst/erb_lint_task.rb

@@ -31,9 +31,10 @@ module RuboCop
       def run_cli(verbose, *options)
         require "erb_lint/cli"
 
+        options.unshift("--config", config.to_path, "--allow-no-files")
         cli = ERBLint::CLI.new
-        puts "Running ERBLint" if verbose
-        result = cli.run(["--config", config.to_path, *options])
+        puts "Running erbLint #{options.join(' ')}" if verbose
+        result = cli.run(options)
         abort("ERBLint failed!") unless result
       end
 
@@ -52,7 +53,7 @@ module RuboCop
       end
 
       def config
-        config = ::Rails.application.root.join(".erb-lint.yml")
+        config = Pathname.new(root).join(".erb-lint.yml")
         config = default_config unless config.exist?
         config
       end
@@ -60,6 +61,10 @@ module RuboCop
       def default_config
         Pathname.new(__dir__).join("../../../.erb-lint.yml")
       end
+
+      def root
+        @root ||= Dir.pwd
+      end
     end
   end
 end

data/lib/rubocop/katalyst/prettier_task.rb

@@ -42,11 +42,9 @@ module RuboCop
 
       def install_prettier
         yarn("add", "--dev", "prettier")
-        File.open(config, "w") do |f|
-          f.write <<~JSON
-            {}
-          JSON
-        end
+        File.write(config, <<~JSON)
+          {}
+        JSON
         yarn("install")
       end
 

data/lib/rubocop/katalyst/rake_task.rb

@@ -11,7 +11,7 @@ module RuboCop
     class RakeTask < ::RuboCop::RakeTask
       attr_accessor :verbose
 
-      def initialize(name = :rubocop, *args, &task_block)
+      def initialize(name = :rubocop, *, &)
         super
 
         task(lint: :rubocop)

data/lib/rubocop/katalyst.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "katalyst/version"
-
 module RuboCop
   module Katalyst
     class Error < StandardError; end

data/lib/rubocop-katalyst.rb

@@ -8,7 +8,6 @@ require "rubocop-rspec"
 
 require_relative "rubocop/katalyst"
 require_relative "rubocop/katalyst/inject"
-require_relative "rubocop/katalyst/version"
 
 RuboCop::Katalyst::Inject.defaults!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-katalyst
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 2.0.0
 platform: ruby
 authors:
 - Katalyst Interactive
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-01 00:00:00.000000000 Z
+date: 2024-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -80,7 +108,21 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Custom RuboCop for the Katalyst styleguide
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: 
 email:
 - developers@katalyst.com.au
 executables: []
@@ -111,7 +153,6 @@ files:
 - lib/rubocop/katalyst/inject.rb
 - lib/rubocop/katalyst/prettier_task.rb
 - lib/rubocop/katalyst/rake_task.rb
-- lib/rubocop/katalyst/version.rb
 - lib/tasks/erb_lint.rake
 - package.json
 homepage: https://github.com/katalyst/rubocop-katalyst
@@ -119,11 +160,8 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-  homepage_uri: https://github.com/katalyst/rubocop-katalyst
-  source_code_uri: https://github.com/katalyst/rubocop-katalyst
-  changelog_uri: https://github.com/katalyst/rubocop-katalyst/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -131,15 +169,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.0
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.12
-signing_key:
+rubygems_version: 3.5.9
+signing_key: 
 specification_version: 4
 summary: Code standards for Katalyst
 test_files: []

data/lib/rubocop/katalyst/version.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Katalyst
-    VERSION = "1.1.4"
-  end
-end