rubocop-kata 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2aecb4f5acadb8c0a79107ec7eda1e8555464a1f7c00c0fc18d8148238b55eb4
-  data.tar.gz: cfe52159c9def4a8217a40cde0534aa4d3d68d7ba457800734716b563606442b
+  metadata.gz: de0b42a4b03480a8a8fff9e89e502eb9be99320bc348157233cd41c7f554cf39
+  data.tar.gz: 9b61887eb55e6b3adcd66f95e366e81e203b72fd9b6a804ea120b9734051d98a
 SHA512:
-  metadata.gz: 8dfbdb1a01717c78669d1f4efc9606bd3796778ea1dc7039c6d2b4c76e45066229f1fcec400973879a011f9092425ad2403f35430d0929c3df966eb5d42e4b64
-  data.tar.gz: 2dbace3f591f7920204c62f8ec94c0153fc91f96f381df1ea73891b93631bdbb0d96782321758bcea984eed0415164334d541c8f4ac64ca1763e490e60820318
+  metadata.gz: 915b4e7e20ed0e9cfca066625c8158e6ac2e2d46f3078c52e86f27c46da8bb2b59c65461ebe7bbbf15627acf793d40408852202a657e84d1f83ee56463deae9c
+  data.tar.gz: a18141d892a1d2833e9db5a7fd541c885218c8233911f507cce289a0f1705e576278de3c68f40ed17a3b76cf03c3594b8b2e2cb84fd001a2cf766da3258f33e6

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [0.3.0] - 2026-08-14
+
+- Ten new house cops in the Elegant Objects spirit, all on by default:
+  `Kata/NoUtilName`, `Kata/NoAbbreviation`, `Kata/BuilderNoun`, `Kata/NoBooleanFlag`,
+  `Kata/ConstructorDiscipline`, `Kata/NoClassMethodLogic`, `Kata/NoHashAsObject`,
+  `Kata/NoNilReturn`, `Kata/ClockDiscipline`, `Kata/EnvDiscipline`.
+
+## [0.2.1] - 2026-08-13
+
+- `Style/MethodCallWithArgsParentheses` disabled, overriding rubocop-elegant.
+- Disabled nine core `Layout/*` cops that autocorrect-loop against `Elegant/PairedBrackets` and `Elegant/NoEmptyLines*`.
+- `AutoCorrect: false` on `Elegant/NoRedundantVariable`, `Style/StaticClass`, and `Lint/NumberConversion` — their correctors rewrite code incorrectly.
+- `Style/RequireOrder` disabled — alphabetizing requires breaks load-order-dependent boot.
+
 ## [0.2.0] - 2026-08-10
 
 - Kata cops now run globally instead of only in `lib/**` — code in `app/`, `Rakefile`, etc. is now covered.

data/README.md

@@ -1,10 +1,10 @@
 # rubocop-kata
 
-A RuboCop plugin that replaces a pile of linter gems and config with one dependency. Install it and your `.rubocop.yml` shrinks to project-specific overrides. Everything else comes from the gem: a curated stack of RuboCop extensions, opinionated style defaults, and four house cops.
+A RuboCop plugin that replaces a pile of linter gems and config with one dependency. Install it and your `.rubocop.yml` shrinks to project-specific overrides. Everything else comes from the gem: a curated stack of RuboCop extensions, opinionated style defaults, and fourteen house cops.
 
 - **One dependency.** Bundles rubocop-rspec, rubocop-performance, rubocop-elegant, rubocop-packaging, and rubocop-thread_safety behind a single gem.
 - **Opinionated defaults.** Methods under 5 lines, classes under 100, 4 parameters max, 120-column lines, double quotes, `NewCops: enable`. See [config/default.yml](config/default.yml).
-- **Four house cops.** `Kata/AgentNoun`, `Kata/NoComments` (autocorrecting), `Kata/IoDiscipline`, `Kata/ProsePlacement`.
+- **Fourteen house cops.** Naming, dependency discipline, and data honesty in the Elegant Objects spirit — from `Kata/AgentNoun` to `Kata/ClockDiscipline`.
 
 ```ruby
 class PaymentProcessor  # Kata/AgentNoun: `PaymentProcessor` names a doer;
@@ -47,6 +47,16 @@ That's it. The plugin loads the bundled extensions and the shared defaults, so y
 | `Kata/NoComments` | on | No prose comments; say it in the code. Magic comments, linter directives, and licence headers survive. Autocorrects. |
 | `Kata/IoDiscipline` | on | No bare `puts`/`warn`/`pp`/`p` outside specs/scripts; write through an injected `@io` or an explicit receiver. |
 | `Kata/ProsePlacement` | off | Sentence-length strings belong in the presentation layer. Enable with an `Include`/`Exclude` matching your layering. |
+| `Kata/NoUtilName` | on | No junk-drawer names (`Util`, `Helper`, `Manager`, `Service`, …). Tune via `BannedNames`. |
+| `Kata/NoAbbreviation` | on | Spell words out; no `usr`, `cfg`, `res`. Tune via `BannedNames`. |
+| `Kata/BuilderNoun` | on | Builders named for what they return: `total`, not `calculate_total`. Tune via `BannedPrefixes`. |
+| `Kata/NoBooleanFlag` | on | No positional boolean arguments; split the method or use a keyword. |
+| `Kata/ConstructorDiscipline` | on | `initialize` assigns, raises, or freezes — never computes. |
+| `Kata/NoClassMethodLogic` | on | Class methods construct (`build`, `parse`, `of`, `from_*`); instances do the work. |
+| `Kata/NoHashAsObject` | on | A hash with `MaxKeys`+ keys (default 4) wants to be an object. Keyword-argument call sites exempt. |
+| `Kata/NoNilReturn` | on | No `return nil` or trailing `nil`; raise or return a real object. |
+| `Kata/ClockDiscipline` | on | No bare `Time.now`/`Date.today`/`.current`; inject a clock. |
+| `Kata/EnvDiscipline` | on | `ENV` reads only in the boot layer (`config/`, `bin/`, `exe/`). |
 
 ## The defaults
 

data/config/default.yml

@@ -41,6 +41,114 @@ Kata/ProsePlacement:
   Enabled: false
   VersionAdded: "0.1"
 
+Kata/NoUtilName:
+  Description: "Junk-drawer names hide the concept the code is missing."
+  Enabled: true
+  VersionAdded: "0.3"
+  BannedNames:
+    - Util
+    - Utils
+    - Utility
+    - Utilities
+    - Helper
+    - Helpers
+    - Manager
+    - Service
+    - Common
+    - Misc
+    - Shared
+
+Kata/NoAbbreviation:
+  Description: "Spell words out; code reads aloud like prose."
+  Enabled: true
+  VersionAdded: "0.3"
+  BannedNames:
+    - usr
+    - cfg
+    - tmp
+    - res
+    - val
+    - obj
+    - arr
+    - num
+    - buf
+    - idx
+    - ctx
+    - err
+
+Kata/BuilderNoun:
+  Description: "Builders are named for what they return; verbs are for side effects."
+  Enabled: true
+  VersionAdded: "0.3"
+  BannedPrefixes:
+    - get
+    - calculate
+    - compute
+    - retrieve
+    - generate
+
+Kata/NoBooleanFlag:
+  Description: "A boolean flag is two methods trapped in one."
+  Enabled: true
+  VersionAdded: "0.3"
+  Exclude:
+    - "spec/**/*"
+
+Kata/ConstructorDiscipline:
+  Description: "Constructors assign; they do not compute."
+  Enabled: true
+  VersionAdded: "0.3"
+  Exclude:
+    - "spec/**/*"
+
+Kata/NoClassMethodLogic:
+  Description: "Classes construct; instances work."
+  Enabled: true
+  VersionAdded: "0.3"
+  Exclude:
+    - "spec/**/*"
+  AllowedNames:
+    - build
+    - parse
+    - of
+
+Kata/NoHashAsObject:
+  Description: "Keys that travel together are an object without a name."
+  Enabled: true
+  VersionAdded: "0.3"
+  MaxKeys: 4
+  Exclude:
+    - "spec/**/*"
+    - "config/**/*"
+
+Kata/NoNilReturn:
+  Description: "Raise or return a real object; never nil."
+  Enabled: true
+  VersionAdded: "0.3"
+  Exclude:
+    - "spec/**/*"
+
+Kata/ClockDiscipline:
+  Description: "Read time from an injected clock, not the ambient one."
+  Enabled: true
+  VersionAdded: "0.3"
+  Exclude:
+    - "spec/**/*"
+    - "bin/**/*"
+    - "exe/**/*"
+
+Kata/EnvDiscipline:
+  Description: "ENV belongs in the boot layer; pass configuration in."
+  Enabled: true
+  VersionAdded: "0.3"
+  Exclude:
+    - "spec/**/*"
+    - "config/**/*"
+    - "bin/**/*"
+    - "exe/**/*"
+    - "Rakefile"
+    - "*.gemspec"
+
 Style/Documentation:
   Enabled: false
 
@@ -110,6 +218,58 @@ Elegant/NoEmptyLinesInMethods:
 Elegant/NoComments:
   Enabled: false
 
+Style/MethodCallWithArgsParentheses:
+  Enabled: false
+
+# --- Core layout cops that autocorrect-loop against Elegant/PairedBrackets
+# and Elegant/NoEmptyLines*; the Elegant cops win.
+Layout/BlockAlignment:
+  Enabled: false
+
+Layout/MultilineBlockLayout:
+  Enabled: false
+
+Layout/ClosingParenthesisIndentation:
+  Enabled: false
+
+Layout/FirstArgumentIndentation:
+  Enabled: false
+
+Layout/MultilineMethodCallBraceLayout:
+  Enabled: false
+
+Layout/MultilineArrayBraceLayout:
+  Enabled: false
+
+Layout/MultilineHashBraceLayout:
+  Enabled: false
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: false
+
+Layout/EmptyLinesAfterModuleInclusion:
+  Enabled: false
+
+# --- Correctors known to rewrite code incorrectly; report only.
+# Inlines a variable past side effects (ivar resets, later statements) and
+# corrupts Ruby 3.1 keyword shorthand.
+Elegant/NoRedundantVariable:
+  AutoCorrect: false
+
+# Rewrites reopened classes into modules, clashing with the primary
+# class definition at boot.
+Style/StaticClass:
+  AutoCorrect: false
+
+# Turns lenient `.to_i` into strict Integer(x, 10), which raises on
+# nils/Integers call sites legitimately receive.
+Lint/NumberConversion:
+  AutoCorrect: false
+
+# Alphabetizing requires breaks load-order-dependent boot sequences.
+Style/RequireOrder:
+  Enabled: false
+
 ThreadSafety/DirChdir:
   Exclude:
     - "spec/**/*"

data/lib/rubocop/cop/kata/builder_noun.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::BuilderNoun < RuboCop::Cop::Base
+  MSG = "A builder is named for what it returns: `%s`, not `%s`."
+
+  def on_def(node) = check(node)
+
+  def on_defs(node) = check(node)
+
+  private
+
+  def check(node)
+    name = node.method_name.to_s
+    verb = prefix(name)
+    return unless verb
+    add_offense(node.loc.name, message: format(MSG, name.delete_prefix("#{verb}_"), name))
+  end
+
+  def prefix(name)
+    Array(cop_config["BannedPrefixes"]).map(&:to_s).find { name.start_with?("#{it}_") }
+  end
+end

data/lib/rubocop/cop/kata/clock_discipline.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::ClockDiscipline < RuboCop::Cop::Base
+  MSG = "Inject a clock; `%s.%s` reads the ambient time."
+
+  RESTRICT_ON_SEND = %i[now today current].freeze
+
+  def_node_matcher :bare_clock?, "(send $(const {nil? cbase} {:Time :Date :DateTime}) ${:now :today :current})"
+
+  def on_send(node)
+    bare_clock?(node) do |const, method|
+      add_offense(node, message: format(MSG, const.const_name, method))
+    end
+  end
+end

data/lib/rubocop/cop/kata/constructor_discipline.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::ConstructorDiscipline < RuboCop::Cop::Base
+  MSG = "A constructor assigns; it does not compute. Move `%s` out of `initialize`."
+
+  ALLOWED = %i[raise freeze].freeze
+
+  def on_def(node)
+    return unless node.method?(:initialize)
+    node.each_descendant(:send) do |send|
+      next if ALLOWED.include?(send.method_name)
+      add_offense(send, message: format(MSG, send.method_name))
+    end
+  end
+end

data/lib/rubocop/cop/kata/env_discipline.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::EnvDiscipline < RuboCop::Cop::Base
+  MSG = "`ENV` belongs in the boot layer; pass configuration in."
+
+  def on_const(node)
+    return unless node.short_name == :ENV
+    return unless node.namespace.nil? || node.namespace.cbase_type?
+    add_offense(node, message: MSG)
+  end
+end

data/lib/rubocop/cop/kata/no_abbreviation.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::NoAbbreviation < RuboCop::Cop::Base
+  MSG = "`%s` is an abbreviation; spell the word out."
+
+  def on_lvasgn(node) = check(node)
+
+  def on_arg(node) = check(node)
+
+  def on_optarg(node) = check(node)
+
+  def on_kwarg(node) = check(node)
+
+  def on_kwoptarg(node) = check(node)
+
+  private
+
+  def check(node)
+    name = node.name.to_s
+    return unless banned?(name)
+    add_offense(node.loc.name, message: format(MSG, name))
+  end
+
+  def banned?(name) = Array(cop_config["BannedNames"]).map(&:to_s).include?(name.sub(/\d+\z/, ""))
+end

data/lib/rubocop/cop/kata/no_boolean_flag.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::NoBooleanFlag < RuboCop::Cop::Base
+  MSG = "A boolean flag is two methods trapped in one; split them or name the argument."
+
+  def on_send(node)
+    return if node.operator_method? || node.assignment_method?
+    node.arguments.each { add_offense(it, message: MSG) if it.boolean_type? }
+  end
+end

data/lib/rubocop/cop/kata/no_class_method_logic.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::NoClassMethodLogic < RuboCop::Cop::Base
+  MSG = "`%s` puts logic on the class; classes construct, instances work."
+
+  def on_defs(node)
+    name = node.method_name.to_s
+    return if constructor?(name)
+    add_offense(node.loc.name, message: format(MSG, name))
+  end
+
+  private
+
+  def constructor?(name) = name.start_with?("from_") || allowed?(name)
+
+  def allowed?(name) = Array(cop_config["AllowedNames"]).map(&:to_s).include?(name)
+end

data/lib/rubocop/cop/kata/no_hash_as_object.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::NoHashAsObject < RuboCop::Cop::Base
+  MSG = "%d keys travelling together are an object without a name."
+
+  def on_hash(node)
+    return if node.pairs.size < limit
+    return if kwargs?(node)
+    add_offense(node, message: format(MSG, node.pairs.size))
+  end
+
+  private
+
+  def kwargs?(node) = node.parent&.send_type? && node.equal?(node.parent.last_argument)
+
+  def limit = Integer(cop_config.fetch("MaxKeys", 4))
+end

data/lib/rubocop/cop/kata/no_nil_return.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::NoNilReturn < RuboCop::Cop::Base
+  MSG = "Returning nil hands the caller a bomb; raise or return a real object."
+
+  def on_return(node)
+    add_offense(node, message: MSG) if node.children.first&.nil_type?
+  end
+
+  def on_def(node)
+    last = tail(node.body)
+    add_offense(last, message: MSG) if last&.nil_type?
+  end
+  alias on_defs on_def
+
+  private
+
+  def tail(body) = body&.begin_type? ? body.children.last : body
+end

data/lib/rubocop/cop/kata/no_util_name.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class RuboCop::Cop::Kata::NoUtilName < RuboCop::Cop::Base
+  MSG = "`%s` is a junk drawer; it hides the concept the code is missing."
+
+  def on_class(node) = check(node)
+
+  def on_module(node) = check(node)
+
+  private
+
+  def check(node)
+    name = node.identifier.short_name.to_s
+    return unless banned?(name)
+    add_offense(node.identifier, message: format(MSG, name))
+  end
+
+  def banned?(name) = Array(cop_config["BannedNames"]).map(&:to_s).include?(name)
+end

data/lib/rubocop/kata/plugin.rb

@@ -6,7 +6,7 @@ class RuboCop::Kata::Plugin < LintRoller::Plugin
   def about
     LintRoller::About.new(
       name: "rubocop-kata", version: RuboCop::Kata::VERSION, homepage: "https://github.com/giacope/rubocop-kata",
-      description: "Practiced forms for Ruby: opinionated defaults and four house cops."
+      description: "Practiced forms for Ruby: opinionated defaults and fourteen house cops."
     )
   end
 

data/lib/rubocop/kata/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Kata
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

data/lib/rubocop-kata.rb

@@ -13,8 +13,18 @@ module RuboCop
 end
 
 require_relative "rubocop/cop/kata/agent_noun"
+require_relative "rubocop/cop/kata/builder_noun"
+require_relative "rubocop/cop/kata/clock_discipline"
+require_relative "rubocop/cop/kata/constructor_discipline"
+require_relative "rubocop/cop/kata/env_discipline"
 require_relative "rubocop/cop/kata/io_discipline"
+require_relative "rubocop/cop/kata/no_abbreviation"
+require_relative "rubocop/cop/kata/no_boolean_flag"
+require_relative "rubocop/cop/kata/no_class_method_logic"
 require_relative "rubocop/cop/kata/no_comments"
+require_relative "rubocop/cop/kata/no_hash_as_object"
+require_relative "rubocop/cop/kata/no_nil_return"
+require_relative "rubocop/cop/kata/no_util_name"
 require_relative "rubocop/cop/kata/prose_placement"
 require_relative "rubocop/kata/plugin"
 require_relative "rubocop/kata/version"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-kata
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Giacomo GK
@@ -122,8 +122,18 @@ files:
 - config/default.yml
 - lib/rubocop-kata.rb
 - lib/rubocop/cop/kata/agent_noun.rb
+- lib/rubocop/cop/kata/builder_noun.rb
+- lib/rubocop/cop/kata/clock_discipline.rb
+- lib/rubocop/cop/kata/constructor_discipline.rb
+- lib/rubocop/cop/kata/env_discipline.rb
 - lib/rubocop/cop/kata/io_discipline.rb
+- lib/rubocop/cop/kata/no_abbreviation.rb
+- lib/rubocop/cop/kata/no_boolean_flag.rb
+- lib/rubocop/cop/kata/no_class_method_logic.rb
 - lib/rubocop/cop/kata/no_comments.rb
+- lib/rubocop/cop/kata/no_hash_as_object.rb
+- lib/rubocop/cop/kata/no_nil_return.rb
+- lib/rubocop/cop/kata/no_util_name.rb
 - lib/rubocop/cop/kata/prose_placement.rb
 - lib/rubocop/kata/plugin.rb
 - lib/rubocop/kata/version.rb