rubocop-jbuilder 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e394cfd7f0a468e9bf48eab1a8eeb73d6319e908e121a2b8c5d84cc0352a8527
-  data.tar.gz: 8da70eccb3c7d8939ea30835c11e6f2d7b6f2b87fbceb5f6bca5efe0abab620d
+  metadata.gz: 7643a97e9b823f3197b2c8b1330dc168860c864d8c24fd07e7c3cca98d9d63fe
+  data.tar.gz: e92acc7906a5b0e4d1a5eecdb939bab8e1318540da1025b3c5fa80b056f67d6b
 SHA512:
-  metadata.gz: 52600605169a3e9ffe5eddf2dcf06bae8251c30683625d44674973236499e3b6fe86b8544d1175c0974ada3b57a082382415d73f7e14ccbf4c1eba290a6a507a
-  data.tar.gz: 4c4dd81131919b6591d6a77a1105d69fa3d6834e3ca7dc934c1466f7f4cf01a76a5e8a77a9d1ded7c775f27e8f9e44b9a76f0a4b3e8b795da820d82e0ee06131
+  metadata.gz: 7ea81e6dc735622da7c99d21b5c0c4d8cc9b92f930aba1faa3d00947d06250269cbe32d7d20ec072146985111a46316e7c240d2477617270b551ea38a555824c
+  data.tar.gz: 2862246d08ca05e6e155bb7facc515cba9d59e41a21586004c2318197af217541c318470bf19e5c267d7f83d0b7d71322651b94298a2036794fa3b86af7ccc9a

data/CHANGELOG.md

@@ -1,4 +1,6 @@
 ## [Unreleased]
+- Fix PartialExists to search for multiple local paths
+- Fix PartialExists to search partials without `.json`
 
 ## [0.1.0] - 2024-01-08
 

data/lib/rubocop/cop/jbuilder/partial_exists.rb

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
-TEST_FILENAME = File.join(Dir.pwd, "app/views/testing/show.json.jbuilder")
+require "pathname"
+
+TEST_FILENAME = File.join(Dir.pwd, "app/views/testing/nested/show.json.jbuilder")
 
 module RuboCop
   module Cop
     module Jbuilder
       class PartialExists < Base
-        MSG = "Partial not found. Looked for: %<path>s"
+        MSG = "Partial not found. Looked for: %<paths>s"
 
         def_node_matcher :has_partial?, <<~PATTERN
           {
@@ -17,21 +19,39 @@ module RuboCop
 
         def on_send(node)
           has_partial?(node) do |actual|
-            full_path = get_view_path_from(actual)
-            path = full_path.sub(rails_root_dirname(node) + "/", "")
-            add_offense(actual, message: format(MSG, path:)) unless File.exist?(full_path)
+            all_globs = get_view_globs_from(actual)
+
+            return if all_globs.any? { |glob| Dir.glob(glob).any? }
+
+            base_path = rails_root_dirname(node)
+            relative_paths = all_globs.map { |glob| relative_path(glob, base_path) }
+            add_offense(actual, message: format(MSG, paths: relative_paths.join(", ")))
           end
         end
 
         private
 
-        def get_view_path_from(node)
+        def get_view_globs_from(node)
           partial = node.source[1..-2]
           segments = partial.split("/")
-          segments.last.sub!(/.*/, '_\&.json.jbuilder')
+          segments.last.sub!(/.*/, '_\&*.jbuilder')
+
+          specific_path = segments.count != 1
+          return [File.join(rails_views_dirname(node), *segments)] if specific_path
+
+          globs = []
+          current_dirname = sut_dirname(node)
+          while current_dirname != rails_views_dirname(node)
+            globs << File.join(current_dirname, *segments)
+            current_dirname = File.expand_path("..", current_dirname)
+          end
+          globs
+        end
 
-          dirname = (segments.count == 1) ? sut_dirname(node) : rails_views_dirname(node)
-          File.join(dirname, *segments)
+        def relative_path(glob, base_path)
+          full = Pathname.new(glob.sub("*", ""))
+          base = Pathname.new(base_path)
+          full.relative_path_from(base).to_s
         end
 
         def sut_dirname(node)

data/lib/rubocop/jbuilder/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Jbuilder
-    VERSION = "0.1.0"
+    VERSION = "0.1.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-jbuilder
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Carlos Molina A
@@ -41,7 +41,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- app/views/testing/_exists.json.jbuilder
+- app/views/testing/_exists.jbuilder
 - config/default.yml
 - lib/rubocop-jbuilder.rb
 - lib/rubocop/cop/jbuilder/partial_exists.rb