rubocop-jbuilder 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e394cfd7f0a468e9bf48eab1a8eeb73d6319e908e121a2b8c5d84cc0352a8527
-  data.tar.gz: 8da70eccb3c7d8939ea30835c11e6f2d7b6f2b87fbceb5f6bca5efe0abab620d
+  metadata.gz: 65d8956a31b6c1e7a41da5b6f141d6e87ad3c57aaaf177001a309309966cb1f1
+  data.tar.gz: 3aecca35e0f09f13d09336918a3d4337f9f5968434cf2cba837489ef6a7a0b10
 SHA512:
-  metadata.gz: 52600605169a3e9ffe5eddf2dcf06bae8251c30683625d44674973236499e3b6fe86b8544d1175c0974ada3b57a082382415d73f7e14ccbf4c1eba290a6a507a
-  data.tar.gz: 4c4dd81131919b6591d6a77a1105d69fa3d6834e3ca7dc934c1466f7f4cf01a76a5e8a77a9d1ded7c775f27e8f9e44b9a76f0a4b3e8b795da820d82e0ee06131
+  metadata.gz: 93dc1a5baab5301e85af4f4261d22dbda7c100a8f01160fbbc750666aa3a297d0db6916436e70aea7bcee874479010fc6c2ad752e6150be474dd096bc4d3fb70
+  data.tar.gz: 420c7475ea90388c43174aa979bd71c61e6aceb1a37668d47cdb372b4f6d87078cab6bd6924f7fcfb537ef9fcf107a101045c5b3bfa213258ea3323ca6b680db

data/lib/rubocop/cop/jbuilder/partial_exists.rb

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
-TEST_FILENAME = File.join(Dir.pwd, "app/views/testing/show.json.jbuilder")
+require 'pathname'
+
+TEST_FILENAME = File.join(Dir.pwd, "app/views/testing/nested/show.json.jbuilder")
 
 module RuboCop
   module Cop
     module Jbuilder
       class PartialExists < Base
-        MSG = "Partial not found. Looked for: %<path>s"
+        MSG = "Partial not found. Looked for: %<paths>s"
 
         def_node_matcher :has_partial?, <<~PATTERN
           {
@@ -17,21 +19,39 @@ module RuboCop
 
         def on_send(node)
           has_partial?(node) do |actual|
-            full_path = get_view_path_from(actual)
-            path = full_path.sub(rails_root_dirname(node) + "/", "")
-            add_offense(actual, message: format(MSG, path:)) unless File.exist?(full_path)
+            all_paths = get_view_paths_from(actual)
+
+            return if all_paths.any? { |full_path| File.exist?(full_path) }
+
+            base_path = rails_root_dirname(node)
+            relative_paths = all_paths.map { |full_path| relative_path(full_path, base_path) }
+            add_offense(actual, message: format(MSG, paths: relative_paths.join(", ")))
           end
         end
 
         private
 
-        def get_view_path_from(node)
+        def get_view_paths_from(node)
           partial = node.source[1..-2]
           segments = partial.split("/")
           segments.last.sub!(/.*/, '_\&.json.jbuilder')
 
-          dirname = (segments.count == 1) ? sut_dirname(node) : rails_views_dirname(node)
-          File.join(dirname, *segments)
+          specific_path = segments.count != 1
+          return [File.join(rails_views_dirname(node), *segments)] if specific_path
+
+          paths = []
+          current_dirname = sut_dirname(node)
+          while current_dirname != rails_views_dirname(node)
+            paths << File.join(current_dirname, *segments)
+            current_dirname = File.expand_path("..", current_dirname)
+          end
+          paths
+        end
+
+        def relative_path(full_path, base_path)
+          full = Pathname.new(full_path)
+          base = Pathname.new(base_path)
+          full.relative_path_from(base).to_s
         end
 
         def sut_dirname(node)

data/lib/rubocop/jbuilder/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Jbuilder
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-jbuilder
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Carlos Molina A