rubocop-itsmycargo 0.1.9 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25db869248a113e54a5b1d363077c4a74ca546132ee7d759ff79ba8e22b4930e
-  data.tar.gz: 680eb697e2d5a2e5c0acd0d89fd52230b6aa8aa5e70d67c6821830c7a21f2120
+  metadata.gz: 6150773ccc539b1839574bccfd699356e99018663220604efc74af7fee5063db
+  data.tar.gz: 7d7ced6bd7da3f178ac705297b8c622c091bc354501b069aff812f78302fc19a
 SHA512:
-  metadata.gz: 54594a0be50d8247e34265c1793da4dc4877783afae4232f0fbe5fc46fd032637b045d11d44848dce26d4f8446798c69791fa03a6f794fac0a51c380ff972b3b
-  data.tar.gz: 222f09f5aad2f9ea8c1983bd283050ac03e6765d086854d954ac4b569a15eac3f095e157d5320fb310adb39ffc242c0864242ac9792745ea6af7e3f1db88a9ed
+  metadata.gz: 8b8e33de82de64541488855880de1059eb6060e6f5f1846ae101008a79df399c5f9ec41d62d1b2917416434f762bc17aa96e04b0f2ee14f91a10d633721ed23b
+  data.tar.gz: 24625c573f46f6a9916ba4d2f0e9b0767a3e4d6be7bcc564b1e0dde078575c6661050d8ad57c59659bf06b294fba33c2b2d0839b0ec9ab2d62f39ea7d9d16ea8

data/.rubocop.yml

@@ -1,2 +1,2 @@
 inherit_from:
-  - config/default.yml
+  - config/base.yml

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ### Next
+### v0.2.4-alpha-alpha-alpha-rc-rc - 2020-05-12
+### v0.2.3-alpha-alpha-alpha-rc-rc - 2020-05-12
+### v0.2.2-alpha-alpha-alpha-rc-rc - 2020-05-06
+### v0.2.1-alpha-alpha-alpha-rc-rc - 2020-05-06
+<<<<<<< HEAD
 ### v0.1.9-alpha-alpha-alpha-rc-rc - 2020-02-13
+=======
+### v0.2.0-alpha-alpha-alpha-rc-rc - 2020-05-06
+>>>>>>> bc0d7cb... v0.2.0
 ### v0.1.8-alpha-alpha-alpha-rc-rc - 2020-02-13
 ### v0.1.10-alpha-alpha-alpha-rc-rc - 2020-02-13
 ### v0.1.9-alpha-alpha-rc-rc - 2020-02-13

data/Gemfile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 

data/Rakefile

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'bump/tasks'
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
+require "bump/tasks"
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
 Bump.tag_by_default = true
 Bump.changelog = true

data/bin/console

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require 'bundler/setup'
-require 'rubocop/itsmycargo'
+require "bundler/setup"
+require "rubocop/itsmycargo"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -11,5 +11,5 @@ require 'rubocop/itsmycargo'
 # require "pry"
 # Pry.start
 
-require 'irb'
+require "irb"
 IRB.start(__FILE__)

data/config/base.yml

@@ -0,0 +1,47 @@
+inherit_mode:
+  merge:
+    - Exclude
+
+require:
+  - rubocop-performance
+  - standard/cop/semantic_blocks
+
+inherit_gem:
+  standard: config/base.yml
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+# Allow longer line length for bigger screens
+Layout/LineLength:
+  Max: 120
+  StyleGuide: 'https://github.com/itsmycargo/rubocop-itsmycargo/blob/master/docs/Guide.adoc#maximum-line-length'
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+# TODO: Enable with Ruby2.6
+Style/SlicingWithRange:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+  StyleGuide: 'https://github.com/itsmycargo/rubocop-itsmycargo/blob/master/docs/Guide.adoc#classmodule-documentation'

data/config/default.yml

@@ -1,38 +1,2 @@
-require:
-  - rubocop-performance
-  - rubocop-rails
-  - rubocop-rspec
-
-AllCops:
-  TargetRubyVersion: 2.6
-
-# Allow longer line length for bigger screens
-Layout/LineLength:
-  Max: 120
-  StyleGuide: 'https://github.com/mikian/itsmycargo/blob/master/docs/Guide.adoc#maximum-line-length'
-
-Lint/UnusedMethodArgument:
-  AllowUnusedKeywordArguments: true
-
-# Allow Ignoring filename requirements for initializers
-Naming/FileName:
-  Exclude:
-    - config/initializers/*.rb
-  StyleGuide: 'https://github.com/mikian/itsmycargo/blob/master/docs/Guide.adoc#snake-case-files'
-
-Style/Documentation:
-  Enabled: false
-  StyleGuide: 'https://github.com/mikian/itsmycargo/blob/master/docs/Guide.adoc#classmodule-documentation'
-
-Style/MethodCalledOnDoEndBlock:
-  Enabled: true
-
-# RSpec
-RSpec/MultipleExpectations:
-  AggregateFailuresByDefault: true
-
-RSpec/ExampleLength:
-  Max: 8
-
-RSpec/NestedGroups:
-  Max: 4
+inherit_from:
+  - ./legacy.yml

data/config/legacy.yml

@@ -0,0 +1,5 @@
+inherit_from:
+  - ./base.yml
+
+Style/StringLiterals:
+  EnforcedStyle: 'single_quotes'

data/config/rails.yml

@@ -0,0 +1,202 @@
+# Based on removed standard configuration:
+# https://github.com/testdouble/standard/commit/94d133f477a5694084ac974d5ee01e8a66ce777e#diff-65478e10d5b2ef41c7293a110c0e6b7c
+
+require:
+  - rubocop-rails
+
+Naming/FileName:
+  Exclude:
+    - config/initializers/*.rb
+
+Rails/ActionFilter:
+  Enabled: true
+  EnforcedStyle: action
+  Include:
+    - app/controllers/**/*.rb
+
+Rails/ActiveRecordAliases:
+  Enabled: true
+
+Rails/ActiveSupportAliases:
+  Enabled: true
+
+Rails/ApplicationJob:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  Enabled: true
+
+Rails/AssertNot:
+  Enabled: true
+  Include:
+    - '**/test/**/*'
+
+Rails/Blank:
+  Enabled: true
+  # Convert usages of `nil? || empty?` to `blank?`
+  NilOrEmpty: true
+  # Convert usages of `!present?` to `blank?`
+  NotPresent: true
+  # Convert usages of `unless present?` to `if blank?`
+  UnlessPresent: true
+
+Rails/BulkChangeTable:
+  Enabled: true
+  Database: null
+  Include:
+    - db/migrate/*.rb
+
+Rails/CreateTableWithTimestamps:
+  Enabled: true
+  Include:
+    - db/migrate/*.rb
+
+Rails/Date:
+  Enabled: true
+  EnforcedStyle: flexible
+
+Rails/Delegate:
+  Enabled: true
+  EnforceForPrefixed: true
+
+Rails/DelegateAllowBlank:
+  Enabled: true
+
+Rails/DynamicFindBy:
+  Enabled: true
+  Whitelist:
+    - find_by_sql
+
+Rails/EnumUniqueness:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+Rails/EnvironmentComparison:
+  Enabled: true
+
+Rails/Exit:
+  Enabled: true
+  Include:
+    - app/**/*.rb
+    - config/**/*.rb
+    - lib/**/*.rb
+  Exclude:
+    - lib/**/*.rake
+
+Rails/FilePath:
+  Enabled: true
+  EnforcedStyle: arguments
+
+Rails/FindBy:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+Rails/FindEach:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+Rails/HasAndBelongsToMany:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+Rails/HttpPositionalArguments:
+  Enabled: true
+  Include:
+    - 'spec/**/*'
+    - 'test/**/*'
+
+Rails/HttpStatus:
+  Enabled: true
+  EnforcedStyle: symbolic
+
+Rails/InverseOf:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+Rails/LexicallyScopedActionFilter:
+  Enabled: true
+  Safe: false
+  Include:
+    - app/controllers/**/*.rb
+
+Rails/NotNullColumn:
+  Enabled: true
+  Include:
+    - db/migrate/*.rb
+
+Rails/Output:
+  Enabled: true
+  Include:
+    - app/**/*.rb
+    - config/**/*.rb
+    - db/**/*.rb
+    - lib/**/*.rb
+
+Rails/OutputSafety:
+  Enabled: true
+
+Rails/PluralizationGrammar:
+  Enabled: true
+
+Rails/Presence:
+  Enabled: true
+
+Rails/Present:
+  Enabled: true
+  NotNilAndNotEmpty: true
+  NotBlank: true
+  UnlessBlank: true
+
+Rails/ReadWriteAttribute:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+Rails/RedundantReceiverInWithOptions:
+  Enabled: true
+
+Rails/RefuteMethods:
+  Enabled: true
+  Include:
+    - '**/test/**/*'
+
+Rails/RelativeDateConstant:
+  Enabled: true
+  AutoCorrect: false
+
+Rails/RequestReferer:
+  Enabled: true
+  EnforcedStyle: referer
+
+Rails/ReversibleMigration:
+  Enabled: true
+  Include:
+    - db/migrate/*.rb
+
+Rails/SafeNavigation:
+  Enabled: true
+  ConvertTry: false
+
+Rails/ScopeArgs:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+Rails/TimeZone:
+  Enabled: true
+  EnforcedStyle: flexible
+
+Rails/UniqBeforePluck:
+  Enabled: true
+  EnforcedStyle: conservative
+  AutoCorrect: false
+
+Rails/Validation:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb

data/config/rspec.yml

@@ -0,0 +1,50 @@
+require:
+  - rubocop-rspec
+
+RSpec/Focus:
+  Enabled: true
+
+RSpec/EmptyExampleGroup:
+  Enabled: true
+
+RSpec/EmptyLineAfterExampleGroup:
+  Enabled: true
+
+RSpec/EmptyLineAfterFinalLet:
+  Enabled: true
+
+RSpec/EmptyLineAfterHook:
+  Enabled: true
+
+RSpec/EmptyLineAfterSubject:
+  Enabled: true
+
+RSpec/HookArgument:
+  Enabled: true
+
+RSpec/HooksBeforeExamples:
+  Enabled: true
+
+RSpec/ImplicitExpect:
+  Enabled: true
+
+RSpec/IteratedExpectation:
+  Enabled: true
+
+RSpec/LetBeforeExamples:
+  Enabled: true
+
+RSpec/MissingExampleGroupArgument:
+  Enabled: true
+
+RSpec/ReceiveCounts:
+  Enabled: true
+
+Capybara/CurrentPathExpectation:
+  Enabled: true
+
+FactoryBot/AttributeDefinedStatically:
+  Enabled: true
+
+FactoryBot/CreateList:
+  Enabled: true

data/docs/Guide.adoc

@@ -2,11 +2,6 @@
 
 Limit lines to 120 characters.
 
-=== Snake Case Files [[snake-case-files]]
-
-Use `snake_case` for naming files, e.g. `hello_world.rb`.
-For Rails initialisers this naming rule is not enforced.
-
 === Class/Module Documentation [[class-documentation]]
 
 Top-level classes and modules are not required to have documentation.

data/lib/rubocop/itsmycargo.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'rubocop/itsmycargo/version'
+require "rubocop/itsmycargo/version"
 
 module Rubocop
   module Itsmycargo

data/lib/rubocop/itsmycargo/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Itsmycargo
-    VERSION = '0.1.9'
+    VERSION = "0.2.4"
   end
 end

data/rubocop-itsmycargo.gemspec

@@ -1,38 +1,37 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('lib', __dir__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'rubocop/itsmycargo/version'
+require "rubocop/itsmycargo/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = 'rubocop-itsmycargo'
-  spec.version       = Rubocop::Itsmycargo::VERSION
-  spec.authors       = ['Mikko Kokkonen']
-  spec.email         = ['oss@itsmycargo.com']
+  spec.name = "rubocop-itsmycargo"
+  spec.version = Rubocop::Itsmycargo::VERSION
+  spec.authors = ["Mikko Kokkonen"]
+  spec.email = ["oss@itsmycargo.com"]
 
-  spec.summary       = 'RuboCop Styles and Configuration for ItsMyCargo.'
-  spec.homepage      = 'https://github.com/itsmycargo/rubocop-itsmycargo'
-  spec.license       = 'MIT'
+  spec.summary = "RuboCop Styles and Configuration for ItsMyCargo."
+  spec.homepage = "https://github.com/itsmycargo/rubocop-itsmycargo"
+  spec.license = "MIT"
 
-  spec.metadata['homepage_uri'] = spec.homepage
-  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = spec.homepage
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
 
-  spec.add_dependency 'rubocop'
-  spec.add_dependency 'rubocop-performance'
-  spec.add_dependency 'rubocop-rails'
-  spec.add_dependency 'rubocop-rspec'
+  spec.add_dependency "rubocop-rails"
+  spec.add_dependency "rubocop-rspec"
+  spec.add_dependency "standard", "~> 0.4.1"
 
-  spec.add_development_dependency 'bump', '~> 0.9'
-  spec.add_development_dependency 'bundler', '~> 2.1'
-  spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency "bump", "~> 0.9"
+  spec.add_development_dependency "bundler", "~> 2.1"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
 end

metadata

@@ -1,31 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-itsmycargo
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.4
 platform: ruby
 authors:
 - Mikko Kokkonen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-13 00:00:00.000000000 Z
+date: 2020-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
+  name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rails
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,19 +39,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.1
 - !ruby/object:Gem::Dependency
   name: bump
   requirement: !ruby/object:Gem::Requirement
@@ -129,7 +115,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/workflows/bump.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -141,7 +126,11 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- config/base.yml
 - config/default.yml
+- config/legacy.yml
+- config/rails.yml
+- config/rspec.yml
 - docs/Guide.adoc
 - lib/rubocop/itsmycargo.rb
 - lib/rubocop/itsmycargo/version.rb

data/.github/workflows/bump.yml

@@ -1,50 +0,0 @@
-name: Ruby Gems
-
-on:
-  push:
-    branches:
-      - master
-
-jobs:
-  build:
-    name: Build & Publish
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-ruby@v1
-      with:
-        ruby-version: '2.7'
-    - run: |
-        git config --local user.email "dev-services@itsmycargo.com"
-        git config --local user.name "ItsMyCargo"
-    - run: bundle
-    - run: rake bump:patch
-    - run: git push --follow-tags
-
-    - name: Publish to RubyGems
-      run: |
-        mkdir -p $HOME/.gem
-        touch $HOME/.gem/credentials
-        chmod 0600 $HOME/.gem/credentials
-        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
-        gem build *.gemspec
-        gem push *.gem
-      env:
-        GEM_HOST_API_KEY: ${{secrets.RUBYGEMS_AUTH_TOKEN}}
-
-    - name: Publish to GitHub Package Registry
-      run: |
-        mkdir -p $HOME/.gem
-        touch $HOME/.gem/credentials
-        chmod 0600 $HOME/.gem/credentials
-        printf -- "---\n:github: Bearer ${GH_TOKEN}\n" > $HOME/.gem/credentials
-        gem build *.gemspec
-        gem push --key github --host https://rubygems.pkg.github.com/itsmycargo *.gem
-      env:
-        GH_TOKEN: ${{secrets.GITHUB_TOKEN}}
-
-    - name: Trigger Wolfhound Build
-      run: curl -s -XPOST "${WEBHOOK_URL}"
-      env:
-        WEBHOOK_URL: ${{secrets.DOCKER_WEBHOOK}}