rubocop-isucon 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b98ffbdad3aac15d06dc8606570be18e31b34a1ee1af1bec422983ce0ba65396
-  data.tar.gz: 804d43a41d8ca7862fbca72cbc5af61867359b76ecd23dee57e275fcea5b24a5
+  metadata.gz: 765ace9ebe80b459b8f3347e7941f88e8c9b55a937b1b2491c15e8ee9d2bb3cb
+  data.tar.gz: 41b4827422e16e5c076b0f8a5498e8fd30262094579c869301985829d7eb8a0c
 SHA512:
-  metadata.gz: 42b31825f977a06c7c3205641bca6d0bbb2325884c38d325791477b90ef82af1aa06cef8a35b10f3ec77502316609c2046dfd40614db211084cfe637de6e52cb
-  data.tar.gz: fad3f42a8d568a4eb131c9c09ae3674990afab6fac232705b99e5c223a8eb078f125e23d525f815a4da6002f5b585a16253ee24aa18e5d0d02f169907b953339
+  metadata.gz: 8243e07bd96cee3ec98fb648a7562a1a3e91f37e962de740671ffb5400c558c560d1088c12f0b203b9487dd1ac8c8ca5990ee7bd9cf997ead8b144aa98e16123
+  data.tar.gz: 9c2952bd62fe3a28f78b260f98ad8624cb5196ffaf974db27c2b0158cef564d1613568ebcc7dd8a06a92bd7ae6950d7d1e1382d9446cf6dc404b498d2f36be6a

data/.github/dependabot.yml

@@ -6,5 +6,7 @@ updates:
     directory: /
     schedule:
       interval: weekly
+    cooldown:
+      default-days: 7
     assignees:
       - sue445

data/.github/workflows/pages.yml

@@ -30,7 +30,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
 
       - name: Install packages
         run: |
@@ -38,7 +38,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libgda-5.0
 
-      - uses: ruby/setup-ruby@v1
+      - uses: ruby/setup-ruby@8aeb6ff8030dd539317f8e1769a044873b56ea71 # v1.268.0
         with:
           ruby-version: ruby
           bundler-cache: true
@@ -46,18 +46,18 @@ jobs:
       - run: bundle exec yard
 
       - name: Setup Pages
-        uses: actions/configure-pages@v5
+        uses: actions/configure-pages@983d7736d9b0ae728b81ab479565c72886d7745b # v5.0.0
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@v3
+        uses: actions/upload-pages-artifact@7b1f4a764d45c48632c6b24a0339c27f5614fb0b # v4.0.0
         with:
           # Upload entire repository
           path: './doc'
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v4
+        uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5
 
       - name: Slack Notification (not success)
-        uses: act10ns/slack@v2
+        uses: act10ns/slack@cfcc30955fe9377f4f55e1079e5419ee1014269f # v2
         if: "! success()"
         continue-on-error: true
         with:

data/.github/workflows/release_gem.yml

@@ -0,0 +1,47 @@
+name: Publish gem to rubygems.org
+
+on:
+  workflow_dispatch:
+
+jobs:
+  release:
+    if: github.repository == 'sue445/rubocop-isucon'
+    runs-on: ubuntu-latest
+
+    environment:
+      name: rubygems.org
+      url: https://rubygems.org/gems/rubocop-isucon
+
+    permissions:
+      contents: write
+      id-token: write
+
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0
+        with:
+          egress-policy: audit
+
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+
+      - name: Install packages
+        run: |
+          set -xe
+          sudo apt-get update
+          sudo apt-get install -y libgda-5.0
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@eaecf785f6a34567a6d97f686bbb7bccc1ac1e5c # v1.237.0
+        with:
+          bundler-cache: true
+          ruby-version: ruby
+
+      - name: Publish to RubyGems
+        uses: rubygems/release-gem@a25424ba2ba8b387abc8ef40807c2c85b96cbe32 # v1.1.1
+
+      - name: Create GitHub release
+        run: |
+          tag_name="$(git describe --tags --abbrev=0)"
+          gh release create "${tag_name}" --verify-tag --generate-notes
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/.github/workflows/test.yml

@@ -26,12 +26,13 @@ jobs:
           - "3.4"
         gemfile:
           - activerecord_8_0
+          - activerecord_8_1
 
     env:
       BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
 
       - name: Install packages
         run: |
@@ -39,7 +40,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libgda-5.0
 
-      - uses: ruby/setup-ruby@v1
+      - uses: ruby/setup-ruby@8aeb6ff8030dd539317f8e1769a044873b56ea71 # v1.268.0
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
@@ -56,7 +57,7 @@ jobs:
       - run: bundle exec yard --fail-on-warning
 
       - name: Slack Notification (not success)
-        uses: act10ns/slack@v2
+        uses: act10ns/slack@cfcc30955fe9377f4f55e1079e5419ee1014269f # v2
         if: "! success()"
         continue-on-error: true
         with:
@@ -72,7 +73,7 @@ jobs:
 
     steps:
       - name: Slack Notification (success)
-        uses: act10ns/slack@v2
+        uses: act10ns/slack@cfcc30955fe9377f4f55e1079e5419ee1014269f # v2
         if: always()
         continue-on-error: true
         with:

data/.rubocop.yml

@@ -1,7 +1,5 @@
 plugins:
   - rubocop-performance
-
-require:
   - rubocop-yard
 
 AllCops:

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
-[full changelog](http://github.com/sue445/rubocop-isucon/compare/v2.0.1...main)
+[full changelog](http://github.com/sue445/rubocop-isucon/compare/v2.0.2...main)
+
+## [2.0.2](https://github.com/sue445/rubocop-isucon/releases/tag/v2.0.2) - 2025-11-30
+[full changelog](http://github.com/sue445/rubocop-isucon/compare/v2.0.1...v2.0.2)
+
+* Release gem from GitHub Actions
+  * https://github.com/sue445/rubocop-isucon/pull/274
 
 ## [2.0.1](https://github.com/sue445/rubocop-isucon/releases/tag/v2.0.1) - 2025-03-25
 [full changelog](http://github.com/sue445/rubocop-isucon/compare/v2.0.0...v2.0.1)

data/README.md

@@ -123,4 +123,4 @@ ISUCON is a trademark or registered trademark of LINE Corporation.
 https://isucon.net
 
 ## Presentation
-* [Fix SQL N\+1 queries with RuboCop](https://speakerdeck.com/sue445/fix-sql-n-plus-one-queries-with-rubocop) at [RubyKaigi 2023](https://rubykaigi.org/2013/) :gem:
+* [Fix SQL N\+1 queries with RuboCop](https://speakerdeck.com/sue445/fix-sql-n-plus-one-queries-with-rubocop) at [RubyKaigi 2023](https://rubykaigi.org/2023/) :gem:

data/gemfiles/activerecord_8_1.gemfile

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 8.1.0.rc1"
+
+group :sqlite3 do
+  # c.f. https://github.com/rails/rails/blob/v8.1.0.rc1/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
+  gem "sqlite3", ">= 2.1"
+end
+
+# eval_gemfile "#{__dir__}/common.gemfile"
+
+gemspec path: "../"

data/lib/rubocop/cop/isucon/correctors/n_plus_one_query_corrector/correctable_methods.rb

@@ -16,7 +16,7 @@ module RuboCop
 
             # @return [Boolean]
             def correctable_gda?
-              gda&.select_query? && gda.table_names.count == 1 && !gda.limit_clause? &&
+              gda&.select_query? && gda.table_names.one? && !gda.limit_clause? &&
                 !gda.group_by_clause? && !gda.contains_aggregate_functions? && where_clause_with_only_single_unique_key?
             end
 
@@ -27,20 +27,20 @@ module RuboCop
 
             # @return [Boolean]
             def where_clause_with_only_primary_key?
-              return false unless gda.where_nodes.count == 1
+              return false unless gda.where_nodes.one?
 
               primary_keys = connection.primary_keys(gda.table_names[0])
-              return false unless primary_keys.count == 1
+              return false unless primary_keys.one?
 
               primary_keys.first == where_column_without_quote
             end
 
             # @return [Boolean]
             def where_clause_with_only_single_unique_index_column?
-              return false unless gda.where_nodes.count == 1
+              return false unless gda.where_nodes.one?
 
               unique_index_columns = connection.unique_index_columns(gda.table_names[0])
-              unique_index_columns.any? { |columns| columns.count == 1 && columns.first == where_column_without_quote }
+              unique_index_columns.any? { |columns| columns.one? && columns.first == where_column_without_quote }
             end
 
             # @return [Boolean]

data/lib/rubocop/isucon/gda/where_condition.rb

@@ -24,7 +24,7 @@ module RuboCop
         def column_operand
           operand0_value = operands[0].value
 
-          return operand0_value if operands.count == 1
+          return operand0_value if operands.one?
 
           operand1_value = operands[1].value
 
@@ -39,7 +39,7 @@ module RuboCop
 
         # @return [String,nil]
         def value_operand
-          return nil if operands.count == 1
+          return nil if operands.one?
 
           operand0_value = operands[0].value
           operand1_value = operands[1].value

data/lib/rubocop/isucon/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Isucon
-    VERSION = "2.0.1"
+    VERSION = "2.0.2"
   end
 end

data/rubocop-isucon.gemspec

@@ -49,7 +49,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-its"
   spec.add_development_dependency "rubocop_auto_corrector"
-  spec.add_development_dependency "rubocop-yard", ">= 0.9.2"
+  spec.add_development_dependency "rubocop-yard", ">= 1.0.0"
   spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "yard"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-isucon
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - sue445
 bindir: exe
 cert_chain: []
-date: 2025-03-24 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -183,14 +183,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -228,6 +228,7 @@ extra_rdoc_files: []
 files:
 - ".github/dependabot.yml"
 - ".github/workflows/pages.yml"
+- ".github/workflows/release_gem.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
@@ -247,6 +248,7 @@ files:
 - config/default.yml
 - config/enable-only-performance.yml
 - gemfiles/activerecord_8_0.gemfile
+- gemfiles/activerecord_8_1.gemfile
 - lib/rubocop-isucon.rb
 - lib/rubocop/cop/isucon/correctors/n_plus_one_query_corrector.rb
 - lib/rubocop/cop/isucon/correctors/n_plus_one_query_corrector/correctable_methods.rb
@@ -318,7 +320,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.7
 specification_version: 4
 summary: RuboCop plugin for ruby reference implementation of ISUCON
 test_files: []