rubocop-isucon 0.1.0 → 1.0.0

data/lib/rubocop/cop/isucon_cops.rb

@@ -1,10 +1,17 @@
 # frozen_string_literal: true
 
 require_relative "isucon/mixin/database_methods"
+require_relative "isucon/mixin/join_without_index_methods"
+require_relative "isucon/mixin/offense_location_methods"
+require_relative "isucon/mixin/many_join_table_methods"
 require_relative "isucon/mixin/mysql2_xquery_methods"
+require_relative "isucon/mixin/n_plus_one_query_methods"
+require_relative "isucon/mixin/select_asterisk_methods"
 require_relative "isucon/mixin/sinatra_methods"
+require_relative "isucon/mixin/sqlite3_execute_methods"
+require_relative "isucon/mixin/where_without_index_methods"
 
-require_relative "isucon/correctors/mysql2_n_plus_one_query_corrector"
+require_relative "isucon/correctors/n_plus_one_query_corrector"
 
 require_relative "isucon/mysql2/join_without_index"
 require_relative "isucon/mysql2/many_join_table"
@@ -18,3 +25,8 @@ require_relative "isucon/sinatra/rack_logger"
 require_relative "isucon/sinatra/serve_static_file"
 require_relative "isucon/shell/backtick"
 require_relative "isucon/shell/system"
+require_relative "isucon/sqlite3/join_without_index"
+require_relative "isucon/sqlite3/many_join_table"
+require_relative "isucon/sqlite3/n_plus_one_query"
+require_relative "isucon/sqlite3/select_asterisk"
+require_relative "isucon/sqlite3/where_without_index"

data/lib/rubocop/isucon/gda/client.rb

@@ -33,7 +33,7 @@ module RuboCop
 
           @table_names =
             if from_targets?
-              ast.from.targets.map(&:table_name).compact.uniq
+              ast.from.targets.filter_map(&:table_name).uniq
             else
               []
             end

data/lib/rubocop/isucon/gda/join_operand.rb

@@ -25,7 +25,7 @@ module RuboCop
         # @param column_name [String]
         # @param as [String]
         # @param node [GDA::Nodes::Expr]
-        def initialize(table_name: nil, column_name: nil, as: nil, node: nil) # rubocop:disable Naming/MethodParameterName
+        def initialize(table_name: nil, column_name: nil, as: nil, node: nil)
           @table_name = table_name
           @column_name = column_name
           @as = as

data/lib/rubocop/isucon/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Isucon
-    VERSION = "0.1.0"
+    VERSION = "1.0.0"
   end
 end

data/rubocop-isucon.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
   spec.description   = "RuboCop plugin for ruby reference implementation of ISUCON"
   spec.homepage      = "https://github.com/sue445/rubocop-isucon"
   spec.license       = "MIT"
-  spec.required_ruby_version = ">= 2.6.0"
+  spec.required_ruby_version = ">= 3.0.0"
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/sue445/rubocop-isucon"
@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "activerecord", ">= 6.1.0"
   spec.add_runtime_dependency "gda", "!= 1.1.2"
-  spec.add_runtime_dependency "rubocop", ">= 1.29.0"
+  spec.add_runtime_dependency "rubocop", ">= 1.49.0"
   spec.add_runtime_dependency "rubocop-performance"
 
   spec.add_development_dependency "benchmark-ips"
@@ -47,6 +47,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-its"
   spec.add_development_dependency "rubocop_auto_corrector"
+  spec.add_development_dependency "rubocop-yard"
   spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "yard"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-isucon
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - sue445
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-07-23 00:00:00.000000000 Z
+date: 2023-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.29.0
+        version: 1.49.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.29.0
+        version: 1.49.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -164,6 +164,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -199,7 +213,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/workflows/gh-pages.yml"
+- ".github/dependabot.yml"
+- ".github/workflows/pages.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
@@ -220,13 +235,21 @@ files:
 - config/enable-only-performance.yml
 - gemfiles/activerecord_6_1.gemfile
 - gemfiles/activerecord_7_0.gemfile
+- gemfiles/activerecord_7_1.gemfile
 - lib/rubocop-isucon.rb
-- lib/rubocop/cop/isucon/correctors/mysql2_n_plus_one_query_corrector.rb
-- lib/rubocop/cop/isucon/correctors/mysql2_n_plus_one_query_corrector/correctable_methods.rb
-- lib/rubocop/cop/isucon/correctors/mysql2_n_plus_one_query_corrector/replace_methods.rb
+- lib/rubocop/cop/isucon/correctors/n_plus_one_query_corrector.rb
+- lib/rubocop/cop/isucon/correctors/n_plus_one_query_corrector/correctable_methods.rb
+- lib/rubocop/cop/isucon/correctors/n_plus_one_query_corrector/replace_methods.rb
 - lib/rubocop/cop/isucon/mixin/database_methods.rb
+- lib/rubocop/cop/isucon/mixin/join_without_index_methods.rb
+- lib/rubocop/cop/isucon/mixin/many_join_table_methods.rb
 - lib/rubocop/cop/isucon/mixin/mysql2_xquery_methods.rb
+- lib/rubocop/cop/isucon/mixin/n_plus_one_query_methods.rb
+- lib/rubocop/cop/isucon/mixin/offense_location_methods.rb
+- lib/rubocop/cop/isucon/mixin/select_asterisk_methods.rb
 - lib/rubocop/cop/isucon/mixin/sinatra_methods.rb
+- lib/rubocop/cop/isucon/mixin/sqlite3_execute_methods.rb
+- lib/rubocop/cop/isucon/mixin/where_without_index_methods.rb
 - lib/rubocop/cop/isucon/mysql2/join_without_index.rb
 - lib/rubocop/cop/isucon/mysql2/many_join_table.rb
 - lib/rubocop/cop/isucon/mysql2/n_plus_one_query.rb
@@ -239,6 +262,11 @@ files:
 - lib/rubocop/cop/isucon/sinatra/logger.rb
 - lib/rubocop/cop/isucon/sinatra/rack_logger.rb
 - lib/rubocop/cop/isucon/sinatra/serve_static_file.rb
+- lib/rubocop/cop/isucon/sqlite3/join_without_index.rb
+- lib/rubocop/cop/isucon/sqlite3/many_join_table.rb
+- lib/rubocop/cop/isucon/sqlite3/n_plus_one_query.rb
+- lib/rubocop/cop/isucon/sqlite3/select_asterisk.rb
+- lib/rubocop/cop/isucon/sqlite3/where_without_index.rb
 - lib/rubocop/cop/isucon_cops.rb
 - lib/rubocop/isucon.rb
 - lib/rubocop/isucon/database_connection.rb
@@ -272,14 +300,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: RuboCop plugin for ruby reference implementation of ISUCON

data/.github/workflows/gh-pages.yml

@@ -1,44 +0,0 @@
-name: gh-pages
-
-on:
-  push:
-    branches:
-      - main
-
-jobs:
-  publish_yard:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v2
-
-      - name: Install packages
-        run: |
-          set -xe
-          sudo apt-get update
-          sudo apt-get install -y libgda-5.0
-
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: "3.1"
-          bundler-cache: true
-
-      - run: bundle exec yard
-
-      - name: Deploy to GitHub Pages
-        uses: peaceiris/actions-gh-pages@v3
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          publish_dir: ./doc
-          publish_branch: gh-pages
-
-      - name: Slack Notification (not success)
-        uses: lazy-actions/slatify@master
-        if: "! success()"
-        continue-on-error: true
-        with:
-          job_name: ${{ format('*publish_yard*') }}
-          type: ${{ job.status }}
-          icon_emoji: ":octocat:"
-          url: ${{ secrets.SLACK_WEBHOOK }}
-          token: ${{ secrets.GITHUB_TOKEN }}