rubocop-iotventure 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13ab895efc82ad4adbf3fda57d05c8107eed7353ac606468e9e2d433b96500a9
-  data.tar.gz: c69374ca50a8adb21fc33d70d4cd74aab6f16beee4de10e54c415fd6f59d8bc5
+  metadata.gz: 5d0d7b568c5726071030b7e7726c8b23c03a6169e717faf47112d76b6c375fc5
+  data.tar.gz: 229e07f5b7b072d3fcaca91b735227c2e639814f3efc949c135b2c47f8df3d8f
 SHA512:
-  metadata.gz: 6f61f1ffa728a317032a3a7031501d8454b47a6ea6e68688951e8f6bbfffe517c930dee650645b0240262fa2bfac29da659d2a9be37adf5b2646bcf7799c93fc
-  data.tar.gz: ff51238471e4c1c69342670135f87d840393a8d4bb7a8a72bad7d0444ea3452de05cb5865fcfa4a97608f5b64d73f219be459ff42775f47b7f7191b4b5557154
+  metadata.gz: 8c79b83a2cb794ffe161438753b0e161e09afec8b9b845b54d62affe8ed25189efc2932932fd56eee60575c98f0631f944502f55853bed59c52a70fe76e2cde0
+  data.tar.gz: cc8f99a6df08bab9d5351aee184403086d6466727b66df22624187ebae6ff2d226f65f82dc2e17289bb18dc96b27f1b5d762b0183f50adc82ea702deb2fa460a

data/.rubocop.yml

@@ -1,6 +1,11 @@
+require:
+  - rubocop-rake
+  - rubocop-iotventure
+
 AllCops:
   TargetRubyVersion: 2.6
   NewCops: enable
+  SuggestExtensions: false
 
 Layout/LineLength:
   Max: 120
@@ -8,6 +13,7 @@ Layout/LineLength:
 Metrics/BlockLength:
   Exclude:
     - '**/spec/**/*'
+    - 'rubocop-iotventure.gemspec'
 
 Naming/FileName:
  Exclude:

data/Gemfile

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rubocop-iotventure.gemspec
 gemspec
 
-gem "rake", "~> 13.0"
+gem 'rake', '~> 13.0'
 
-gem "rubocop", "~> 1.21"
+gem 'rubocop', '~> 1.21'

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    rubocop-iotventure (0.1.0)
+    rubocop-iotventure (0.1.1)
       rubocop (~> 1.0)
+      rubocop-rake (~> 0.6.0)
 
 GEM
   remote: https://rubygems.org/
@@ -46,6 +47,8 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.17.0)
       parser (>= 3.1.1.0)
+    rubocop-rake (0.6.0)
+      rubocop (~> 1.0)
     ruby-progressbar (1.11.0)
     simplecov (0.21.2)
       docile (~> 1.1)

data/Rakefile

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require "bundler/gem_tasks"
-require "rubocop/rake_task"
+require 'bundler/gem_tasks'
+require 'rubocop/rake_task'
 
 RuboCop::RakeTask.new
 

data/bin/console

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require "bundler/setup"
-require "rubocop/iotventure"
+require 'bundler/setup'
+require 'rubocop/iotventure'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -11,5 +11,5 @@ require "rubocop/iotventure"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/lib/rubocop/cop/iotventure/save_request_example.rb

@@ -93,15 +93,23 @@ module RuboCop
         private
 
         def check_for_wrong_save_request_example(node, body_param_name)
-          success_node, arguments_hash_capture = node.children.each do |child|
+          success_node, arguments_hash = success_node_and_arguments_hash(node)
+
+          return if success_node.nil?
+
+          return add_missing_offense(success_node, body_param_name) if arguments_hash.empty?
+
+          check_arguments_hash(success_node, body_param_name, arguments_hash.first)
+        end
+
+        def success_node_and_arguments_hash(node)
+          node.children.each do |child|
             capture = success_response(child)
 
-            break child, capture if capture
+            return child, capture if capture
           end
 
-          return add_missing_offense(success_node, body_param_name) if arguments_hash_capture.empty?
-
-          check_arguments_hash(success_node, body_param_name, arguments_hash_capture.first)
+          [nil, nil]
         end
 
         def check_arguments_hash(success_node, body_param_name, arguments_hash)

data/lib/rubocop/iotventure/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Iotventure
-    VERSION = "0.1.0"
+    VERSION = '0.1.1'
   end
 end

data/lib/rubocop/iotventure.rb

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 
-require_relative "iotventure/version"
+require_relative 'iotventure/version'
 
 module RuboCop
+  # A module containing cops created for Iotventure GmbH
   module Iotventure
     class Error < StandardError; end
-    # Your code goes here...
+
     PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
     CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
     CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
@@ -13,4 +14,3 @@ module RuboCop
     private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
   end
 end
-

data/rubocop-iotventure.gemspec

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
 
-require_relative "lib/rubocop/iotventure/version"
+require_relative 'lib/rubocop/iotventure/version'
 
 Gem::Specification.new do |spec|
-  spec.name = "rubocop-iotventure"
+  spec.name = 'rubocop-iotventure'
   spec.version = RuboCop::Iotventure::VERSION
-  spec.authors = ["Fynn Starke"]
-  spec.email = ["f.starke@iot-venture.com"]
+  spec.authors = ['Fynn Starke']
+  spec.email = ['f.starke@iot-venture.com']
 
   spec.summary = 'Rswag cops.'
   spec.description = 'Adds some helpful internal cops'
   spec.homepage = 'https://rubygems.org/gems/rubocop-iotventure'
-  spec.license = "MIT"
-  spec.required_ruby_version = ">= 2.6.0"
+  spec.license = 'MIT'
+  spec.required_ruby_version = '>= 2.6.0'
 
-  # spec.metadata["homepage_uri"] = spec.homepage
-  # spec.metadata["source_code_uri"] = "TODO: Put your gem's public repo URL here."
-  # spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = 'https://bitbucket.org/iotventure/rubocop-iotventure/src'
+  spec.metadata['changelog_uri'] = 'https://bitbucket.org/iotventure/rubocop-iotventure/src/master/CHANGELOG.md'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -25,21 +25,17 @@ Gem::Specification.new do |spec|
       (f == __FILE__) || f.match(%r{\A(?:(?:test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
     end
   end
-  spec.bindir = "exe"
+  spec.bindir = 'exe'
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
-
-  # Uncomment to register a new dependency of your gem
-  # spec.add_dependency "example-gem", "~> 1.0"
-
-  # For more information and examples about making a new gem, checkout our
-  # guide at: https://bundler.io/guides/creating_gem.html
+  spec.require_paths = ['lib']
 
   spec.add_dependency 'rubocop', '~> 1.0'
+  spec.add_dependency 'rubocop-rake', '~> 0.6.0'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'simplecov'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-iotventure
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Fynn Starke
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -124,7 +138,11 @@ files:
 homepage: https://rubygems.org/gems/rubocop-iotventure
 licenses:
 - MIT
-metadata: {}
+metadata:
+  homepage_uri: https://rubygems.org/gems/rubocop-iotventure
+  source_code_uri: https://bitbucket.org/iotventure/rubocop-iotventure/src
+  changelog_uri: https://bitbucket.org/iotventure/rubocop-iotventure/src/master/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths: