rubocop-inhouse 0.1.8 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 874a0aa1b66e253256357908b57673b8656451f5b7e6c04db26fe8fff27d92a2
-  data.tar.gz: 12f9db69d12eda04234603042a8420699d76580dec09cc5fd87f1d92571d0d6c
+  metadata.gz: 98d160ba6828e46ab71ef1afdf695c9acf928c600199dc08d1fd53350059b3e3
+  data.tar.gz: f0c637b591446b93c3129a7f7bff6a1b0d8bf9811b7931f4555e7b489c468ed2
 SHA512:
-  metadata.gz: 5c68c7d2fb6b92c4f523f0f2b91582f1ffcbefbb52219ca8017e0acf4039d42b5c71abd518fcdbfff1c116b9a967f9fd207be032537cb7c717abe1dbcf7131a0
-  data.tar.gz: f9dd32c19e0c5d33016eee61023a70bc343ec836275d0d324bfd896ef9b5829491762dd9c975553a76220d09d2141007dcab5bc2165b5bbdcc9218e33b6ff61a
+  metadata.gz: f99a568c805e79b5e3fa34726ceea2bb5793c30c7190c40b2016705e6fed324983d0503109daf91c64d89358d767f3ad00359aaeb0b437108110dc9045c8a606
+  data.tar.gz: cb7b055f488480d1550f3c4fb3f59581003abd1d18a0fc966711adb20df10bc8bd7cad5145ebaf1159f34e2a912f290427d3f8da45a622f6aa027e14fa622feb

data/config/default.yml

@@ -1,9 +1,12 @@
 require:
-  - rubocop-inhouse
   - rubocop-performance
   - rubocop-rspec
   - rubocop-rake
 
+inherit_mode:
+  merge:
+    - Exclude
+
 inherit_from:
   - ./layout.yml
   - ./lint.yml
@@ -14,7 +17,9 @@ inherit_from:
 
 AllCops:
   NewCops: enable
+  SuggestExtensions: false
   Exclude:
+    - "data/**/*"
     - "**/bin/*"
     - "**/db/migrate/*.rb"
     - "**/db/schema.rb"
@@ -41,4 +46,3 @@ Security/CompoundHash:
 
 Security/IoMethods:
   Enabled: true
-

data/config/layout.yml

@@ -26,8 +26,40 @@ Layout/ClassStructure:
     - private_delegate
     - private_methods
 
+Layout/CaseIndentation:
+  Enabled: true
+  EnforcedStyle: end
+
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+  EnforcedStyle: no_empty_lines
+
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+  EnforcedStyle: no_empty_lines
+
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+  EnforcedStyle: no_empty_lines
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
 Layout/EndAlignment:
+  Enabled: true
   EnforcedStyleAlignWith: variable
+  AutoCorrect: true
 
 Layout/FirstArgumentIndentation:
   EnforcedStyle: consistent
@@ -50,7 +82,18 @@ Layout/FirstMethodArgumentLineBreak:
 Layout/FirstMethodParameterLineBreak:
   Enabled: true
 
+Layout/IndentationConsistency:
+  Enabled: true
+
+# Detect hard tabs, no hard tabs.
+Layout/IndentationStyle:
+  Enabled: true
+
+# Two spaces, no tabs (for indentation).
+#
+# Doesn't behave properly with private-only concerns, so it's disabled.
 Layout/IndentationWidth:
+  Enabled: false
   Exclude:
     - "**/*.erb"
 
@@ -58,6 +101,9 @@ Layout/InitialIndentation:
   Exclude:
     - "**/*.erb"
 
+Layout/LeadingCommentSpace:
+  Enabled: true
+
 Layout/LineContinuationSpacing:
   Enabled: true
 
@@ -71,7 +117,7 @@ Layout/LineEndStringConcatenationIndentation:
 Layout/LineLength:
   Max: 80
   Exclude:
-    - "spec/**/*"
+    - "**/spec/**/*"
 
 Layout/MultilineArrayBraceLayout:
   EnforcedStyle: new_line
@@ -102,13 +148,6 @@ Layout/MultilineMethodCallBraceLayout:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
-Layout/SpaceInsideParens:
-  Exclude:
-    - "**/*.erb"
-
 Layout/MultilineMethodDefinitionBraceLayout:
   EnforcedStyle: new_line
 
@@ -118,14 +157,65 @@ Layout/MultilineMethodParameterLineBreaks:
 Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 
-Layout/SingleLineBlockChain:
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
   Enabled: true
 
-Layout/SpaceBeforeBrackets:
+Lint/UriEscapeUnescape:
+  Enabled: true
+
+Layout/SpaceAfterColon:
   Enabled: true
 
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+# Use `->(x, y) { x + y }` not `-> (x, y) { x + y }`
 Layout/SpaceInLambdaLiteral:
-  EnforcedStyle: require_no_space
+  Enabled: true
+
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+  EnforcedStyleForEmptyBraces: space
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+  EnforcedStyle: space
+  EnforcedStyleForEmptyBraces: no_space
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+  Exclude:
+    - "**/*.erb"
+
+# Use `hash[:key]` not `hash[ :key ]`
+Layout/SpaceInsideReferenceBrackets:
+  Enabled: true
+
+Layout/SingleLineBlockChain:
+  Enabled: true
+
+Layout/SpaceBeforeBrackets:
+  Enabled: true
 
 Layout/TrailingEmptyLines:
   Exclude:

data/config/lint.yml

@@ -3,7 +3,7 @@ Lint/AmbiguousAssignment:
 
 Lint/AmbiguousBlockAssociation:
   Exclude:
-    - "spec/**/*.rb"
+    - "**/spec/**/*.rb"
 
 Lint/AmbiguousOperatorPrecedence:
   Enabled: true

data/config/metrics.yml

@@ -4,17 +4,17 @@ Metrics/AbcSize:
   # Excluding controllers here because respond_to blocks and others make this
   # higher than they otherwise should be
   Exclude:
-    - "app/controllers/**/*"
-    - "app/views/**/*.rb"
+    - "**/app/controllers/**/*"
+    - "**/app/views/**/*.rb"
 
 Metrics/BlockLength:
   CountComments: false
   Max: 25
   Exclude:
-    - "spec/**/*.rb"
-    - "config/**/*.rb"
-    - "app/views/**/*.rb"
-    - "lib/tasks/**/*.rake"
+    - "**/app/controllers/**/*.rb"
+    - "**/spec/**/*.rb"
+    - "**/config/**/*.rb"
+    - "**/app/views/**/*.rb"
     - "**/*.rake"
 
 Metrics/CollectionLiteralLength:
@@ -24,8 +24,8 @@ Metrics/ClassLength:
   CountAsOne: ["array", "hash"]
   Max: 100
   Exclude:
-    - "app/controllers/**/*.rb"
-    - "app/views/**/*.rb"
+    - "**/app/controllers/**/*.rb"
+    - "**/app/views/**/*.rb"
 
 Metrics/CyclomaticComplexity:
   Max: 10
@@ -34,19 +34,22 @@ Metrics/MethodLength:
   CountAsOne: ["array", "hash", "method_call"]
   Max: 20
   Exclude:
-    - "app/views/**/*.rb"
+    - "**/app/views/**/*.rb"
+    - "**/app/controllers/**/*.rb"
+    - "**/app/views/**/*.rb"
+    - "**/spec/**/*.rb"
 
 Metrics/ModuleLength:
   CountAsOne: ["array", "hash"]
   Max: 100
   Exclude:
-    - "spec/**/*.rb"
+    - "**/spec/**/*.rb"
 
 Metrics/ParameterLists:
-  Max: 2
+  Max: 3
   CountKeywordArgs: false
 
 Metrics/PerceivedComplexity:
   Max: 8
   Exclude:
-    - "app/views/**/*.rb"
+    - "**/app/views/**/*.rb"

data/config/performance.yml

@@ -1,3 +1,8 @@
+Performance:
+  Exclude:
+    - "spec/**/*"
+    - "test/**/*"
+
 Performance/AncestorsInclude:
   Enabled: true
 
@@ -16,6 +21,9 @@ Performance/ConcurrentMonotonicTime:
 Performance/ConstantRegexp:
   Enabled: true
 
+Performance/FlatMap:
+  Enabled: true
+
 Performance/MapCompact:
   Enabled: true
 
@@ -54,3 +62,6 @@ Performance/StringInclude:
 
 Performance/Sum:
   Enabled: true
+
+Performance/UnfreezeString:
+  Enabled: true

data/config/rails.yml

@@ -33,6 +33,16 @@ Rails/ActiveSupportOnLoad:
 Rails/AddColumnIndex:
   Enabled: true
 
+# Prefer assert_not over assert !
+Rails/AssertNot:
+  Include:
+    - "test/**/*"
+
+# Prefer assert_not_x over refute_x
+Rails/RefuteMethods:
+  Include:
+    - "test/**/*"
+
 Rails/AttributeDefaultBlockValue:
   Enabled: true
 
@@ -159,9 +169,9 @@ Rails/SaveBang:
   Enabled: true
   AllowImplicitReturn: false
   Exclude:
-    - "spec/**/*.rb"
-    - "config/**/*.rb"
-    - "lib/**/*.rb"
+    - "**/spec/**/*.rb"
+    - "**/config/**/*.rb"
+    - "**/lib/**/*.rb"
 
 Rails/ShortI18n:
   Enabled: true

data/config/rspec.yml

@@ -67,96 +67,96 @@ RSpec/VerifiedDoubleReference:
 RSpec/SpecFilePathFormat:
   Enabled: true
   Exclude:
-    - "spec/factories/**/*.rb"
-    - "spec/components/**/*.rb"
+    - "**/spec/factories/**/*.rb"
+    - "**/spec/components/**/*.rb"
 
 RSpec/MissingExampleGroupArgument:
   Enabled: true
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/EmptyExampleGroup:
   Enabled: true
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/AnyInstance:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/BeforeAfterAll:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/ContextWording:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/DescribeClass:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/ExampleLength:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/ExpectInHook:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/InstanceVariable:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/LetSetup:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/MessageChain:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/MessageSpies:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/MultipleExpectations:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/NamedSubject:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/NestedGroups:
   Max: 7
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/SubjectStub:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/VerifiedDoubles:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 
 RSpec/VoidExpect:
   Enabled: false
   Exclude:
-    - 'spec/factories/**/*.rb'
+    - '**/spec/factories/**/*.rb'
 

data/config/style.yml

@@ -1,3 +1,7 @@
+# We generally prefer &&/|| but like low-precedence and/or in context
+Style/AndOr:
+  Enabled: false
+
 Style/ArgumentsForwarding:
   Enabled: true
 
@@ -12,7 +16,11 @@ Style/AutoResourceCleanup:
 
 Style/BlockDelimiters:
   Exclude:
-    - app/views/**/*.rb
+    - "**/app/views/**/*.rb"
+
+# Prefer Foo.method over Foo::method
+Style/ColonMethodCall:
+  Enabled: true
 
 Style/CollectionCompact:
   Enabled: true
@@ -32,6 +40,9 @@ Style/ConcatArrayLiterals:
 Style/DataInheritance:
   Enabled: true
 
+Style/DefWithParentheses:
+  Enabled: true
+
 Style/DirEmpty:
   Enabled: true
 
@@ -41,6 +52,9 @@ Style/Documentation:
 Style/DocumentDynamicEvalDefinition:
   Enabled: true
 
+Style/EmptyMethod:
+  Enabled: false
+
 Style/EmptyHeredoc:
   Enabled: true
 
@@ -75,6 +89,11 @@ Style/HashConversion:
 Style/HashExcept:
   Enabled: true
 
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+  EnforcedShorthandSyntax: either
+
 Style/IfWithBooleanLiteralBranches:
   Enabled: true
 
@@ -117,6 +136,10 @@ Style/MethodCallWithArgsParentheses:
 Style/MethodCalledOnDoEndBlock:
   Enabled: true
 
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
 Style/MinMaxComparison:
   Enabled: true
 
@@ -144,6 +167,20 @@ Style/NumericLiterals:
   Exclude:
     - '**/db/migrate/*'
 
+Style/PercentLiteralDelimiters:
+  Enabled: true
+  PreferredDelimiters:
+    default: "()"
+    "%i": "[]"
+    "%I": "[]"
+    "%r": "{}"
+    "%w": "[]"
+    "%W": "[]"
+
+# Use quotes for string literals when they are enough.
+Style/RedundantPercentQ:
+  Enabled: false
+
 Style/ObjectThen:
   Enabled: true
   EnforcedStyle: then
@@ -160,6 +197,9 @@ Style/OptionHash:
 Style/QuotedSymbols:
   Enabled: true
 
+Style/ParenthesesAroundCondition:
+  Enabled: true
+
 Style/RedundantArrayConstructor:
   Enabled: true
 
@@ -181,6 +221,10 @@ Style/RedundantRegexpArgument:
 Style/RedundantRegexpConstructor:
   Enabled: true
 
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: true
+
 Style/RedundantSelfAssignmentBranch:
   Enabled: true
 
@@ -208,6 +252,10 @@ Style/ReturnNilInPredicateMethodDefinition:
 Style/SelectByRegexp:
   Enabled: true
 
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true
+
 Style/SingleLineDoEndBlock:
   Enabled: true
 
@@ -220,11 +268,23 @@ Style/StringChars:
 Style/StringHashKeys:
   Enabled: false
 
+Style/StabbyLambdaParentheses:
+  Enabled: true
+
 Style/SwapValues:
   Enabled: true
 
+# Use `"foo"` not `'foo'` unless escaping is required
 Style/StringLiterals:
+  Enabled: true
   EnforcedStyle: double_quotes
+  Include:
+    - "app/**/*"
+    - "config/**/*"
+    - "lib/**/*"
+    - "test/**/*"
+    - "spec/**/*"
+    - "Gemfile"
 
 Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
@@ -235,6 +295,12 @@ Style/TopLevelMethodDefinition:
 Style/TrailingCommaInBlockArgs:
   Enabled: true
 
+Style/TrailingCommaInArrayLiteral:
+  Enabled: true
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: true
+
 Style/YAMLFileRead:
   Enabled: true
 

data/lib/rubocop/inhouse/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Inhouse
-    VERSION = "0.1.8"
+    VERSION = "0.2.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-inhouse
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.2.0
 platform: ruby
 authors:
 - Nolan J Tait
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-07 00:00:00.000000000 Z
+date: 2024-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop