rubocop-infinum 0.9.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1135b596b05a6c1ca1a301ebd22040ec140a9c3a83409c3d1a261b839f4b7f50
-  data.tar.gz: d983ba7eac41b7ca5e282deb9d2d4bccd24ee3fea51e3e6c058de5a87566bb3b
+  metadata.gz: 15c594d1defeb4fe076eb18d219cd1c966bd0ad50c642ad8b1f45b9d0605ce39
+  data.tar.gz: 8d398bdc3702b8762b363ea922f71d38c6e0faaeb682c4ac0f429599781f348a
 SHA512:
-  metadata.gz: 74a5e95b3d4125d93b19b7ba67bd4413539287da3a12a16783533391903bc2630ef66a95baa83ed751dde6d92c9b0998d840955ac6df9ad64399a6471fb1243b
-  data.tar.gz: 378598448bc083feb676a192ca232ee107003e52e410b040f1fac2a8ec530194f85a21c551cd474f3aa173b85c3804efbd31483956057ba06f147be87271c406
+  metadata.gz: 44a30428a78b3da72521d0dc3d19062839e1e687f22f4776eec4a6d4fa125418bbe65120387d0826958dff7043197c7ec822df5aefa2fc860fecd97bdc8002ac
+  data.tar.gz: 28eae8d7b3ce7da5bafb34ce42b5f8bdee3473f2e99ed072457e56f0f324c9733912ba8b1a54ca94610c5025cdcb0db6ead950bcabfff73f8f9610969b88e05f

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # RuboCop Infinum Change Log
 
+## 1.0.0 (Jun 12th 2025)
+
+- Pluginify Rubocop Infinum (PR[#23](https://github.com/infinum/rubocop-infinum/pull/23) @imnastasia)
+
+## 0.9.1 (Oct 24th 2024)
+
+- Resolved deprecated usage of `RuboCop::Cop::Cop` and updated cops to use new rubocop API (PR[#22](https://github.com/infinum/rubocop-infinum/pull/22) @PetarCurkovic)
+
 ## 0.9.0 (Oct 7th 2024)
 
 - "Cop#corrections is deprecated" warning fixed ([PR#21](https://github.com/infinum/rubocop-infinum/pull/21) tnx @unavailabl3)

data/README.md

@@ -11,10 +11,11 @@ To use it, you can add this to your `Gemfile` (`group :development`):
 And add to the top of your project's RuboCop configuration file:
 
   ~~~yml
-  inherit_gem:
-    rubocop-infinum: rubocop.yml
-
-  require: rubocop-infinum
+  plugins: rubocop-infinum
   ~~~
 
+
+> [!NOTE]
+> The plugin system is supported in RuboCop 1.72+. In earlier versions, use `require` instead of `plugins`.
+
 If you dislike some rules, please check [RuboCop's documentation](https://rubocop.readthedocs.io/en/latest/configuration/#inheriting-configuration-from-a-dependency-gem) on inheriting configuration from a gem.

data/lib/rubocop/cop/infinum/attribute_default_block_value.rb

@@ -18,7 +18,9 @@ module RuboCop
       #   class User < ActiveRecord::Base
       #     attribute :confirmed_at, :datetime, default: -> { Time.zone.now }
       #   end
-      class AttributeDefaultBlockValue < ::RuboCop::Cop::Cop
+      class AttributeDefaultBlockValue < ::RuboCop::Cop::Base
+        extend AutoCorrector
+
         MSG = 'Pass method in a block to `:default` option.'
 
         def_node_matcher :default_attribute, <<~PATTERN
@@ -29,17 +31,14 @@ module RuboCop
 
         def on_send(node)
           default_attribute(node) do |hash_pair|
-            value = attribute(hash_pair)
-
-            add_offense(node, location: value) if value.send_type?
-          end
-        end
+            target_node = attribute(hash_pair)
+            return unless target_node.send_type?
 
-        def autocorrect(node)
-          expression = attribute(default_attribute(node))
+            add_offense(target_node, message: MSG) do |corrector|
+              expression = attribute(default_attribute(node))
 
-          lambda do |corrector|
-            corrector.replace(expression, "-> { #{expression.source} }")
+              corrector.replace(target_node, "-> { #{expression.source} }")
+            end
           end
         end
       end

data/lib/rubocop/cop/infinum/factory_bot_association.rb

@@ -38,7 +38,10 @@ module RuboCop
       #        name { 'J. R. R. Tolkien' }
       #      end
       #    end
-      class FactoryBotAssociation < ::RuboCop::Cop::Cop
+      class FactoryBotAssociation < ::RuboCop::Cop::Base
+        extend AutoCorrector
+        include IgnoredNode
+
         MSG = 'Use %<association_name>s { build(:%<factory_name>s) } instead'
 
         def_node_matcher :association_definition, <<~PATTERN
@@ -53,7 +56,7 @@ module RuboCop
           inline_association_definition(node) do |association_name, factory_name|
             message = format(MSG, association_name: association_name.to_s, factory_name: factory_name.to_s)
 
-            add_offense(node, message: message)
+            handle_offense(node, message)
           end
         end
 
@@ -63,21 +66,21 @@ module RuboCop
 
             message = format(MSG, association_name: association_name.to_s, factory_name: factory_name.first.to_s)
 
-            add_offense(node, message: message)
+            handle_offense(node, message)
           end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            if expression(node).size == 1
-              corrector.replace(node, "#{expression(node)[0]} { build(:#{expression(node)[0]}) }")
-            else
-              corrector.replace(node, "#{expression(node)[0]} { build(:#{expression(node)[1]}) }")
-            end
+        private
+
+        def handle_offense(node, message)
+          add_offense(node, message: message) do |corrector|
+            next if part_of_ignored_node?(node)
+
+            corrector.replace(node, "#{expression(node).first} { build(:#{expression(node).last}) }")
           end
-        end
 
-        private
+          ignore_node(node)
+        end
 
         def expression(node)
           if node.block_type?

data/lib/rubocop/infinum/plugin.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'rubocop/infinum/version'
+require 'lint_roller'
+
+module RuboCop
+  module Infinum
+    # The main plugin class for RuboCop Infinum.
+    class Plugin < LintRoller::Plugin
+      def about
+        LintRoller::About.new(
+          name: 'rubocop-infinum',
+          version: VERSION,
+          homepage: 'https://github.com/infinum/rubocop-infinum',
+          description: 'This plugin provides the RuboCop configuration file ' \
+                       'alongside some custom cops used at Infinum.'
+        )
+      end
+
+      def supported?(context)
+        context.engine == :rubocop
+      end
+
+      def rules(_context)
+        LintRoller::Rules.new(
+          type: :path,
+          config_format: :rubocop,
+          value: Pathname.new(__dir__).join('../../../rubocop.yml')
+        )
+      end
+    end
+  end
+end

data/lib/rubocop/infinum/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Infinum
-    VERSION = '0.9.0'
+    VERSION = '1.0.0'
   end
 end

data/lib/rubocop-infinum.rb

@@ -6,6 +6,7 @@ require 'rubocop'
 
 require_relative 'rubocop/infinum'
 require_relative 'rubocop/infinum/version'
+require_relative 'rubocop/infinum/plugin'
 
 require_relative 'rubocop/cop/infinum_cops'
 

data/rubocop-infinum.gemspec

@@ -17,6 +17,7 @@ Gem::Specification.new do |spec|
   spec.metadata['allowed_push_host'] = 'https://rubygems.org'
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/infinum/rubocop-infinum'
+  spec.metadata['default_lint_roller_plugin'] = 'RuboCop::Infinum::Plugin'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -30,8 +31,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency('pry-byebug', '< 4')
   spec.add_development_dependency('rspec', '~> 3.9')
 
-  spec.add_runtime_dependency('rubocop', '>= 1.28.0')
-  spec.add_runtime_dependency('rubocop-rails')
-  spec.add_runtime_dependency('rubocop-rspec')
-  spec.add_runtime_dependency('rubocop-performance')
+  spec.add_dependency('lint_roller')
+  spec.add_dependency('rubocop', '>= 1.72.1')
+  spec.add_runtime_dependency('rubocop-factory_bot', '>=2.27.1')
+  spec.add_runtime_dependency('rubocop-performance', '>= 1.24.0')
+  spec.add_runtime_dependency('rubocop-rails', '>= 2.30.0')
+  spec.add_runtime_dependency('rubocop-rspec', '>= 3.5.0')
+  spec.add_runtime_dependency('rubocop-rspec_rails', '>= 2.31.0')
 end

data/rubocop.yml

@@ -1,6 +1,8 @@
-require:
+plugins:
   - rubocop-rails
   - rubocop-rspec
+  - rubocop-rspec_rails
+  - rubocop-factory_bot
   - rubocop-performance
 
 Layout/LineLength:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-infinum
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Marko Ćilimković
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-07 00:00:00.000000000 Z
+date: 2025-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-byebug
@@ -40,62 +40,104 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.28.0
+        version: 1.72.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.28.0
+        version: 1.72.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.27.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.27.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.24.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.24.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.30.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.30.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
-  name: rubocop-performance
+  name: rubocop-rspec_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.31.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.31.0
 description:
 email:
 - team.backend@infinum.com
@@ -117,6 +159,7 @@ files:
 - lib/rubocop/cop/infinum/factory_bot_association.rb
 - lib/rubocop/cop/infinum_cops.rb
 - lib/rubocop/infinum.rb
+- lib/rubocop/infinum/plugin.rb
 - lib/rubocop/infinum/version.rb
 - rubocop-infinum.gemspec
 - rubocop.yml
@@ -127,6 +170,7 @@ metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/infinum/rubocop-infinum
   source_code_uri: https://github.com/infinum/rubocop-infinum
+  default_lint_roller_plugin: RuboCop::Infinum::Plugin
 post_install_message:
 rdoc_options: []
 require_paths: