rubocop-infinum 0.5.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abf5743e5f9cb860ccccd40aa99cc051b583115693c6b4e69be6d39eb0346c72
-  data.tar.gz: 9d9c6d46dae69c7f86cf1f8b43d0c475691870ac672354b7ebae9171de4a714a
+  metadata.gz: eb4cbafaa4d31485e68abafcf382d32ab840d0487c8414d260f40411b7017090
+  data.tar.gz: a0016264cc32af54cfde8fe31688f45cf189724c2df52fe462f91a947959a181
 SHA512:
-  metadata.gz: 492842a441bb84e5b77fce3b5041dc7b81a529798f68f8ddd07dca6ca3e127475e20a8a6508deafde9a35d0650a630a4b108d3a977fd1e25096fd50462fd4b58
-  data.tar.gz: 925d8a1e346acd5dd9d710ed0ab28788f83f50b17e4e1caae8ec1bc9765753657f792578604f6336ba6c0f4f97543ee9eccfd0ae6f64d2157084ece54aa95225
+  metadata.gz: 90182373858f8f363ca0789478382a645a046df2588f55a41301e1bd1e8812781e97f261fc2c3832a7907855de189d4d965b25a5c18acbc6942bac03b3a791a1
+  data.tar.gz: f3cb86e550f0e7ed51419ddf30b18f80f26b1354879506f9e17241c1e7b1133fd46aaae7409b941f8dfbf3ded5af049605c146ac190135049256f2ffcabaa837

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # RuboCop Infinum Change Log
 
+## 0.8.0 (May 11th, 2022)
+
+- Remove TargetRubyVersion from rubocop yml template (@cilim)
+
+## 0.7.0 (Apr 28th, 2022)
+
+- Rename Layout/LineLength IgnoredPatterns to AllowedPatterns (@vlakre)
+
+## 0.6.0 (Feb 18th, 2022)
+
+- Create FactoryBotAssociation cop (@Benaaaaa)
+- Fix issue with second optional parameter and refactor attribute_default_block_value cop (@Benaaaaa)
+
 ## 0.5.1 (Sep 16th, 2021)
 
 - Enforce separated accessor grouping (@d4be4st)

data/lib/rubocop/cop/infinum/attribute_default_block_value.rb

@@ -22,21 +22,21 @@ module RuboCop
         MSG = 'Pass method in a block to `:default` option.'
 
         def_node_matcher :default_attribute, <<~PATTERN
-          (send nil? :attribute _ _ (hash <$#attribute ...>))
+          (send nil? :attribute _ ?_ (hash <$#attribute ...>))
         PATTERN
 
         def_node_matcher :attribute, '(pair (sym :default) $_)'
 
         def on_send(node)
-          default_attribute(node) do |attribute|
-            value = attribute.children.last
+          default_attribute(node) do |hash_pair|
+            value = attribute(hash_pair)
 
             add_offense(node, location: value) if value.send_type?
           end
         end
 
         def autocorrect(node)
-          expression = default_attribute(node).children.last
+          expression = attribute(default_attribute(node))
 
           lambda do |corrector|
             corrector.replace(expression, "-> { #{expression.source} }")

data/lib/rubocop/cop/infinum/factory_bot_association.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Infinum
+      # This cop looks for 'association' in factories that specify a ':factory' option
+      # and tells you to use explicit build reference which improves the performance
+      # as cascading factories will not be saved unless needed to
+      #
+      # @example
+      #   #bad
+      #    FactoryBot.define do
+      #      factory :book do
+      #        title { 'Lord of the Rings' }
+      #        association :author
+      #      end
+      #    end
+      #
+      #    FactoryBoy.define do
+      #      factory :book do
+      #        title {'Lord of the Rings'}
+      #        author { association :author }
+      #      end
+      #    end
+      #
+      #    #good
+      #    FactoryBot.define do
+      #      factory :book do
+      #        title { 'Lord of the Rings' }
+      #        author { build(:author) }
+      #      end
+      #    end
+      #
+      #    FactoryBot.define do
+      #      factory :author do
+      #        name { 'J. R. R. Tolkien' }
+      #      end
+      #    end
+      class FactoryBotAssociation < ::RuboCop::Cop::Cop
+        MSG = 'Use %<association_name>s { build(:%<factory_name>s) } instead'
+
+        def_node_matcher :association_definition, <<~PATTERN
+          (send nil? :association (:sym $_) (hash (pair (sym :factory) (:sym $_))) ?)
+        PATTERN
+
+        def_node_matcher :inline_association_definition, <<~PATTERN
+          (block (send nil? $_) (args) (send nil? :association (sym $_)))
+        PATTERN
+
+        def on_block(node)
+          inline_association_definition(node) do |association_name, factory_name|
+            message = format(MSG, association_name: association_name.to_s, factory_name: factory_name.to_s)
+
+            add_offense(node, location: node, message: message)
+          end
+        end
+
+        def on_send(node)
+          return unless corrections.empty?
+
+          association_definition(node) do |association_name, factory_name|
+            factory_name = [association_name] if factory_name.empty?
+
+            message = format(MSG, association_name: association_name.to_s, factory_name: factory_name.first.to_s)
+
+            add_offense(node, location: node, message: message)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            if expression(node).size == 1
+              corrector.replace(node, "#{expression(node)[0]} { build(:#{expression(node)[0]}) }")
+            else
+              corrector.replace(node, "#{expression(node)[0]} { build(:#{expression(node)[1]}) }")
+            end
+          end
+        end
+
+        private
+
+        def expression(node)
+          @expression = if node.block_type?
+                          inline_association_definition(node)
+                        else
+                          association_definition(node).flatten
+                        end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/infinum_cops.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 
 require_relative 'infinum/attribute_default_block_value'
+require_relative 'infinum/factory_bot_association'

data/lib/rubocop/infinum/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Infinum
-    VERSION = '0.5.1'
+    VERSION = '0.8.0'
   end
 end

data/rubocop-infinum.gemspec

@@ -5,7 +5,7 @@ require_relative 'lib/rubocop/infinum/version'
 Gem::Specification.new do |spec|
   spec.name          = 'rubocop-infinum'
   spec.version       = RuboCop::Infinum::VERSION
-  spec.authors       = ['Marko Ćilimković', 'Stjepan Hađić']
+  spec.authors       = ['Marko Ćilimković', 'Stjepan Hađić', 'Tin Benaković']
   spec.email         = ['team.backend@infinum.com']
 
   spec.summary       = 'Automatic Infinum code style checking tool.'
@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency('pry-byebug', '< 4')
   spec.add_development_dependency('rspec', '~> 3.9')
 
-  spec.add_runtime_dependency('rubocop')
+  spec.add_runtime_dependency('rubocop', '>= 1.28.0')
   spec.add_runtime_dependency('rubocop-rails')
   spec.add_runtime_dependency('rubocop-rspec')
   spec.add_runtime_dependency('rubocop-performance')

data/rubocop.yml

@@ -5,7 +5,7 @@ require:
 
 Layout/LineLength:
   Max: 120
-  IgnoredPatterns: ['\A#']
+  AllowedPatterns: ['\A#']
 
 Naming/InclusiveLanguage:
   Enabled: false
@@ -42,7 +42,6 @@ Metrics/BlockLength:
     - 'spec/**/*_spec.rb'
 
 AllCops:
-  TargetRubyVersion: 2.5
   Exclude:
     - 'db/schema.rb'
     - 'db/migrate/*.rb'

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-infinum
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Marko Ćilimković
 - Stjepan Hađić
+- Tin Benaković
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-09-16 00:00:00.000000000 Z
+date: 2022-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-byebug
@@ -45,14 +46,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.28.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.28.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -113,6 +114,7 @@ files:
 - bin/setup
 - lib/rubocop-infinum.rb
 - lib/rubocop/cop/infinum/attribute_default_block_value.rb
+- lib/rubocop/cop/infinum/factory_bot_association.rb
 - lib/rubocop/cop/infinum_cops.rb
 - lib/rubocop/infinum.rb
 - lib/rubocop/infinum/version.rb