rubocop-infinum 0.3.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bef0aacf541f51bc823409584a2e1a63092c6778e60965f75f237549b8bc4fc5
-  data.tar.gz: c8f072eae9fa8f5954e6114390d6129863cec2377c9d7b3a4235ff1dc159ab05
+  metadata.gz: eab4ddaf8d28fe1b4549a6cada698ea7a839c65dedd6ada156b7347273783946
+  data.tar.gz: 696b1a2a1c359e2da6c4ccc699a7cf1738be0ec21e63bdcdbca36a2c227628bf
 SHA512:
-  metadata.gz: ce24d80185cb1b9aa639b7ba2779cbfc54b8712f590baf2159d5869ca590fa30d485bd548863ac0124ef3c8d1caa301b45348664a859d950c52a8f4680e4fa77
-  data.tar.gz: 9ea8c0b301e532b7bde66f290764906eccb48b944808d450c15a06713ba3c91ca9bd899b51cf6e47927a052f0451b66ad3c8829f950fc927ec26a628f9376d9f
+  metadata.gz: cc4248284de8b3665408d46d2251c170d5b1285173ac690f90a6df1acec8d8c38dfbee66762681ade893907d49dd34d467666301543f92940ceec832915f35b6
+  data.tar.gz: 951a92324c0b959841771b982558b093039e9f633ce2ec1a00788956aa6a86667d149460d4bd42093165755617f3cf33243f3404bd997c9a5f65f52fa60136b4

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # RuboCop Infinum Change Log
 
+## 0.6.0 (Feb 18th, 2022)
+
+- Create FactoryBotAssociation cop (@Benaaaaa)
+- Fix issue with second optional parameter and refactor attribute_default_block_value cop (@Benaaaaa)
+## 0.5.1 (Sep 16th, 2021)
+
+- Enforce separated accessor grouping (@d4be4st)
+
+## 0.5.0 (Aug 25th, 2021)
+
+- Add rubocop-performance (@PetarCurkovic)
+
+## 0.4.0 (Aug 20th, 2021)
+
+- Rename config file to rubocop.yml (keeping a convention with other rubocop gems)
+
 ## 0.3.0 (Aug 20th, 2021)
 
 - Rename config file to .infinum.yml (fixes inheriting configuration)

data/README.md

@@ -12,7 +12,7 @@ And add to the top of your project's RuboCop configuration file:
 
   ~~~yml
   inherit_gem:
-    rubocop-infinum: .infinum.yml
+    rubocop-infinum: rubocop.yml
 
   require: rubocop-infinum
   ~~~

data/lib/rubocop/cop/infinum/attribute_default_block_value.rb

@@ -22,21 +22,21 @@ module RuboCop
         MSG = 'Pass method in a block to `:default` option.'
 
         def_node_matcher :default_attribute, <<~PATTERN
-          (send nil? :attribute _ _ (hash <$#attribute ...>))
+          (send nil? :attribute _ ?_ (hash <$#attribute ...>))
         PATTERN
 
         def_node_matcher :attribute, '(pair (sym :default) $_)'
 
         def on_send(node)
-          default_attribute(node) do |attribute|
-            value = attribute.children.last
+          default_attribute(node) do |hash_pair|
+            value = attribute(hash_pair)
 
             add_offense(node, location: value) if value.send_type?
           end
         end
 
         def autocorrect(node)
-          expression = default_attribute(node).children.last
+          expression = attribute(default_attribute(node))
 
           lambda do |corrector|
             corrector.replace(expression, "-> { #{expression.source} }")

data/lib/rubocop/cop/infinum/factory_bot_association.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Infinum
+      # This cop looks for 'association' in factories that specify a ':factory' option
+      # and tells you to use explicit build reference which improves the performance
+      # as cascading factories will not be saved unless needed to
+      #
+      # @example
+      #   #bad
+      #    FactoryBot.define do
+      #      factory :book do
+      #        title { 'Lord of the Rings' }
+      #        association :author
+      #      end
+      #    end
+      #
+      #    FactoryBoy.define do
+      #      factory :book do
+      #        title {'Lord of the Rings'}
+      #        author { association :author }
+      #      end
+      #    end
+      #
+      #    #good
+      #    FactoryBot.define do
+      #      factory :book do
+      #        title { 'Lord of the Rings' }
+      #        author { build(:author) }
+      #      end
+      #    end
+      #
+      #    FactoryBot.define do
+      #      factory :author do
+      #        name { 'J. R. R. Tolkien' }
+      #      end
+      #    end
+      class FactoryBotAssociation < ::RuboCop::Cop::Cop
+        MSG = 'Use %<association_name>s { build(:%<factory_name>s) } instead'
+
+        def_node_matcher :association_definition, <<~PATTERN
+          (send nil? :association (:sym $_) (hash (pair (sym :factory) (:sym $_))) ?)
+        PATTERN
+
+        def_node_matcher :inline_association_definition, <<~PATTERN
+          (block (send nil? $_) (args) (send nil? :association (sym $_)))
+        PATTERN
+
+        def on_block(node)
+          inline_association_definition(node) do |association_name, factory_name|
+            message = format(MSG, association_name: association_name.to_s, factory_name: factory_name.to_s)
+
+            add_offense(node, location: node, message: message)
+          end
+        end
+
+        def on_send(node)
+          return unless corrections.empty?
+
+          association_definition(node) do |association_name, factory_name|
+            factory_name = [association_name] if factory_name.empty?
+
+            message = format(MSG, association_name: association_name.to_s, factory_name: factory_name.first.to_s)
+
+            add_offense(node, location: node, message: message)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            if expression(node).size == 1
+              corrector.replace(node, "#{expression(node)[0]} { build(:#{expression(node)[0]}) }")
+            else
+              corrector.replace(node, "#{expression(node)[0]} { build(:#{expression(node)[1]}) }")
+            end
+          end
+        end
+
+        private
+
+        def expression(node)
+          @expression = if node.block_type?
+                          inline_association_definition(node)
+                        else
+                          association_definition(node).flatten
+                        end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/infinum_cops.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 
 require_relative 'infinum/attribute_default_block_value'
+require_relative 'infinum/factory_bot_association'

data/lib/rubocop/infinum/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Infinum
-    VERSION = '0.3.0'
+    VERSION = '0.6.0'
   end
 end

data/rubocop-infinum.gemspec

@@ -5,7 +5,7 @@ require_relative 'lib/rubocop/infinum/version'
 Gem::Specification.new do |spec|
   spec.name          = 'rubocop-infinum'
   spec.version       = RuboCop::Infinum::VERSION
-  spec.authors       = ['Marko Ćilimković', 'Stjepan Hađić']
+  spec.authors       = ['Marko Ćilimković', 'Stjepan Hađić', 'Tin Benaković']
   spec.email         = ['team.backend@infinum.com']
 
   spec.summary       = 'Automatic Infinum code style checking tool.'
@@ -33,4 +33,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency('rubocop')
   spec.add_runtime_dependency('rubocop-rails')
   spec.add_runtime_dependency('rubocop-rspec')
+  spec.add_runtime_dependency('rubocop-performance')
 end

data/{.infinum.yml → rubocop.yml}

@@ -1,6 +1,7 @@
 require:
   - rubocop-rails
   - rubocop-rspec
+  - rubocop-performance
 
 Layout/LineLength:
   Max: 120
@@ -15,6 +16,9 @@ Rails:
 RSpec/ExampleLength:
   Max: 10
 
+Style/AccessorGrouping:
+  EnforcedStyle: separated
+
 Style/Documentation:
   Enabled: false
 

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-infinum
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Marko Ćilimković
 - Stjepan Hađić
-autorequire: 
+- Tin Benaković
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-20 00:00:00.000000000 Z
+date: 2022-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-byebug
@@ -81,7 +82,21 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description:
 email:
 - team.backend@infinum.com
 executables: []
@@ -89,7 +104,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".infinum.yml"
 - ".rspec"
 - ".ruby-version"
 - CHANGELOG.md
@@ -100,10 +114,12 @@ files:
 - bin/setup
 - lib/rubocop-infinum.rb
 - lib/rubocop/cop/infinum/attribute_default_block_value.rb
+- lib/rubocop/cop/infinum/factory_bot_association.rb
 - lib/rubocop/cop/infinum_cops.rb
 - lib/rubocop/infinum.rb
 - lib/rubocop/infinum/version.rb
 - rubocop-infinum.gemspec
+- rubocop.yml
 homepage: https://github.com/infinum/rubocop-infinum
 licenses:
 - MIT
@@ -111,7 +127,7 @@ metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/infinum/rubocop-infinum
   source_code_uri: https://github.com/infinum/rubocop-infinum
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -126,9 +142,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
+rubyforge_project:
 rubygems_version: 2.7.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Automatic Infinum code style checking tool.
 test_files: []