rubocop-iknow 0.0.6 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6095d79bd2ef760088027a2d7b92e37af0cfedcdf9b70c120d88655302d0893c
-  data.tar.gz: ea4856a93e68e158a555c2ffa2c9241a570ab7055d31ea70880daeb8fd33ad27
+  metadata.gz: ffa087314e293e1f086b60edd2675c7121a9863f0ed23373963cfb8dbe3c9236
+  data.tar.gz: 16167a4f521f1042e51f19fbc1dccc81098ccc1b60ea9793369cdf89e6ade56e
 SHA512:
-  metadata.gz: d055e17e935cdd9a62a18cd577dfc6818ba119dce79be61034b39d3b2aa1a623fa27282ef04630b48c3e312c71a8c862eb77fbb07e9ad60dc62cb09c9a335616
-  data.tar.gz: 8b1a86a2a4896adaa565a857902eb64cd98a2d0654648493137b847df9c845a794d3f2f8ea4e0c9f3d61a7f71badb8efc069f9e3b8ffdb3d2f792d27e29cf9ea
+  metadata.gz: f3d1a3257ef3561407120786e6499b000218b85923eed9ada1852dad8411a32a29ffb3a165736eda6afcefd1222c0ea5be9cb1f3d11b1268235c8abe98c2a267
+  data.tar.gz: 598cd7700e49deaaac0d9141e4eb02d376400456bee59fff86951f9d3773d82e1d1bde73efd50b97c8380643c239caabc985a81608d8557081864ee1504707c6

data/rubocop.yml

@@ -1,176 +1,282 @@
----
 AllCops:
   TargetRubyVersion: 2.5
   NewCops: enable
+
+Layout/EmptyLineAfterMagicComment:
+  Severity: error
+
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Enabled: false
+
+Layout/FirstArgumentIndentation:
+  # This forbids indentation relative to the expression
+  Enabled: false
+
+Layout/FirstHashElementIndentation:
+  # This one in particular forbids what Emacs does by default for multi-line
+  # hash entries
+  Enabled: false
+
+Layout/HashAlignment:
+  EnforcedHashRocketStyle:
+  - table
+  - key
+  EnforcedColonStyle:
+  - table
+  - key
+
 Layout/LineLength:
   # Max: 100
   Enabled: false # Potentially bring this back later
-Metrics/BlockLength:
-  Enabled: false
-Style/AsciiComments:
-  Enabled: false
-Style/Documentation:
+
+Layout/MultilineHashBraceLayout:
   Enabled: false
-Style/BlockDelimiters:
+
+Layout/MultilineMethodCallBraceLayout:
+  # Rules for formatting hash and method call braces: let's avoid these unless we
+  # can find something unambiguously positive.
   Enabled: false
-Style/TernaryParentheses:
+
+Layout/MultilineMethodCallIndentation:
+  # Cannot be configured to indent relative to expression.
   Enabled: false
-Style/RedundantReturn:
+
+Layout/MultilineMethodDefinitionBraceLayout:
+  # None of their options are lovely
   Enabled: false
-Style/RedundantSelf:
+
+Layout/SpaceInsideRangeLiteral:
   Enabled: false
-Style/GuardClause:
+
+Layout/TrailingWhitespace:
+  Severity: error
+
+Lint/AmbiguousBlockAssociation:
+  # In practise this rule seems overly restrictive for
+  # DSLs like RSpec that avoid parens.
   Enabled: false
-Style/IfUnlessModifier:
+
+Lint/EmptyWhen:
   Enabled: false
-Style/WhileUntilModifier:
+
+Lint/ParenthesesAsGroupedExpression:
   Enabled: false
-Style/RaiseArgs:
-  EnforcedStyle: compact
-Style/RedundantException:
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/ShadowingOuterLocalVariable:
+  # I like this rule, but can see arguments against it
+  Enabled: true
+
+Lint/StructNewOverride:
   Enabled: false
-Style/SpecialGlobalVars:
+
+Lint/UnusedBlockArgument:
+  AllowUnusedKeywordArguments: true
+
+Lint/UnusedMethodArgument:
+  AllowUnusedKeywordArguments: true
+  IgnoreEmptyMethods: true
+
+Metrics/AbcSize:
   Enabled: false
-Style/EmptyCaseCondition:
+
+Metrics/BlockLength:
   Enabled: false
-Style/RedundantCondition:
+
+Metrics/ClassLength:
   Enabled: false
-Metrics/AbcSize:
+
+Metrics/CyclomaticComplexity:
   Enabled: false
+
 Metrics/MethodLength:
   Enabled: false
-Metrics/CyclomaticComplexity:
+
+Metrics/ModuleLength:
   Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
 Metrics/PerceivedComplexity:
   Enabled: false
-Metrics/ClassLength:
+
+Naming/AccessorMethodName:
   Enabled: false
-Metrics/ModuleLength:
+
+Naming/MethodParameterName:
   Enabled: false
-Style/Lambda:
+
+Naming/PredicateName:
+  NamePrefix: [is_]
+
+Naming/RescuedExceptionsVariableName:
   Enabled: false
-Style/LambdaCall:
+
+Naming/VariableNumber:
   Enabled: false
-Style/MultilineBlockChain:
+
+Style/AccessorGrouping:
   Enabled: false
-Style/WordArray:
+
+Style/AsciiComments:
   Enabled: false
-Style/SymbolArray:
+
+Style/BlockDelimiters:
   Enabled: false
-Style/PreferredHashMethods:
-  EnforcedStyle: verbose
-Metrics/ParameterLists:
+
+Style/ClassAndModuleChildren:
   Enabled: false
-Layout/MultilineMethodCallIndentation:
-  # Cannot be configured to indent relative to expression.
+
+Style/ClassVars:
+  # Class vars are usually bad practice. Not universally.
   Enabled: false
-Style/RescueModifier:
-  # I can see valid uses for this but they're far and few between.
-  # That said, nobody in our team is going to use one of these unless
-  # it's a valid case
+
+Style/CommentedKeyword:
   Enabled: false
-Lint/UnusedMethodArgument:
-  AllowUnusedKeywordArguments: true
-  IgnoreEmptyMethods: true
-Lint/EmptyWhen:
+
+Style/Documentation:
   Enabled: false
-Lint/RaiseException:
-  Enabled: true
-Lint/StructNewOverride:
+
+Style/EmptyCaseCondition:
   Enabled: false
-Style/ClassAndModuleChildren:
+
+Style/EmptyElse:
   Enabled: false
-Style/NonNilCheck:
+
+Style/ExplicitBlockArgument:
+  # This goes too far by demanding expensive block allocation always
   Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Severity: error
+
+Style/GuardClause:
+  # This is too prescriptive
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
 Style/HashSyntax:
   # We explicitly choose to use rocket style syntax when the Hash is being used
   # to represent some other sort of data structure (trees, pairs, etc).
   Enabled: false
-Style/HashEachMethods:
-  Enabled: true
+
 Style/HashTransformKeys:
   Enabled: true
+
 Style/HashTransformValues:
   Enabled: true
-Layout/FirstArgumentIndentation:
-  # This forbids indentation relative to the expression
-  Enabled: false
-Style/SafeNavigation:
-  Enabled: false
-Layout/EmptyLinesAroundExceptionHandlingKeywords:
+
+Style/IfUnlessModifier:
   Enabled: false
-Layout/SpaceInsideRangeLiteral:
+
+Style/KeywordParametersOrder:
   Enabled: false
-Style/SymbolProc:
+
+Style/Lambda:
+  Enabled: true
+  EnforcedStyle: literal
+
+Style/LambdaCall:
+  # restricts foo.() syntax, which we favour
   Enabled: false
-Lint/ParenthesesAsGroupedExpression:
+
+Style/MultilineBlockChain:
   Enabled: false
-Style/EmptyElse:
+
+Style/MutableConstant:
+  Severity: error
+
+Style/NonNilCheck:
   Enabled: false
+
 Style/NumericLiterals:
   Enabled: false
+
 Style/NumericPredicate:
   Enabled: false
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: consistent_comma
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: comma
-Style/SymbolLiteral:
-  Enabled: false
-Naming/AccessorMethodName:
+
+Style/PreferredHashMethods:
+  EnforcedStyle: verbose
+
+Style/RaiseArgs:
+  EnforcedStyle: compact
+
+Style/RedundantCondition:
   Enabled: false
-Naming/MethodParameterName:
+
+Style/RedundantException:
   Enabled: false
-Naming/VariableNumber:
+
+Style/RedundantReturn:
+  # allow redundant return keyword where appropriate to convey meaning
   Enabled: false
-Naming/PredicateName:
-  NamePrefix: ['is_']
-Naming/RescuedExceptionsVariableName:
+
+Style/RedundantSelf:
+  # allow redundant self keyword where appropriate to convey meaning
   Enabled: false
-Style/SingleLineMethods:
+
+Style/RescueModifier:
+  # I can see valid uses for this but they're far and few between.
+  # That said, nobody in our team is going to use one of these unless
+  # it's a valid case
   Enabled: false
-Style/CommentedKeyword:
+
+Style/SafeNavigation:
   Enabled: false
 
-Layout/HashAlignment:
-  EnforcedHashRocketStyle:
-    - table
-    - key
-  EnforcedColonStyle:
-    - table
-    - key
+Style/SingleLineMethods:
+  Enabled: false
 
-Style/ClassVars:
-  # Class vars are usually bad practice. Not universally.
+Style/SpecialGlobalVars:
   Enabled: false
 
-Layout/MultilineMethodDefinitionBraceLayout:
-  # None of their options are lovely
+Style/StringConcatenation:
   Enabled: false
 
 Style/StringLiterals:
   Enabled: true
+  Severity: error
+
 Style/StringLiteralsInInterpolation:
   Enabled: true
+  Severity: error
 
-Lint/AmbiguousBlockAssociation:
-  # In practise this rule seems overly restrictive for
-  # DSLs like RSpec that avoid parens.
+Style/SymbolArray:
   Enabled: false
 
-Lint/ShadowingOuterLocalVariable:
-  # I like this rule, but can see arguments against it
+Style/SymbolLiteral:
+  Enabled: false
+
+Style/SymbolProc:
+  Enabled: false
+
+Style/TernaryParentheses:
   Enabled: true
+  EnforcedStyle: require_parentheses_when_complex
 
-# Rules for formatting hash and method call braces: let's avoid these unless we
-# can find something unambiguously positive.
-Layout/MultilineMethodCallBraceLayout:
+Style/TrailingCommaInArguments:
+  Severity: error
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  Severity: error
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInHashLiteral:
+  Severity: error
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingUnderscoreVariable:
+  # I think this does more harm than good by hiding the array destructuring
   Enabled: false
-Layout/MultilineHashBraceLayout:
+
+Style/WhileUntilModifier:
   Enabled: false
-Layout/FirstHashElementIndentation:
-  # This one in particular forbids what Emacs does by default for multi-line
-  # hash entries
+
+Style/WordArray:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-iknow
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.9
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-14 00:00:00.000000000 Z
+date: 2022-04-11 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: edge@iknow.jp
@@ -36,7 +36,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.3.1
 signing_key: 
 specification_version: 4
 summary: Rubocop Configuration used with iKnow Projects