rubocop-hk 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a57757c3616476f00576220bcfcfcb7d074bac9d76428decaae65d6c088ef1c
-  data.tar.gz: 6f0d46d1e3521cee22488d0218a061734bd9dcd492ff49e0df7fa0740bac5fc4
+  metadata.gz: 99001468214b3d18783e17411c2adbcf9ce55703a2ec3a975f8f673b05b2fc0a
+  data.tar.gz: bf63386c1eebe83bce0fce9e621f863e95572ff8e7a11e572b321b4918f21f2a
 SHA512:
-  metadata.gz: d77e3ccd41040583b742a9cc7c930d22295090613e79fa98c47b5587759ecb8bb55d7370ae79de9c6d6aa9fe63c011328d4cc7e370aa3a3bc26819aaf27b4249
-  data.tar.gz: e8132cee7ded0a47a6b4c9294f1df2216146643266950ad4c87e6d698fa5df3da3d98d5a481f19e2d7c73fad11bdda4b5836b518eec326413c718d7648629c2a
+  metadata.gz: 92b2d5dffb92e97f6c9de6921e5f3a3636fac9363591a289e9f8a693ce04fcfc06ef2a45e0d6ecd77d7a577d71b9880541508a71f95be917a75f7e8f17734717
+  data.tar.gz: '00559444896a2c0e48ea8a4f015e2d82676acd7cc5bc11bb0cb7f91ec969aba0923634652eb352ebe7ed01ade47590bda3b1507925752da928ae19506879138d'

data/config/default.yml

@@ -1,7 +1,7 @@
 AllCops:
   # Target versions for Rails 6-8.x applications (2025)
-  TargetRubyVersion: 3.2
-  TargetRailsVersion: 8.1
+  TargetRubyVersion: 3.3
+  TargetRailsVersion: 8.0
   
   # Enhanced exclusions for typical Rails project structure
   Exclude:

data/config/rubocop-lint.yml

@@ -41,3 +41,90 @@ Lint/UriEscapeUnescape:
 Lint/UselessAssignment:
   Description: Checks for useless assignment to a local variable.
   Enabled: true
+
+# ==========================================
+# Modern Security & Quality Lint Cops (2025) - All WARNING ONLY
+# These catch potential bugs and security issues without breaking builds
+# ==========================================
+
+Lint/RequireRangeParentheses:
+  Description: |
+    Use parentheses for ranges in conditionals to avoid precedence issues.
+    Without parentheses, expressions like x == 1..10 are parsed as (x == 1)..10
+    instead of x == (1..10). This prevents subtle bugs and makes intent clear.
+  Enabled: true
+  Severity: warning
+
+Lint/SymbolConversion:
+  Description: |
+    Avoid unnecessary symbol conversions that can impact performance.
+    Converting strings to symbols repeatedly or converting symbols back to strings
+    unnecessarily creates memory overhead. Use the appropriate type from the start
+    when possible for better performance.
+  Enabled: true
+  Severity: warning
+
+Lint/ToEnumArguments:
+  Description: |
+    Pass correct arguments to to_enum for proper enumerator behavior.
+    Incorrect arguments can cause enumerators to behave unexpectedly or
+    raise errors when iterated. This ensures enumerators work as expected
+    and prevents runtime errors.
+  Enabled: true
+  Severity: warning
+
+Lint/UnexpectedBlockArity:
+  Description: |
+    Check for unexpected block arity in method calls. When blocks expect
+    a certain number of arguments but receive different amounts, it can
+    cause unexpected behavior or errors. This helps catch such mismatches early.
+  Enabled: true
+  Severity: warning
+
+Lint/DuplicateBranch:
+  Description: |
+    Avoid duplicate branches in conditional statements. Having identical
+    code in multiple branches often indicates a logic error or unnecessary
+    complexity. This helps identify redundant code that can be simplified.
+  Enabled: true
+  Severity: warning
+
+Lint/DuplicateRegexpCharacterClassElement:
+  Description: |
+    Remove duplicate elements in regexp character classes. Duplicates like
+    [aa-z] or [a-za] don't change regexp behavior but add confusion and
+    may indicate typos. Clean character classes are easier to understand and maintain.
+  Enabled: true
+  Severity: warning
+
+Lint/EmptyBlock:
+  Description: |
+    Avoid empty blocks that serve no purpose. Empty blocks often indicate
+    incomplete implementation or can be removed entirely. This helps identify
+    dead code and potential bugs from incomplete implementations.
+  Enabled: true
+  Severity: warning
+
+Lint/NoReturnInBeginEndBlocks:
+  Description: |
+    Avoid using return in begin/end blocks as it can cause unexpected behavior.
+    Return statements in begin blocks can bypass ensure clauses or cause
+    confusing control flow. Use explicit value assignment instead.
+  Enabled: true
+  Severity: warning
+
+Lint/NumberedParameterAssignment:
+  Description: |
+    Avoid assigning to numbered parameters (_1, _2, etc.) as it can cause
+    confusion and unexpected behavior. Numbered parameters should be treated
+    as read-only to maintain clarity in block parameter usage.
+  Enabled: true
+  Severity: warning
+
+Lint/OrAssignmentToConstant:
+  Description: |
+    Avoid using ||= with constants as it can cause unexpected behavior.
+    Constants should be assigned once and not modified. Using ||= with
+    constants can lead to confusing code and potential runtime errors.
+  Enabled: true
+  Severity: warning

data/config/rubocop-performance.yml

@@ -30,4 +30,78 @@ Performance/CollectionLiteralInLoop:
   # More permissive in configuration and initializer files
   Exclude:
     - "config/**/*"
-    - "db/**/*"
+    - "db/**/*"
+
+# ==========================================
+# Modern Performance Cops (2025) - All WARNING ONLY
+# These improve code performance without breaking builds
+# ==========================================
+
+Performance/BlockGivenWithExplicitBlock:
+  Description: |
+    Use block_given? efficiently with explicit blocks. When a method accepts
+    an explicit block parameter (&block), using block_given? is redundant
+    because you can check if the block parameter is nil. This improves performance
+    by avoiding unnecessary method calls.
+  Enabled: true
+  Severity: warning
+
+Performance/ConstantRegexp:
+  Description: |
+    Use constant regexps for better performance. Creating regexp objects
+    repeatedly in loops or frequently-called methods is expensive. Store
+    regexps in constants to avoid recompilation and improve performance
+    in performance-critical code paths.
+  Enabled: true
+  Severity: warning
+
+Performance/MethodObjectAsBlock:
+  Description: |
+    Use method objects as blocks when appropriate for better performance.
+    Using &:method_name syntax is often more performant than creating
+    explicit blocks, especially in collection methods like map, select, etc.
+    This reduces object allocation overhead.
+  Enabled: true
+  Severity: warning
+
+Performance/RedundantEqualityComparisonBlock:
+  Description: |
+    Avoid redundant equality comparison blocks in collection methods.
+    Instead of arr.select { |x| x == value }, use more direct approaches
+    or built-in methods when available. This reduces unnecessary block
+    calls and improves performance.
+  Enabled: true
+  Severity: warning
+
+Performance/RedundantSplitRegexpArgument:
+  Description: |
+    Avoid redundant regexp arguments to String#split. When splitting on
+    single characters, use string arguments instead of regexp for better
+    performance. For example, use str.split(',') instead of str.split(/,/).
+  Enabled: true
+  Severity: warning
+
+Performance/StringInclude:
+  Description: |
+    Use String#include? instead of String#match? when you only need to
+    check for substring presence. #include? is faster for simple substring
+    checks because it doesn't need to compile regexp patterns or capture groups.
+  Enabled: true
+  Severity: warning
+
+Performance/Sum:
+  Description: |
+    Use Array#sum instead of inject(:+) or reduce(:+) for numeric calculations.
+    Array#sum is optimized for numeric operations and provides better performance
+    and clearer intent when summing arrays of numbers.
+  Enabled: true
+  Severity: warning
+
+Performance/RangeInclude:
+  Description: |
+    Use Range#cover? instead of Range#include? for performance. #cover? only
+    checks if the value falls within the range boundaries, while #include?
+    iterates through all values in the range, making #cover? much faster
+    for large ranges.
+  Enabled: true
+  Severity: warning

data/config/rubocop-rails.yml

@@ -321,13 +321,9 @@ Rails/CompactBlank:
   Description: Use compact_blank instead of reject(&:blank?)
   Enabled: true
 
-Rails/DuplicateAssociation:
-  Description: Avoid duplicate associations in models
-  Enabled: true
+# Rails/DuplicateAssociation: Moved to modern cops section below
 
-Rails/DuplicateScope:
-  Description: Avoid duplicate scopes in models
-  Enabled: true
+# Rails/DuplicateScope: Moved to modern cops section below
 
 Rails/ExpandedDateRange:
   Description: Use Range#cover? instead of Range#include? for date ranges
@@ -345,9 +341,7 @@ Rails/PluralizationGrammar:
   Description: Use correct pluralization grammar
   Enabled: true
 
-Rails/ResponseParsedBody:
-  Description: Use response.parsed_body in tests
-  Enabled: true
+# Rails/ResponseParsedBody: Moved to modern cops section below
 
 Rails/RootJoinChain:
   Description: Use Rails.root.join for multiple path segments
@@ -371,4 +365,113 @@ Rails/TransactionExitStatement:
 
 Rails/UniqueValidationWithoutIndex:
   Description: Add database index for unique validations
-  Enabled: true
+  Enabled: true
+
+# ==========================================
+# Rails 8.0+ Modern Cops (2025) - All WARNING ONLY
+# These enforce Rails 8.0 best practices and modern patterns
+# ==========================================
+
+Rails/EnumSyntax:
+  Description: |
+    Use Rails 8.0+ enum syntax with positional arguments instead of keyword arguments.
+    The keyword argument syntax (enum status: {...}, _prefix: true) is deprecated in Rails 8.0.
+    Use: enum :status, {...}, prefix: true instead. This prepares your code for future Rails versions.
+  Enabled: true
+  Severity: warning
+
+Rails/RedundantActiveRecordAllMethod:
+  Description: |
+    Avoid redundant .all method calls in ActiveRecord queries. Modern Rails often
+    returns ActiveRecord::Relation objects that are already lazy-loaded, so .all
+    may be unnecessary and can impact performance. Remove when the relation is already sufficient.
+  Enabled: true
+  Severity: warning
+
+Rails/MigrationClassName:
+  Description: |
+    Use appropriate migration class names that reflect the migration's purpose.
+    Migration class names should be descriptive and follow Rails conventions
+    (PascalCase matching the filename). This improves code maintainability and searchability.
+  Enabled: true
+  Severity: warning
+
+Rails/WhereRange:
+  Description: |
+    Use range conditions in where clauses for better readability and performance.
+    Instead of where(created_at: start_date..end_date), consider using where(created_at: start_date...end_date)
+    or explicit range methods for clearer intent and potential query optimization.
+  Enabled: true
+  Severity: warning
+
+Rails/ThreeStateBooleanColumn:
+  Description: |
+    Avoid three-state boolean columns (true/false/null). These create confusion
+    about the meaning of null vs false. Use explicit status enums or separate
+    boolean columns with defaults to make data meaning clear and queries predictable.
+  Enabled: true
+  Severity: warning
+
+Rails/AddColumnIndex:
+  Description: |
+    Add database indexes when adding new columns that will be queried frequently.
+    This prevents performance issues as data grows. Consider adding indexes for
+    foreign keys, columns used in where clauses, and columns used for ordering.
+  Enabled: true
+  Severity: warning
+
+Rails/FreezeTime:
+  Description: |
+    Use Rails' travel_to instead of Time.stub or similar time mocking approaches.
+    travel_to is the Rails-standard way to manipulate time in tests and provides
+    better integration with Rails' time handling and ActiveSupport extensions.
+  Enabled: true
+  Severity: warning
+
+Rails/ResponseParsedBody:
+  Description: |
+    Use response.parsed_body in tests instead of JSON.parse(response.body).
+    This is more reliable, handles different content types automatically,
+    and is the Rails-standard approach for parsing response bodies in tests.
+  Enabled: true
+  Severity: warning
+
+Rails/DotSeparatedKeys:
+  Description: |
+    Use dot-separated keys in I18n for better organization and namespacing.
+    This creates clearer hierarchical structure in locale files and makes
+    translations easier to organize and maintain in large applications.
+  Enabled: true
+  Severity: warning
+
+Rails/RootPublicPath:
+  Description: |
+    Use Rails.root.join('public') instead of File.join(Rails.root, 'public').
+    This is more idiomatic Rails and handles path construction more reliably
+    across different operating systems and Ruby versions.
+  Enabled: true
+  Severity: warning
+
+Rails/DeprecatedActiveModelErrorsMethods:
+  Description: |
+    Avoid deprecated ActiveModel::Errors methods. Rails 6.1+ changed the errors
+    API significantly. Use errors.add instead of errors[] = and similar modern
+    approaches to future-proof your validation error handling.
+  Enabled: true
+  Severity: warning
+
+Rails/DuplicateAssociation:
+  Description: |
+    Avoid duplicate associations in ActiveRecord models. Multiple associations
+    with the same name can cause unexpected behavior and make code harder to
+    understand. Each association should have a unique, descriptive name.
+  Enabled: true
+  Severity: warning
+
+Rails/DuplicateScope:
+  Description: |
+    Avoid duplicate scopes in ActiveRecord models. Multiple scopes with the
+    same name override each other, leading to confusion. Each scope should
+    have a unique, descriptive name that clearly indicates its purpose.
+  Enabled: true
+  Severity: warning

data/config/rubocop-rspec.yml

@@ -27,3 +27,112 @@ RSpec/MultipleMemoizedHelpers:
 RSpec/NestedGroups:
   Description: Checks for nested example groups.
   Enabled: false
+
+RSpec/VerifiedDoubles:
+  Description: Prefer instance doubles over stubbing any instance of a class.
+  Enabled: false
+
+RSpec/MessageChain:
+  Description: Check that chains of messages are not being stubbed.
+  Enabled: false
+
+# ==========================================
+# Modern RSpec Cops (2025) - All WARNING ONLY
+# These improve test quality and readability without breaking builds
+# ==========================================
+
+RSpec/BeEq:
+  Description: |
+    Use be_eq matcher when testing for object equality. This is more explicit than
+    using == and provides better failure messages. It clearly indicates you're testing
+    for value equality rather than object identity (be_equal).
+  Enabled: true
+  Severity: warning
+
+RSpec/BeNil:
+  Description: |
+    Use be_nil matcher instead of be(nil) or eq(nil). This provides more descriptive
+    failure messages and is the conventional RSpec way to test for nil values.
+    Makes test intent clearer and improves readability.
+  Enabled: true
+  Severity: warning
+
+RSpec/ChangeByZero:
+  Description: |
+    Use 'not_to change' instead of 'to change.by(0)' for better expressiveness.
+    This makes test intent clearer - you're explicitly stating that something
+    should NOT change rather than implying it changes by zero.
+  Enabled: true
+  Severity: warning
+
+RSpec/ClassCheck:
+  Description: |
+    Use be_a/be_kind_of instead of be_instance_of when testing class inheritance.
+    be_instance_of tests for exact class match, while be_a allows inheritance,
+    which is usually what you want in object-oriented testing.
+  Enabled: true
+  Severity: warning
+
+RSpec/EmptyMetadata:
+  Description: |
+    Avoid empty metadata hashes in RSpec examples. Empty metadata serves no purpose
+    and adds noise to test files. Either add meaningful metadata or remove the
+    empty hash entirely for cleaner test code.
+  Enabled: true
+  Severity: warning
+
+RSpec/ExcessiveDocstringSpacing:
+  Description: |
+    Avoid excessive spacing in RSpec docstrings. Consistent formatting improves
+    readability and maintains professional code appearance. Too much spacing
+    makes tests harder to scan and understand quickly.
+  Enabled: true
+  Severity: warning
+
+RSpec/IdenticalEqualityAssertion:
+  Description: |
+    Avoid identical equality assertions like expect(foo).to eq(foo). These tests
+    will always pass and don't provide value. They may indicate copy-paste errors
+    or misunderstanding of what's being tested.
+  Enabled: true
+  Severity: warning
+
+RSpec/SubjectDeclaration:
+  Description: |
+    Use subject blocks consistently throughout your test suite. This ensures
+    uniform test structure and makes tests more predictable and maintainable.
+    Consistent patterns reduce cognitive load when reading tests.
+  Enabled: true
+  Severity: warning
+
+RSpec/VerifiedDoubleReference:
+  Description: |
+    Reference classes when using verified doubles for better test reliability.
+    Verified doubles catch method signature changes and prevent tests from
+    passing when the actual API has changed. However, kept flexible per your needs.
+  Enabled: false
+  Severity: warning
+
+RSpec/RedundantAround:
+  Description: |
+    Avoid redundant around blocks that only call yield. These add complexity
+    without providing value. Use before/after hooks or remove the around block
+    entirely for cleaner, more direct test setup.
+  Enabled: true
+  Severity: warning
+
+RSpec/ScatteredSetup:
+  Description: |
+    Group setup logic together instead of scattering it throughout tests.
+    This improves test readability and makes the setup phase clear and
+    maintainable. Scattered setup makes tests harder to understand.
+  Enabled: true
+  Severity: warning
+
+RSpec/StubbedMock:
+  Description: |
+    Avoid stubbing methods on mocked objects. This can create confusing test
+    scenarios where it's unclear what's being tested. Keep mocking and stubbing
+    separate for clearer test intent and easier debugging.
+  Enabled: true
+  Severity: warning

data/config/rubocop-style.yml

@@ -105,17 +105,7 @@ Style/FrozenStringLiteralComment:
     - "config/boot.rb"
     - "db/migrate/**/*"
 
-Style/HashSyntax:
-  Description: Checks hash literal syntax
-  Enabled: true
-  EnforcedStyle: ruby19
-  UseHashRocketsWithSymbolValues: false
-  PreferHashRocketsForNonAlnumEndingSymbols: false
-  SupportedStyles:
-  - ruby19
-  - hash_rockets
-  - no_mixed_keys
-  - ruby19_no_mixed_keys
+# Style/HashSyntax: Updated configuration moved to modern cops section below
 
 Style/MethodDefParentheses:
   Description: Checks if the method definitions have or don't have parentheses.
@@ -195,3 +185,89 @@ Style/TrivialAccessors:
   AllowDSLWriters: true
   IgnoreClassMethods: false
 
+# ==========================================
+# Modern Ruby 3.3 Style Cops (2025) - All WARNING ONLY
+# These help adopt modern Ruby patterns without breaking builds
+# ==========================================
+
+Style/FetchEnvVar:
+  Description: |
+    Use ENV.fetch for environment variables instead of ENV[] for better error handling.
+    This prevents silent failures when environment variables are missing and provides
+    clear error messages. Example: ENV.fetch('API_KEY') vs ENV['API_KEY']
+  Enabled: true
+  Severity: warning
+
+Style/HashSyntax:
+  Description: |
+    Use modern Ruby hash syntax consistently. Ruby 1.9+ allows symbol: value syntax
+    which is more readable and concise than :symbol => value. This cop enforces
+    consistent usage across your codebase for better readability.
+  Enabled: true
+  Severity: warning
+  EnforcedStyle: ruby19_no_mixed_keys
+
+Style/ArgumentsForwarding:
+  Description: |
+    Use Ruby 2.7+ argument forwarding (...) instead of explicit *args, **kwargs.
+    This makes method delegation cleaner and more efficient. Example: def foo(...); bar(...); end
+    instead of def foo(*args, **kwargs); bar(*args, **kwargs); end
+  Enabled: true
+  Severity: warning
+  
+Style/CollectionCompact:
+  Description: |
+    Use Array#compact and Hash#compact instead of reject(&:nil?) or similar patterns.
+    These methods are more expressive and potentially more performant. They clearly
+    indicate intent to remove nil values from collections.
+  Enabled: true
+  Severity: warning
+
+Style/StringChars:
+  Description: |
+    Use String#chars instead of String#each_char.to_a for converting strings to arrays.
+    #chars is more direct and readable, clearly expressing the intent to get an array
+    of characters rather than iterating through them.
+  Enabled: true
+  Severity: warning
+
+Style/MapToHash:
+  Description: |
+    Use to_h instead of map followed by Hash[] for converting arrays to hashes.
+    This is more readable and potentially more performant, clearly expressing the
+    intent to create a hash from key-value pairs.
+  Enabled: true
+  Severity: warning
+
+Style/HashTransformKeys:
+  Description: |
+    Use transform_keys instead of each_with_object or map for transforming hash keys.
+    This method is more expressive and clearly indicates the intent to modify keys
+    while preserving values, making code more maintainable.
+  Enabled: true
+  Severity: warning
+
+Style/HashTransformValues:
+  Description: |
+    Use transform_values instead of each_with_object or map for transforming hash values.
+    This method is more expressive and clearly indicates the intent to modify values
+    while preserving keys, improving code readability and intent.
+  Enabled: true
+  Severity: warning
+
+Style/SlicingWithRange:
+  Description: |
+    Use range slicing syntax (arr[1..3]) instead of arr.slice(1, 3) when working with ranges.
+    This is more concise and idiomatic Ruby, making code more readable and consistent
+    with Ruby conventions for array manipulation.
+  Enabled: true
+  Severity: warning
+
+Style/RedundantArgument:
+  Description: |
+    Remove redundant arguments that match method defaults. This reduces code noise
+    and makes the essential parts of method calls more visible. It also future-proofs
+    code against changes in default values.
+  Enabled: true
+  Severity: warning
+

data/lib/rubocop/hk/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Hk
-    VERSION = "1.1.1"
+    VERSION = "1.2.0" unless defined?(VERSION)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-hk
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Hammad Khan
@@ -114,7 +114,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="