rubocop-gusto 11.2.0 → 11.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd7d9b067df7edfe822d63daa4c1ffb54b54086cbf80f185ca20888a513d88ec
-  data.tar.gz: 4f62f8d399612f2aa26e929b765b33e54324bee3306c27f515b43e15f0c3111f
+  metadata.gz: 63e4d5c0598bcf51b28b73659d6ef7d2441d350b425f8d34ac4b02dc7eaaf41c
+  data.tar.gz: 0ac1b025edbc7f1add82364538074752bd47c2272d8b5fd59fc3aa90db9b052c
 SHA512:
-  metadata.gz: 5393a0a5937de49f0f70bfd74f401bcabe17a0c24292a9921277d2f81dbf51661e730995b16db0c3de5888ef7e3842236016f156fc94b7446f1eb8693a8beb77
-  data.tar.gz: 53114fe101a37c7d0a34f291e038b70c16186c8b4352991d7b7bd03e40b8b293281e62b1adc8fd4d2c6fdeabcc143bd7ff262baaef4c471e5e895f00e843803d
+  metadata.gz: 827456db6259cd5414df4d864b65b360cf67f1ba6f8d047d4e4d5bc3374fe42f9220d7012bbf8b1f84fcbac1b5b6d675ea9bc42a77a26ef59f86a0179b92800d
+  data.tar.gz: 7543bc23e8c2aaf3747bbfe9e661fb0c83c1a62d23dad639dc95bbc60a7ecd913dce2bc3c8057f35183b8a9367105ee2b6e64821513f50d6365aa74e1935b776

data/CHANGELOG.md

@@ -3,6 +3,13 @@
 - Remove redundant `Rails: Enabled: true` from `config/rails.yml` (already set by rubocop-rails' own defaults)
 - Enable `Rails/DefaultScope` cop (disabled by default in rubocop-rails)
 
+## [11.3.0](https://github.com/Gusto/rubocop-gusto/compare/v11.2.0...v11.3.0) (2026-06-29)
+
+
+### Features
+
+* add Gusto/FeatureFlagConstants cop (RR-890) ([#144](https://github.com/Gusto/rubocop-gusto/issues/144)) ([9058e0e](https://github.com/Gusto/rubocop-gusto/commit/9058e0e3055445a6be1818f2c142013239773bb5))
+
 ## [11.2.0](https://github.com/Gusto/rubocop-gusto/compare/v11.1.1...v11.2.0) (2026-06-26)
 
 

data/config/gusto_cops.yml

@@ -43,6 +43,9 @@ Gusto/FactoryClassesOrModules:
   Include:
     - 'spec/**/factories/*.rb'
 
+Gusto/FeatureFlagConstants:
+  Description: 'FeatureFlag keys should be constants, not strings.'
+
 Gusto/MinByMaxBy:
   Description: 'Checks for the use of `min` or `max` with a proc. Corrects to `min_by` or `max_by`.'
   Safe: false

data/lib/rubocop/cop/gusto/feature_flag_constants.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Gusto
+      # Enforces that `FeatureFlag.active?` is called with a constant rather than a
+      # string literal. Defining flag keys as constants keeps them in one place,
+      # makes typos a load-time error instead of a silent always-off flag, and lets
+      # tools find every reference to a flag.
+      #
+      # `FeatureFlag` is a constant, so it is never nil and safe navigation
+      # (`FeatureFlag&.active?`) is never used; the cop only handles `on_send`.
+      #
+      # @example
+      #   # bad
+      #   FeatureFlag.active?("some_feature_flag")
+      #
+      #   # good
+      #   FeatureFlag.active?(SomeModule::SOME_FEATURE_FLAG)
+      class FeatureFlagConstants < Base
+        MSG = "FeatureFlag keys should be constants, not strings"
+        RESTRICT_ON_SEND = %i(active?).freeze
+
+        # @!method feature_flag_with_string?(node)
+        def_node_matcher :feature_flag_with_string?, <<~PATTERN
+          (send (const nil? :FeatureFlag) :active? (str _) ...)
+        PATTERN
+
+        def on_send(node)
+          add_offense(node) if feature_flag_with_string?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/gusto/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Gusto
-    VERSION = "11.2.0"
+    VERSION = "11.3.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-gusto
 version: !ruby/object:Gem::Version
-  version: 11.2.0
+  version: 11.3.0
 platform: ruby
 authors:
 - Gusto Engineering
@@ -160,6 +160,7 @@ files:
 - lib/rubocop/cop/gusto/discouraged_gem.rb
 - lib/rubocop/cop/gusto/execute_migration.rb
 - lib/rubocop/cop/gusto/factory_classes_or_modules.rb
+- lib/rubocop/cop/gusto/feature_flag_constants.rb
 - lib/rubocop/cop/gusto/min_by_max_by.rb
 - lib/rubocop/cop/gusto/no_metaprogramming.rb
 - lib/rubocop/cop/gusto/no_rescue_error_message_checking.rb