rubocop-gusto 10.0.1 → 10.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d5f9caaca5dbe1a2cdd70a064d7bf6f5a29a029ae5bc5efe9071613785a698c
-  data.tar.gz: 1b355982894e5ef91090dfb8e2d0fe4d301690d55d47c485f0951c2d38f1a77e
+  metadata.gz: 53a74cd600bf2446b894971dad3e18c55cf1f3c76485c3a5b4f00c65d672f658
+  data.tar.gz: a39f3b4113a0ac8f9ab0abb1d4d1b8ca77f540f620873db86e533bc465221bf5
 SHA512:
-  metadata.gz: 48e622d548efed1455bccd269a0c3e459d9149e4e782058f0540505e7a528bb7e1c6ce3d5cbede01f2be62b587ef11cfd2a32ba914f2806f36a4fa57117d4f3a
-  data.tar.gz: c11542ccc1d6029a8b15cc1ef89de87adcbb8fb2ed7eb0492efc4ce90454f959877b73daaddcdaf443417ebab40a78f60343024ca7f323fa4f1380e6b82c2c55
+  metadata.gz: 6b23cefe43c61ff7af9988fd5e0eeb7e63fadf62ee961e77edd65a132a3ccbb7c92541ff3206b1e217128d8676933bf37c650c3d6abb8416742828125e4c62a3
+  data.tar.gz: 04c1cb8f540994333c88372160840f00d4b51bbd9bfa093238ef65edcab9f15837496729c4621e7930c57e2312af61749642c0d4c4cf0d11f88eae4c59174538

data/config/default.yml

@@ -58,6 +58,9 @@ Gusto/FactoryClassesOrModules:
   Include:
     - 'spec/**/factories/*.rb'
 
+Gusto/IgnoredColumnsAssignment:
+  Description: 'Use `+=` with an array for `ignored_columns` assignment instead of direct assignment.'
+
 Gusto/MinByMaxBy:
   Description: 'Checks for the use of `min` or `max` with a proc. Corrects to `min_by` or `max_by`.'
   Safe: false

data/lib/rubocop/cop/gusto/ignored_columns_assignment.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Gusto
+      # Enforces proper usage of `ignored_columns` assignment
+      #
+      # This cop ensures that `ignored_columns` is assigned using `+=` with an array
+      # instead of direct assignment, which will overwrite the existing list of
+      # ignored columns for the model, or overwrite the list it should inherit in the
+      # case of single table inheritance.
+      #
+      # @example
+      #
+      #   # bad
+      #   self.ignored_columns = :column_name
+      #   self.ignored_columns = 'column_name'
+      #   self.ignored_columns = [:column_name]
+      #   self.ignored_columns = ['column_name']
+      #
+      #   # good
+      #   self.ignored_columns += [:column_name]
+      #   self.ignored_columns += ['column_name']
+      #
+      class IgnoredColumnsAssignment < Base
+        MSG = 'Use `+=` with an array for `ignored_columns` assignment instead of direct assignment.'
+        RESTRICT_ON_SEND = %i(ignored_columns=).freeze
+
+        # @!method ignored_columns_direct_assignment?(node)
+        def_node_matcher :ignored_columns_direct_assignment?, <<~PATTERN
+          (send (self) :ignored_columns= _)
+        PATTERN
+
+        def on_send(node)
+          if ignored_columns_direct_assignment?(node)
+            add_offense(node.loc.selector)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/gusto/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Gusto
-    VERSION = '10.0.1'
+    VERSION = '10.1.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-gusto
 version: !ruby/object:Gem::Version
-  version: 10.0.1
+  version: 10.1.0
 platform: ruby
 authors:
 - Gusto Engineering
@@ -127,6 +127,7 @@ files:
 - lib/rubocop/cop/gusto/datadog_constant.rb
 - lib/rubocop/cop/gusto/execute_migration.rb
 - lib/rubocop/cop/gusto/factory_classes_or_modules.rb
+- lib/rubocop/cop/gusto/ignored_columns_assignment.rb
 - lib/rubocop/cop/gusto/min_by_max_by.rb
 - lib/rubocop/cop/gusto/no_metaprogramming.rb
 - lib/rubocop/cop/gusto/no_rescue_error_message_checking.rb
@@ -172,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.7.1
 specification_version: 4
 summary: A gem for sharing gusto rubocop rules
 test_files: []