rubocop-graphql 0.9.0 → 0.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e63911b5c7c77f1d207fc9a1d411c61b874f51b372507bd7fd4c8072addd0663
-  data.tar.gz: 5581dcb49597ece10a23dba6f191b531d80d313e265fb6a61ec6db172691ad75
+  metadata.gz: 60522da6cb205f7667084ee8a44f5500a426e4e52d677c60dee314d7e11e2129
+  data.tar.gz: 6d091ec89349bd1b2d9ca160c53566fd11cd2dc0a786f33e81a12e7b46e9a20e
 SHA512:
-  metadata.gz: ff897f7cfd8f63f3435915d3c9203803b7d81cb4d3997b5ef6e8e3822cb95ae77cc7eb3573bc6c50aa54c630eec59c550b35dca07d12412bcf7a460e00e3290f
-  data.tar.gz: cb02df1ef01c442dd7c3ad1abd89b6e8457bf83aa52391c78ead27e7c8d0793f8794ac4eb7295e234022763081f640115c3adef8a1f42f81600ef714655f6c06
+  metadata.gz: 708fbacb5879ce6be4ff0b9a9f34f85d13e1b65945a854c4b63cd96d9a74e145a8f20c1d792fcca9639ac524cb5c5353ddc09dd6f68e556c7e0167fbd4a9c544
+  data.tar.gz: e827fa568a4a472b2246185afc47bca7c119b9af60a3cc77e8d9033556866468988f1f79b8e2e2f60a8b43381e97a416f9825e61317a850475961414b29578ac

data/config/default.yml

@@ -48,6 +48,7 @@ GraphQL/FieldName:
   Enabled: true
   VersionAdded: '0.80'
   Description: 'This cop checks whether field names are snake_case'
+  SafeAutoCorrect: false
 
 GraphQL/ExtractInputType:
   Enabled: true
@@ -79,3 +80,13 @@ GraphQL/ObjectDescription:
   Exclude:
     - '**/*_schema.rb'
     - '**/base_*.rb'
+
+GraphQL/OrderedArguments:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'Arguments should be alphabetically sorted within groups'
+
+GraphQL/OrderedFields:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'Fields should be alphabetically sorted within groups'

data/lib/refinements/underscore_string.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module UnderscoreString
+  refine String do
+    # This method was extracted from activesupport in Rails:
+    # https://github.com/rails/rails/blob/8dab534ca81dd32c6a83ac03596a1feb7ddaaca7/activesupport/lib/active_support/inflector/methods.rb#L96
+
+    def underscore
+      camel_cased_word = self
+      regex = /(?:(?<=([A-Za-z\d]))|\b)((?=a)b)(?=\b|[^a-z])/
+      return camel_cased_word.to_s unless /[A-Z-]|::/.match?(camel_cased_word)
+
+      word = camel_cased_word.to_s.gsub("::", "/")
+      word.gsub!(regex) { "#{Regexp.last_match(1) && '_'}#{Regexp.last_match(2).downcase}" }
+      word.gsub!(/([A-Z\d]+)(?=[A-Z][a-z])|([a-z\d])(?=[A-Z])/) do
+        (Regexp.last_match(1) || Regexp.last_match(2)) << "_"
+      end
+      word.tr!("-", "_")
+      word.downcase!
+      word
+    end
+  end
+end

data/lib/rubocop/cop/graphql/field_hash_key.rb

@@ -34,7 +34,7 @@ module RuboCop
             (args)
             (send
               (send nil? :object) :[]
-              (_type $_)
+              ({sym str} $_)
             )
           )
         PATTERN

data/lib/rubocop/cop/graphql/field_name.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
+require_relative "../../../refinements/underscore_string"
+
+using UnderscoreString unless String.method_defined?(:underscore)
+
 module RuboCop
   module Cop
     module GraphQL
@@ -19,6 +23,7 @@ module RuboCop
       #   end
       #
       class FieldName < Base
+        extend AutoCorrector
         include RuboCop::GraphQL::NodePattern
 
         using RuboCop::GraphQL::Ext::SnakeCase
@@ -31,7 +36,17 @@ module RuboCop
           field = RuboCop::GraphQL::Field.new(node)
           return if field.name.snake_case?
 
-          add_offense(node)
+          add_offense(node) do |corrector|
+            rename_field_name(corrector, field, node)
+          end
+        end
+
+        private
+
+        def rename_field_name(corrector, field, node)
+          name_field = field.name.to_s
+          new_line = node.source.sub(name_field, name_field.underscore)
+          corrector.replace(node, new_line)
         end
       end
     end

data/lib/rubocop/cop/graphql/ordered_fields.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module GraphQL
-      # Field should be alphabetically sorted within groups.
+      # Fields should be alphabetically sorted within groups.
       #
       # @example
       #   # good

data/lib/rubocop/graphql/field/block.rb

@@ -11,7 +11,7 @@ module RuboCop
           (block
             (send nil? :field ...)
             (args)
-            $...
+            {(begin $...)|$...}
           )
         PATTERN
 

data/lib/rubocop/graphql/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module GraphQL
-    VERSION = "0.9.0".freeze
+    VERSION = "0.10.3".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-graphql
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.3
 platform: ruby
 authors:
 - Dmitry Tsepelev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-18 00:00:00.000000000 Z
+date: 2021-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -82,6 +82,7 @@ files:
 - LICENSE.txt
 - README.md
 - config/default.yml
+- lib/refinements/underscore_string.rb
 - lib/rubocop-graphql.rb
 - lib/rubocop/cop/graphql/argument_description.rb
 - lib/rubocop/cop/graphql/argument_name.rb
@@ -134,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.