rubocop-graphql 0.8.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c68112dd907111859f0c8ca78ad31c6bea918c11411d9d89a4a4ae289fc3630d
-  data.tar.gz: cfeed828552dcdc4509b476f4d6a9672c111ef2e11001fad01f52b3699d26bc9
+  metadata.gz: 0d039f4e52b3e606bee7cfc92f14743ead168fd8e9afeefc9c3f73a5e8f97acb
+  data.tar.gz: 443920f9aa279503373dc467b91d5f8bb3e8fe510037c12e791a6231a1612cb3
 SHA512:
-  metadata.gz: 7a20bb455185e7eb0ceeffb6da3f33438a416f003ce6fd7287483a34aab61301051a72e0b6b13967ead0c2b14c5ce31d28f4c9c864ed24ab627b34e7f322e40c
-  data.tar.gz: e3badf19ec0a0ec03fe7be4d71324cb65e70f64c2ed3919334836f5d532e10fd16b3f54f58f2e909c987b72957027a13fa27fedf35f1bba2d2cceb6c9e66ca69
+  metadata.gz: 475dd5aa2de580c3ddc072fa66bc9cc09818dbf0e720bd1a2b874c56cba537dbd3dd63aa99e5bf30e33612981fddd4bb547f9224d5bab3352568564c93f1814e
+  data.tar.gz: c6faab3fb41885f25938ff17f8b18eafe4c2c6ba5a951a118ddeba5985448907597527242a35c1944f9f9a43067be2ec8e5849e605f206530c085c6c4e1da24c

data/config/default.yml

@@ -1,7 +1,6 @@
-AllCops:
-  GraphQL:
-    Patterns:
-      - "(?:^|/)graphql/"
+GraphQL:
+  Include:
+    - "**/graphql/**/*"
 
 GraphQL/ArgumentDescription:
   Enabled: true
@@ -49,6 +48,7 @@ GraphQL/FieldName:
   Enabled: true
   VersionAdded: '0.80'
   Description: 'This cop checks whether field names are snake_case'
+  SafeAutoCorrect: false
 
 GraphQL/ExtractInputType:
   Enabled: true
@@ -68,10 +68,15 @@ GraphQL/ExtractType:
     - min
     - max
 
+GraphQL/LegacyDsl:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'Checks that types are defined with class-based API'
+
 GraphQL/ObjectDescription:
   Enabled: true
   VersionAdded: '0.80'
   Description: 'Ensures all types have a description'
   Exclude:
     - '**/*_schema.rb'
-    - '**/base_*.rb'
+    - '**/base_*.rb'

data/lib/refinements/underscore_string.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module UnderscoreString
+  refine String do
+    # This method was extracted from activesupport in Rails:
+    # https://github.com/rails/rails/blob/8dab534ca81dd32c6a83ac03596a1feb7ddaaca7/activesupport/lib/active_support/inflector/methods.rb#L96
+
+    def underscore
+      camel_cased_word = self
+      regex = /(?:(?<=([A-Za-z\d]))|\b)((?=a)b)(?=\b|[^a-z])/
+      return camel_cased_word.to_s unless /[A-Z-]|::/.match?(camel_cased_word)
+
+      word = camel_cased_word.to_s.gsub("::", "/")
+      word.gsub!(regex) { "#{Regexp.last_match(1) && '_'}#{Regexp.last_match(2).downcase}" }
+      word.gsub!(/([A-Z\d]+)(?=[A-Z][a-z])|([a-z\d])(?=[A-Z])/) do
+        (Regexp.last_match(1) || Regexp.last_match(2)) << "_"
+      end
+      word.tr!("-", "_")
+      word.downcase!
+      word
+    end
+  end
+end

data/lib/rubocop-graphql.rb

@@ -7,7 +7,9 @@ require_relative "rubocop/graphql/ext/snake_case"
 require_relative "rubocop/graphql"
 require_relative "rubocop/graphql/version"
 require_relative "rubocop/graphql/inject"
+require_relative "rubocop/graphql/description_method"
 require_relative "rubocop/graphql/node_pattern"
+require_relative "rubocop/graphql/swap_range"
 
 require_relative "rubocop/graphql/argument"
 require_relative "rubocop/graphql/argument/block"

data/lib/rubocop/cop/graphql/argument_description.rb

@@ -18,7 +18,7 @@ module RuboCop
       #     argument :uuid, ID, required: true
       #   end
       #
-      class ArgumentDescription < Cop
+      class ArgumentDescription < Base
         include RuboCop::GraphQL::NodePattern
 
         MSG = "Missing argument description"

data/lib/rubocop/cop/graphql/argument_name.rb

@@ -18,7 +18,7 @@ module RuboCop
       #     argument :userId, ID, required: true
       #   end
       #
-      class ArgumentName < Cop
+      class ArgumentName < Base
         include RuboCop::GraphQL::NodePattern
 
         using RuboCop::GraphQL::Ext::SnakeCase

data/lib/rubocop/cop/graphql/extract_input_type.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module GraphQL
-      class ExtractInputType < Cop
+      class ExtractInputType < Base
         # This cop checks fields on common prefix groups
         #
         # # @example

data/lib/rubocop/cop/graphql/extract_type.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module GraphQL
-      class ExtractType < Cop
+      class ExtractType < Base
         # This cop checks fields on common prefix groups
         #
         # # @example

data/lib/rubocop/cop/graphql/field_definitions.rb

@@ -44,7 +44,8 @@ module RuboCop
       #       object.contact_data.last_name
       #     end
       #   end
-      class FieldDefinitions < Cop
+      class FieldDefinitions < Base
+        extend AutoCorrector
         include ConfigurableEnforcedStyle
         include RuboCop::GraphQL::NodePattern
         include RuboCop::Cop::RangeHelp
@@ -75,17 +76,6 @@ module RuboCop
           end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            case style
-            when :define_resolver_after_definition
-              place_resolver_after_definitions(corrector, node)
-            when :group_definitions
-              group_field_declarations(corrector, node)
-            end
-          end
-        end
-
         private
 
         GROUP_DEFS_MSG = "Group all field definitions together."
@@ -98,7 +88,9 @@ module RuboCop
           fields.each_with_index do |node, idx|
             next if node.sibling_index == first_field.sibling_index + idx
 
-            add_offense(node, message: GROUP_DEFS_MSG)
+            add_offense(node, message: GROUP_DEFS_MSG) do |corrector|
+              group_field_declarations(corrector, node)
+            end
           end
         end
 
@@ -133,7 +125,9 @@ module RuboCop
 
           return if method_definition.sibling_index - field_sibling_index == 1
 
-          add_offense(field.node, message: RESOLVER_AFTER_FIELD_MSG)
+          add_offense(field.node, message: RESOLVER_AFTER_FIELD_MSG) do |corrector|
+            place_resolver_after_definitions(corrector, field.node)
+          end
         end
 
         def place_resolver_after_definitions(corrector, node)

data/lib/rubocop/cop/graphql/field_description.rb

@@ -18,7 +18,7 @@ module RuboCop
       #     field :name, String, null: true
       #   end
       #
-      class FieldDescription < Cop
+      class FieldDescription < Base
         include RuboCop::GraphQL::NodePattern
 
         MSG = "Missing field description"

data/lib/rubocop/cop/graphql/field_hash_key.rb

@@ -23,7 +23,8 @@ module RuboCop
       #     end
       #   end
       #
-      class FieldHashKey < Cop
+      class FieldHashKey < Base
+        extend AutoCorrector
         include RuboCop::GraphQL::NodePattern
         include RuboCop::Cop::RangeHelp
 
@@ -47,32 +48,32 @@ module RuboCop
           method_definition = resolver_method_definition_for(field)
 
           if (suggested_hash_key_name = hash_key_to_use(method_definition))
-            add_offense(node, message: message(suggested_hash_key_name))
+            add_offense(node, message: message(suggested_hash_key_name)) do |corrector|
+              autocorrect(corrector, node)
+            end
           end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            field = RuboCop::GraphQL::Field.new(node)
-            method_definition = resolver_method_definition_for(field)
-            suggested_hash_key_name = hash_key_to_use(method_definition)
+        private
 
-            corrector.insert_after(
-              node.loc.expression, ", hash_key: #{suggested_hash_key_name.inspect}"
-            )
+        def message(hash_key)
+          format(MSG, hash_key: hash_key)
+        end
 
-            range = range_with_surrounding_space(
-              range: method_definition.loc.expression, side: :left
-            )
+        def autocorrect(corrector, node)
+          field = RuboCop::GraphQL::Field.new(node)
+          method_definition = resolver_method_definition_for(field)
+          suggested_hash_key_name = hash_key_to_use(method_definition)
 
-            corrector.remove(range)
-          end
-        end
+          corrector.insert_after(
+            node.loc.expression, ", hash_key: #{suggested_hash_key_name.inspect}"
+          )
 
-        private
+          range = range_with_surrounding_space(
+            range: method_definition.loc.expression, side: :left
+          )
 
-        def message(hash_key)
-          format(MSG, hash_key: hash_key)
+          corrector.remove(range)
         end
 
         def resolver_method_definition_for(field)

data/lib/rubocop/cop/graphql/field_method.rb

@@ -23,7 +23,8 @@ module RuboCop
       #     end
       #   end
       #
-      class FieldMethod < Cop
+      class FieldMethod < Base
+        extend AutoCorrector
         include RuboCop::GraphQL::NodePattern
         include RuboCop::Cop::RangeHelp
 
@@ -46,22 +47,9 @@ module RuboCop
           method_definition = suggest_method_name_for(field)
 
           if (suggested_method_name = method_to_use(method_definition))
-            add_offense(node, message: message(suggested_method_name))
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            field = RuboCop::GraphQL::Field.new(node)
-            method_definition = suggest_method_name_for(field)
-            suggested_method_name = method_to_use(method_definition)
-
-            corrector.insert_after(node.loc.expression, ", method: :#{suggested_method_name}")
-
-            range = range_with_surrounding_space(
-              range: method_definition.loc.expression, side: :left
-            )
-            corrector.remove(range)
+            add_offense(node, message: message(suggested_method_name)) do |corrector|
+              autocorrect(corrector, node)
+            end
           end
         end
 
@@ -71,6 +59,19 @@ module RuboCop
           format(MSG, method_name: method_name)
         end
 
+        def autocorrect(corrector, node)
+          field = RuboCop::GraphQL::Field.new(node)
+          method_definition = suggest_method_name_for(field)
+          suggested_method_name = method_to_use(method_definition)
+
+          corrector.insert_after(node.loc.expression, ", method: :#{suggested_method_name}")
+
+          range = range_with_surrounding_space(
+            range: method_definition.loc.expression, side: :left
+          )
+          corrector.remove(range)
+        end
+
         def suggest_method_name_for(field)
           method_name = field.resolver_method_name
           field.schema_member.find_method_definition(method_name)

data/lib/rubocop/cop/graphql/field_name.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
+require_relative "../../../refinements/underscore_string"
+
+using UnderscoreString unless String.method_defined?(:underscore)
+
 module RuboCop
   module Cop
     module GraphQL
@@ -18,7 +22,8 @@ module RuboCop
       #     field :firstName, String, null: true
       #   end
       #
-      class FieldName < Cop
+      class FieldName < Base
+        extend AutoCorrector
         include RuboCop::GraphQL::NodePattern
 
         using RuboCop::GraphQL::Ext::SnakeCase
@@ -31,7 +36,17 @@ module RuboCop
           field = RuboCop::GraphQL::Field.new(node)
           return if field.name.snake_case?
 
-          add_offense(node)
+          add_offense(node) do |corrector|
+            rename_field_name(corrector, field, node)
+          end
+        end
+
+        private
+
+        def rename_field_name(corrector, field, node)
+          name_field = field.name.to_s
+          new_line = node.source.sub(name_field, name_field.underscore)
+          corrector.replace(node, new_line)
         end
       end
     end

data/lib/rubocop/cop/graphql/legacy_dsl.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # This cop checks whether type definitions are class-based or legacy.
+    #
+    # @example
+    #   # good
+    #
+    #   class Example < BaseType
+    #     ....
+    #   end
+    #
+    #   # bad
+    #
+    #   Example = GraphQL::ObjectType.define do
+    #     ....
+    #     ....
+    #   end
+    #
+    module GraphQL
+      class LegacyDsl < Base
+        def_node_matcher :legacy_dsl?, <<~PATTERN
+          (block
+            (send
+              (const
+                (const nil? :GraphQL) _) :define)
+            ...
+          )
+        PATTERN
+
+        MSG = "Avoid using legacy based type-based definitions. Use class-based defintions instead."
+
+        def on_send(node)
+          return unless node.parent.type == :block
+
+          add_offense(node.parent) if legacy_dsl?(node.parent)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/graphql/object_description.rb

@@ -20,8 +20,9 @@ module RuboCop
       #     # ...
       #   end
       #
-      class ObjectDescription < Cop
+      class ObjectDescription < Base
         include RuboCop::GraphQL::NodePattern
+        include RuboCop::GraphQL::DescriptionMethod
 
         MSG = "Missing type description"
 
@@ -29,14 +30,6 @@ module RuboCop
           (send nil? :description (send (const nil? :I18n) :t ...))
         PATTERN
 
-        def_node_matcher :has_string_description?, <<~PATTERN
-          (send nil? :description (:str $_))
-        PATTERN
-
-        def_node_matcher :has_multiline_string_description?, <<~PATTERN
-          (send nil? :description (:dstr ...))
-        PATTERN
-
         def_node_matcher :interface?, <<~PATTERN
           (send nil? :include (const ...))
         PATTERN
@@ -59,8 +52,7 @@ module RuboCop
 
         def has_description?(node)
           has_i18n_description?(node) ||
-            has_string_description?(node) ||
-            has_multiline_string_description?(node)
+            description_kwarg?(node)
         end
 
         def child_nodes(node)

data/lib/rubocop/cop/graphql/ordered_arguments.rb

@@ -48,15 +48,16 @@ module RuboCop
       #     end
       #   end
       #
-      class OrderedArguments < Cop
+      class OrderedArguments < Base
+        extend AutoCorrector
+
+        include RuboCop::GraphQL::SwapRange
+
         MSG = "Arguments should be sorted in an alphabetical order within their section. " \
               "Field `%<current>s` should appear before `%<previous>s`."
 
-        def investigate(processed_source)
-          return if processed_source.blank?
-
-          argument_declarations(processed_source.ast)
-            .each_cons(2) do |previous, current|
+        def on_class(node)
+          argument_declarations(node).each_cons(2) do |previous, current|
             next unless consecutive_lines(previous, current)
             next if argument_name(current) > argument_name(previous)
 
@@ -64,43 +65,18 @@ module RuboCop
           end
         end
 
-        def autocorrect(node)
-          declarations = argument_declarations(processed_source.ast)
-          node_index = declarations.map(&:location).find_index(node.location)
-          previous_declaration = declarations.to_a[node_index - 1]
-
-          current_range = declaration(node)
-          previous_range = declaration(previous_declaration)
-
-          lambda do |corrector|
-            swap_range(corrector, current_range, previous_range)
-          end
-        end
-
         private
 
-        def declaration(node)
-          buffer = processed_source.buffer
-          begin_pos = node.source_range.begin_pos
-          end_line = buffer.line_for_position(node.loc.expression.end_pos)
-          end_pos = buffer.line_range(end_line).end_pos
-          Parser::Source::Range.new(buffer, begin_pos, end_pos)
-        end
-
-        def swap_range(corrector, range1, range2)
-          src1 = range1.source
-          src2 = range2.source
-          corrector.replace(range1, src2)
-          corrector.replace(range2, src1)
-        end
-
         def register_offense(previous, current)
           message = format(
             self.class::MSG,
             previous: argument_name(previous),
             current: argument_name(current)
           )
-          add_offense(current, message: message)
+
+          add_offense(current, message: message) do |corrector|
+            swap_range(corrector, current, previous)
+          end
         end
 
         def argument_name(node)

data/lib/rubocop/cop/graphql/ordered_fields.rb

@@ -30,33 +30,21 @@ module RuboCop
       #     field :name, String, null: true
       #   end
       #
-      class OrderedFields < Cop
+      class OrderedFields < Base
+        extend AutoCorrector
+
+        include RuboCop::GraphQL::SwapRange
+
         MSG = "Fields should be sorted in an alphabetical order within their "\
               "section. "\
               "Field `%<current>s` should appear before `%<previous>s`."
 
-        def investigate(processed_source)
-          return if processed_source.blank?
-
-          field_declarations(processed_source.ast)
-            .each_cons(2) do |previous, current|
-              next unless consecutive_lines(previous, current)
-              next if field_name(current) > field_name(previous)
-
-              register_offense(previous, current)
-            end
-        end
-
-        def autocorrect(node)
-          declarations = field_declarations(processed_source.ast)
-          node_index = declarations.map(&:location).find_index(node.location)
-          previous_declaration = declarations.to_a[node_index - 1]
-
-          current_range = declaration(node)
-          previous_range = declaration(previous_declaration)
+        def on_class(node)
+          field_declarations(node).each_cons(2) do |previous, current|
+            next unless consecutive_lines(previous, current)
+            next if field_name(current) > field_name(previous)
 
-          lambda do |corrector|
-            swap_range(corrector, current_range, previous_range)
+            register_offense(previous, current)
           end
         end
 
@@ -68,7 +56,10 @@ module RuboCop
             previous: field_name(previous),
             current: field_name(current)
           )
-          add_offense(current, message: message)
+
+          add_offense(current, message: message) do |corrector|
+            swap_range(corrector, current, previous)
+          end
         end
 
         def field_name(node)
@@ -83,21 +74,6 @@ module RuboCop
           previous.source_range.last_line == current.source_range.first_line - 1
         end
 
-        def declaration(node)
-          buffer = processed_source.buffer
-          begin_pos = node.source_range.begin_pos
-          end_line = buffer.line_for_position(node.loc.expression.end_pos)
-          end_pos = buffer.line_range(end_line).end_pos
-          Parser::Source::Range.new(buffer, begin_pos, end_pos)
-        end
-
-        def swap_range(corrector, range1, range2)
-          src1 = range1.source
-          src2 = range2.source
-          corrector.replace(range1, src2)
-          corrector.replace(range2, src1)
-        end
-
         def_node_search :field_declarations, <<~PATTERN
           {
             (send nil? :field (:sym _) ...)

data/lib/rubocop/cop/graphql/resolver_method_length.rb

@@ -7,7 +7,7 @@ module RuboCop
       # Comment lines can optionally be ignored.
       #
       # The maximum allowed length is configurable using the Max option.
-      class ResolverMethodLength < Cop
+      class ResolverMethodLength < Base
         include RuboCop::Cop::ConfigurableMax
         include RuboCop::Cop::CodeLength
 

data/lib/rubocop/cop/graphql_cops.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "graphql/cop"
-
 require_relative "graphql/argument_description"
 require_relative "graphql/argument_name"
 require_relative "graphql/extract_input_type"
@@ -11,6 +9,7 @@ require_relative "graphql/field_description"
 require_relative "graphql/field_hash_key"
 require_relative "graphql/field_method"
 require_relative "graphql/field_name"
+require_relative "graphql/legacy_dsl"
 require_relative "graphql/resolver_method_length"
 require_relative "graphql/object_description"
 require_relative "graphql/ordered_arguments"

data/lib/rubocop/graphql/argument/block.rb

@@ -5,6 +5,7 @@ module RuboCop
     class Argument
       class Block
         extend RuboCop::NodePattern::Macros
+        include DescriptionMethod
 
         def_node_matcher :argument_block, <<~PATTERN
           (block
@@ -14,16 +15,12 @@ module RuboCop
           )
         PATTERN
 
-        def_node_matcher :description_kwarg?, <<~PATTERN
-          (send nil? :description (str ...))
-        PATTERN
-
         def initialize(argument_node)
           @nodes = argument_block(argument_node) || []
         end
 
         def description
-          @nodes.find { |kwarg| description_kwarg?(kwarg) }
+          find_description_method(@nodes)
         end
       end
     end

data/lib/rubocop/graphql/argument/kwargs.rb

@@ -20,7 +20,7 @@ module RuboCop
         PATTERN
 
         def initialize(argument_node)
-          @nodes = argument_kwargs(argument_node)
+          @nodes = argument_kwargs(argument_node) || []
         end
 
         def description

data/lib/rubocop/graphql/description_method.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module GraphQL
+    # Matches a variety of description formats commonly seen in Rails applications
+    #
+    #   description 'blah'
+    #
+    #   description "blah"
+    #
+    #   description <<~EOT
+    #      blah
+    #      bloop
+    #   EOT
+    #
+    #   description <<-EOT.squish
+    #      blah
+    #      bloop
+    #   EOT
+    module DescriptionMethod
+      extend RuboCop::NodePattern::Macros
+
+      def_node_matcher :description_kwarg?, <<~PATTERN
+        (send nil? :description {({str|dstr} ...)|(send ({str|dstr} ...) _)})
+      PATTERN
+
+      def find_description_method(nodes)
+        nodes.find { |kwarg| description_kwarg?(kwarg) }
+      end
+    end
+  end
+end

data/lib/rubocop/graphql/field/block.rb

@@ -5,6 +5,7 @@ module RuboCop
     class Field
       class Block
         extend RuboCop::NodePattern::Macros
+        include DescriptionMethod
 
         def_node_matcher :field_block, <<~PATTERN
           (block
@@ -14,16 +15,12 @@ module RuboCop
           )
         PATTERN
 
-        def_node_matcher :description_kwarg?, <<~PATTERN
-          (send nil? :description (str ...))
-        PATTERN
-
         def initialize(field_node)
           @nodes = field_block(field_node) || []
         end
 
         def description
-          @nodes.find { |kwarg| description_kwarg?(kwarg) }
+          find_description_method(@nodes)
         end
       end
     end

data/lib/rubocop/graphql/swap_range.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module GraphQL
+    module SwapRange
+      def swap_range(corrector, current, previous)
+        current_range = declaration(current)
+        previous_range = declaration(previous)
+
+        src1 = current_range.source
+        src2 = previous_range.source
+
+        corrector.replace(current_range, src2)
+        corrector.replace(previous_range, src1)
+      end
+
+      def declaration(node)
+        buffer = processed_source.buffer
+        begin_pos = node.source_range.begin_pos
+        end_line = buffer.line_for_position(node.loc.expression.end_pos)
+        end_pos = buffer.line_range(end_line).end_pos
+        Parser::Source::Range.new(buffer, begin_pos, end_pos)
+      end
+    end
+  end
+end

data/lib/rubocop/graphql/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module GraphQL
-    VERSION = "0.8.0".freeze
+    VERSION = "0.10.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-graphql
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Dmitry Tsepelev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-08 00:00:00.000000000 Z
+date: 2021-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -82,10 +82,10 @@ files:
 - LICENSE.txt
 - README.md
 - config/default.yml
+- lib/refinements/underscore_string.rb
 - lib/rubocop-graphql.rb
 - lib/rubocop/cop/graphql/argument_description.rb
 - lib/rubocop/cop/graphql/argument_name.rb
-- lib/rubocop/cop/graphql/cop.rb
 - lib/rubocop/cop/graphql/extract_input_type.rb
 - lib/rubocop/cop/graphql/extract_type.rb
 - lib/rubocop/cop/graphql/field_definitions.rb
@@ -93,6 +93,7 @@ files:
 - lib/rubocop/cop/graphql/field_hash_key.rb
 - lib/rubocop/cop/graphql/field_method.rb
 - lib/rubocop/cop/graphql/field_name.rb
+- lib/rubocop/cop/graphql/legacy_dsl.rb
 - lib/rubocop/cop/graphql/object_description.rb
 - lib/rubocop/cop/graphql/ordered_arguments.rb
 - lib/rubocop/cop/graphql/ordered_fields.rb
@@ -102,6 +103,7 @@ files:
 - lib/rubocop/graphql/argument.rb
 - lib/rubocop/graphql/argument/block.rb
 - lib/rubocop/graphql/argument/kwargs.rb
+- lib/rubocop/graphql/description_method.rb
 - lib/rubocop/graphql/ext/snake_case.rb
 - lib/rubocop/graphql/field.rb
 - lib/rubocop/graphql/field/block.rb
@@ -109,6 +111,7 @@ files:
 - lib/rubocop/graphql/inject.rb
 - lib/rubocop/graphql/node_pattern.rb
 - lib/rubocop/graphql/schema_member.rb
+- lib/rubocop/graphql/swap_range.rb
 - lib/rubocop/graphql/version.rb
 homepage: https://github.com/DmitryTsepelev/rubocop-graphql
 licenses:
@@ -125,7 +128,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/rubocop/cop/graphql/cop.rb

@@ -1,91 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  # Inspied by https://github.com/rubocop-hq/rubocop-rspec/blob/3a2088f79737e2e8e0e21482783f7d61411bf021/lib/rubocop/cop/rspec/cop.rb
-  module Cop
-    WorkaroundGraphqlCop = Cop.dup
-
-    # Clone of the the normal RuboCop::Cop::Cop class so we can rewrite
-    # the inherited method without breaking functionality
-    class WorkaroundGraphqlCop
-      # Remove the Cop.inherited method to be a noop. Our RSpec::Cop
-      # class will invoke the inherited hook instead
-      class << self
-        undef inherited
-        def inherited(*); end # rubocop:disable Lint/MissingSuper
-      end
-
-      # Special case `Module#<` so that the rspec support rubocop exports
-      # is compatible with our subclass
-      def self.<(other)
-        other.equal?(RuboCop::Cop::Cop) || super
-      end
-    end
-    private_constant(:WorkaroundGraphqlCop)
-
-    module GraphQL
-      # @abstract parent class to graphql-ruby cops
-      #
-      # The criteria for whether rubocop-rspec analyzes a certain ruby file
-      # is configured via `AllCops/GraphQL`. For example, if you want to
-      # customize your project to scan all files within a `graph/` directory
-      # then you could add this to your configuration:
-      #
-      # @example configuring analyzed paths
-      #
-      #   AllCops:
-      #     GraphQL:
-      #       Patterns:
-      #       - '(?:^|/)graph/'
-      class Cop < WorkaroundGraphqlCop
-        DEFAULT_CONFIGURATION =
-          RuboCop::GraphQL::CONFIG.fetch("AllCops").fetch("GraphQL")
-
-        DEFAULT_PATTERN_RE = Regexp.union(
-          DEFAULT_CONFIGURATION.fetch("Patterns")
-                               .map(&Regexp.public_method(:new))
-        )
-
-        # Invoke the original inherited hook so our cops are recognized
-        def self.inherited(subclass)  # rubocop:disable Lint/MissingSuper
-          RuboCop::Cop::Cop.inherited(subclass)
-        end
-
-        def relevant_file?(file)
-          relevant_rubocop_graphql_file?(file) && super
-        end
-
-        private
-
-        def relevant_rubocop_graphql_file?(file)
-          graphql_pattern =~ file
-        end
-
-        def graphql_pattern
-          if rspec_graphql_config?
-            Regexp.union(rspec_graphql_config.map(&Regexp.public_method(:new)))
-          else
-            DEFAULT_PATTERN_RE
-          end
-        end
-
-        def all_cops_config
-          config
-            .for_all_cops
-        end
-
-        def rspec_graphql_config?
-          return unless all_cops_config.key?("GraphQL")
-
-          all_cops_config.fetch("GraphQL").key?("Patterns")
-        end
-
-        def rspec_graphql_config
-          all_cops_config
-            .fetch("GraphQL", DEFAULT_CONFIGURATION)
-            .fetch("Patterns")
-        end
-      end
-    end
-  end
-end