rubocop-graphql 0.5.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3be1c838260c7be6902b6c06cf411ee768c39dab704b078d0204d8d1fa24fc5
-  data.tar.gz: 1061e5a30067f55254d5a89e87ff6a1597ac8df321e6be74b06a937ddd8da1e1
+  metadata.gz: c68112dd907111859f0c8ca78ad31c6bea918c11411d9d89a4a4ae289fc3630d
+  data.tar.gz: cfeed828552dcdc4509b476f4d6a9672c111ef2e11001fad01f52b3699d26bc9
 SHA512:
-  metadata.gz: 32e42d5a360bf522df3408bcfbc906e830eb7dcbc46aef53e967567c73f3634908a9cb6e9fb51967e79d1e64be24074067eca0e2870d45137c97b66f2b6354f4
-  data.tar.gz: 83a9f4756bec98ff082561a1cc1b81e64335a914bd343ba9353ccb865f38714219619594b8c6844b020fa04b3202412b5533a6fb01e2cbfb59b2a352d6465f57
+  metadata.gz: 7a20bb455185e7eb0ceeffb6da3f33438a416f003ce6fd7287483a34aab61301051a72e0b6b13967ead0c2b14c5ce31d28f4c9c864ed24ab627b34e7f322e40c
+  data.tar.gz: e3badf19ec0a0ec03fe7be4d71324cb65e70f64c2ed3919334836f5d532e10fd16b3f54f58f2e909c987b72957027a13fa27fedf35f1bba2d2cceb6c9e66ca69

data/lib/rubocop/cop/graphql/cop.rb

@@ -12,7 +12,7 @@ module RuboCop
       # class will invoke the inherited hook instead
       class << self
         undef inherited
-        def inherited(*); end
+        def inherited(*); end # rubocop:disable Lint/MissingSuper
       end
 
       # Special case `Module#<` so that the rspec support rubocop exports
@@ -47,7 +47,7 @@ module RuboCop
         )
 
         # Invoke the original inherited hook so our cops are recognized
-        def self.inherited(subclass)
+        def self.inherited(subclass)  # rubocop:disable Lint/MissingSuper
           RuboCop::Cop::Cop.inherited(subclass)
         end
 

data/lib/rubocop/cop/graphql/extract_input_type.rb

@@ -32,7 +32,12 @@ module RuboCop
           if (body = schema_member.body)
             arguments = body.select { |node| argument?(node) }
 
-            add_offense(arguments.last) if arguments.count > cop_config["MaxArguments"]
+            excess_arguments = arguments.count - cop_config["MaxArguments"]
+            return unless excess_arguments.positive?
+
+            arguments.last(excess_arguments).each do |excess_argument|
+              add_offense(excess_argument)
+            end
           end
         end
       end

data/lib/rubocop/cop/graphql/field_definitions.rb

@@ -109,7 +109,7 @@ module RuboCop
             field_definition?(node) || field_definition_with_body?(node)
           end
 
-          source_to_insert = "\n" + indent(node) + node.source
+          source_to_insert = "\n#{indent(node)}#{node.source}"
           corrector.insert_after(first_field.loc.expression, source_to_insert)
 
           range = range_with_surrounding_space(range: node.loc.expression, side: :left)
@@ -143,7 +143,7 @@ module RuboCop
 
           field_definition = field_definition_with_body?(node.parent) ? node.parent : node
 
-          source_to_insert = indent(method_definition) + field_definition.source + "\n\n"
+          source_to_insert = "#{indent(method_definition)}#{field_definition.source}\n\n"
           method_range = range_by_whole_lines(method_definition.loc.expression)
           corrector.insert_before(method_range, source_to_insert)
 

data/lib/rubocop/cop/graphql/object_description.rb

@@ -33,6 +33,10 @@ module RuboCop
           (send nil? :description (:str $_))
         PATTERN
 
+        def_node_matcher :has_multiline_string_description?, <<~PATTERN
+          (send nil? :description (:dstr ...))
+        PATTERN
+
         def_node_matcher :interface?, <<~PATTERN
           (send nil? :include (const ...))
         PATTERN
@@ -54,7 +58,9 @@ module RuboCop
         private
 
         def has_description?(node)
-          has_i18n_description?(node) || has_string_description?(node)
+          has_i18n_description?(node) ||
+            has_string_description?(node) ||
+            has_multiline_string_description?(node)
         end
 
         def child_nodes(node)

data/lib/rubocop/cop/graphql/ordered_arguments.rb

@@ -0,0 +1,120 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GraphQL
+      # Arguments should be alphabetically sorted within groups.
+      #
+      # @example
+      #   # good
+      #
+      #   class UpdateProfile < BaseMutation
+      #     argument :email, String, required: false
+      #     argument :name, String, required: false
+      #   end
+      #
+      #   # good
+      #
+      #   class UpdateProfile < BaseMutation
+      #     argument :uuid, ID, required: true
+      #
+      #     argument :email, String, required: false
+      #     argument :name, String, required: false
+      #   end
+      #
+      #   # good
+      #
+      #   class UserType < BaseType
+      #     field :posts, PostType do
+      #       argument :created_after, ISO8601DateTime, required: false
+      #       argument :created_before, ISO8601DateTime, required: false
+      #     end
+      #   end
+      #
+      #   # bad
+      #
+      #   class UpdateProfile < BaseMutation
+      #     argument :uuid, ID, required: true
+      #     argument :name, String, required: false
+      #     argument :email, String, required: false
+      #   end
+      #
+      #   # bad
+      #
+      #   class UserType < BaseType
+      #     field :posts, PostType do
+      #       argument :created_before, ISO8601DateTime, required: false
+      #       argument :created_after, ISO8601DateTime, required: false
+      #     end
+      #   end
+      #
+      class OrderedArguments < Cop
+        MSG = "Arguments should be sorted in an alphabetical order within their section. " \
+              "Field `%<current>s` should appear before `%<previous>s`."
+
+        def investigate(processed_source)
+          return if processed_source.blank?
+
+          argument_declarations(processed_source.ast)
+            .each_cons(2) do |previous, current|
+            next unless consecutive_lines(previous, current)
+            next if argument_name(current) > argument_name(previous)
+
+            register_offense(previous, current)
+          end
+        end
+
+        def autocorrect(node)
+          declarations = argument_declarations(processed_source.ast)
+          node_index = declarations.map(&:location).find_index(node.location)
+          previous_declaration = declarations.to_a[node_index - 1]
+
+          current_range = declaration(node)
+          previous_range = declaration(previous_declaration)
+
+          lambda do |corrector|
+            swap_range(corrector, current_range, previous_range)
+          end
+        end
+
+        private
+
+        def declaration(node)
+          buffer = processed_source.buffer
+          begin_pos = node.source_range.begin_pos
+          end_line = buffer.line_for_position(node.loc.expression.end_pos)
+          end_pos = buffer.line_range(end_line).end_pos
+          Parser::Source::Range.new(buffer, begin_pos, end_pos)
+        end
+
+        def swap_range(corrector, range1, range2)
+          src1 = range1.source
+          src2 = range2.source
+          corrector.replace(range1, src2)
+          corrector.replace(range2, src1)
+        end
+
+        def register_offense(previous, current)
+          message = format(
+            self.class::MSG,
+            previous: argument_name(previous),
+            current: argument_name(current)
+          )
+          add_offense(current, message: message)
+        end
+
+        def argument_name(node)
+          node.first_argument.value.to_s
+        end
+
+        def consecutive_lines(previous, current)
+          previous.source_range.last_line == current.source_range.first_line - 1
+        end
+
+        def_node_search :argument_declarations, <<~PATTERN
+          (send nil? :argument (:sym _) ...)
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/graphql/ordered_fields.rb

@@ -47,6 +47,19 @@ module RuboCop
             end
         end
 
+        def autocorrect(node)
+          declarations = field_declarations(processed_source.ast)
+          node_index = declarations.map(&:location).find_index(node.location)
+          previous_declaration = declarations.to_a[node_index - 1]
+
+          current_range = declaration(node)
+          previous_range = declaration(previous_declaration)
+
+          lambda do |corrector|
+            swap_range(corrector, current_range, previous_range)
+          end
+        end
+
         private
 
         def register_offense(previous, current)
@@ -70,6 +83,21 @@ module RuboCop
           previous.source_range.last_line == current.source_range.first_line - 1
         end
 
+        def declaration(node)
+          buffer = processed_source.buffer
+          begin_pos = node.source_range.begin_pos
+          end_line = buffer.line_for_position(node.loc.expression.end_pos)
+          end_pos = buffer.line_range(end_line).end_pos
+          Parser::Source::Range.new(buffer, begin_pos, end_pos)
+        end
+
+        def swap_range(corrector, range1, range2)
+          src1 = range1.source
+          src2 = range2.source
+          corrector.replace(range1, src2)
+          corrector.replace(range2, src1)
+        end
+
         def_node_search :field_declarations, <<~PATTERN
           {
             (send nil? :field (:sym _) ...)

data/lib/rubocop/cop/graphql_cops.rb

@@ -13,4 +13,5 @@ require_relative "graphql/field_method"
 require_relative "graphql/field_name"
 require_relative "graphql/resolver_method_length"
 require_relative "graphql/object_description"
+require_relative "graphql/ordered_arguments"
 require_relative "graphql/ordered_fields"

data/lib/rubocop/graphql/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module GraphQL
-    VERSION = "0.5.0".freeze
+    VERSION = "0.8.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-graphql
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Dmitry Tsepelev
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-02 00:00:00.000000000 Z
+date: 2021-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -56,16 +56,22 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.87'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.87'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
 description: A collection of RuboCop cops to improve GraphQL-related code
 email:
 - dmitry.a.tsepelev@gmail.com
@@ -88,6 +94,7 @@ files:
 - lib/rubocop/cop/graphql/field_method.rb
 - lib/rubocop/cop/graphql/field_name.rb
 - lib/rubocop/cop/graphql/object_description.rb
+- lib/rubocop/cop/graphql/ordered_arguments.rb
 - lib/rubocop/cop/graphql/ordered_fields.rb
 - lib/rubocop/cop/graphql/resolver_method_length.rb
 - lib/rubocop/cop/graphql_cops.rb
@@ -110,7 +117,7 @@ metadata:
   homepage_uri: https://github.com/DmitryTsepelev/rubocop-graphql
   source_code_uri: https://github.com/DmitryTsepelev/rubocop-graphql
   changelog_uri: https://github.com/DmitryTsepelev/rubocop-graphql/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -125,8 +132,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.
 test_files: []