rubocop-graphql 0.10.3 → 0.11.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60522da6cb205f7667084ee8a44f5500a426e4e52d677c60dee314d7e11e2129
-  data.tar.gz: 6d091ec89349bd1b2d9ca160c53566fd11cd2dc0a786f33e81a12e7b46e9a20e
+  metadata.gz: ffc9fa90011bdaddbf2d485a5948ede1e7bf2ade1c91c3a960799a1e0cd47bb3
+  data.tar.gz: 4dcbb755ed55538cfb8539b86f0c186e13b201bbfd0bbf3201d3091b8058c0fe
 SHA512:
-  metadata.gz: 708fbacb5879ce6be4ff0b9a9f34f85d13e1b65945a854c4b63cd96d9a74e145a8f20c1d792fcca9639ac524cb5c5353ddc09dd6f68e556c7e0167fbd4a9c544
-  data.tar.gz: e827fa568a4a472b2246185afc47bca7c119b9af60a3cc77e8d9033556866468988f1f79b8e2e2f60a8b43381e97a416f9825e61317a850475961414b29578ac
+  metadata.gz: 25cf86cd5e3e3942eafed3383df445c3f71296bc63a617ba4a0a9e597f6c355a1f5f94b1f2718439cd5606c50573758b8d3381a40af59937ba20cba150a9fe3d
+  data.tar.gz: 745057b345ba218c88b5a21addced87fc6bd972147ac72281efa0e1c1db005694f3ec44d33dc6760bdff68edddf8fedaff1d23f270ca3fc5162b5f01652da902

data/config/default.yml

@@ -1,6 +1,9 @@
 GraphQL:
   Include:
     - "**/graphql/**/*"
+  Exclude:
+    - "spec/**/*"
+    - "test/**/*"
 
 GraphQL/ArgumentDescription:
   Enabled: true
@@ -12,6 +15,11 @@ GraphQL/ArgumentName:
   VersionAdded: '0.80'
   Description: 'This cop checks whether argument names are snake_case'
 
+GraphQL/ArgumentUniqueness:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'This cop enforces arguments to be defined once per block'
+
 GraphQL/ResolverMethodLength:
   Enabled: true
   VersionAdded: '0.80'
@@ -50,6 +58,11 @@ GraphQL/FieldName:
   Description: 'This cop checks whether field names are snake_case'
   SafeAutoCorrect: false
 
+GraphQL/FieldUniqueness:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'This cop enforces fields to be defined once'
+
 GraphQL/ExtractInputType:
   Enabled: true
   VersionAdded: '0.80'
@@ -90,3 +103,5 @@ GraphQL/OrderedFields:
   Enabled: true
   VersionAdded: '0.80'
   Description: 'Fields should be alphabetically sorted within groups'
+
+

data/lib/rubocop/cop/graphql/argument_uniqueness.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GraphQL
+      #  This cop detects duplicate argument definitions
+      #
+      # @example
+      #   # good
+      #
+      #   class BanUser < BaseMutation
+      #     argument :user_id, ID, required: true
+      #   end
+      #
+      #   # bad
+      #
+      #   class BanUser < BaseMutation
+      #     argument :user_id, ID, required: true
+      #     argument :user_id, ID, required: true
+      #   end
+      #
+      class ArgumentUniqueness < Base
+        MSG = "Argument names should only be defined once per block. "\
+              "Argument `%<current>s` is duplicated%<field_name>s."
+
+        def on_class(node)
+          global_argument_names = Set.new
+          argument_names_by_field = {}
+
+          argument_declarations(node).each do |current|
+            current_field_name = field_name(current)
+            current_argument_name = argument_name(current)
+
+            if current_field_name
+              argument_names_by_field[current_field_name] ||= Set.new
+              argument_names = argument_names_by_field[current_field_name]
+            else
+              argument_names = global_argument_names
+            end
+
+            unless argument_names.include?(current_argument_name)
+              argument_names.add(current_argument_name)
+              next
+            end
+
+            register_offense(current)
+          end
+        end
+
+        private
+
+        def register_offense(current)
+          current_field_name = field_name(current)
+          field_name_message = " in field `#{current_field_name}`" if current_field_name
+
+          message = format(
+            self.class::MSG,
+            current: argument_name(current),
+            field_name: field_name_message
+          )
+
+          add_offense(current, message: message)
+        end
+
+        def argument_name(node)
+          node.first_argument.value.to_s
+        end
+
+        # Find parent field block, if available
+        def field_name(node)
+          return if node.nil?
+
+          is_field_block = node.block_type? &&
+                           node.respond_to?(:method_name) &&
+                           node.method_name == :field
+          return node.send_node.first_argument.value.to_s if is_field_block
+
+          field_name(node.parent)
+        end
+
+        def_node_search :argument_declarations, <<~PATTERN
+          (send nil? :argument (:sym _) ...)
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/graphql/field_uniqueness.rb

@@ -0,0 +1,83 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GraphQL
+      # This cop detects duplicate field definitions within
+      # the same type
+      #
+      # @example
+      #   # good
+      #
+      #   class UserType < BaseType
+      #     field :name, String, null: true
+      #     field :phone, String, null: true do
+      #       argument :something, String, required: false
+      #     end
+      #   end
+      #
+      #   # bad
+      #
+      #   class UserType < BaseType
+      #     field :name, String, null: true
+      #     field :phone, String, null: true
+      #     field :phone, String, null: true do
+      #       argument :something, String, required: false
+      #     end
+      #   end
+      #
+      class FieldUniqueness < Base
+        MSG = "Field names should only be defined once per type. "\
+              "Field `%<current>s` is duplicated."
+
+        def on_class(node)
+          return if nested_class?(node)
+
+          field_names_by_class = Hash.new { |h, k| h[k] = Set.new }
+
+          field_declarations(node).each do |current|
+            current_class = current_class_name(current)
+            field_names = field_names_by_class[current_class]
+            current_field_name = field_name(current)
+
+            unless field_names.include?(current_field_name)
+              field_names.add(current_field_name)
+              next
+            end
+
+            register_offense(current)
+          end
+        end
+
+        private
+
+        def nested_class?(node)
+          node.each_ancestor(:class).any?
+        end
+
+        def register_offense(current)
+          message = format(
+            self.class::MSG,
+            current: field_name(current)
+          )
+
+          add_offense(current, message: message)
+        end
+
+        def field_name(node)
+          node.first_argument.value.to_s
+        end
+
+        def current_class_name(node)
+          node.each_ancestor(:class).first.defined_module_name
+        end
+
+        def_node_search :field_declarations, <<~PATTERN
+          {
+            (send nil? :field (:sym _) ...)
+          }
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/graphql/ordered_arguments.rb

@@ -59,7 +59,7 @@ module RuboCop
         def on_class(node)
           argument_declarations(node).each_cons(2) do |previous, current|
             next unless consecutive_lines(previous, current)
-            next if argument_name(current) > argument_name(previous)
+            next if argument_name(current) >= argument_name(previous)
 
             register_offense(previous, current)
           end

data/lib/rubocop/cop/graphql/ordered_fields.rb

@@ -42,7 +42,7 @@ module RuboCop
         def on_class(node)
           field_declarations(node).each_cons(2) do |previous, current|
             next unless consecutive_lines(previous, current)
-            next if field_name(current) > field_name(previous)
+            next if field_name(current) >= field_name(previous)
 
             register_offense(previous, current)
           end

data/lib/rubocop/cop/graphql_cops.rb

@@ -2,6 +2,7 @@
 
 require_relative "graphql/argument_description"
 require_relative "graphql/argument_name"
+require_relative "graphql/argument_uniqueness"
 require_relative "graphql/extract_input_type"
 require_relative "graphql/extract_type"
 require_relative "graphql/field_definitions"
@@ -9,6 +10,7 @@ require_relative "graphql/field_description"
 require_relative "graphql/field_hash_key"
 require_relative "graphql/field_method"
 require_relative "graphql/field_name"
+require_relative "graphql/field_uniqueness"
 require_relative "graphql/legacy_dsl"
 require_relative "graphql/resolver_method_length"
 require_relative "graphql/object_description"

data/lib/rubocop/graphql/description_method.rb

@@ -21,7 +21,8 @@ module RuboCop
       extend RuboCop::NodePattern::Macros
 
       def_node_matcher :description_kwarg?, <<~PATTERN
-        (send nil? :description {({str|dstr} ...)|(send ({str|dstr} ...) _)})
+        (send nil? :description
+          {({str|dstr|const} ...)|(send const ...)|(send ({str|dstr} ...) _)})
       PATTERN
 
       def find_description_method(nodes)

data/lib/rubocop/graphql/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module GraphQL
-    VERSION = "0.10.3".freeze
+    VERSION = "0.11.3".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-graphql
 version: !ruby/object:Gem::Version
-  version: 0.10.3
+  version: 0.11.3
 platform: ruby
 authors:
 - Dmitry Tsepelev
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-09 00:00:00.000000000 Z
+date: 2021-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,6 +86,7 @@ files:
 - lib/rubocop-graphql.rb
 - lib/rubocop/cop/graphql/argument_description.rb
 - lib/rubocop/cop/graphql/argument_name.rb
+- lib/rubocop/cop/graphql/argument_uniqueness.rb
 - lib/rubocop/cop/graphql/extract_input_type.rb
 - lib/rubocop/cop/graphql/extract_type.rb
 - lib/rubocop/cop/graphql/field_definitions.rb
@@ -93,6 +94,7 @@ files:
 - lib/rubocop/cop/graphql/field_hash_key.rb
 - lib/rubocop/cop/graphql/field_method.rb
 - lib/rubocop/cop/graphql/field_name.rb
+- lib/rubocop/cop/graphql/field_uniqueness.rb
 - lib/rubocop/cop/graphql/legacy_dsl.rb
 - lib/rubocop/cop/graphql/object_description.rb
 - lib/rubocop/cop/graphql/ordered_arguments.rb
@@ -120,7 +122,7 @@ metadata:
   homepage_uri: https://github.com/DmitryTsepelev/rubocop-graphql
   source_code_uri: https://github.com/DmitryTsepelev/rubocop-graphql
   changelog_uri: https://github.com/DmitryTsepelev/rubocop-graphql/CHANGELOG.md
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -135,8 +137,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key:
+rubygems_version: 3.0.3.1
+signing_key: 
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.
 test_files: []