rubocop-graphql 0.10.1 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 306f0b68587158302fed968f58c2696c5cfcbd65a1a762ef8d80c99ced67915e
-  data.tar.gz: 73e0308c1bd1a159264a34372c92d8bc8b8814aa60f872ca38df91e1b16f845d
+  metadata.gz: 660e5888a933adf211a4c140882cd9bab799e0f0bcaa545f7ec1bbe9668e064f
+  data.tar.gz: efca9c85b37c7a91d46844ef7f574dc434ffffbb1a01adfcefc3a31c71cf2d02
 SHA512:
-  metadata.gz: d0c6d84f77b000fde31fe670666710c50b7609d5f947553a41bd50534e2e1e66415449a9fdaa750dd6570cc6be48c0b4f759c5532bd7753a50b61d2023df0001
-  data.tar.gz: ba226bf80d8bd6a52b95813dc20e5aff871b01bf71b39da9f0f9937fbb7449729ea889e95f9dc2a2939ebb72e4434524c386bebc9da3755ea77ff6487c878fc3
+  metadata.gz: b51da944eeca0ff3be527823992860e9c690bf8dca86eab7800e0d694cd212654bdc614c5e849516bf7afabbb36c36c1da8cdcb7bb490c84f66606d79439dab5
+  data.tar.gz: acd228993fe068085136b68e21d872ac52db7ddd7dd36e7ee047d95b2f7fe406db2af8de01a51275b023d45a29bf4a9b0eca60d824fcfb31742e3115b0703bb8

data/config/default.yml

@@ -12,6 +12,11 @@ GraphQL/ArgumentName:
   VersionAdded: '0.80'
   Description: 'This cop checks whether argument names are snake_case'
 
+GraphQL/ArgumentUniqueness:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'This cop enforces arguments to be defined once per block'
+
 GraphQL/ResolverMethodLength:
   Enabled: true
   VersionAdded: '0.80'
@@ -50,6 +55,11 @@ GraphQL/FieldName:
   Description: 'This cop checks whether field names are snake_case'
   SafeAutoCorrect: false
 
+GraphQL/FieldUniqueness:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'This cop enforces fields to be defined once'
+
 GraphQL/ExtractInputType:
   Enabled: true
   VersionAdded: '0.80'
@@ -80,3 +90,15 @@ GraphQL/ObjectDescription:
   Exclude:
     - '**/*_schema.rb'
     - '**/base_*.rb'
+
+GraphQL/OrderedArguments:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'Arguments should be alphabetically sorted within groups'
+
+GraphQL/OrderedFields:
+  Enabled: true
+  VersionAdded: '0.80'
+  Description: 'Fields should be alphabetically sorted within groups'
+
+

data/lib/rubocop/cop/graphql/argument_uniqueness.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GraphQL
+      #  This cop detects duplicate argument definitions
+      #
+      # @example
+      #   # good
+      #
+      #   class BanUser < BaseMutation
+      #     argument :user_id, ID, required: true
+      #   end
+      #
+      #   # bad
+      #
+      #   class BanUser < BaseMutation
+      #     argument :user_id, ID, required: true
+      #     argument :user_id, ID, required: true
+      #   end
+      #
+      class ArgumentUniqueness < Base
+        MSG = "Argument names should only be defined once per block. "\
+              "Argument `%<current>s` is duplicated%<field_name>s."
+
+        def on_class(node)
+          global_argument_names = Set.new
+          argument_names_by_field = {}
+
+          argument_declarations(node).each do |current|
+            current_field_name = field_name(current)
+            current_argument_name = argument_name(current)
+
+            if current_field_name
+              argument_names_by_field[current_field_name] ||= Set.new
+              argument_names = argument_names_by_field[current_field_name]
+            else
+              argument_names = global_argument_names
+            end
+
+            unless argument_names.include?(current_argument_name)
+              argument_names.add(current_argument_name)
+              next
+            end
+
+            register_offense(current)
+          end
+        end
+
+        private
+
+        def register_offense(current)
+          current_field_name = field_name(current)
+          field_name_message = " in field `#{current_field_name}`" if current_field_name
+
+          message = format(
+            self.class::MSG,
+            current: argument_name(current),
+            field_name: field_name_message
+          )
+
+          add_offense(current, message: message)
+        end
+
+        def argument_name(node)
+          node.first_argument.value.to_s
+        end
+
+        # Find parent field block, if available
+        def field_name(node)
+          return if node.nil?
+
+          is_field_block = node.block_type? &&
+                           node.respond_to?(:method_name) &&
+                           node.method_name == :field
+          return node.send_node.first_argument.value.to_s if is_field_block
+
+          field_name(node.parent)
+        end
+
+        def_node_search :argument_declarations, <<~PATTERN
+          (send nil? :argument (:sym _) ...)
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/graphql/field_uniqueness.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module GraphQL
+      # This cop detects duplicate field definitions within
+      # the same type
+      #
+      # @example
+      #   # good
+      #
+      #   class UserType < BaseType
+      #     field :name, String, null: true
+      #     field :phone, String, null: true do
+      #       argument :something, String, required: false
+      #     end
+      #   end
+      #
+      #   # bad
+      #
+      #   class UserType < BaseType
+      #     field :name, String, null: true
+      #     field :phone, String, null: true
+      #     field :phone, String, null: true do
+      #       argument :something, String, required: false
+      #     end
+      #   end
+      #
+      class FieldUniqueness < Base
+        MSG = "Field names should only be defined once per type. "\
+              "Field `%<current>s` is duplicated."
+
+        def on_class(node)
+          field_names = Set.new
+
+          field_declarations(node).each do |current|
+            current_field_name = field_name(current)
+
+            unless field_names.include?(current_field_name)
+              field_names.add(current_field_name)
+              next
+            end
+
+            register_offense(current)
+          end
+        end
+
+        private
+
+        def register_offense(current)
+          message = format(
+            self.class::MSG,
+            current: field_name(current)
+          )
+
+          add_offense(current, message: message)
+        end
+
+        def field_name(node)
+          node.first_argument.value.to_s
+        end
+
+        def_node_search :field_declarations, <<~PATTERN
+          {
+            (send nil? :field (:sym _) ...)
+          }
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/graphql/ordered_arguments.rb

@@ -59,7 +59,7 @@ module RuboCop
         def on_class(node)
           argument_declarations(node).each_cons(2) do |previous, current|
             next unless consecutive_lines(previous, current)
-            next if argument_name(current) > argument_name(previous)
+            next if argument_name(current) >= argument_name(previous)
 
             register_offense(previous, current)
           end

data/lib/rubocop/cop/graphql/ordered_fields.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module GraphQL
-      # Field should be alphabetically sorted within groups.
+      # Fields should be alphabetically sorted within groups.
       #
       # @example
       #   # good
@@ -42,7 +42,7 @@ module RuboCop
         def on_class(node)
           field_declarations(node).each_cons(2) do |previous, current|
             next unless consecutive_lines(previous, current)
-            next if field_name(current) > field_name(previous)
+            next if field_name(current) >= field_name(previous)
 
             register_offense(previous, current)
           end

data/lib/rubocop/cop/graphql_cops.rb

@@ -2,6 +2,7 @@
 
 require_relative "graphql/argument_description"
 require_relative "graphql/argument_name"
+require_relative "graphql/argument_uniqueness"
 require_relative "graphql/extract_input_type"
 require_relative "graphql/extract_type"
 require_relative "graphql/field_definitions"
@@ -9,6 +10,7 @@ require_relative "graphql/field_description"
 require_relative "graphql/field_hash_key"
 require_relative "graphql/field_method"
 require_relative "graphql/field_name"
+require_relative "graphql/field_uniqueness"
 require_relative "graphql/legacy_dsl"
 require_relative "graphql/resolver_method_length"
 require_relative "graphql/object_description"

data/lib/rubocop/graphql/description_method.rb

@@ -21,7 +21,8 @@ module RuboCop
       extend RuboCop::NodePattern::Macros
 
       def_node_matcher :description_kwarg?, <<~PATTERN
-        (send nil? :description {({str|dstr} ...)|(send ({str|dstr} ...) _)})
+        (send nil? :description
+          {({str|dstr|const} ...)|(send const ...)|(send ({str|dstr} ...) _)})
       PATTERN
 
       def find_description_method(nodes)

data/lib/rubocop/graphql/field/block.rb

@@ -11,7 +11,7 @@ module RuboCop
           (block
             (send nil? :field ...)
             (args)
-            $...
+            {(begin $...)|$...}
           )
         PATTERN
 

data/lib/rubocop/graphql/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module GraphQL
-    VERSION = "0.10.1".freeze
+    VERSION = "0.11.1".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-graphql
 version: !ruby/object:Gem::Version
-  version: 0.10.1
+  version: 0.11.1
 platform: ruby
 authors:
 - Dmitry Tsepelev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-19 00:00:00.000000000 Z
+date: 2021-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,6 +86,7 @@ files:
 - lib/rubocop-graphql.rb
 - lib/rubocop/cop/graphql/argument_description.rb
 - lib/rubocop/cop/graphql/argument_name.rb
+- lib/rubocop/cop/graphql/argument_uniqueness.rb
 - lib/rubocop/cop/graphql/extract_input_type.rb
 - lib/rubocop/cop/graphql/extract_type.rb
 - lib/rubocop/cop/graphql/field_definitions.rb
@@ -93,6 +94,7 @@ files:
 - lib/rubocop/cop/graphql/field_hash_key.rb
 - lib/rubocop/cop/graphql/field_method.rb
 - lib/rubocop/cop/graphql/field_name.rb
+- lib/rubocop/cop/graphql/field_uniqueness.rb
 - lib/rubocop/cop/graphql/legacy_dsl.rb
 - lib/rubocop/cop/graphql/object_description.rb
 - lib/rubocop/cop/graphql/ordered_arguments.rb
@@ -135,7 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.31
 signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.