rubocop-grape 0.2.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92c8005ffcb25101074781a0e8ef2dde2eec522fe78d8c8a56c2b4bc19f0ecec
-  data.tar.gz: 91e7e2fa44a245223f72235c9655a9d124232f09ecb27eb32bae8a7d01725294
+  metadata.gz: d1ddcfa8ca8f07c8b82d051f1b962d106b7e9390f505bce166901deb3d9421c4
+  data.tar.gz: c7de3f5ff9600b83a730d347278e52d0f3f4553389c184b2c04be425193079b3
 SHA512:
-  metadata.gz: 6becb4f74dcfaa3c922a5c4aab58f4b540286f412c2d4c697aea3bfe69ce16d32ce795b0944b7e1401fd8ed98aa0f779a95d54ce7a1e51b053084cf4bafcd8d9
-  data.tar.gz: 507a763177ce9a01c1b50fbe067a37c40673c673a469daea3d3c6180dedeac16671e87bbbb3c2b64c625be599dcc020ebacd964804dad6d26f6206915038a864
+  metadata.gz: 204e3c444825e10ab0c90bdfbb3dac71db90d5aeb56a718a6124ef1b19a3883e93e5815131aefbc8bcc8ba5c20d46c2bdf987f145914167299a33f7cbf95fd44
+  data.tar.gz: 02ebbff3326f417c71983683ed98aa7a414e9a2d3456b671b4a5fe7f19ae4cb84ccb42723f47ee1ed5085f359d6fb70557b1703045f053430e4726c32417f80a

data/config/default.yml

@@ -1,6 +1,18 @@
 AllCops:
   GrapeDir: 'app/api'
 
+Grape/AbcSize:
+  Description: >-
+                 A calculated magnitude based on number of assignments,
+                 branches, and conditions.
+  Reference:
+    - http://c2.com/cgi/wiki?AbcMetric
+    - https://en.wikipedia.org/wiki/ABC_Software_Metric
+    - https://www.rubydoc.info/gems/rubocop/0.27.0/RuboCop/Cop/Metrics/AbcSize
+  Enabled: true
+  Max: 20
+  CountRepeatedAttributes: true
+
 Grape/FieldName:
   EnforcedStyle: snake_case
   SupportedStyles:

data/lib/rubocop/cop/grape/abc_size.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Grape
+      # Checks that the ABC size of endpoints is not higher than the
+      # configured maximum. The ABC size is based on assignments, branches
+      # (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
+      # and https://en.wikipedia.org/wiki/ABC_Software_Metric.
+      class AbcSize < Base
+        extend ExcludeLimit
+
+        exclude_limit 'Max'
+
+        MSG = 'Assignment Branch Condition size is too high. [%<abc_vector>s %<complexity>d/%<max>d]'
+
+        def_node_matcher :http_method_node?, <<~PATTERN
+          (block (send _ {:get :post :put :patch :delete} ...) ...)
+        PATTERN
+
+        def on_block(node)
+          return unless http_method_node?(node)
+
+          check_complexity(node)
+        end
+
+        def check_complexity(node)
+          return unless node.body
+
+          max = cop_config['Max']
+          complexity, abc_vector = complexity(node.body)
+          return unless complexity > max
+
+          msg = format(self.class::MSG, abc_vector: abc_vector, complexity: complexity, max: max)
+          add_offense(node, message: msg) { self.max = complexity.ceil }
+        end
+
+        def complexity(node)
+          Metrics::Utils::AbcSizeCalculator.calculate(
+            node,
+            discount_repeated_attributes: !cop_config['CountRepeatedAttributes']
+          )
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/grape/field_name.rb

@@ -46,18 +46,27 @@ module RuboCop
         def on_block(node)
           return unless (body = params_block?(node))
 
-          if body.type == :begin
-            body.children.each(&method(:check_field_name))
-          else
-            check_field_name(body)
-          end
+          find_field_node(body)
         end
 
         private
 
+        def find_field_node(node)
+          case node.type
+          when :begin
+            node.each_child_node(&method(:find_field_node))
+          when :block
+            find_field_node(node.send_node)
+            find_field_node(node.body)
+          else
+            check_field_name(node)
+          end
+        end
+
         def check_field_name(node)
-          field = node.children[2]
-          check_name(node, field_name(node), field.source_range)
+          return unless (field_name = field_name(node))
+
+          check_name(node, field_name, node.first_argument.source_range)
         end
 
         def message(style)

data/lib/rubocop/cop/grape_cops.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative 'grape/abc_size'
 require_relative 'grape/field_name'
 require_relative 'grape/ivar'
 require_relative 'grape/params_position'

data/lib/rubocop/grape/grape_files.rb

@@ -26,11 +26,11 @@ module RuboCop
           @config.for_all_cops['GrapeDir']
         end
 
-        def roundup_relevant_cops(filename)
+        def roundup_relevant_cops(processed_source)
           super.select do |cop|
             next true unless cop.class.name.match?(/RuboCop::Cop::Grape::.+$/)
 
-            grape_files.include?(filename)
+            grape_files.include?(processed_source.path)
           end
         end
       end

data/lib/rubocop/grape/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Grape
-    VERSION = '0.2.2'
+    VERSION = '0.4.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-grape
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Akito Hikasa
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-14 00:00:00.000000000 Z
+date: 2023-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -44,6 +44,7 @@ files:
 - bin/console
 - config/default.yml
 - lib/rubocop-grape.rb
+- lib/rubocop/cop/grape/abc_size.rb
 - lib/rubocop/cop/grape/field_name.rb
 - lib/rubocop/cop/grape/ivar.rb
 - lib/rubocop/cop/grape/params_position.rb