rubocop-govuk 3.9.0 → 3.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9c2665fb72c667c3f07e7b9c58773452d606d6ef538eb8a72ec737db214387c
-  data.tar.gz: a651269b0301ba985c67ca643505becad473424dacb789cabfc0ecca51e756c9
+  metadata.gz: 9e5ccad5d8a29404c085805725894f1e34fcddd9a8081fb6d49dc46fcb83c442
+  data.tar.gz: bff295ee9cf144c60f5b2653f7c3744e886c34303032d443d735f022269cb94e
 SHA512:
-  metadata.gz: 151c3d8ec8811c0f8921a4f3ce842527e0c9b677a425c17891da6e379c97b30b1f22fad6f18e4dfcfa4f65a492baea8b62060431830b057bfb83b575448318ae
-  data.tar.gz: 7516c91b9bc30c5565fcff0000a456c48f8adecd3fcc74f4675bd0f6172798d5fa5d70402b7f92b502b45d0af196ca782a438ef71753e4cbd4907fe622a61d71
+  metadata.gz: 5dfb9ea5aca2f9158feb74e46141b32b0a48054ccfa90e82f5cf337a26bcd9ab12ffefc005f930828f0839afdee26fc9aaf22695421dfc6672678ec6e36ab440
+  data.tar.gz: 34c1d26adf2d8d9118ffccca9128ba3f402328d6378865d949c50707fcd38d2b58c7dbcd91de33d3ea9937d5b9570c8aee670bc73ed284f405b53d86470503b0

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+# 3.10.0
+
+* Enable Style/NegatedIf (#71)
+* Enable Style/GlobalVars (#71)
+* Enable Style/RaiseArgs (#71)
+* Enable Style/MethodDefParentheses (#71)
+* Enable Style/NumericLiterals (#71)
+* Enable Layout/MultilineArrayLineBreaks (#63)
+* Enable Layout/MultilineHashKeyLineBreaks (#63)
+* Enable Layout/MultilineMethodArgumentLineBreaks (#63)
+* Enable Layout/FirstMethodArgumentLineBreak (#63)
+* Fix bug with Style/FormatString (#70)
+
 # 3.9.0
 
 * Enable Style/Alias (#60)

data/config/layout.yml

@@ -72,3 +72,31 @@ Layout/FirstHashElementIndentation:
 # Introduced in: 9b2a744ab119d7797aaf423abcec914360f4208e
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
+
+# We should be consistent: if some items of an array are
+# on multiple lines, then all items should be. This works
+# better with the indentation Cops, produces clearer diffs,
+# and avoids wasting time tweaking an arbitrary layout.
+Layout/MultilineArrayLineBreaks:
+  Enabled: true
+
+# We should be consistent: if some items of a hash are
+# on multiple lines, then all items should be. This works
+# better with the indentation Cops, produces clearer diffs,
+# and avoids wasting time tweaking an arbitrary layout.
+Layout/MultilineHashKeyLineBreaks:
+  Enabled: true
+
+# We should be consistent: if some items of a method call are
+# on multiple lines, then all items should be. This works
+# better with the indentation Cops, produces clearer diffs,
+# and avoids wasting time tweaking an arbitrary layout.
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: true
+
+# We should put each argument of a method call on a new line,
+# if any are on new lines. This prevents unnecessary decisions
+# about which style to use; the multiline style also helps to
+# avoid excessively long lines.
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: true

data/config/style.yml

@@ -80,6 +80,16 @@ Style/StringLiterals:
 Style/FormatStringToken:
   Enabled: false
 
+# Using the default style leads to buggy auto-correct in several
+# repos that have their own 'format' method defined. While it's not
+# ideal to override a standard/Kernel method, it's also not practical
+# to change a term that's so deeply embedded within our domain.
+#
+# Related PR: https://github.com/alphagov/specialist-publisher/pull/1640
+# Related PR: https://github.com/alphagov/publisher/pull/1268
+Style/FormatString:
+  EnforcedStyle: sprintf
+
 # This is a contentious issue, since 'alias_method' works in
 # all circumstances, whereas 'alias' only works lexically. As
 # with single vs. double quotes, it seems pointless to expend
@@ -121,12 +131,6 @@ Style/Documentation:
   Description: 'Document classes and non-namespace modules.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/GlobalVars:
-  Description: 'Do not introduce global variables.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # This can lead to excessively long lines. Consistent with
 # disabling "Layout/LineLength".
@@ -137,43 +141,12 @@ Style/GuardClause:
   Description: 'Check for conditionals that can be replaced with guard clauses'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/MethodDefParentheses:
-  Description: >-
-    Checks if the method definitions have or don't have
-    parentheses.
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/NegatedIf:
-  Description: >-
-    Favor unless over if for negative conditions
-    (or control flow or).
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Style/Next:
   Description: 'Use `next` to skip iteration instead of a condition at the end.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/NumericLiterals:
-  Description: >-
-    Add underscores to large numeric literals to improve their
-    readability.
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here! Suggest enabling with
-# "EnforcedStyle: compact"
-Style/RaiseArgs:
-  Description: 'Checks the arguments passed to raise/fail.'
-  Enabled: false
-
 # Analog of: 736b3d295f88b9ba6676fc168b823535582388c2
 # "Disable opinionated cops"
 #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.9.0
+  version: 3.10.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-11 00:00:00.000000000 Z
+date: 2020-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.83.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.83.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement