rubocop-govuk 3.7.0 → 3.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9460cb1bd124d0db3bad61e69a4fca8fea76d1b58197766820aca957f4241854
-  data.tar.gz: 13319b8ceece3b49c2c4363f23c418cebd5f87db081fe1eecb63afb777c88194
+  metadata.gz: ab10ddfc89214d7fae46f59e6c4b562938daa350796eb48e2f78ab56fcd7df7c
+  data.tar.gz: 574eef536a366973c7c7f8fd36d3a824ad034056957730247345899323a21f21
 SHA512:
-  metadata.gz: 981c47d318c535003c5e3b5206ca85ead3fda8895c770d4957cc4ee19f698d4bd04ad3483c17d064b079b87e9276c188ce06f478413dc2ed11ee8b2ec2b61c7c
-  data.tar.gz: 127e187db28bad0c6803c1fb8e8208277d55617698aef72befcddb4285449a62a65ee91836808b252f2a75c78fb40699d7b66ab0d4804cb523306d281866838a
+  metadata.gz: f11edcb99e6acaf178b3daaacedccd66764e8b660a824e12016057b5877cbd11249e41e08a7697ee5610fc8fb09a8ffe3834d748d6930bf4472294aa9633ff5c
+  data.tar.gz: 12cf45d1bb91ad44bf5cdc42e7a8d223a062e8ecf2156273d0c6bf298ff741747d146af837882dbf9700f321fb82a8b3b603d6fa1a39378ca5018230177a70e0

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# 3.8.0
+
+* Enable check for flip-flops (#55)
+* Enable Layout/FirstArrayElementIndentation (#56)
+* Enable Layout/FirstHashElementIndentation (#56)
+* Enable Naming/AsciiIdentifiers (#58)
+* Enable Naming/FileName (#58)
+* Enable Rails/ActionFilter (#59)
+* Enable Rails/ScopeArgs (#59)
+
 # 3.7.0
 
 * Turn a load of Cops back on (#52)

data/config/default.yml

@@ -22,7 +22,6 @@ AllCops:
 inherit_from:
   - bundler.yml
   - layout.yml
-  - lint.yml
   - metrics.yml
   - naming.yml
   - style.yml

data/config/layout.yml

@@ -15,8 +15,17 @@ Layout/LineLength:
   Description: Limit lines to 80 characters.
   Enabled: false
 
-# TODO: unclear why this is here!
-# https://github.com/alphagov/govuk-lint/commit/5e42ec5690e3d4cc8fff44d0b0268c8e581c423a
+# We have two styles of method call in our apps:
+#
+# SomeClass.first_method_call_on_same_line
+#          .other_method_call
+#
+# a_particularly_long_first_method_call
+#   .subsequent_method_call
+#
+# Any setting of this Cop would cause odd alignment
+# for one of these styles. Since there isn't a Cop to
+# set a preferred style, we should disable this one.
 Layout/MultilineMethodCallIndentation:
   Enabled: false
 
@@ -28,24 +37,38 @@ Layout/AccessModifierIndentation:
   Enabled: true
   EnforcedStyle: outdent
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here! Suggest enabling this with
-# "EnforcedStyle: consistent".
+# Our predominant style of writing multiline arrays is:
+#
+# my_array = [
+#   element_1,
+#   element_2,
+# ]
+#
+# even_in_a_method_call([
+#   element_1,
+#   element_2,
+# ])
 Layout/FirstArrayElementIndentation:
-  Description: >-
-    Checks the indentation of the first element in an array
-    literal.
-  Enabled: false
+  EnforcedStyle: consistent
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here! Suggest enabling this with
-# "EnforcedStyle: consistent".
+# Our predominant style of writing multiline hashes is:
+#
+# my_hash = {
+#   key_1: value_1,
+#   key_2: value_2,
+# }
+#
+# even_in_a_method_call({
+#   key_1: value_1,
+#   key_2: value_2,
+# })
 Layout/FirstHashElementIndentation:
-  Description: 'Checks the indentation of the first key in a hash literal.'
-  Enabled: false
+  EnforcedStyle: consistent
 
+# Our predominant style of writing multiline operations is
+# to indent the subsequent lines. This helps to prevent
+# misreading the next line as a new/separate statement.
+#
 # Introduced in: 9b2a744ab119d7797aaf423abcec914360f4208e
-# "More lenient on multi-line operations"
-# TODO: unclear why this is here!
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented

data/config/metrics.yml

@@ -46,7 +46,9 @@ Metrics/PerceivedComplexity:
   Enabled: false
 
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
+#
+# We should avoid cops that are based on heuristics, since
+# it's not clear what action to take to fix an issue.
 Metrics/BlockNesting:
   Description: 'Avoid excessive block nesting'
   Enabled: false

data/config/naming.yml

@@ -1,21 +1,16 @@
+# Conflicts with the original GDS styleguide
+#
+# While this may conflict with the original GDS styleguide, there
+# are times where we wish to call a method that "sets" something.
+#
+# def set_political_and_government(edition)
+#
+# The original styleguide only accounts for a specific kind of "set"
+# operation, where the argument is the value being assigned.
+#
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: conflicts with the original GDS styleguide
-# "Avoid get/set method names"
 # https://github.com/alphagov/styleguides/blob/6395a10d41c3938f4c147cda443fd83f854c3e7a/ruby.md#naming
 Naming/AccessorMethodName:
-  Description: Check the naming of accessor methods for get_/set_.
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Naming/AsciiIdentifiers:
-  Description: 'Use only ascii symbols in identifiers.'
-  Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Naming/FileName:
-  Description: 'Use snake_case for source file names.'
   Enabled: false
 
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429

data/config/rails.yml

@@ -13,12 +13,6 @@ AllCops:
 Rails:
   Enabled: true
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Rails/ActionFilter:
-  Description: 'Enforces consistent use of action filter methods.'
-  Enabled: false
-
 # Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
 # TODO: unclear why this is here!
 Rails/HasAndBelongsToMany:
@@ -31,12 +25,6 @@ Rails/Output:
   Description: 'Checks for calls to puts, print, etc.'
   Enabled: false
 
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Rails/ScopeArgs:
-  Description: 'Checks the arguments of ActiveRecord scopes.'
-  Enabled: false
-
 # Introduced in: 91d7bf4895db12727582ad7bf47bdcb20ab178f7
 # TODO: unclear (in any real detail) why this is here!
 Rails/SkipsModelValidations:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.7.0
+  version: 3.8.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-29 00:00:00.000000000 Z
+date: 2020-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -93,7 +93,6 @@ files:
 - config/bundler.yml
 - config/default.yml
 - config/layout.yml
-- config/lint.yml
 - config/metrics.yml
 - config/naming.yml
 - config/rails.yml
@@ -118,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: RuboCop GOV.UK

data/config/lint.yml

@@ -1,5 +0,0 @@
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Lint/FlipFlop:
-  Description: 'Checks for flip flops'
-  Enabled: false