rubocop-govuk 3.3.1 → 3.7.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.7.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-18 00:00:00.000000000 Z
+date: 2020-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.80.1
+        version: 0.82.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.80.1
+        version: 0.82.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -76,13 +90,15 @@ files:
 - CHANGELOG.md
 - LICENSE.md
 - README.md
+- config/bundler.yml
 - config/default.yml
-- config/gds-ruby-styleguide.yml
-- config/other-excludes.yml
-- config/other-lint.yml
-- config/other-metrics.yml
-- config/other-style.yml
+- config/layout.yml
+- config/lint.yml
+- config/metrics.yml
+- config/naming.yml
 - config/rails.yml
+- config/rake.yml
+- config/style.yml
 homepage: https://github.com/alphagov/rubocop-govuk
 licenses:
 - MIT
@@ -102,7 +118,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: RuboCop GOV.UK

data/config/gds-ruby-styleguide.yml

@@ -1,337 +0,0 @@
-############
-## General
-############
-
-Layout/BlockAlignment:
-  Description: 'Align block ends correctly.'
-  Enabled: true
-
-Layout/CaseIndentation:
-  Description: Indentation of when in a case/when/[else/]end.
-  Enabled: true
-  EnforcedStyle: case
-  SupportedStyles:
-  - case
-  - end
-  IndentOneStep: false
-
-Layout/ClosingParenthesisIndentation:
-  Description: 'Checks the indentation of hanging closing parentheses.'
-  Enabled: false
-
-Style/MutableConstant:
-  Description: 'Freeze mutable objects assigned to constants.'
-  Enabled: true
-
-Lint/ElseLayout:
-  Description: 'Check for odd code arrangement in an else block.'
-  Enabled: true
-
-# Supports --auto-correct
-Layout/EmptyLineBetweenDefs:
-  Description: Use empty lines between defs.
-  Enabled: true
-  AllowAdjacentOneLineDefs: false
-
-Layout/EmptyLines:
-  Description: "Don't use several empty lines in a row."
-  Enabled: true
-
-Layout/EndAlignment:
-  Description: 'Align ends correctly.'
-  Enabled: true
-
-Layout/EndOfLine:
-  Description: 'Use Unix-style line endings.'
-  Enabled: true
-
-# Supports --auto-correct
-Layout/IndentationWidth:
-  Description: Use 2 spaces for indentation.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/IndentationConsistency:
-  Description: Keep indentation straight.
-  Enabled: true
-
-Layout/LineLength:
-  Description: Limit lines to 80 characters.
-  Enabled: false
-  Max: 80
-
- # Supports --auto-correct
-Layout/SpaceAroundOperators:
-  Description: Use spaces around operators.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/SpaceBeforeBlockBraces:
-  Description: Checks that the left block brace has or doesn't have space before it.
-  Enabled: true
-  EnforcedStyle: space
-  SupportedStyles:
-  - space
-  - no_space
-
-# Supports --auto-correct
-Layout/SpaceAfterSemicolon:
-  Description: Use spaces after semicolons.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/SpaceAfterColon:
-  Description: Use spaces after colons.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/SpaceAfterComma:
-  Description: Use spaces after commas.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/SpaceInsideReferenceBrackets:
-  Description: No spaces after array[ or before ].
-  Enabled: true
-
-# Supports --auto-correct
-Layout/SpaceInsideArrayLiteralBrackets:
-  Description: No spaces after array = [ or before ].
-  Enabled: true
-
-# Supports --auto-correct
-Layout/SpaceInsideParens:
-  Description: No spaces after ( or before ).
-  Enabled: true
-
-Layout/Tab:
-  Description: No hard tabs.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/TrailingWhitespace:
-  Description: Avoid trailing whitespace.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/TrailingEmptyLines:
-  Description: Checks trailing blank lines and final newline.
-  Enabled: true
-  EnforcedStyle: final_newline
-  SupportedStyles:
-  - final_newline
-  - final_blank_line
-
-## Syntax
-
-# Supports --auto-correct
-Style/AndOr:
-  Description: Use &&/|| instead of and/or.
-  Enabled: true
-
-# Supports --auto-correct
-Style/DefWithParentheses:
-  Description: Use def with parentheses when there are arguments.
-  Enabled: true
-
-Style/For:
-  Description: Checks use of for or each in multiline loops.
-  Enabled: true
-  EnforcedStyle: each
-  SupportedStyles:
-  - for
-  - each
-
-Style/IfUnlessModifier:
-  Description: Favor modifier if/unless usage when you have a single-line body.
-  Enabled: false
-
-Style/MethodCalledOnDoEndBlock:
-  Description: Avoid chaining a method call on a do...end block.
-  Enabled: true
-
-Style/MethodCallWithoutArgsParentheses:
-  Description: 'Do not use parentheses for method calls with no arguments.'
-  Enabled: true
-
-Style/MultilineBlockChain:
-  Description: Avoid multi-line chains of blocks.
-  Enabled: true
-
-Style/MultilineIfThen:
-  Description: Never use then for multi-line if/unless.
-  Enabled: true
-
-Style/MultilineTernaryOperator:
-  Description: 'Avoid multi-line ?: (the ternary operator); use if/unless instead.'
-  Enabled: true
-
-Style/NestedTernaryOperator:
-  Description: Use one expression per branch in a ternary operator.
-  Enabled: true
-
-Style/OneLineConditional:
-  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
-  Enabled: true
-
-# Supports --auto-correct
-Style/ParenthesesAroundCondition:
-  Description: Don't use parentheses around the condition of an if/unless/while.
-  Enabled: true
-  AllowSafeAssignment: true
-
-# Supports --auto-correct
-Style/RedundantReturn:
-  Description: Don't use return where it's not required.
-  Enabled: true
-  AllowMultipleReturnValues: false
-
-# Supports --auto-correct
-Layout/SpaceAfterMethodName:
-  Description: Never put a space between a method name and the opening parenthesis in
-    a method definition.
-  Enabled: true
-
-# Supports --auto-correct
-Layout/SpaceAroundEqualsInParameterDefault:
-  Description: Checks that the equals signs in parameter default assignments have or
-    don't have surrounding space depending on configuration.
-  Enabled: true
-  EnforcedStyle: space
-  SupportedStyles:
-  - space
-  - no_space
-
-Style/UnlessElse:
-  Description: Never use unless with else. Rewrite these with the positive case first.
-  Enabled: true
-
-# Supports --auto-correct
-Lint/UnusedBlockArgument:
-  Description: Checks for unused block arguments.
-  Enabled: true
-
-## Naming
-
-Naming/ClassAndModuleCamelCase:
-  Description: Use CamelCase for classes and modules.
-  Enabled: true
-
-# Supports --auto-correct
-Style/ClassMethods:
-  Description: Use self when defining module/class methods.
-  Enabled: true
-
-Style/ClassVars:
-  Description: Avoid the use of class variables.
-  Enabled: true
-
-Naming/ConstantName:
-  Description: Constants should use SCREAMING_SNAKE_CASE.
-  Enabled: true
-
-Naming/MethodName:
-  Description: Use the configured style when naming methods.
-  Enabled: true
-  EnforcedStyle: snake_case
-  SupportedStyles:
-  - snake_case
-  - camelCase
-
-# Supports --auto-correct
-Style/TrivialAccessors:
-  Description: Prefer attr_* methods to trivial readers/writers.
-  Enabled: true
-  ExactNameMatch: true
-  AllowPredicates: true
-  AllowDSLWriters: false
-  AllowedMethods:
-  - to_ary
-  - to_a
-  - to_c
-  - to_enum
-  - to_h
-  - to_hash
-  - to_i
-  - to_int
-  - to_io
-  - to_open
-  - to_path
-  - to_proc
-  - to_r
-  - to_regexp
-  - to_str
-  - to_s
-  - to_sym
-
-Naming/VariableName:
-  Description: Use the configured style when naming variables.
-  Enabled: true
-  EnforcedStyle: snake_case
-  SupportedStyles:
-  - snake_case
-  - camelCase
-
-## Exceptions
-
-# Supports --auto-correct
-Lint/RescueException:
-  Description: Avoid rescuing the Exception class.
-  Enabled: true
-
-## Collections
-
-# Supports --auto-correct
-Layout/ArrayAlignment:
-  Description: Align the elements of an array literal if they span more than one line.
-  Enabled: true
-
-# Supports --auto-correct
-Style/HashSyntax:
-  Description: 'Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax { :a => 1,
-    :b => 2 }.'
-  Enabled: true
-  Exclude:
-  - 'db/schema.rb'
-
-  EnforcedStyle: ruby19
-  SupportedStyles:
-  - ruby19
-  - hash_rockets
-
-Style/TrailingCommaInArrayLiteral:
-  Enabled: true
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInHashLiteral:
-  Enabled: true
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInArguments:
-  Enabled: true
-  EnforcedStyleForMultiline: comma
-
-# Supports --auto-correct
-Style/WordArray:
-  Description: Use %w or %W for arrays of words.
-  Enabled: true
-  MinSize: 0
-
-Layout/MultilineMethodCallIndentation:
-  Enabled: false
-
-## Strings
-
-# Supports --auto-correct
-Lint/RedundantStringCoercion:
-  Description: Checks for Object#to_s usage in string interpolation.
-  Enabled: true
-
-# Supports --auto-correct
-Style/StringLiterals:
-  Description: Checks if uses of quotes match the configured preference.
-  Enabled: true
-  EnforcedStyle: double_quotes
-  SupportedStyles:
-  - single_quotes
-  - double_quotes

data/config/other-excludes.yml

@@ -1,23 +0,0 @@
-AllCops:
-  Exclude:
-    - db/schema.rb
-
-Metrics/BlockLength:
-  Enabled: true
-  Exclude:
-    - test/**/*
-    - "**/spec/**/*"
-  ExcludedMethods: ["namespace"]
-
-Bundler/DuplicatedGem:
-  Enabled: false
-
-Style/FormatStringToken:
-  Enabled: false
-
-# These can result in false positives
-Style/HashTransformKeys:
-  Enabled: false
-
-Style/HashTransformValues:
-  Enabled: false

data/config/other-lint.yml

@@ -1,129 +0,0 @@
-Lint/AmbiguousOperator:
-  Description: >-
-     Checks for ambiguous operators in the first argument of a
-     method invocation without parentheses.
-  Enabled: true
-
-Lint/AmbiguousRegexpLiteral:
-  Description: >-
-    Checks for ambiguous regexp literals in the first argument of
-    a method invocation without parenthesis.
-  Enabled: true
-
-Lint/AssignmentInCondition:
-  Description: "Don't use assignment in conditions."
-  Enabled: true
-
-Layout/ConditionPosition:
-  Description: 'Checks for condition placed in a confusing position relative to the keyword.'
-  Enabled: true
-
-Lint/Debugger:
-  Description: 'Check for debugger calls.'
-  Enabled: true
-
-Lint/DeprecatedClassMethods:
-  Description: 'Check for deprecated class method calls.'
-  Enabled: true
-
-Lint/EmptyEnsure:
-  Description: 'Checks for empty ensure block.'
-  Enabled: true
-
-Lint/EmptyInterpolation:
-  Description: 'Checks for empty string interpolation.'
-  Enabled: true
-
-Lint/EndInMethod:
-  Description: 'END blocks should not be placed inside method definitions.'
-  Enabled: true
-
-Lint/EnsureReturn:
-  Description: 'Never use return in an ensure block.'
-  Enabled: true
-
-Security/Eval:
-  Description: 'The use of eval represents a serious security risk.'
-  Enabled: true
-
-Lint/SuppressedException:
-  Description: "Don't suppress exception."
-  Enabled: true
-
-Lint/LiteralAsCondition:
-  Description: 'Checks of literals used in conditions.'
-  Enabled: true
-
-Lint/LiteralInInterpolation:
-  Description: 'Checks for literals used in interpolation.'
-  Enabled: true
-
-Lint/Loop:
-  Description: >-
-     Use Kernel#loop with break rather than begin/end/until or
-     begin/end/while for post-loop tests.
-  Enabled: true
-
-Lint/ParenthesesAsGroupedExpression:
-  Description: >-
-     Checks for method calls with a space before the opening
-     parenthesis.
-  Enabled: true
-
-Lint/PercentStringArray:
-  Description: Checks for unwanted commas and quotes in %w/%W literals eg %w('foo', “bar”).
-  Enabled: true
-
-Lint/RequireParentheses:
-  Description: >-
-     Use parentheses in the method call to avoid confusion
-     about precedence.
-  Enabled: true
-
-Lint/ShadowingOuterLocalVariable:
-  Description: >-
-     Do not use the same name as outer local variable
-     for block arguments or block local variables.
-  Enabled: true
-
-Layout/SpaceBeforeFirstArg:
-  Description: >-
-     Put a space between a method name and the first argument
-     in a method call without parentheses.
-  Enabled: true
-
-Lint/UnderscorePrefixedVariableName:
-  Description: 'Do not use prefix `_` for a variable that is used.'
-  Enabled: true
-
-Lint/UnusedMethodArgument:
-  Description: 'Checks for unused method arguments.'
-  Enabled: true
-
-Lint/UnreachableCode:
-  Description: 'Unreachable code.'
-  Enabled: true
-
-Lint/UselessAccessModifier:
-  Description: 'Checks for useless access modifiers.'
-  Enabled: true
-
-Lint/UselessAssignment:
-  Description: 'Checks for useless assignment to a local variable.'
-  Enabled: true
-
-Lint/UselessComparison:
-  Description: 'Checks for comparison of something with itself.'
-  Enabled: true
-
-Lint/UselessElseWithoutRescue:
-  Description: 'Checks for useless `else` in `begin..end` without `rescue`.'
-  Enabled: true
-
-Lint/UselessSetterCall:
-  Description: 'Checks for useless setter call to a local variable.'
-  Enabled: true
-
-Lint/Void:
-  Description: 'Possible use of operator/literal/variable in void context.'
-  Enabled: true