rubocop-govuk 3.17.1 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ef0a8b1f526bdba1c8152abe1e2c64899667bae4333034e8fe522860a96fedc
-  data.tar.gz: ae376a5117e15ba9ce86e83524df9422c6211d56f3298a24344101ac5cfb24e3
+  metadata.gz: 414ff4213da8a8ea70821cb630647952e771f98d01279d790463a92bcf350ac2
+  data.tar.gz: 7db52250855d45d7315911320daa0f659c2a0f646d708b5ad94f6ab21de052e1
 SHA512:
-  metadata.gz: 3f8c2597c64a1842bb5e8c5a9a78fb7dac3b898865c3da60dfad238a0c022ff95bf32cb2f3bee1ffe2ab7e9897378c93670ced073d428613e4bc1267c9e662a5
-  data.tar.gz: 32b99fa71506c6314f783ae30b84f077ec56de20dc6a27f1530fb829581b7b0cbf7404d5cc70aaa1761792f60b886865f2736cddddb125c0ae3b1792a48a7ee9
+  metadata.gz: ec499801f4cd3ebfa79c4bca8a996cdc5534d86e6cef016b4e0c6668ce1c4baf0115d797197cf693e1821dc428ac37249bda3629e83d6aebc80816229bb1b09f
+  data.tar.gz: 5821f363ebc0ee793bc6cf9469b91dbdf3e4f6ca4d8de54e7ce5ab3811e5b59f9218beae08053e5fade8ca5b250163bb07bf37a080c35d17ce1370875ac3b15e

data/CHANGELOG.md

@@ -1,3 +1,46 @@
+# 4.1.0
+
+- Update rubocop to 1.21.0
+- Update rubocop-ast to 1.11.0
+- Update rubocop-rails to 2.12.0
+- Update rubocop-rspec to 2.4.0
+- Update rubocop-rake to 0.6.0
+
+# 4.0.0
+
+- Update rubocop to 1.15.0
+- Update rubocop-ast to 1.6.0
+- Update rubocop-rails to 2.10.0
+- Update rubocop-rspec to 2.3.0
+
+# 4.0.0.pre.1
+
+- Released as a pre-release to try surface any issues before wider rollout,
+  use https://github.com/alphagov/rubocop-govuk/issues/129 to record any
+  problems
+- BREAKING: Upgraded from Rubocop 0.x to 1.x which introduces lots of new
+  cops
+- Update rubocop to 1.10.0
+- Update rubocop-ast to 1.4.0
+- Update rubocop-rails to 2.9.1
+- Update rubocop-rspec to 2.2.0
+- Make stable dependencies (>= 1.0) less strict on patch version
+- Disable `SuggestExtensions` to stop Rubocop suggesting additional
+  extensions at runtime
+- Explicitly set target Ruby version to `>= 2.6` in gemspec
+- Downgrade local Ruby version to `2.6.6` to capture lowest supported
+  Ruby version
+- Fix namespace change of `Capybara/FeatureMethods`
+- Disable `Naming/VariableNumbers`
+
+# 4.0.0.pre.pre.1
+
+- Mistakenly named release, same as 4.0.0.pre.1
+
+# 3.17.2
+
+- Rename Blacklist to ForbiddenMethods to fix rubocop-rails warnings
+
 # 3.17.1
 
 - Pin rubocop-ast to 0.8.0

data/README.md

@@ -8,7 +8,7 @@ Add `rubocop-govuk` to your Gemfile and then run `bundle install`:
 
 ```ruby
 # Gemfile
-gem 'rubocop-govuk'
+gem 'rubocop-govuk', require: false
 ```
 
 Then inherit the default rules by adding the following in your project:

data/config/capybara.yml

@@ -1,5 +1,5 @@
 # Within GOV.UK we use Capybara test method syntax of feature,
 # scenario. We don't want this outside of feature specs though.
-Capybara/FeatureMethods:
+RSpec/Capybara/FeatureMethods:
   Exclude:
     - 'spec/features/**/*.rb'

data/config/default.yml

@@ -1,5 +1,6 @@
 AllCops:
   NewCops: disable
+  SuggestExtensions: false
   Exclude:
     - 'bin/**'
     - 'config.ru'

data/config/naming.yml

@@ -19,3 +19,10 @@ Naming/AccessorMethodName:
 # repos, which would require manual intervention.
 Naming/PredicateName:
   Enabled: false
+
+# This rule can cause readability issues when applied (for example
+# `born_on_or_before_6_april_1935` becomes `born_on_or_before_6april1935`)
+# and would require lots of amends to apply either `normalcase`
+# or `snake_case` to projects. It is not auto-correctable.
+Naming/VariableNumber:
+  Enabled: false

data/config/rails.yml

@@ -36,7 +36,7 @@ Rails/Output:
 # no efficient alternative. Instead, we should only enable
 # this Cop for methods that have a clear alternative.
 Rails/SkipsModelValidations:
-  Blacklist:
+  ForbiddenMethods:
     - update_attribute
 
 # While using has_many/through does have some advantages,

data/config/rspec.yml

@@ -10,6 +10,11 @@ inherit_from:
 RSpec/ExampleLength:
   Enabled: false
 
+# We should avoid cops that are based on heuristics, since
+# it's not clear what action to take to fix an issue.
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 # We have common cases, such as rake tasks, where we do not
 # use a class to the describe the test.
 RSpec/DescribeClass:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.17.1
+  version: 4.1.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-13 00:00:00.000000000 Z
+date: 2021-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -30,70 +30,70 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 1.21.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 1.21.0
 - !ruby/object:Gem::Dependency
   name: rubocop-ast
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 1.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 1.11.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.12.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.12.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.42.0
+        version: 2.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.42.0
+        version: 2.4.0
 description: Shared RuboCop rules for Ruby projects in GOV.UK
 email:
 - govuk-dev@digital.cabinet-office.gov.uk
@@ -125,14 +125,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.27
 signing_key: 
 specification_version: 4
 summary: RuboCop GOV.UK