rubocop-govuk 3.16.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bbde5e0b6a71966c3c76a712077229e4be9de9ab400a3ad54e43ce55a98d2920
-  data.tar.gz: f09db889982c986669ce7a6ab535f3d8011d2725ee65aa5aa92df451e2cb406a
+  metadata.gz: d331e57f5c75b5cc5191e165259b4e00b292862dafa2d3c882f79783bda4b704
+  data.tar.gz: 21a76a6e200eac94a0aeed6177d85e901aed8d3a773df5ea2f6ce5d4e030c778
 SHA512:
-  metadata.gz: bed4ce6b4dc5eb4633258405831b182e72f495738b3152eca931623069a35cbf37322e3788da43c616960cfe1a668871ba41b26d9104e98416853d86ba03b83a
-  data.tar.gz: b299bbdb9ec85294230c07239cec79e256d39f3203257ba2fe6ae8ef1c2da53a64ea93911564d2de01b3c3174e5bb602949da656f27240b3c144f9c1f190fabd
+  metadata.gz: d67c0dff23b2a2eddbc492d8f2fbccce7029ba0a1bd9d6647d3325c99f6f0bfe9fad9c2cdb8312b27279580d8229af65d2233d2480c1b7ecb19dbf37f2e37226
+  data.tar.gz: 8b61dbbb55cf17b9557b704b66b6614b28c85d2698e9e4e976c495dbe17bc71d3161db5da67e18923f01941670bd7e3c97510da8c70c08cb97ffdeafbb6da54c

data/CHANGELOG.md

@@ -1,3 +1,50 @@
+# 4.0.0
+
+- Update rubocop to 1.15.0
+- Update rubocop-ast to 1.6.0
+- Update rubocop-rails to 2.10.0
+- Update rubocop-rspec to 2.3.0
+
+# 4.0.0.pre.1
+
+- Released as a pre-release to try surface any issues before wider rollout,
+  use https://github.com/alphagov/rubocop-govuk/issues/129 to record any
+  problems
+- BREAKING: Upgraded from Rubocop 0.x to 1.x which introduces lots of new
+  cops
+- Update rubocop to 1.10.0
+- Update rubocop-ast to 1.4.0
+- Update rubocop-rails to 2.9.1
+- Update rubocop-rspec to 2.2.0
+- Make stable dependencies (>= 1.0) less strict on patch version
+- Disable `SuggestExtensions` to stop Rubocop suggesting additional
+  extensions at runtime
+- Explicitly set target Ruby version to `>= 2.6` in gemspec
+- Downgrade local Ruby version to `2.6.6` to capture lowest supported
+  Ruby version
+- Fix namespace change of `Capybara/FeatureMethods`
+- Disable `Naming/VariableNumbers`
+
+# 4.0.0.pre.pre.1
+
+- Mistakenly named release, same as 4.0.0.pre.1
+
+# 3.17.2
+
+- Rename Blacklist to ForbiddenMethods to fix rubocop-rails warnings
+
+# 3.17.1
+
+- Pin rubocop-ast to 0.8.0
+
+# 3.17.0
+
+- Enable Rails/SaveBang
+- Enable Style/DateTime
+- Enforce strict Time.zone.now
+- Bump rubocop to 0.87.1
+- Bump rubocop-rspec to 1.42.0
+
 # 3.16.0
 
 - Bump and lock rubocop-rails to 2.6.0

data/README.md

@@ -8,7 +8,7 @@ Add `rubocop-govuk` to your Gemfile and then run `bundle install`:
 
 ```ruby
 # Gemfile
-gem 'rubocop-govuk'
+gem 'rubocop-govuk', require: false
 ```
 
 Then inherit the default rules by adding the following in your project:

data/config/capybara.yml

@@ -1,5 +1,5 @@
 # Within GOV.UK we use Capybara test method syntax of feature,
 # scenario. We don't want this outside of feature specs though.
-Capybara/FeatureMethods:
+RSpec/Capybara/FeatureMethods:
   Exclude:
     - 'spec/features/**/*.rb'

data/config/default.yml

@@ -1,5 +1,6 @@
 AllCops:
   NewCops: disable
+  SuggestExtensions: false
   Exclude:
     - 'bin/**'
     - 'config.ru'

data/config/naming.yml

@@ -19,3 +19,10 @@ Naming/AccessorMethodName:
 # repos, which would require manual intervention.
 Naming/PredicateName:
   Enabled: false
+
+# This rule can cause readability issues when applied (for example
+# `born_on_or_before_6_april_1935` becomes `born_on_or_before_6april1935`)
+# and would require lots of amends to apply either `normalcase`
+# or `snake_case` to projects. It is not auto-correctable.
+Naming/VariableNumber:
+  Enabled: false

data/config/rails.yml

@@ -36,7 +36,7 @@ Rails/Output:
 # no efficient alternative. Instead, we should only enable
 # this Cop for methods that have a clear alternative.
 Rails/SkipsModelValidations:
-  Blacklist:
+  ForbiddenMethods:
     - update_attribute
 
 # While using has_many/through does have some advantages,
@@ -79,3 +79,16 @@ Rails/HasManyOrHasOneDependent:
 # little value to many developers.
 Rails/OutputSafety:
   Enabled: false
+
+# We seldom check the return value of 'update' to see if
+# the operation was successful. Since we assume success, we
+# should raise an exception if this is not the case.
+Rails/SaveBang:
+  Enabled: true
+
+# We should avoid unnecessary ambiguity between 'Time.current'
+# and 'Time.zone.now', where 'Time.current' behaves differently
+# depending on application config. We should always be explicit
+# about whether we mean 'Time[.zone].now'.
+Rails/TimeZone:
+  EnforcedStyle: "strict"

data/config/rspec.yml

@@ -10,6 +10,11 @@ inherit_from:
 RSpec/ExampleLength:
   Enabled: false
 
+# We should avoid cops that are based on heuristics, since
+# it's not clear what action to take to fix an issue.
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 # We have common cases, such as rake tasks, where we do not
 # use a class to the describe the test.
 RSpec/DescribeClass:

data/config/style.yml

@@ -145,3 +145,11 @@ Style/SafeNavigation:
 # https://github.com/rubocop-hq/rubocop/issues/7197
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+# We should only use DateTime when it's necessary to account
+# for ancient calendar changes. Otherwise, the arbitrary use
+# of this class in place of Date or Time is confusing.
+#
+# https://rubystyle.guide/#no-datetime
+Style/DateTime:
+  Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 3.16.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-10 00:00:00.000000000 Z
+date: 2021-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -28,30 +28,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.85.1
+        version: 1.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.15.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-ast
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.6.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.85.1
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.10.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -70,16 +84,16 @@ dependencies:
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: 2.3.0
 description: Shared RuboCop rules for Ruby projects in GOV.UK
 email:
 - govuk-dev@digital.cabinet-office.gov.uk
@@ -111,14 +125,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.19
 signing_key: 
 specification_version: 4
 summary: RuboCop GOV.UK