rubocop-govuk 1.0.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 64fec5146e2d9675100ef4f3e9e2e20662b9fe142c3543ba944b093a22567e5c
-  data.tar.gz: e3b797ff3bda459208fab3db93f3cdb852cbbe694afdd7ef75df89cf290e1cdc
+  metadata.gz: 4947e41fd12635ee3de075acde23d364be021367110d0b1952773d9f29953dd2
+  data.tar.gz: 00f07260888c5f71ed363e51f7c6f21c8e7f06108996670920a591ebd8f373b1
 SHA512:
-  metadata.gz: 1f31c42621eb74cea67290c161c8febe47f85adffa4a6caa392290d8a48b02f2c0113e992aa1e97aca3335d8a1aae2ed97b2d133622c0e3215238bf988fa0dc2
-  data.tar.gz: 751fdab0163a353a6c65233c9a752df7b011fb5e551caf48a0e848013050fbcd343ba263fda5de2667fb4eaabe0d1910b06cadb55758020e7248a5f67af47f4e
+  metadata.gz: e4b1c8d275050bf3e29f0e0ecbaf78d9636ee9491f25c2942b28f825e7c1d7fd7b9ddb51b7efc14ddf70098fb347279b633a94fbbb7176c58ac6377bff678271
+  data.tar.gz: 575aa067b5cd319f1c62fe8296b3473ad017ca4b060ee5ee684aa9842793ca459d37e01596ef33056af37179e9b8e72af5100a86d353e2b5d04a92749b0f7de7

data/CHANGELOG.md

@@ -1,3 +1,29 @@
+# 3.3.0
+
+* Exclude Rails migrations from linting checks (#25)
+
+# 3.2.0
+
+* Configure new cops about hash styles (#24)
+* Exclude `tmp` directory from linting checks (#22)
+
+# 3.1.0
+
+* Fix deprecation warning for AllCops/Excludes => AllCops/Exclude (#17)
+* Exclude `config.ru` from linter checks (#18)
+
+# 3.0.0
+
+* Update Rubocop to 0.80.1
+  * This deletes the Style/BracesAroundHashParameters cop for future
+    Ruby 3 compatibility.
+* Exclude `bin` directory and `db/schema.rb` from linter checks (#14)
+
+# 2.0.0
+
+* Use specific version for RuboCop
+* Update RuboCop to 0.77
+
 # 1.0.0
 
 * Allow importing of Ruby and Rails rules seperately

data/README.md

@@ -5,14 +5,16 @@ This repository provides common RuboCop rules for use with GOV.UK Ruby projects
 ## Installation
 
 Add `rubocop-govuk` to your Gemfile and then run `bundle install`:
+
 ```ruby
 # Gemfile
 gem 'rubocop-govuk'
 ```
 
 Inherit rules from the gem by adding the following to your project's RuboCop config:
+
 ```yaml
-# .rubocop
+# .rubocop.yml
 inherit_gem:
   rubocop-govuk: 
     - config/default.yml
@@ -21,7 +23,7 @@ inherit_gem:
 or if you also need Rails specific rules:
 
 ```yaml
-# .rubocop
+# .rubocop.yml
 inherit_gem:
   rubocop-govuk: 
     - config/default.yml

data/config/default.yml

@@ -1,4 +1,9 @@
 AllCops:
+  Exclude:
+    - 'bin/**'
+    - 'config.ru'
+    - 'tmp/**'
+
   DisplayCopNames:
     Description: 'Display cop names in offense messages'
     Enabled: true

data/config/gds-ruby-styleguide.yml

@@ -55,7 +55,7 @@ Layout/IndentationConsistency:
   Description: Keep indentation straight.
   Enabled: true
 
-Metrics/LineLength:
+Layout/LineLength:
   Description: Limit lines to 80 characters.
   Enabled: false
   Max: 80
@@ -114,7 +114,7 @@ Layout/TrailingWhitespace:
   Enabled: true
 
 # Supports --auto-correct
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Description: Checks trailing blank lines and final newline.
   Enabled: true
   EnforcedStyle: final_newline
@@ -245,7 +245,7 @@ Style/TrivialAccessors:
   ExactNameMatch: true
   AllowPredicates: true
   AllowDSLWriters: false
-  Whitelist:
+  AllowedMethods:
   - to_ary
   - to_a
   - to_c
@@ -282,7 +282,7 @@ Lint/RescueException:
 ## Collections
 
 # Supports --auto-correct
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Description: Align the elements of an array literal if they span more than one line.
   Enabled: true
 
@@ -323,7 +323,7 @@ Layout/MultilineMethodCallIndentation:
 ## Strings
 
 # Supports --auto-correct
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Description: Checks for Object#to_s usage in string interpolation.
   Enabled: true
 

data/config/other-lint.yml

@@ -46,7 +46,7 @@ Security/Eval:
   Description: 'The use of eval represents a serious security risk.'
   Enabled: true
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Description: "Don't suppress exception."
   Enabled: true
 

data/config/other-style.yml

@@ -11,13 +11,13 @@ Style/Alias:
   Description: 'Use alias_method instead of alias.'
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Description: >-
     Align the elements of a hash literal if they span more than
     one line.
   Enabled: false
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Description: >-
     Align the parameters of a method call if they span more
     than one line.
@@ -58,10 +58,6 @@ Style/BlockDelimiters:
     Prefer {...} over do...end for single-line blocks.
   Enabled: false
 
-Style/BracesAroundHashParameters:
-  Description: 'Enforce braces style inside hash parameters.'
-  Enabled: true
-
 Style/CaseEquality:
   Description: 'Avoid explicit use of the case equality operator(===).'
   Enabled: false
@@ -168,13 +164,13 @@ Style/IfWithSemicolon:
   Description: 'Never use if x; .... Use the ternary operator instead.'
   Enabled: false
 
-Layout/IndentFirstArrayElement:
+Layout/FirstArrayElementIndentation:
   Description: >-
     Checks the indentation of the first element in an array
     literal.
   Enabled: false
 
-Layout/IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   Description: 'Checks the indentation of the first key in a hash literal.'
   Enabled: false
 
@@ -384,3 +380,12 @@ Style/WhileUntilModifier:
 
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true

data/config/rails.yml

@@ -5,6 +5,11 @@
 
 require: rubocop-rails
 
+AllCops:
+  Exclude:
+    - 'db/schema.rb'
+    - 'db/migrate/201*'
+
 Rails:
   Enabled: true
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-06 00:00:00.000000000 Z
+date: 2020-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.76'
+        version: 0.80.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.76'
+        version: 0.80.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement