rubocop-govuk 0.2.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40f84a8c1d1205d4b33bc14effe51e26e365ddca8e51068df0603b9b87d61818
-  data.tar.gz: e3dd20d13999c8ac7a32b2b6637d65aa7d614943fd8677818543dd171ce46c83
+  metadata.gz: 82b9a8a41b6ff232b9f25c7fde4a498c8f6cdf950749a7b6b2174bab4f4239e0
+  data.tar.gz: 779bd06389fe70038b21396ddb62e54fdd5e39e21fd6c2047d49db39e5657ae8
 SHA512:
-  metadata.gz: e4b2958fe04fb97c2b747fff19dae0659388017a1ca06d5e92b75cbeef7aa8c9547343a22fc62a4acbfde31b75bdbd6ef813dbc41bb8ac511766f98aedf68a71
-  data.tar.gz: a8947cb7df4765416a3d2ce06de851955151cec7f37d46e78648db00f0c1e4b0b04b08d72205afd5f034475251f507dce49995717153fd8a8b1a89381ad23ce8
+  metadata.gz: 68ff798125fe9145572f42d53660e2195d238899bd38a55d384bc735a793ec987e02c579c827a64a1e13592fb99d9a7f92efa3e5eeb195c8cda830eb648989d8
+  data.tar.gz: 72549606aec583281a87915192229543ad5e4c0eb405ca710e08142471ffdfb70ee646474000d3a50cc9321a69d2f24a034413d38999de19adc4b02db2353065

data/CHANGELOG.md

@@ -1,3 +1,29 @@
+# 3.2.0
+
+* Configure new cops about hash styles (#24)
+* Exclude `tmp` directory from linting checks (#22)
+
+# 3.1.0
+
+* Fix deprecation warning for AllCops/Excludes => AllCops/Exclude (#17)
+* Exclude `config.ru` from linter checks (#18)
+
+# 3.0.0
+
+* Update Rubocop to 0.80.1
+  * This deletes the Style/BracesAroundHashParameters cop for future
+    Ruby 3 compatibility.
+* Exclude `bin` directory and `db/schema.rb` from linter checks (#14)
+
+# 2.0.0
+
+* Use specific version for RuboCop
+* Update RuboCop to 0.77
+
+# 1.0.0
+
+* Allow importing of Ruby and Rails rules seperately
+
 # 0.2.0
 
 * Disable the Style/FormatStringToken cop

data/README.md

@@ -5,16 +5,29 @@ This repository provides common RuboCop rules for use with GOV.UK Ruby projects
 ## Installation
 
 Add `rubocop-govuk` to your Gemfile and then run `bundle install`:
+
 ```ruby
 # Gemfile
 gem 'rubocop-govuk'
 ```
 
 Inherit rules from the gem by adding the following to your project's RuboCop config:
+
+```yaml
+# .rubocop.yml
+inherit_gem:
+  rubocop-govuk: 
+    - config/default.yml
+```
+
+or if you also need Rails specific rules:
+
 ```yaml
-# .rubocop
+# .rubocop.yml
 inherit_gem:
-  rubocop-govuk: config/all.yml
+  rubocop-govuk: 
+    - config/default.yml
+    - config/rails.yml
 ```
 
 ## Usage

data/config/{all.yml → default.yml}

@@ -1,4 +1,9 @@
 AllCops:
+  Exclude:
+    - 'bin/**'
+    - 'config.ru'
+    - 'tmp/**'
+
   DisplayCopNames:
     Description: 'Display cop names in offense messages'
     Enabled: true
@@ -11,12 +16,9 @@ AllCops:
     Description: 'Display style guide URLs in offense messages.'
     Enabled: true
 
-require: rubocop-rails
-
 inherit_from:
   - gds-ruby-styleguide.yml
   - other-lint.yml
-  - other-rails.yml
   - other-style.yml
   - other-metrics.yml
   - other-excludes.yml

data/config/gds-ruby-styleguide.yml

@@ -55,7 +55,7 @@ Layout/IndentationConsistency:
   Description: Keep indentation straight.
   Enabled: true
 
-Metrics/LineLength:
+Layout/LineLength:
   Description: Limit lines to 80 characters.
   Enabled: false
   Max: 80
@@ -114,7 +114,7 @@ Layout/TrailingWhitespace:
   Enabled: true
 
 # Supports --auto-correct
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Description: Checks trailing blank lines and final newline.
   Enabled: true
   EnforcedStyle: final_newline
@@ -245,7 +245,7 @@ Style/TrivialAccessors:
   ExactNameMatch: true
   AllowPredicates: true
   AllowDSLWriters: false
-  Whitelist:
+  AllowedMethods:
   - to_ary
   - to_a
   - to_c
@@ -282,7 +282,7 @@ Lint/RescueException:
 ## Collections
 
 # Supports --auto-correct
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Description: Align the elements of an array literal if they span more than one line.
   Enabled: true
 
@@ -323,7 +323,7 @@ Layout/MultilineMethodCallIndentation:
 ## Strings
 
 # Supports --auto-correct
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Description: Checks for Object#to_s usage in string interpolation.
   Enabled: true
 

data/config/other-lint.yml

@@ -46,7 +46,7 @@ Security/Eval:
   Description: 'The use of eval represents a serious security risk.'
   Enabled: true
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Description: "Don't suppress exception."
   Enabled: true
 

data/config/other-style.yml

@@ -11,13 +11,13 @@ Style/Alias:
   Description: 'Use alias_method instead of alias.'
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Description: >-
     Align the elements of a hash literal if they span more than
     one line.
   Enabled: false
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Description: >-
     Align the parameters of a method call if they span more
     than one line.
@@ -58,10 +58,6 @@ Style/BlockDelimiters:
     Prefer {...} over do...end for single-line blocks.
   Enabled: false
 
-Style/BracesAroundHashParameters:
-  Description: 'Enforce braces style inside hash parameters.'
-  Enabled: true
-
 Style/CaseEquality:
   Description: 'Avoid explicit use of the case equality operator(===).'
   Enabled: false
@@ -168,13 +164,13 @@ Style/IfWithSemicolon:
   Description: 'Never use if x; .... Use the ternary operator instead.'
   Enabled: false
 
-Layout/IndentFirstArrayElement:
+Layout/FirstArrayElementIndentation:
   Description: >-
     Checks the indentation of the first element in an array
     literal.
   Enabled: false
 
-Layout/IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   Description: 'Checks the indentation of the first key in a hash literal.'
   Enabled: false
 
@@ -384,3 +380,12 @@ Style/WhileUntilModifier:
 
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true

data/config/{other-rails.yml → rails.yml}

@@ -2,8 +2,15 @@
 
 # By default Rails is switched off so this can be used by non-Rails apps,
 # this can be enabled in a local .rubocop.yml file
+
+require: rubocop-rails
+
+AllCops:
+  Exclude:
+    - 'db/schema.rb'
+
 Rails:
-  Enabled: false
+  Enabled: true
 
 Rails/ActionFilter:
   Description: 'Enforces consistent use of action filter methods.'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-govuk
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-04 00:00:00.000000000 Z
+date: 2020-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.76'
+        version: 0.80.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.76'
+        version: 0.80.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -76,13 +76,13 @@ files:
 - CHANGELOG.md
 - LICENSE.md
 - README.md
-- config/all.yml
+- config/default.yml
 - config/gds-ruby-styleguide.yml
 - config/other-excludes.yml
 - config/other-lint.yml
 - config/other-metrics.yml
-- config/other-rails.yml
 - config/other-style.yml
+- config/rails.yml
 homepage: https://github.com/alphagov/rubocop-govuk
 licenses:
 - MIT