rubocop-github 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2deac26f12f0be3a1298967c4c2e039758a6f4b1
-  data.tar.gz: 644561f2ad8355dd7270e5882e70212dc1337bce
+  metadata.gz: 80d199ffcd70d816e6bc8d7cfbc385d8da6104c7
+  data.tar.gz: 28cb103afd0a87170f8e389a67678b0a8384d2aa
 SHA512:
-  metadata.gz: 6f00919c2d133c2b58de06a6d64659bf5646a5d9f65040683750b132ff4317a43c0394c74b2ee14d13c27fef24183ccfd27d25856ae914964756890ffa8f2342
-  data.tar.gz: 1f57f3eaee766eeb2fd65b5a1265f53d883564d88a3a6fb925c990ce5fa33af2b30c0d854019c9fd66cb9bc122f75ff3126e2dd08370afc3c4c23d8a53f1d55b
+  metadata.gz: 215ecd2cea223b595711365c443a21c0935990f0c83383827b4eb9b92d53a48ed92a0ee3e38f8d1665f1046e1b4114537b91bfdcf7d4d874333944326f3d9c06
+  data.tar.gz: c69e5919daa8ebd0abc60d8f0d59fc72b506a908656c2d992ef5b149a3844f964706f59cff955febd685224c3456bfda8814c00e28982c23272780745b70baef

data/STYLEGUIDE.md

@@ -224,6 +224,31 @@ def multiplex(text, count)
 end
 ```
 
+## Dynamic Dispatch
+
+Avoid calling `send` and its cousins unless you really need it. Metaprogramming can be extremely powerful, but in most cases you can write code that captures your meaning by being explicit:
+
+``` ruby
+# avoid 
+unless [:base, :head].include?(base_or_head)
+  raise ArgumentError, "base_or_head must be either :base or :head"
+end
+
+repository = pull.send("#{base_or_head}_repository")
+branch = pull.send("#{base_or_head}_ref_name")
+
+# prefer
+case base_or_head
+when :base
+  repository = pull.base_repository
+  branch = pull.base_ref_name
+when :head
+  repository = pull.head_repository
+  branch = pull.head_ref_name
+else
+  raise ArgumentError, "base_or_head must be either :base or :head"
+end
+```
 ## Exceptions
 
 * Don't use exceptions for flow of control.

data/config/default.yml

@@ -9,9 +9,21 @@ Bundler/DuplicatedGem:
 Bundler/OrderedGems:
   Enabled: true
 
+Layout/BlockAlignment:
+  Enabled: true
+
 Layout/BlockEndNewline:
   Enabled: true
 
+Layout/ConditionPosition:
+  Enabled: true
+
+Layout/DefEndAlignment:
+  Enabled: true
+
+Layout/EndAlignment:
+  Enabled: false
+
 Layout/EndOfLine:
   Enabled: true
 
@@ -70,21 +82,12 @@ Layout/TrailingBlankLines:
 Layout/TrailingWhitespace:
   Enabled: true
 
-Lint/BlockAlignment:
-  Enabled: true
-
 Lint/CircularArgumentReference:
   Enabled: true
 
-Lint/ConditionPosition:
-  Enabled: true
-
 Lint/Debugger:
   Enabled: true
 
-Lint/DefEndAlignment:
-  Enabled: true
-
 Lint/DeprecatedClassMethods:
   Enabled: true
 
@@ -106,9 +109,6 @@ Lint/EmptyEnsure:
 Lint/EmptyInterpolation:
   Enabled: true
 
-Lint/EndAlignment:
-  Enabled: false
-
 Lint/EndInMethod:
   Enabled: true
 
@@ -226,9 +226,6 @@ Performance/EndWith:
 Performance/FlatMap:
   Enabled: true
 
-Performance/HashEachMethods:
-  Enabled: true
-
 Performance/LstripRstrip:
   Enabled: true
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-github
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - GitHub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-01 00:00:00.000000000 Z
+date: 2018-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop