rubocop-github 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4850486ea03d870f6aead0f4a2517fb0b2276d65
-  data.tar.gz: b9b7f0edd11e56766593cc80ef423982df6604e8
+  metadata.gz: 6af726432cd153410483cfe93e2f502d7e98c93f
+  data.tar.gz: 6951ded262807d7ac3cc1fd139302ea5eec60eb5
 SHA512:
-  metadata.gz: 7ecedba5945565a11735da85a501aa8fa45d855eba35d1a2d5cfd0e916dd937f59c44610379aff891852f253f2e12b6d5e2daf2de7182040b9599e5739a807e2
-  data.tar.gz: 86a229e24c43620c4f2c56acc005702f8102839744658627689054e6f9b5d86ef507431e9961cce13af4b7b616ac0d584dbe0db456f292fcb1cff1c26f5a5180
+  metadata.gz: 763fe41dba94fcbb0d400fb742fef4b9e9ce3370a32f254184012eba36a3fb6b887ec0692944d9eb41025d15ae5f8184774b114e748c68966842daa1381be131
+  data.tar.gz: f9cbb9f51e5b9d0436a9cad3c1afa33b62ec5610e822ca152cdad3d1d4506af4566fe2b2d4afec6b1b4cd42399197ffd0a1e55e943b2d054314dd8623247b6ac

data/config/default.yml

@@ -9,6 +9,57 @@ Bundler/DuplicatedGem:
 Bundler/OrderedGems:
   Enabled: true
 
+Layout/BlockEndNewline:
+  Enabled: true
+
+Layout/EndOfLine:
+  Enabled: true
+
+Layout/InitialIndentation:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAfterMethodName:
+  Enabled: true
+
+Layout/SpaceAfterNot:
+  Enabled: true
+
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
+Layout/SpaceAroundBlockParameters:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceInsideArrayPercentLiteral:
+  Enabled: true
+
+Layout/SpaceInsideBrackets:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+Layout/SpaceInsideRangeLiteral:
+  Enabled: true
+
+Layout/Tab:
+  Enabled: true
+
+Layout/TrailingBlankLines:
+  Enabled: true
+
+Layout/TrailingWhitespace:
+  Enabled: true
+
 Lint/BlockAlignment:
   Enabled: true
 
@@ -42,15 +93,15 @@ Lint/ElseLayout:
 Lint/EmptyEnsure:
   Enabled: true
 
-Lint/EndInMethod:
-  Enabled: true
-
 Lint/EmptyInterpolation:
   Enabled: true
 
 Lint/EndAlignment:
   Enabled: false
 
+Lint/EndInMethod:
+  Enabled: true
+
 Lint/EnsureReturn:
   Enabled: true
 
@@ -60,14 +111,7 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
-Style/HashSyntax:
-  Enabled: true
-  EnforcedStyle: ruby19
-
-Lint/InvalidCharacterLiteral:
-  Enabled: true
-
-Lint/LiteralInCondition:
+Lint/LiteralAsCondition:
   Enabled: true
 
 Lint/LiteralInInterpolation:
@@ -142,6 +186,18 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Enabled: false
 
+Naming/AsciiIdentifiers:
+  Enabled: true
+
+Naming/ClassAndModuleCamelCase:
+  Enabled: true
+
+Naming/FileName:
+  Enabled: true
+
+Naming/MethodName:
+  Enabled: true
+
 Performance/CaseWhenSplat:
   Enabled: false
 
@@ -197,27 +253,18 @@ Security/Eval:
 Style/ArrayJoin:
   Enabled: true
 
-Style/AsciiIdentifiers:
-  Enabled: true
-
 Style/BeginBlock:
   Enabled: true
 
 Style/BlockComments:
   Enabled: true
 
-Layout/BlockEndNewline:
-  Enabled: true
-
 Style/CaseEquality:
   Enabled: true
 
 Style/CharacterLiteral:
   Enabled: true
 
-Style/ClassAndModuleCamelCase:
-  Enabled: true
-
 Style/ClassMethods:
   Enabled: true
 
@@ -230,12 +277,6 @@ Style/DefWithParentheses:
 Style/EndBlock:
   Enabled: true
 
-Layout/EndOfLine:
-  Enabled: true
-
-Style/FileName:
-  Enabled: true
-
 Style/FlipFlop:
   Enabled: true
 
@@ -245,8 +286,9 @@ Style/For:
 Style/FrozenStringLiteralComment:
   Enabled: true
 
-Layout/InitialIndentation:
+Style/HashSyntax:
   Enabled: true
+  EnforcedStyle: ruby19
 
 Style/LambdaCall:
   Enabled: true
@@ -257,9 +299,6 @@ Style/MethodCallWithoutArgsParentheses:
 Style/MethodDefParentheses:
   Enabled: true
 
-Style/MethodName:
-  Enabled: true
-
 Style/MultilineIfThen:
   Enabled: true
 
@@ -272,51 +311,9 @@ Style/Not:
 Style/OneLineConditional:
   Enabled: true
 
-Layout/SpaceAfterMethodName:
-  Enabled: true
-
-Layout/SpaceAfterColon:
-  Enabled: true
-
-Layout/SpaceAfterComma:
-  Enabled: true
-
-Layout/SpaceAfterNot:
-  Enabled: true
-
-Layout/SpaceAfterSemicolon:
-  Enabled: true
-
-Layout/SpaceAroundBlockParameters:
-  Enabled: true
-
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
-
-Layout/SpaceInsideArrayPercentLiteral:
-  Enabled: true
-
-Layout/SpaceInsideBrackets:
-  Enabled: true
-
-Layout/SpaceInsideParens:
-  Enabled: true
-
-Layout/SpaceInsideRangeLiteral:
-  Enabled: true
-
 Style/StabbyLambdaParentheses:
   Enabled: true
 
 Style/StringLiterals:
   Enabled: true
   EnforcedStyle: double_quotes
-
-Layout/Tab:
-  Enabled: true
-
-Layout/TrailingBlankLines:
-  Enabled: true
-
-Layout/TrailingWhitespace:
-  Enabled: true

data/lib/rubocop/cop/github/rails_application_record.rb

@@ -9,18 +9,18 @@ module RuboCop
         MSG = "Models should subclass from ApplicationRecord"
 
         def_node_matcher :active_record_base_const?, <<-PATTERN
-          (const (const nil :ActiveRecord) :Base)
+          (const (const nil? :ActiveRecord) :Base)
         PATTERN
 
         def_node_matcher :application_record_const?, <<-PATTERN
-          (const nil :ApplicationRecord)
+          (const nil? :ApplicationRecord)
         PATTERN
 
         def on_class(node)
           klass, superclass, _ = *node
 
           if active_record_base_const?(superclass) && !(application_record_const?(klass))
-            add_offense(superclass, :expression)
+            add_offense(superclass, location: :expression)
           end
         end
       end

data/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb

@@ -9,11 +9,11 @@ module RuboCop
         MSG = "Prefer `render` with string instead of symbol"
 
         def_node_matcher :render_sym?, <<-PATTERN
-          (send nil :render $(sym _))
+          (send nil? :render $(sym _))
         PATTERN
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil :render (hash $...))
+          (send nil? :render (hash $...))
         PATTERN
 
         def_node_matcher :action_key?, <<-PATTERN
@@ -22,11 +22,11 @@ module RuboCop
 
         def on_send(node)
           if sym_node = render_sym?(node)
-            add_offense(sym_node, :expression)
+            add_offense(sym_node, location: :expression)
           elsif option_pairs = render_with_options?(node)
             option_pairs.each do |pair|
               if sym_node = action_key?(pair)
-                add_offense(sym_node, :expression)
+                add_offense(sym_node, location: :expression)
               end
             end
           end

data/lib/rubocop/cop/github/rails_controller_render_literal.rb

@@ -9,19 +9,19 @@ module RuboCop
         MSG = "render must be used with a string literal"
 
         def_node_matcher :literal?, <<-PATTERN
-          ({str sym true false nil} ...)
+          ({str sym true false nil?} ...)
         PATTERN
 
         def_node_matcher :render?, <<-PATTERN
-          (send nil :render ...)
+          (send nil? :render ...)
         PATTERN
 
         def_node_matcher :render_literal?, <<-PATTERN
-          (send nil :render ({str sym} $_) $...)
+          (send nil? :render ({str sym} $_) $...)
         PATTERN
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil :render (hash $...))
+          (send nil? :render (hash $...))
         PATTERN
 
         def_node_matcher :ignore_key?, <<-PATTERN
@@ -73,19 +73,19 @@ module RuboCop
 
             if template_node = option_pairs.map { |pair| template_key?(pair) }.compact.first
               if !literal?(template_node)
-                add_offense(node, :expression)
+                add_offense(node, location: :expression)
               end
             else
-              add_offense(node, :expression)
+              add_offense(node, location: :expression)
             end
 
             if layout_node = option_pairs.map { |pair| layout_key?(pair) }.compact.first
               if !literal?(layout_node)
-                add_offense(node, :expression)
+                add_offense(node, location: :expression)
               end
             end
           else
-            add_offense(node, :expression)
+            add_offense(node, location: :expression)
           end
         end
       end

data/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb

@@ -7,15 +7,15 @@ module RuboCop
     module GitHub
       class RailsControllerRenderPathsExist < Cop
         def_node_matcher :render?, <<-PATTERN
-          (send nil :render $...)
+          (send nil? :render $...)
         PATTERN
 
         def_node_matcher :render_str?, <<-PATTERN
-          (send nil :render $({str sym} $_) ...)
+          (send nil? :render $({str sym} $_) ...)
         PATTERN
 
         def_node_matcher :render_options?, <<-PATTERN
-          (send nil :render (hash $...))
+          (send nil? :render (hash $...))
         PATTERN
 
         def_node_matcher :render_key?, <<-PATTERN
@@ -28,7 +28,7 @@ module RuboCop
           if args = render_str?(node)
             node, path = args
             unless resolve_template(path.to_s)
-              add_offense(node, :expression, "Template could not be found")
+              add_offense(node, location: :expression, message: "Template could not be found")
             end
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| render_key?(p) }
@@ -37,11 +37,11 @@ module RuboCop
               case key
               when :action, :template
                 unless resolve_template(path.to_s)
-                  add_offense(node, :expression, "Template could not be found")
+                  add_offense(node, location: :expression, message: "Template could not be found")
                 end
               when :partial
                 unless resolve_partial(path.to_s)
-                  add_offense(node, :expression, "Partial template could not be found")
+                  add_offense(node, location: :expression, message: "Partial template could not be found")
                 end
               end
             end

data/lib/rubocop/cop/github/rails_controller_render_shorthand.rb

@@ -9,7 +9,7 @@ module RuboCop
         MSG = "Prefer `render` template shorthand"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil :render (hash $...))
+          (send nil? :render (hash $...))
         PATTERN
 
         def_node_matcher :action_key?, <<-PATTERN
@@ -40,7 +40,7 @@ module RuboCop
                 @autocorrect[node] = lambda do |corrector|
                   corrector.replace(node.source_range, corrected_source)
                 end
-                add_offense(node, :expression, "Use `#{corrected_source}` instead")
+                add_offense(node, location: :expression, message: "Use `#{corrected_source}` instead")
               end
             end
           end

data/lib/rubocop/cop/github/rails_render_inline.rb

@@ -9,7 +9,7 @@ module RuboCop
         MSG = "Avoid `render inline:`"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil :render (hash $...))
+          (send nil? :render (hash $...))
         PATTERN
 
         def_node_matcher :inline_key?, <<-PATTERN
@@ -19,7 +19,7 @@ module RuboCop
         def on_send(node)
           if option_pairs = render_with_options?(node)
             if option_pairs.detect { |pair| inline_key?(pair) }
-              add_offense(node, :expression)
+              add_offense(node, location: :expression)
             end
           end
         end

data/lib/rubocop/cop/github/rails_render_object_collection.rb

@@ -9,7 +9,7 @@ module RuboCop
         MSG = "Avoid `render object:`"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil :render (hash $...) ...)
+          (send nil? :render (hash $...) ...)
         PATTERN
 
         def_node_matcher :partial_key?, <<-PATTERN
@@ -34,9 +34,9 @@ module RuboCop
                 if partial_name.children[0].is_a?(String)
                   suggestion = ", instead `render partial: #{partial_name.source}, locals: { #{File.basename(partial_name.children[0], '.html.erb')}: #{object_node.source} }`"
                 end
-                add_offense(node, :expression, "Avoid `render object:`#{suggestion}")
+                add_offense(node, location: :expression, message: "Avoid `render object:`#{suggestion}")
               when :collection, :spacer_template
-                add_offense(node, :expression, "Avoid `render collection:`")
+                add_offense(node, location: :expression, message: "Avoid `render collection:`")
               end
             end
           end

data/lib/rubocop/cop/github/rails_view_render_literal.rb

@@ -9,19 +9,19 @@ module RuboCop
         MSG = "render must be used with a string literal"
 
         def_node_matcher :literal?, <<-PATTERN
-          ({str sym true false nil} ...)
+          ({str sym true false nil?} ...)
         PATTERN
 
         def_node_matcher :render?, <<-PATTERN
-          (send nil :render $...)
+          (send nil? :render $...)
         PATTERN
 
         def_node_matcher :render_literal?, <<-PATTERN
-          (send nil :render ({str sym} $_) $...)
+          (send nil? :render ({str sym} $_) $...)
         PATTERN
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil :render (hash $...) ...)
+          (send nil? :render (hash $...) ...)
         PATTERN
 
         def_node_matcher :ignore_key?, <<-PATTERN
@@ -49,13 +49,13 @@ module RuboCop
 
             if partial_node = option_pairs.map { |pair| partial_key?(pair) }.compact.first
               if !literal?(partial_node)
-                add_offense(node, :expression)
+                add_offense(node, location: :expression)
               end
             else
-              add_offense(node, :expression)
+              add_offense(node, location: :expression)
             end
           else
-            add_offense(node, :expression)
+            add_offense(node, location: :expression)
           end
         end
       end

data/lib/rubocop/cop/github/rails_view_render_paths_exist.rb

@@ -7,15 +7,15 @@ module RuboCop
     module GitHub
       class RailsViewRenderPathsExist < Cop
         def_node_matcher :render?, <<-PATTERN
-          (send nil :render $...)
+          (send nil? :render $...)
         PATTERN
 
         def_node_matcher :render_str?, <<-PATTERN
-          (send nil :render $(str $_) ...)
+          (send nil? :render $(str $_) ...)
         PATTERN
 
         def_node_matcher :render_options?, <<-PATTERN
-          (send nil :render (hash $...))
+          (send nil? :render (hash $...))
         PATTERN
 
         def_node_matcher :partial_key?, <<-PATTERN
@@ -28,14 +28,14 @@ module RuboCop
           if args = render_str?(node)
             node, path = args
             unless resolve_partial(path.to_s)
-              add_offense(node, :expression, "Partial template could not be found")
+              add_offense(node, location: :expression, message: "Partial template could not be found")
             end
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| partial_key?(p) }
               node, path = partial_key?(pair)
 
               unless resolve_partial(path.to_s)
-                add_offense(node, :expression, "Partial template could not be found")
+                add_offense(node, location: :expression, message: "Partial template could not be found")
               end
             end
           end

data/lib/rubocop/cop/github/rails_view_render_shorthand.rb

@@ -9,7 +9,7 @@ module RuboCop
         MSG = "Prefer `render` partial shorthand"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil :render (hash $...))
+          (send nil? :render (hash $...))
         PATTERN
 
         def_node_matcher :partial_key?, <<-PATTERN
@@ -26,9 +26,9 @@ module RuboCop
             locals_key = option_pairs.map { |pair| locals_key?(pair) }.compact.first
 
             if option_pairs.length == 1 && partial_key
-              add_offense(node, :expression, "Use `render #{partial_key.source}` instead")
+              add_offense(node, location: :expression, message: "Use `render #{partial_key.source}` instead")
             elsif option_pairs.length == 2 && partial_key && locals_key
-              add_offense(node, :expression, "Use `render #{partial_key.source}, #{locals_key.source}` instead")
+              add_offense(node, location: :expression, message: "Use `render #{partial_key.source}, #{locals_key.source}` instead")
             end
           end
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-github
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - GitHub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-22 00:00:00.000000000 Z
+date: 2017-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '0.51'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '0.51'
 - !ruby/object:Gem::Dependency
   name: actionview
   requirement: !ruby/object:Gem::Requirement
@@ -125,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: RuboCop GitHub