rubocop-github 0.27.0 → 0.29.0

data/config/default_cops.yml

@@ -1,3 +1,7 @@
 GitHub/InsecureHashAlgorithm:
   Description: 'Encourage usage of secure hash algorithms'
   Enabled: pending
+
+GitHub/UnreliableSubclasses:
+  Description: "Avoid `Class#subclasses` and `Class#descendants`; they miss not-yet-autoloaded classes and depend on GC timing."
+  Enabled: pending

data/config/default_pending.yml

@@ -1,116 +1 @@
-Lint/DuplicateMagicComment: # new in 1.37
-  Enabled: false
-Style/OperatorMethodCall: # new in 1.37
-  Enabled: false
-Style/RedundantStringEscape: # new in 1.37
-  Enabled: false
-Gemspec/DevelopmentDependencies: # new in 1.44
-  Enabled: false
-Lint/DuplicateMatchPattern: # new in 1.50
-  Enabled: false
-Lint/ItWithoutArgumentsInBlock: # new in 1.59
-  Enabled: false
-Lint/LiteralAssignmentInCondition: # new in 1.58
-  Enabled: false
-Lint/MixedCaseRange: # new in 1.53
-  Enabled: false
-Lint/RedundantRegexpQuantifiers: # new in 1.53
-  Enabled: false
-Lint/UselessRescue: # new in 1.43
-  Enabled: false
-Metrics/CollectionLiteralLength: # new in 1.47
-  Enabled: false
-Style/ArrayIntersect: # new in 1.40
-  Enabled: false
-Style/ComparableClamp: # new in 1.44
-  Enabled: false
-Style/ConcatArrayLiterals: # new in 1.41
-  Enabled: false
-Style/DataInheritance: # new in 1.49
-  Enabled: false
-Style/DirEmpty: # new in 1.48
-  Enabled: false
-Style/ExactRegexpMatch: # new in 1.51
-  Enabled: false
-Style/FileEmpty: # new in 1.48
-  Enabled: false
-Style/MapIntoArray: # new in 1.63
-  Enabled: false
-Style/MapToSet: # new in 1.42
-  Enabled: false
-Style/MinMaxComparison: # new in 1.42
-  Enabled: false
-Style/RedundantArrayConstructor: # new in 1.52
-  Enabled: false
-Style/RedundantConstantBase: # new in 1.40
-  Enabled: false
-Style/RedundantCurrentDirectoryInPath: # new in 1.53
-  Enabled: false
-Style/RedundantDoubleSplatHashBraces: # new in 1.41
-  Enabled: false
-Style/RedundantEach: # new in 1.38
-  Enabled: false
-Style/RedundantFilterChain: # new in 1.52
-  Enabled: false
-Style/RedundantHeredocDelimiterQuotes: # new in 1.45
-  Enabled: false
-Style/RedundantLineContinuation: # new in 1.49
-  Enabled: false
-Style/RedundantRegexpArgument: # new in 1.53
-  Enabled: false
-Style/RedundantRegexpConstructor: # new in 1.52
-  Enabled: false
-Style/ReturnNilInPredicateMethodDefinition: # new in 1.53
-  Enabled: false
-Style/SingleLineDoEndBlock: # new in 1.57
-  Enabled: false
-Style/SuperWithArgsParentheses: # new in 1.58
-  Enabled: false
-Style/YAMLFileRead: # new in 1.53
-  Enabled: false
-Performance/MapMethodChain: # new in 1.19
-  Enabled: false
-Gemspec/AddRuntimeDependency: # new in 1.65
-  Enabled: false
-Lint/ConstantReassignment: # new in 1.70
-  Enabled: false
-Lint/DuplicateSetElement: # new in 1.67
-  Enabled: false
-Lint/HashNewWithKeywordArgumentsAsDefault: # new in 1.69
-  Enabled: false
-Lint/NumericOperationWithConstantResult: # new in 1.69
-  Enabled: false
-Lint/SharedMutableDefault: # new in 1.70
-  Enabled: false
-Lint/UnescapedBracketInRegexp: # new in 1.68
-  Enabled: false
-Lint/UselessDefined: # new in 1.69
-  Enabled: false
-Lint/UselessNumericOperation: # new in 1.66
-  Enabled: false
-Style/AmbiguousEndlessMethodDefinition: # new in 1.68
-  Enabled: false
-Style/BitwisePredicate: # new in 1.68
-  Enabled: false
-Style/CombinableDefined: # new in 1.68
-  Enabled: false
-Style/DigChain: # new in 1.69
-  Enabled: false
-Style/FileNull: # new in 1.69
-  Enabled: false
-Style/FileTouch: # new in 1.69
-  Enabled: false
-Style/ItAssignment: # new in 1.70
-  Enabled: false
-Style/KeywordArgumentsMerging: # new in 1.68
-  Enabled: false
-Style/RedundantInterpolationUnfreeze: # new in 1.66
-  Enabled: false
-Style/SafeNavigationChainLength: # new in 1.68
-  Enabled: false
-Style/SendWithLiteralMethodName: # new in 1.64
-  Enabled: false
-Style/SuperArguments: # new in 1.64
-  Enabled: false
-Performance/StringBytesize: # new in 1.23
-  Enabled: false
+# Newly introduced cops awaiting an explicit enabled or disabled decision.

data/config/rails.yml

@@ -60,12 +60,18 @@ Lint/UselessAccessModifier:
   ContextCreatingMethods:
     - concerning
 
+Rails/ActionControllerFlashBeforeRender:
+  Enabled: true
+
 Rails/ActionControllerTestCase:
   Enabled: false
 
 Rails/ActionFilter:
   Enabled: false
 
+Rails/ActionOrder:
+  Enabled: false
+
 Rails/ActiveRecordAliases:
   Enabled: false
 
@@ -78,6 +84,9 @@ Rails/ActiveRecordOverride:
 Rails/ActiveSupportAliases:
   Enabled: false
 
+Rails/ActiveSupportOnLoad:
+  Enabled: true
+
 Rails/AddColumnIndex:
   Enabled: false
 
@@ -123,6 +132,9 @@ Rails/ContentTag:
 Rails/CreateTableWithTimestamps:
   Enabled: false
 
+Rails/DangerousColumnNames:
+  Enabled: true
+
 Rails/Date:
   Enabled: false
 
@@ -159,6 +171,9 @@ Rails/EagerEvaluationLogMessage:
 Rails/EnumHash:
   Enabled: false
 
+Rails/EnumSyntax:
+  Enabled: true
+
 Rails/EnumUniqueness:
   Enabled: false
 
@@ -168,6 +183,9 @@ Rails/EnvironmentComparison:
 Rails/EnvironmentVariableAccess:
   Enabled: false
 
+Rails/EnvLocal:
+  Enabled: true
+
 Rails/Exit:
   Enabled: false
 
@@ -183,9 +201,15 @@ Rails/FindBy:
 Rails/FindById:
   Enabled: false
 
+Rails/FindByOrAssignmentMemoization:
+  Enabled: true
+
 Rails/FindEach:
   Enabled: false
 
+Rails/FreezeTime:
+  Enabled: true
+
 Rails/HasAndBelongsToMany:
   Enabled: false
 
@@ -201,6 +225,9 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   Enabled: false
 
+Rails/HttpStatusNameConsistency:
+  Enabled: false
+
 Rails/I18nLazyLookup:
   Enabled: false
 
@@ -210,6 +237,9 @@ Rails/I18nLocaleAssignment:
 Rails/I18nLocaleTexts:
   Enabled: false
 
+Rails/IgnoredColumnsAssignment:
+  Enabled: true
+
 Rails/IgnoredSkipActionFilterOption:
   Enabled: false
 
@@ -240,12 +270,18 @@ Rails/MatchRoute:
 Rails/MigrationClassName:
   Enabled: false
 
+Rails/MultipleRoutePaths:
+  Enabled: true
+
 Rails/NegateInclude:
   Enabled: false
 
 Rails/NotNullColumn:
   Enabled: false
 
+Rails/OrderArguments:
+  Enabled: false
+
 Rails/OrderById:
   Enabled: false
 
@@ -282,6 +318,12 @@ Rails/RakeEnvironment:
 Rails/ReadWriteAttribute:
   Enabled: false
 
+Rails/RedirectBackOrTo:
+  Enabled: true
+
+Rails/RedundantActiveRecordAllMethod:
+  Enabled: false
+
 Rails/RedundantAllowNil:
   Enabled: false
 
@@ -325,9 +367,15 @@ Rails/ReversibleMigration:
 Rails/ReversibleMigrationMethodDefinition:
   Enabled: false
 
+Rails/ResponseParsedBody:
+  Enabled: false
+
 Rails/RootJoinChain:
   Enabled: false
 
+Rails/RootPathnameMethods:
+  Enabled: false
+
 Rails/RootPublicPath:
   Enabled: false
 
@@ -358,9 +406,15 @@ Rails/SquishedSQLHeredocs:
 Rails/StripHeredoc:
   Enabled: false
 
+Rails/StrongParametersExpect:
+  Enabled: true
+
 Rails/TableNameAssignment:
   Enabled: false
 
+Rails/ThreeStateBooleanColumn:
+  Enabled: true
+
 Rails/TimeZone:
   Enabled: false
 
@@ -370,6 +424,12 @@ Rails/TimeZoneAssignment:
 Rails/ToFormattedS:
   Enabled: false
 
+Rails/TopLevelHashWithIndifferentAccess:
+  Enabled: true
+
+Rails/ToSWithArgument:
+  Enabled: true
+
 Rails/TransactionExitStatement:
   Enabled: false
 
@@ -385,6 +445,9 @@ Rails/UnknownEnv:
 Rails/UnusedIgnoredColumns:
   Enabled: false
 
+Rails/UnusedRenderContent:
+  Enabled: true
+
 Rails/Validation:
   Enabled: false
 
@@ -394,9 +457,18 @@ Rails/WhereEquals:
 Rails/WhereExists:
   Enabled: false
 
+Rails/WhereMissing:
+  Enabled: true
+
 Rails/WhereNot:
   Enabled: false
 
+Rails/WhereNotWithMultipleConditions:
+  Enabled: true
+
+Rails/WhereRange:
+  Enabled: true
+
 Style/For:
   Exclude:
     - "**/*.erb"

data/config/rails_pending.yml

@@ -1,102 +1 @@
-Rails/ActionControllerFlashBeforeRender: # new in 2.16
-  Enabled: false
-Rails/ActionOrder: # new in 2.17
-  Enabled: false
-Rails/ActiveSupportOnLoad: # new in 2.16
-  Enabled: false
-Rails/FreezeTime: # new in 2.16
-  Enabled: false
-Rails/IgnoredColumnsAssignment: # new in 2.17
-  Enabled: false
-Rails/RootPathnameMethods: # new in 2.16
-  Enabled: false
-Rails/ToSWithArgument: # new in 2.16
-  Enabled: false
-Rails/TopLevelHashWithIndifferentAccess: # new in 2.16
-  Enabled: false
-Rails/WhereMissing: # new in 2.16
-  Enabled: false
-Rails/WhereNotWithMultipleConditions: # new in 2.17
-  Enabled: false
-Gemspec/DevelopmentDependencies: # new in 1.44
-  Enabled: false
-Lint/DuplicateMatchPattern: # new in 1.50
-  Enabled: false
-Lint/ItWithoutArgumentsInBlock: # new in 1.59
-  Enabled: false
-Lint/LiteralAssignmentInCondition: # new in 1.58
-  Enabled: false
-Lint/MixedCaseRange: # new in 1.53
-  Enabled: false
-Lint/RedundantRegexpQuantifiers: # new in 1.53
-  Enabled: false
-Lint/UselessRescue: # new in 1.43
-  Enabled: false
-Metrics/CollectionLiteralLength: # new in 1.47
-  Enabled: false
-Style/ArrayIntersect: # new in 1.40
-  Enabled: false
-Style/ComparableClamp: # new in 1.44
-  Enabled: false
-Style/ConcatArrayLiterals: # new in 1.41
-  Enabled: false
-Style/DataInheritance: # new in 1.49
-  Enabled: false
-Style/DirEmpty: # new in 1.48
-  Enabled: false
-Style/ExactRegexpMatch: # new in 1.51
-  Enabled: false
-Style/FileEmpty: # new in 1.48
-  Enabled: false
-Style/MapIntoArray: # new in 1.63
-  Enabled: false
-Style/MapToSet: # new in 1.42
-  Enabled: false
-Style/MinMaxComparison: # new in 1.42
-  Enabled: false
-Style/RedundantArrayConstructor: # new in 1.52
-  Enabled: false
-Style/RedundantConstantBase: # new in 1.40
-  Enabled: false
-Style/RedundantCurrentDirectoryInPath: # new in 1.53
-  Enabled: false
-Style/RedundantDoubleSplatHashBraces: # new in 1.41
-  Enabled: false
-Style/RedundantEach: # new in 1.38
-  Enabled: false
-Style/RedundantFilterChain: # new in 1.52
-  Enabled: false
-Style/RedundantHeredocDelimiterQuotes: # new in 1.45
-  Enabled: false
-Style/RedundantLineContinuation: # new in 1.49
-  Enabled: false
-Style/RedundantRegexpArgument: # new in 1.53
-  Enabled: false
-Style/RedundantRegexpConstructor: # new in 1.52
-  Enabled: false
-Style/ReturnNilInPredicateMethodDefinition: # new in 1.53
-  Enabled: false
-Style/SingleLineDoEndBlock: # new in 1.57
-  Enabled: false
-Style/SuperWithArgsParentheses: # new in 1.58
-  Enabled: false
-Style/YAMLFileRead: # new in 1.53
-  Enabled: false
-Performance/MapMethodChain: # new in 1.19
-  Enabled: false
-Rails/DangerousColumnNames: # new in 2.21
-  Enabled: false
-Rails/EnvLocal: # new in 2.22
-  Enabled: false
-Rails/RedundantActiveRecordAllMethod: # new in 2.21
-  Enabled: false
-Rails/ResponseParsedBody: # new in 2.18
-  Enabled: false
-Rails/ThreeStateBooleanColumn: # new in 2.19
-  Enabled: false
-Rails/UnusedRenderContent: # new in 2.21
-  Enabled: false
-Rails/EnumSyntax: # new in 2.26
-  Enabled: false
-Rails/WhereRange: # new in 2.25
-  Enabled: false
+# Newly introduced cops awaiting an explicit enabled or disabled decision.

data/lib/rubocop/cop/github/rails_view_render_literal.rb

@@ -52,6 +52,7 @@ module RuboCop
             return
           end
 
+          # `many?` is an ActiveSupport extension, but this cop runs without ActiveSupport.
           if render_literal?(node) && node.arguments.count > 1
             locals = node.arguments[1]
           elsif option_pairs = render_with_options?(node)

data/lib/rubocop/cop/github/unreliable_subclasses.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      # Inform people when they reach for Class#subclasses (Ruby) or
+      # Class#descendants (ActiveSupport).
+      #
+      # two reasons these can be unreliable:
+      #   1. autoload hasn't run yet, so half the tree is invisible
+      #   2. GC may have eaten dynamically-defined classes (i.e. in test suites)
+      #
+      # If you really need it, add a rubocop:disable on the line with a note
+      # explaining why future-you won't be sad.
+      class UnreliableSubclasses < Base
+        MSG = "Avoid `%<method>s` here. It may miss not-yet-autoloaded classes and depends on GC timing. " \
+              "Prefer an explicit registry or eager loading."
+
+        RESTRICT_ON_SEND = %i[descendants subclasses].freeze
+
+        # matches Foo.descendants, Foo::Bar.subclasses, self.descendants
+        # receiver has to be a constant or `self`
+        def_node_matcher :unreliable_call?, <<~PATTERN
+          (send {const self} {:descendants :subclasses})
+        PATTERN
+
+        # the same thing but with safe navigation operator
+        def_node_matcher :unreliable_csend?, <<~PATTERN
+          (csend {const self} {:descendants :subclasses})
+        PATTERN
+
+        def on_send(node)
+          return unless unreliable_call?(node)
+
+          add_offense(node, message: format(MSG, method: node.method_name))
+        end
+
+        def on_csend(node)
+          return unless unreliable_csend?(node)
+
+          add_offense(node, message: format(MSG, method: node.method_name))
+        end
+      end
+    end
+  end
+end

data/lib/rubocop-github.rb

@@ -8,3 +8,4 @@ RuboCop::GitHub::Inject.default_defaults!
 
 require "rubocop/cop/github/avoid_object_send_with_dynamic_method"
 require "rubocop/cop/github/insecure_hash_algorithm"
+require "rubocop/cop/github/unreliable_subclasses"

data/lib/version.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-VERSION = "0.27.0"
+VERSION = "0.29.0"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-github
 version: !ruby/object:Gem::Version
-  version: 0.27.0
+  version: 0.29.0
 platform: ruby
 authors:
 - GitHub
 bindir: bin
 cert_chain: []
-date: 2026-03-13 00:00:00.000000000 Z
+date: 2026-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.76'
+        version: '1.91'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.76'
+        version: '1.91'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -43,28 +43,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.23'
+        version: '2.34'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.23'
+        version: '2.34'
 - !ruby/object:Gem::Dependency
   name: actionview
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.2.3
+        version: 8.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.2.3
+        version: 8.1.3
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -124,6 +124,7 @@ files:
 - lib/rubocop/cop/github/rails_view_render_paths_exist.rb
 - lib/rubocop/cop/github/rails_view_render_shorthand.rb
 - lib/rubocop/cop/github/render_literal_helpers.rb
+- lib/rubocop/cop/github/unreliable_subclasses.rb
 - lib/rubocop/github.rb
 - lib/rubocop/github/inject.rb
 - lib/version.rb
@@ -141,7 +142,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.3.0
+      version: 3.4.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="