rubocop-github 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d42ae8bd8c8eeef0abfcd1d6560f1e74dd0e528
-  data.tar.gz: 121f88f09c74fbced513562a09cee6496d6c63cd
+  metadata.gz: 601fcd9953677e8b83264571ab930fb673ce9308
+  data.tar.gz: 7cb82de90efa33ab5bd9f2123938f49a131cb448
 SHA512:
-  metadata.gz: b51ddf7214f92505176be5d3bf9829ed297b73d08a69753c8ff083286534593297190c236f35562503c408e9b7a728f4399e5c5eb60da3880ee64eae59f21592
-  data.tar.gz: e89b66df87c492ea490f559dc02c57e7a16b60c516df0c43497800a269e6a541d491901a4812c568a98e19268841309d82b64f8879d90297b509635ceb0460e6
+  metadata.gz: 0ac31931fe1edf63b4ecb4bf2f1177ea2b7a68a7db69e3ffdb802aaac8be2c4f122c88ac755a9d197d8fa4676b1d3ec2a4717e615b66e1afb07d385f96ed99e8
+  data.tar.gz: a7da9a85c62522bfdee8e3f9a97b4c303ae49af3baf97ab1a647e9b4e3d44042f53a3c646f3b47f5689ce844fee212bda37bc1fae27e574da7eca52834f6af51

data/STYLEGUIDE.md

@@ -0,0 +1,738 @@
+# Ruby Style Guide
+
+* Use soft-tabs with a two space indent.
+
+* Keep each line of code to a readable length. Unless you have a reason to, keep lines to fewer than 100 characters.
+
+* Never leave trailing whitespace.
+
+* End each file with a [newline](https://github.com/bbatsov/ruby-style-guide#newline-eof).
+
+* Use spaces around operators, after commas, colons and semicolons, around `{`
+  and before `}`.
+
+``` ruby
+sum = 1 + 2
+a, b = 1, 2
+1 > 2 ? true : false; puts "Hi"
+[1, 2, 3].each { |e| puts e }
+```
+
+* No spaces after `(`, `[` or before `]`, `)`.
+
+``` ruby
+some(arg).other
+[1, 2, 3].length
+```
+
+* No spaces after `!`.
+
+``` ruby
+!array.include?(element)
+```
+
+* Indent `when` as deep as `case`.
+
+``` ruby
+case
+when song.name == "Misty"
+  puts "Not again!"
+when song.duration > 120
+  puts "Too long!"
+when Time.now.hour > 21
+  puts "It's too late"
+else
+  song.play
+end
+
+kind = case year
+       when 1850..1889 then "Blues"
+       when 1890..1909 then "Ragtime"
+       when 1910..1929 then "New Orleans Jazz"
+       when 1930..1939 then "Swing"
+       when 1940..1950 then "Bebop"
+       else "Jazz"
+       end
+```
+
+* Use empty lines between `def`s and to break up a method into logical
+  paragraphs.
+
+``` ruby
+def some_method
+  data = initialize(options)
+
+  data.manipulate!
+
+  data.result
+end
+
+def some_method
+  result
+end
+```
+
+## Classes
+
+* Avoid the usage of class (`@@`) variables due to their unusual behavior
+in inheritance.
+
+``` ruby
+class Parent
+  @@class_var = "parent"
+
+  def self.print_class_var
+    puts @@class_var
+  end
+end
+
+class Child < Parent
+  @@class_var = "child"
+end
+
+Parent.print_class_var # => will print "child"
+```
+
+    As you can see all the classes in a class hierarchy actually share one
+    class variable. Class instance variables should usually be preferred
+    over class variables.
+
+* Use `def self.method` to define singleton methods. This makes the methods
+  more resistant to refactoring changes.
+
+``` ruby
+class TestClass
+  # bad
+  def TestClass.some_method
+    # body omitted
+  end
+
+  # good
+  def self.some_other_method
+    # body omitted
+  end
+```
+
+* Avoid `class << self` except when necessary, e.g. single accessors and aliased
+  attributes.
+
+``` ruby
+class TestClass
+  # bad
+  class << self
+    def first_method
+      # body omitted
+    end
+
+    def second_method_etc
+      # body omitted
+    end
+  end
+
+  # good
+  class << self
+    attr_accessor :per_page
+    alias_method :nwo, :find_by_name_with_owner
+  end
+
+  def self.first_method
+    # body omitted
+  end
+
+  def self.second_method_etc
+    # body omitted
+  end
+end
+```
+
+* Indent the `public`, `protected`, and `private` methods as much the
+  method definitions they apply to. Leave one blank line above them.
+
+``` ruby
+class SomeClass
+  def public_method
+    # ...
+  end
+
+  private
+  def private_method
+    # ...
+  end
+end
+```
+
+* Avoid explicit use of `self` as the recipient of internal class or instance
+  messages unless to specify a method shadowed by a variable.
+
+``` ruby
+class SomeClass
+  attr_accessor :message
+
+  def greeting(name)
+    message = "Hi #{name}" # local variable in Ruby, not attribute writer
+    self.message = message
+  end
+end
+```
+
+## Collections
+
+* Prefer `%w` to the literal array syntax when you need an array of
+strings.
+
+``` ruby
+# bad
+STATES = ["draft", "open", "closed"]
+
+# good
+STATES = %w(draft open closed)
+```
+
+* Use `Set` instead of `Array` when dealing with unique elements. `Set`
+  implements a collection of unordered values with no duplicates. This
+  is a hybrid of `Array`'s intuitive inter-operation facilities and
+  `Hash`'s fast lookup.
+
+* Use symbols instead of strings as hash keys.
+
+``` ruby
+# bad
+hash = { "one" => 1, "two" => 2, "three" => 3 }
+
+# good
+hash = { one: 1, two: 2, three: 3 }
+```
+
+## Documentation
+
+Use [TomDoc](http://tomdoc.org) to the best of your ability. It's pretty sweet:
+
+``` ruby
+# Public: Duplicate some text an arbitrary number of times.
+#
+# text  - The String to be duplicated.
+# count - The Integer number of times to duplicate the text.
+#
+# Examples
+#
+#   multiplex("Tom", 4)
+#   # => "TomTomTomTom"
+#
+# Returns the duplicated String.
+def multiplex(text, count)
+  text * count
+end
+```
+
+## Exceptions
+
+* Don't use exceptions for flow of control.
+
+``` ruby
+# bad
+begin
+  n / d
+rescue ZeroDivisionError
+  puts "Cannot divide by 0!"
+end
+
+# good
+if d.zero?
+  puts "Cannot divide by 0!"
+else
+  n / d
+end
+```
+
+* Rescue specific exceptions, not `StandardError` or its superclasses.
+
+``` ruby
+# bad
+begin
+  # an exception occurs here
+rescue
+  # exception handling
+end
+
+# still bad
+begin
+  # an exception occurs here
+rescue Exception
+  # exception handling
+end
+```
+
+## Hashes
+
+Use the Ruby 1.9 syntax for hash literals when all the keys are symbols:
+
+``` ruby
+# good
+user = {
+  login: "defunkt",
+  name: "Chris Wanstrath"
+}
+
+# bad
+user = {
+  :login => "defunkt",
+  :name => "Chris Wanstrath"
+}
+
+```
+
+Use the 1.9 syntax when calling a method with Hash options arguments or named arguments:
+
+``` ruby
+# good
+user = User.create(login: "jane")
+link_to("Account", controller: "users", action: "show", id: user)
+
+# bad
+user = User.create(:login => "jane")
+link_to("Account", :controller => "users", :action => "show", :id => user)
+```
+
+If you have a hash with mixed key types, use the legacy hashrocket style to avoid mixing styles within the same hash:
+
+``` ruby
+# good
+hsh = {
+  :user_id => 55,
+  "followers-count" => 1000
+}
+
+# bad
+hsh = {
+  user_id: 55,
+  "followers-count" => 1000
+}
+```
+
+## Keyword Arguments
+
+[Keyword arguments](http://magazine.rubyist.net/?Ruby200SpecialEn-kwarg) are recommended but not required when a method's arguments may otherwise be opaque or non-obvious when called. Additionally, prefer them over the old "Hash as pseudo-named args" style from pre-2.0 ruby.
+
+So instead of this:
+``` ruby
+def remove_member(user, skip_membership_check=false)
+  # ...
+end
+
+# Elsewhere: what does true mean here?
+remove_member(user, true)
+```
+
+Do this, which is much clearer.
+``` ruby
+def remove_member(user, skip_membership_check: false)
+  # ...
+end
+
+# Elsewhere, now with more clarity:
+remove_member user, skip_membership_check: true
+```
+
+## Naming
+
+* Use `snake_case` for methods and variables.
+
+* Use `CamelCase` for classes and modules.  (Keep acronyms like HTTP,
+  RFC, XML uppercase.)
+
+* Use `SCREAMING_SNAKE_CASE` for other constants.
+
+* The names of predicate methods (methods that return a boolean value)
+  should end in a question mark. (i.e. `Array#empty?`).
+
+* The names of potentially "dangerous" methods (i.e. methods that modify `self` or the
+  arguments, `exit!`, etc.) should end with an exclamation mark. Bang methods
+  should only exist if a non-bang method exists. ([More on this](http://dablog.rubypal.com/2007/8/15/bang-methods-or-danger-will-rubyist)).
+
+## Percent Literals
+
+* Use `%w` freely.
+
+``` ruby
+STATES = %w(draft open closed)
+```
+
+* Use `%()` for single-line strings which require both interpolation
+  and embedded double-quotes. For multi-line strings, prefer heredocs.
+
+``` ruby
+# bad (no interpolation needed)
+%(<div class="text">Some text</div>)
+# should be "<div class=\"text\">Some text</div>"
+
+# bad (no double-quotes)
+%(This is #{quality} style)
+# should be "This is #{quality} style"
+
+# bad (multiple lines)
+%(<div>\n<span class="big">#{exclamation}</span>\n</div>)
+# should be a heredoc.
+
+# good (requires interpolation, has quotes, single line)
+%(<tr><td class="name">#{name}</td>)
+```
+
+* Use `%r` only for regular expressions matching *more than* one '/' character.
+
+``` ruby
+# bad
+%r(\s+)
+
+# still bad
+%r(^/(.*)$)
+# should be /^\/(.*)$/
+
+# good
+%r(^/blog/2011/(.*)$)
+```
+
+## Regular Expressions
+
+* Avoid using $1-9 as it can be hard to track what they contain. Named groups
+  can be used instead.
+
+``` ruby
+# bad
+/(regexp)/ =~ string
+...
+process $1
+
+# good
+/(?<meaningful_var>regexp)/ =~ string
+...
+process meaningful_var
+```
+
+* Be careful with `^` and `$` as they match start/end of line, not string endings.
+  If you want to match the whole string use: `\A` and `\z`.
+
+``` ruby
+string = "some injection\nusername"
+string[/^username$/]   # matches
+string[/\Ausername\z/] # don't match
+```
+
+* Use `x` modifier for complex regexps. This makes them more readable and you
+  can add some useful comments. Just be careful as spaces are ignored.
+
+``` ruby
+regexp = %r{
+  start         # some text
+  \s            # white space char
+  (group)       # first group
+  (?:alt1|alt2) # some alternation
+  end
+}x
+```
+
+## Requires
+
+Always `require` dependencies used directly in a script at the start of the same file.
+Resources that will get autoloaded on first use—such as Rails models, controllers, or
+helpers—don't need to be required.
+
+``` ruby
+require "set"
+require "time"
+
+%w(foo bar).to_set
+Time.parse("2015-10-21")
+```
+
+This not only loads the necessary dependencies if they haven't already, but acts as
+documentation about the libraries that the current file uses.
+
+## Strings
+
+* Prefer string interpolation instead of string concatenation:
+
+``` ruby
+# bad
+email_with_name = user.name + " <" + user.email + ">"
+
+# good
+email_with_name = "#{user.name} <#{user.email}>"
+```
+
+* Use double-quoted strings. Interpolation and escaped characters
+  will always work without a delimiter change, and `'` is a lot more
+  common than `"` in string literals.
+
+``` ruby
+# bad
+name = 'Bozhidar'
+
+# good
+name = "Bozhidar"
+```
+
+* Avoid using `String#+` when you need to construct large data chunks.
+  Instead, use `String#<<`. Concatenation mutates the string instance in-place
+  and is always faster than `String#+`, which creates a bunch of new string objects.
+
+``` ruby
+# good and also fast
+html = ""
+html << "<h1>Page title</h1>"
+
+paragraphs.each do |paragraph|
+  html << "<p>#{paragraph}</p>"
+end
+```
+
+## Syntax
+
+* Use `def` with parentheses when there are arguments. Omit the
+  parentheses when the method doesn't accept any arguments.
+
+ ``` ruby
+ def some_method
+   # body omitted
+ end
+
+ def some_method_with_arguments(arg1, arg2)
+   # body omitted
+ end
+ ```
+
+* Never use `for`, unless you know exactly why. Most of the time iterators
+  should be used instead. `for` is implemented in terms of `each` (so
+  you're adding a level of indirection), but with a twist - `for`
+  doesn't introduce a new scope (unlike `each`) and variables defined
+  in its block will be visible outside it.
+
+``` ruby
+arr = [1, 2, 3]
+
+# bad
+for elem in arr do
+  puts elem
+end
+
+# good
+arr.each { |elem| puts elem }
+```
+
+* Never use `then` for multi-line `if/unless`.
+
+``` ruby
+# bad
+if some_condition then
+  # body omitted
+end
+
+# good
+if some_condition
+  # body omitted
+end
+```
+
+* Avoid the ternary operator (`?:`) except in cases where all expressions are extremely
+  trivial. However, do use the ternary operator(`?:`) over `if/then/else/end` constructs
+  for single line conditionals.
+
+``` ruby
+# bad
+result = if some_condition then something else something_else end
+
+# good
+result = some_condition ? something : something_else
+```
+
+* Use one expression per branch in a ternary operator. This
+  also means that ternary operators must not be nested. Prefer
+  `if/else` constructs in these cases.
+
+``` ruby
+# bad
+some_condition ? (nested_condition ? nested_something : nested_something_else) : something_else
+
+# good
+if some_condition
+  nested_condition ? nested_something : nested_something_else
+else
+  something_else
+end
+```
+
+* The `and` and `or` keywords are banned. It's just not worth it. Always use `&&` and `||` instead.
+
+* Avoid multi-line `?:` (the ternary operator), use `if/unless` instead.
+
+* Favor modifier `if/unless` usage when you have a single-line
+  body.
+
+``` ruby
+# bad
+if some_condition
+  do_something
+end
+
+# good
+do_something if some_condition
+```
+
+* Never use `unless` with `else`. Rewrite these with the positive case first.
+
+``` ruby
+# bad
+unless success?
+  puts "failure"
+else
+  puts "success"
+end
+
+# good
+if success?
+  puts "success"
+else
+  puts "failure"
+end
+```
+
+* Don't use parentheses around the condition of an `if/unless/while`.
+
+``` ruby
+# bad
+if (x > 10)
+  # body omitted
+end
+
+# good
+if x > 10
+  # body omitted
+end
+```
+
+* Prefer `{...}` over `do...end` for single-line blocks.  Avoid using
+  `{...}` for multi-line blocks (multiline chaining is always
+  ugly). Always use `do...end` for "control flow" and "method
+  definitions" (e.g. in Rakefiles and certain DSLs).  Avoid `do...end`
+  when chaining.
+
+``` ruby
+names = ["Bozhidar", "Steve", "Sarah"]
+
+# good
+names.each { |name| puts name }
+
+# bad
+names.each do |name|
+  puts name
+end
+
+# good
+names.select { |name| name.start_with?("S") }.map { |name| name.upcase }
+
+# bad
+names.select do |name|
+  name.start_with?("S")
+end.map { |name| name.upcase }
+```
+
+    Some will argue that multiline chaining would look OK with the use of {...}, but they should
+    ask themselves - is this code really readable and can't the block's contents be extracted into
+    nifty methods?
+
+* Avoid `return` where not required.
+
+``` ruby
+# bad
+def some_method(some_arr)
+  return some_arr.size
+end
+
+# good
+def some_method(some_arr)
+  some_arr.size
+end
+```
+
+* Use spaces around the `=` operator when assigning default values to method parameters:
+
+``` ruby
+# bad
+def some_method(arg1=:default, arg2=nil, arg3=[])
+  # do something...
+end
+
+# good
+def some_method(arg1 = :default, arg2 = nil, arg3 = [])
+  # do something...
+end
+```
+
+While several Ruby books suggest the first style, the second is much more prominent
+in practice (and arguably a bit more readable).
+
+* Using the return value of `=` (an assignment) is ok.
+
+``` ruby
+# bad
+if (v = array.grep(/foo/)) ...
+
+# good
+if v = array.grep(/foo/) ...
+
+# also good - has correct precedence.
+if (v = next_value) == "hello" ...
+```
+
+* Use `||=` freely to initialize variables.
+
+``` ruby
+# set name to Bozhidar, only if it's nil or false
+name ||= "Bozhidar"
+```
+
+* Don't use `||=` to initialize boolean variables. (Consider what
+  would happen if the current value happened to be `false`.)
+
+``` ruby
+# bad - would set enabled to true even if it was false
+enabled ||= true
+
+# good
+enabled = true if enabled.nil?
+```
+
+* Avoid using Perl-style special variables (like `$0-9`, `$`,
+  etc. ). They are quite cryptic and their use in anything but
+  one-liner scripts is discouraged. Prefer long form versions such as
+  `$PROGRAM_NAME`.
+
+* Never put a space between a method name and the opening parenthesis.
+
+``` ruby
+# bad
+f (3 + 2) + 1
+
+# good
+f(3 + 2) + 1
+```
+
+* If the first argument to a method begins with an open parenthesis,
+  always use parentheses in the method invocation. For example, write
+`f((3 + 2) + 1)`.
+
+* Use `_` for unused block parameters.
+
+``` ruby
+# bad
+result = hash.map { |k, v| v + 1 }
+
+# good
+result = hash.map { |_, v| v + 1 }
+```
+
+* Don't use the `===` (threequals) operator to check types. `===` is mostly an
+  implementation detail to support Ruby features like `case`, and it's not commutative.
+  For example, `String === "hi"` is true and `"hi" === String` is false.
+  Instead, use `is_a?` or `kind_of?` if you must.
+
+  Refactoring is even better. It's worth looking hard at any code that explicitly checks types.

data/config/default.yml

@@ -48,15 +48,16 @@ Lint/EndAlignment:
 Lint/EnsureReturn:
   Enabled: true
 
-Lint/Eval:
-  Enabled: true
-
 Lint/FloatOutOfRange:
   Enabled: true
 
 Lint/FormatParameterMismatch:
   Enabled: true
 
+Style/HashSyntax:
+  Enabled: true
+  EnforcedStyle: ruby19
+
 Lint/InvalidCharacterLiteral:
   Enabled: true
 
@@ -105,6 +106,36 @@ Lint/UselessSetterCall:
 Lint/Void:
   Enabled: true
 
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
 Performance/CaseWhenSplat:
   Enabled: false
 
@@ -154,6 +185,9 @@ Performance/Size:
 Performance/StartWith:
   Enabled: true
 
+Security/Eval:
+  Enabled: true
+
 Style/ArrayJoin:
   Enabled: true
 
@@ -181,6 +215,9 @@ Style/ClassAndModuleCamelCase:
 Style/ClassMethods:
   Enabled: true
 
+Style/Copyright:
+  Enabled: false
+
 Style/DefWithParentheses:
   Enabled: true
 
@@ -208,7 +245,7 @@ Style/InitialIndentation:
 Style/LambdaCall:
   Enabled: true
 
-Style/MethodCallParentheses:
+Style/MethodCallWithoutArgsParentheses:
   Enabled: true
 
 Style/MethodDefParentheses:

data/config/rails.yml

@@ -38,6 +38,10 @@ Style/OneLineConditional:
   Exclude:
     - 'app/views/**/*.erb'
 
+Style/Semicolon:
+  Exclude:
+    - 'app/views/**/*.erb'
+
 Style/SpaceInsideParens:
   Exclude:
     - 'app/views/**/*.erb'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-github
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - GitHub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-29 00:00:00.000000000 Z
+date: 2017-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.47'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.47'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -60,6 +60,7 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - README.md
+- STYLEGUIDE.md
 - config/default.yml
 - config/rails.yml
 - lib/rubocop/cop/github.rb