rubocop-github 0.18.0 → 0.20.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-github
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.20.0
 platform: ruby
 authors:
 - GitHub
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-27 00:00:00.000000000 Z
+date: 2022-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.37'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.37'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.15'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.17'
 - !ruby/object:Gem::Dependency
   name: actionview
   requirement: !ruby/object:Gem::Requirement
@@ -104,23 +104,28 @@ files:
 - README.md
 - STYLEGUIDE.md
 - config/default.yml
+- config/default_cops.yml
+- config/default_pending.yml
 - config/rails.yml
+- config/rails_cops.yml
+- config/rails_pending.yml
 - guides/rails-controller-render-shorthand.md
-- guides/rails-render-inline.md
 - guides/rails-render-literal.md
+- lib/rubocop-github-rails.rb
+- lib/rubocop-github.rb
 - lib/rubocop/cop/github.rb
 - lib/rubocop/cop/github/insecure_hash_algorithm.rb
-- lib/rubocop/cop/github/rails_application_record.rb
 - lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
 - lib/rubocop/cop/github/rails_controller_render_literal.rb
 - lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
 - lib/rubocop/cop/github/rails_controller_render_shorthand.rb
-- lib/rubocop/cop/github/rails_render_inline.rb
 - lib/rubocop/cop/github/rails_render_object_collection.rb
 - lib/rubocop/cop/github/rails_view_render_literal.rb
 - lib/rubocop/cop/github/rails_view_render_paths_exist.rb
 - lib/rubocop/cop/github/rails_view_render_shorthand.rb
 - lib/rubocop/cop/github/render_literal_helpers.rb
+- lib/rubocop/github.rb
+- lib/rubocop/github/inject.rb
 homepage: https://github.com/github/rubocop-github
 licenses:
 - MIT
@@ -140,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: RuboCop GitHub

data/guides/rails-render-inline.md

@@ -1,27 +0,0 @@
-# GitHub/RailsRenderInline
-
-tldr; Do not use `render inline:`.
-
-## Rendering plain text
-
-``` ruby
-render inline: "Just plain text" # bad
-```
-
-The `inline:` option is often misused when plain text is being returned. Instead use `render plain: "Just plain text"`.
-
-## Rendering a dynamic ERB string
-
-String `#{}` interpolation is often misused with `render inline:` instead of using `<%= %>` interpolation. This will lead to a memory leak where an ERB method will be compiled and cached for each invocation of `render inline:`.
-
-``` ruby
-render inline: "Hello #{@name}" # bad
-```
-
-## Rendering static ERB strings
-
-``` ruby
-render inline: "Hello <%= @name %>" # bad
-```
-
-If you are passing a static ERB string to `render inline:`, this string is best moved to a `.erb` template under `app/views`. Template files are able to be precompiled at boot time.

data/lib/rubocop/cop/github/rails_application_record.rb

@@ -1,29 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      class RailsApplicationRecord < Base
-        MSG = "Models should subclass from ApplicationRecord"
-
-        def_node_matcher :active_record_base_const?, <<-PATTERN
-          (const (const nil? :ActiveRecord) :Base)
-        PATTERN
-
-        def_node_matcher :application_record_const?, <<-PATTERN
-          (const nil? :ApplicationRecord)
-        PATTERN
-
-        def on_class(node)
-          klass, superclass, _ = *node
-
-          if active_record_base_const?(superclass) && !(application_record_const?(klass))
-            add_offense(superclass)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/github/rails_render_inline.rb

@@ -1,29 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      class RailsRenderInline < Base
-        MSG = "Avoid `render inline:`"
-
-        def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? {:render :render_to_string} (hash $...))
-        PATTERN
-
-        def_node_matcher :inline_key?, <<-PATTERN
-          (pair (sym :inline) $_)
-        PATTERN
-
-        def on_send(node)
-          if option_pairs = render_with_options?(node)
-            if option_pairs.detect { |pair| inline_key?(pair) }
-              add_offense(node)
-            end
-          end
-        end
-      end
-    end
-  end
-end