rubocop-github 0.12.0 → 0.16.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (24) hide show
  1. checksums.yaml +5 -5
  2. data/README.md +31 -2
  3. data/STYLEGUIDE.md +27 -11
  4. data/config/_default_shared.yml +329 -0
  5. data/config/_rails_shared.yml +120 -0
  6. data/config/default.yml +2 -326
  7. data/config/default_deprecated.yml +4 -0
  8. data/config/default_edge.yml +4 -0
  9. data/config/rails.yml +2 -118
  10. data/config/rails_deprecated.yml +7 -0
  11. data/config/rails_edge.yml +4 -0
  12. data/lib/rubocop/cop/github.rb +1 -0
  13. data/lib/rubocop/cop/github/insecure_hash_algorithm.rb +139 -0
  14. data/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb +2 -2
  15. data/lib/rubocop/cop/github/rails_controller_render_literal.rb +31 -16
  16. data/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb +3 -3
  17. data/lib/rubocop/cop/github/rails_controller_render_shorthand.rb +1 -1
  18. data/lib/rubocop/cop/github/rails_render_inline.rb +1 -1
  19. data/lib/rubocop/cop/github/rails_render_object_collection.rb +1 -1
  20. data/lib/rubocop/cop/github/rails_view_render_literal.rb +26 -16
  21. data/lib/rubocop/cop/github/rails_view_render_paths_exist.rb +3 -3
  22. data/lib/rubocop/cop/github/rails_view_render_shorthand.rb +1 -1
  23. data/lib/rubocop/cop/github/render_literal_helpers.rb +54 -0
  24. metadata +49 -14
data/config/_rails_shared.yml ADDED
@@ -0,0 +1,120 @@
1
+ Rails/OutputSafety:
2
+ Enabled: true
3
+
4
+ Rails/PluralizationGrammar:
5
+ Enabled: true
6
+
7
+ Rails/RequestReferer:
8
+ Enabled: true
9
+ EnforcedStyle: referrer
10
+
11
+ Rails/ScopeArgs:
12
+ Enabled: true
13
+
14
+ Rails/UniqBeforePluck:
15
+ Enabled: true
16
+
17
+ GitHub/RailsApplicationRecord:
18
+ Enabled: true
19
+
20
+ GitHub/RailsControllerRenderActionSymbol:
21
+ Enabled: true
22
+ Include:
23
+ - 'app/controllers/**/*.rb'
24
+
25
+ GitHub/RailsControllerRenderLiteral:
26
+ Enabled: true
27
+ StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
28
+ Include:
29
+ - 'app/controllers/**/*.rb'
30
+
31
+ GitHub/RailsControllerRenderPathsExist:
32
+ Enabled: true
33
+ ViewPath:
34
+ - 'app/views'
35
+ Include:
36
+ - 'app/controllers/**/*.rb'
37
+
38
+ GitHub/RailsControllerRenderShorthand:
39
+ Enabled: true
40
+ StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-shorthand.md
41
+ Include:
42
+ - 'app/controllers/**/*.rb'
43
+
44
+ GitHub/RailsRenderInline:
45
+ Enabled: true
46
+ StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-inline.md
47
+ Include:
48
+ - 'app/controllers/**/*.rb'
49
+ - 'app/helpers/**/*.rb'
50
+ - 'app/view_models/**/*.rb'
51
+ - 'app/views/**/*.erb'
52
+
53
+ GitHub/RailsRenderObjectCollection:
54
+ Enabled: false
55
+
56
+ GitHub/RailsViewRenderLiteral:
57
+ Enabled: true
58
+ StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
59
+ Include:
60
+ - 'app/helpers/**/*.rb'
61
+ - 'app/view_models/**/*.rb'
62
+ - 'app/views/**/*.erb'
63
+
64
+ GitHub/RailsViewRenderPathsExist:
65
+ Enabled: true
66
+ ViewPath:
67
+ - 'app/views'
68
+ Include:
69
+ - 'app/helpers/**/*.rb'
70
+ - 'app/view_models/**/*.rb'
71
+ - 'app/views/**/*.erb'
72
+
73
+ GitHub/RailsViewRenderShorthand:
74
+ Enabled: true
75
+ Include:
76
+ - 'app/helpers/**/*.rb'
77
+ - 'app/view_models/**/*.rb'
78
+ - 'app/views/**/*.erb'
79
+
80
+ # Exclude Rails ERB files from incompatible cops
81
+
82
+ Layout/BlockAlignment:
83
+ Exclude:
84
+ - 'app/views/**/*.erb'
85
+
86
+ Style/For:
87
+ Exclude:
88
+ - 'app/views/**/*.erb'
89
+
90
+ Style/OneLineConditional:
91
+ Exclude:
92
+ - 'app/views/**/*.erb'
93
+
94
+ Style/Semicolon:
95
+ Exclude:
96
+ - 'app/views/**/*.erb'
97
+
98
+ Layout/SpaceInsideParens:
99
+ Exclude:
100
+ - 'app/views/**/*.erb'
101
+
102
+ Style/StringLiterals:
103
+ Exclude:
104
+ - 'app/views/**/*.erb'
105
+
106
+ Layout/TrailingEmptyLines:
107
+ Exclude:
108
+ - 'app/views/**/*.erb'
109
+
110
+ Layout/TrailingWhitespace:
111
+ Exclude:
112
+ - 'app/views/**/*.erb'
113
+
114
+ Layout/InitialIndentation:
115
+ Exclude:
116
+ - 'app/views/**/*.erb'
117
+
118
+ Lint/UselessAccessModifier:
119
+ ContextCreatingMethods:
120
+ - concerning
data/config/default.yml CHANGED
@@ -1,326 +1,2 @@
1
- require: rubocop/cop/github
2
-
3
- AllCops:
4
- DisabledByDefault: true
5
-
6
- Bundler/DuplicatedGem:
7
- Enabled: true
8
-
9
- Bundler/OrderedGems:
10
- Enabled: true
11
-
12
- Layout/BlockAlignment:
13
- Enabled: true
14
-
15
- Layout/BlockEndNewline:
16
- Enabled: true
17
-
18
- Layout/ConditionPosition:
19
- Enabled: true
20
-
21
- Layout/DefEndAlignment:
22
- Enabled: true
23
-
24
- Layout/EndAlignment:
25
- Enabled: false
26
-
27
- Layout/EndOfLine:
28
- Enabled: true
29
-
30
- Layout/InitialIndentation:
31
- Enabled: true
32
-
33
- Layout/SpaceAfterColon:
34
- Enabled: true
35
-
36
- Layout/SpaceAfterComma:
37
- Enabled: true
38
-
39
- Layout/SpaceAfterMethodName:
40
- Enabled: true
41
-
42
- Layout/SpaceAfterNot:
43
- Enabled: true
44
-
45
- Layout/SpaceAfterSemicolon:
46
- Enabled: true
47
-
48
- Layout/SpaceAroundBlockParameters:
49
- Enabled: true
50
-
51
- Layout/SpaceAroundEqualsInParameterDefault:
52
- Enabled: true
53
-
54
- Layout/SpaceBeforeBlockBraces:
55
- Enabled: true
56
-
57
- Layout/SpaceInsideArrayLiteralBrackets:
58
- Enabled: true
59
- EnforcedStyle: no_space
60
-
61
- Layout/SpaceInsideArrayPercentLiteral:
62
- Enabled: true
63
-
64
- Layout/SpaceInsideBlockBraces:
65
- Enabled: true
66
-
67
- Layout/SpaceInsideParens:
68
- Enabled: true
69
-
70
- Layout/SpaceInsideRangeLiteral:
71
- Enabled: true
72
-
73
- Layout/SpaceInsideReferenceBrackets:
74
- Enabled: true
75
-
76
- Layout/Tab:
77
- Enabled: true
78
-
79
- Layout/TrailingBlankLines:
80
- Enabled: true
81
-
82
- Layout/TrailingWhitespace:
83
- Enabled: true
84
-
85
- Lint/CircularArgumentReference:
86
- Enabled: true
87
-
88
- Lint/Debugger:
89
- Enabled: true
90
-
91
- Lint/DeprecatedClassMethods:
92
- Enabled: true
93
-
94
- Lint/DuplicateMethods:
95
- Enabled: true
96
-
97
- Lint/DuplicatedKey:
98
- Enabled: true
99
-
100
- Lint/EachWithObjectArgument:
101
- Enabled: true
102
-
103
- Lint/ElseLayout:
104
- Enabled: true
105
-
106
- Lint/EmptyEnsure:
107
- Enabled: true
108
-
109
- Lint/EmptyInterpolation:
110
- Enabled: true
111
-
112
- Lint/EndInMethod:
113
- Enabled: true
114
-
115
- Lint/EnsureReturn:
116
- Enabled: true
117
-
118
- Lint/FloatOutOfRange:
119
- Enabled: true
120
-
121
- Lint/FormatParameterMismatch:
122
- Enabled: true
123
-
124
- Lint/LiteralAsCondition:
125
- Enabled: true
126
-
127
- Lint/LiteralInInterpolation:
128
- Enabled: true
129
-
130
- Lint/Loop:
131
- Enabled: true
132
-
133
- Lint/NextWithoutAccumulator:
134
- Enabled: true
135
-
136
- Lint/RandOne:
137
- Enabled: true
138
-
139
- Lint/RequireParentheses:
140
- Enabled: true
141
-
142
- Lint/RescueException:
143
- Enabled: true
144
-
145
- Lint/StringConversionInInterpolation:
146
- Enabled: true
147
-
148
- Lint/UnderscorePrefixedVariableName:
149
- Enabled: true
150
-
151
- Lint/UnneededCopDisableDirective:
152
- Enabled: true
153
-
154
- Lint/UnneededSplatExpansion:
155
- Enabled: true
156
-
157
- Lint/UnreachableCode:
158
- Enabled: true
159
-
160
- Lint/UselessComparison:
161
- Enabled: true
162
-
163
- Lint/UselessSetterCall:
164
- Enabled: true
165
-
166
- Lint/Void:
167
- Enabled: true
168
-
169
- Metrics/AbcSize:
170
- Enabled: false
171
-
172
- Metrics/BlockLength:
173
- Enabled: false
174
-
175
- Metrics/BlockNesting:
176
- Enabled: false
177
-
178
- Metrics/ClassLength:
179
- Enabled: false
180
-
181
- Metrics/CyclomaticComplexity:
182
- Enabled: false
183
-
184
- Metrics/LineLength:
185
- Enabled: false
186
-
187
- Metrics/MethodLength:
188
- Enabled: false
189
-
190
- Metrics/ModuleLength:
191
- Enabled: false
192
-
193
- Metrics/ParameterLists:
194
- Enabled: false
195
-
196
- Metrics/PerceivedComplexity:
197
- Enabled: false
198
-
199
- Naming/AsciiIdentifiers:
200
- Enabled: true
201
-
202
- Naming/ClassAndModuleCamelCase:
203
- Enabled: true
204
-
205
- Naming/FileName:
206
- Enabled: true
207
-
208
- Naming/MethodName:
209
- Enabled: true
210
-
211
- Performance/CaseWhenSplat:
212
- Enabled: false
213
-
214
- Performance/Count:
215
- Enabled: true
216
-
217
- Performance/Detect:
218
- Enabled: true
219
-
220
- Performance/DoubleStartEndWith:
221
- Enabled: true
222
-
223
- Performance/EndWith:
224
- Enabled: true
225
-
226
- Performance/FlatMap:
227
- Enabled: true
228
-
229
- Performance/LstripRstrip:
230
- Enabled: true
231
-
232
- Performance/RangeInclude:
233
- Enabled: false
234
-
235
- Performance/RedundantMatch:
236
- Enabled: false
237
-
238
- Performance/RedundantMerge:
239
- Enabled: true
240
- MaxKeyValuePairs: 1
241
-
242
- Performance/RedundantSortBy:
243
- Enabled: true
244
-
245
- Performance/ReverseEach:
246
- Enabled: true
247
-
248
- Performance/Sample:
249
- Enabled: true
250
-
251
- Performance/Size:
252
- Enabled: true
253
-
254
- Performance/StartWith:
255
- Enabled: true
256
-
257
- Security/Eval:
258
- Enabled: true
259
-
260
- Style/ArrayJoin:
261
- Enabled: true
262
-
263
- Style/BeginBlock:
264
- Enabled: true
265
-
266
- Style/BlockComments:
267
- Enabled: true
268
-
269
- Style/CaseEquality:
270
- Enabled: true
271
-
272
- Style/CharacterLiteral:
273
- Enabled: true
274
-
275
- Style/ClassMethods:
276
- Enabled: true
277
-
278
- Style/Copyright:
279
- Enabled: false
280
-
281
- Style/DefWithParentheses:
282
- Enabled: true
283
-
284
- Style/EndBlock:
285
- Enabled: true
286
-
287
- Style/FlipFlop:
288
- Enabled: true
289
-
290
- Style/For:
291
- Enabled: true
292
-
293
- Style/FrozenStringLiteralComment:
294
- Enabled: true
295
-
296
- Style/HashSyntax:
297
- Enabled: true
298
- EnforcedStyle: ruby19_no_mixed_keys
299
-
300
- Style/LambdaCall:
301
- Enabled: true
302
-
303
- Style/MethodCallWithoutArgsParentheses:
304
- Enabled: true
305
-
306
- Style/MethodDefParentheses:
307
- Enabled: true
308
-
309
- Style/MultilineIfThen:
310
- Enabled: true
311
-
312
- Style/NilComparison:
313
- Enabled: true
314
-
315
- Style/Not:
316
- Enabled: true
317
-
318
- Style/OneLineConditional:
319
- Enabled: true
320
-
321
- Style/StabbyLambdaParentheses:
322
- Enabled: true
323
-
324
- Style/StringLiterals:
325
- Enabled: true
326
- EnforcedStyle: double_quotes
1
+ # Inherit from default_deprecated until 1.0
2
+ inherit_from: default_deprecated.yml
data/config/default_deprecated.yml ADDED
@@ -0,0 +1,4 @@
1
+ inherit_from: _default_shared.yml
2
+
3
+ AllCops:
4
+ DisabledByDefault: true