RubyGems - rubocop-github - Versions diffs - 0.12.0 → 0.16.1 - Mend

rubocop-github 0.12.0 → 0.16.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (24) hide show

checksums.yaml +5 -5
data/README.md +31 -2
data/STYLEGUIDE.md +27 -11
data/config/_default_shared.yml +329 -0
data/config/_rails_shared.yml +120 -0
data/config/default.yml +2 -326
data/config/default_deprecated.yml +4 -0
data/config/default_edge.yml +4 -0
data/config/rails.yml +2 -118
data/config/rails_deprecated.yml +7 -0
data/config/rails_edge.yml +4 -0
data/lib/rubocop/cop/github.rb +1 -0
data/lib/rubocop/cop/github/insecure_hash_algorithm.rb +139 -0
data/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb +2 -2
data/lib/rubocop/cop/github/rails_controller_render_literal.rb +31 -16
data/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb +3 -3
data/lib/rubocop/cop/github/rails_controller_render_shorthand.rb +1 -1
data/lib/rubocop/cop/github/rails_render_inline.rb +1 -1
data/lib/rubocop/cop/github/rails_render_object_collection.rb +1 -1
data/lib/rubocop/cop/github/rails_view_render_literal.rb +26 -16
data/lib/rubocop/cop/github/rails_view_render_paths_exist.rb +3 -3
data/lib/rubocop/cop/github/rails_view_render_shorthand.rb +1 -1
data/lib/rubocop/cop/github/render_literal_helpers.rb +54 -0
metadata +49 -14

data/config/_rails_shared.yml ADDED Viewed

@@ -0,0 +1,120 @@
+Rails/OutputSafety:
+  Enabled: true
+Rails/PluralizationGrammar:
+  Enabled: true
+Rails/RequestReferer:
+  Enabled: true
+  EnforcedStyle: referrer
+Rails/ScopeArgs:
+  Enabled: true
+Rails/UniqBeforePluck:
+  Enabled: true
+GitHub/RailsApplicationRecord:
+  Enabled: true
+GitHub/RailsControllerRenderActionSymbol:
+  Enabled: true
+  Include:
+    - 'app/controllers/**/*.rb'
+GitHub/RailsControllerRenderLiteral:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
+  Include:
+    - 'app/controllers/**/*.rb'
+GitHub/RailsControllerRenderPathsExist:
+  Enabled: true
+  ViewPath:
+    - 'app/views'
+  Include:
+    - 'app/controllers/**/*.rb'
+GitHub/RailsControllerRenderShorthand:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-shorthand.md
+  Include:
+    - 'app/controllers/**/*.rb'
+GitHub/RailsRenderInline:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-inline.md
+  Include:
+    - 'app/controllers/**/*.rb'
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
+GitHub/RailsRenderObjectCollection:
+  Enabled: false
+GitHub/RailsViewRenderLiteral:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
+  Include:
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
+GitHub/RailsViewRenderPathsExist:
+  Enabled: true
+  ViewPath:
+    - 'app/views'
+  Include:
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
+GitHub/RailsViewRenderShorthand:
+  Enabled: true
+  Include:
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
+# Exclude Rails ERB files from incompatible cops
+Layout/BlockAlignment:
+  Exclude:
+    - 'app/views/**/*.erb'
+Style/For:
+  Exclude:
+    - 'app/views/**/*.erb'
+Style/OneLineConditional:
+  Exclude:
+    - 'app/views/**/*.erb'
+Style/Semicolon:
+  Exclude:
+    - 'app/views/**/*.erb'
+Layout/SpaceInsideParens:
+  Exclude:
+    - 'app/views/**/*.erb'
+Style/StringLiterals:
+  Exclude:
+    - 'app/views/**/*.erb'
+Layout/TrailingEmptyLines:
+  Exclude:
+    - 'app/views/**/*.erb'
+Layout/TrailingWhitespace:
+  Exclude:
+    - 'app/views/**/*.erb'
+Layout/InitialIndentation:
+  Exclude:
+    - 'app/views/**/*.erb'
+Lint/UselessAccessModifier:
+  ContextCreatingMethods:
+    - concerning

data/config/default.yml CHANGED Viewed

@@ -1,326 +1,2 @@
-require: rubocop/cop/github
-AllCops:
-  DisabledByDefault: true
-Bundler/DuplicatedGem:
-  Enabled: true
-Bundler/OrderedGems:
-  Enabled: true
-Layout/BlockAlignment:
-  Enabled: true
-Layout/BlockEndNewline:
-  Enabled: true
-Layout/ConditionPosition:
-  Enabled: true
-Layout/DefEndAlignment:
-  Enabled: true
-Layout/EndAlignment:
-  Enabled: false
-Layout/EndOfLine:
-  Enabled: true
-Layout/InitialIndentation:
-  Enabled: true
-Layout/SpaceAfterColon:
-  Enabled: true
-Layout/SpaceAfterComma:
-  Enabled: true
-Layout/SpaceAfterMethodName:
-  Enabled: true
-Layout/SpaceAfterNot:
-  Enabled: true
-Layout/SpaceAfterSemicolon:
-  Enabled: true
-Layout/SpaceAroundBlockParameters:
-  Enabled: true
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
-Layout/SpaceBeforeBlockBraces:
-  Enabled: true
-Layout/SpaceInsideArrayLiteralBrackets:
-  Enabled: true
-  EnforcedStyle: no_space
-Layout/SpaceInsideArrayPercentLiteral:
-  Enabled: true
-Layout/SpaceInsideBlockBraces:
-  Enabled: true
-Layout/SpaceInsideParens:
-  Enabled: true
-Layout/SpaceInsideRangeLiteral:
-  Enabled: true
-Layout/SpaceInsideReferenceBrackets:
-  Enabled: true
-Layout/Tab:
-  Enabled: true
-Layout/TrailingBlankLines:
-  Enabled: true
-Layout/TrailingWhitespace:
-  Enabled: true
-Lint/CircularArgumentReference:
-  Enabled: true
-Lint/Debugger:
-  Enabled: true
-Lint/DeprecatedClassMethods:
-  Enabled: true
-Lint/DuplicateMethods:
-  Enabled: true
-Lint/DuplicatedKey:
-  Enabled: true
-Lint/EachWithObjectArgument:
-  Enabled: true
-Lint/ElseLayout:
-  Enabled: true
-Lint/EmptyEnsure:
-  Enabled: true
-Lint/EmptyInterpolation:
-  Enabled: true
-Lint/EndInMethod:
-  Enabled: true
-Lint/EnsureReturn:
-  Enabled: true
-Lint/FloatOutOfRange:
-  Enabled: true
-Lint/FormatParameterMismatch:
-  Enabled: true
-Lint/LiteralAsCondition:
-  Enabled: true
-Lint/LiteralInInterpolation:
-  Enabled: true
-Lint/Loop:
-  Enabled: true
-Lint/NextWithoutAccumulator:
-  Enabled: true
-Lint/RandOne:
-  Enabled: true
-Lint/RequireParentheses:
-  Enabled: true
-Lint/RescueException:
-  Enabled: true
-Lint/StringConversionInInterpolation:
-  Enabled: true
-Lint/UnderscorePrefixedVariableName:
-  Enabled: true
-Lint/UnneededCopDisableDirective:
-  Enabled: true
-Lint/UnneededSplatExpansion:
-  Enabled: true
-Lint/UnreachableCode:
-  Enabled: true
-Lint/UselessComparison:
-  Enabled: true
-Lint/UselessSetterCall:
-  Enabled: true
-Lint/Void:
-  Enabled: true
-Metrics/AbcSize:
-  Enabled: false
-Metrics/BlockLength:
-  Enabled: false
-Metrics/BlockNesting:
-  Enabled: false
-Metrics/ClassLength:
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Enabled: false
-Metrics/LineLength:
-  Enabled: false
-Metrics/MethodLength:
-  Enabled: false
-Metrics/ModuleLength:
-  Enabled: false
-Metrics/ParameterLists:
-  Enabled: false
-Metrics/PerceivedComplexity:
-  Enabled: false
-Naming/AsciiIdentifiers:
-  Enabled: true
-Naming/ClassAndModuleCamelCase:
-  Enabled: true
-Naming/FileName:
-  Enabled: true
-Naming/MethodName:
-  Enabled: true
-Performance/CaseWhenSplat:
-  Enabled: false
-Performance/Count:
-  Enabled: true
-Performance/Detect:
-  Enabled: true
-Performance/DoubleStartEndWith:
-  Enabled: true
-Performance/EndWith:
-  Enabled: true
-Performance/FlatMap:
-  Enabled: true
-Performance/LstripRstrip:
-  Enabled: true
-Performance/RangeInclude:
-  Enabled: false
-Performance/RedundantMatch:
-  Enabled: false
-Performance/RedundantMerge:
-  Enabled: true
-  MaxKeyValuePairs: 1
-Performance/RedundantSortBy:
-  Enabled: true
-Performance/ReverseEach:
-  Enabled: true
-Performance/Sample:
-  Enabled: true
-Performance/Size:
-  Enabled: true
-Performance/StartWith:
-  Enabled: true
-Security/Eval:
-  Enabled: true
-Style/ArrayJoin:
-  Enabled: true
-Style/BeginBlock:
-  Enabled: true
-Style/BlockComments:
-  Enabled: true
-Style/CaseEquality:
-  Enabled: true
-Style/CharacterLiteral:
-  Enabled: true
-Style/ClassMethods:
-  Enabled: true
-Style/Copyright:
-  Enabled: false
-Style/DefWithParentheses:
-  Enabled: true
-Style/EndBlock:
-  Enabled: true
-Style/FlipFlop:
-  Enabled: true
-Style/For:
-  Enabled: true
-Style/FrozenStringLiteralComment:
-  Enabled: true
-Style/HashSyntax:
-  Enabled: true
-  EnforcedStyle: ruby19_no_mixed_keys
-Style/LambdaCall:
-  Enabled: true
-Style/MethodCallWithoutArgsParentheses:
-  Enabled: true
-Style/MethodDefParentheses:
-  Enabled: true
-Style/MultilineIfThen:
-  Enabled: true
-Style/NilComparison:
-  Enabled: true
-Style/Not:
-  Enabled: true
-Style/OneLineConditional:
-  Enabled: true
-Style/StabbyLambdaParentheses:
-  Enabled: true
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: double_quotes
+# Inherit from default_deprecated until 1.0
+inherit_from: default_deprecated.yml

data/config/default_deprecated.yml ADDED Viewed

@@ -0,0 +1,4 @@
+inherit_from: _default_shared.yml
+AllCops:
+  DisabledByDefault: true