rubocop-g2 1.5.2 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 982a0b5149f0b032cbc1507f6c73fbbefe834747ac7ccf539b5a63dcaa942a6c
-  data.tar.gz: 88056a2738f25250eba732b682b769168289ca3d09d931b778cdb559a96a3dfb
+  metadata.gz: b484fad7593fa6a699916c560ed8ec2b5d4926496168486b48ff6fff18492bb3
+  data.tar.gz: e4096d81c7896f473c6191e0f6f864f58d3a18e1872297ce2d32687400e78c2f
 SHA512:
-  metadata.gz: 3d0f849b6d7db262ccacaf432bb69a957cca880479b48bb9c25989fda6b6c9f31371450d0c050ad9a93a06ca26bd13279b2a7da0504202180b848e3ece130eb7
-  data.tar.gz: 3a578661ba3403a7d011f2e7450918b9f35f16896d43fc46ed6b6d3c05dfd81ca7b8c2dd689d879e26276049f4e9b40a4bed7809ece78acb97bb9e161a6e8fcf
+  metadata.gz: 1483423826e3a387185ac626fc3b41a86531cddb705c5c9a02695c4534dc1353ae8504227ed5fc973fb3e1f1bec7068deda047a099cbd4df2d45709ebffd9ea3
+  data.tar.gz: dafd8ef06fa641161e1eb9a0073a65de9ab78046adc79f1f9afbadf420d69aafd613244ad4c3e277e0de1b1e24473e911a208fdf4bb4377c77daaecd1916f012

data/.rubocop.yml

@@ -1,102 +1,17 @@
+inherit_from:
+  - config/ruby/default.yml
+  - config/rspec/default.yml
+
 require:
   - rubocop-rspec
 
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: false
-
-Layout/SpaceBeforeFirstArg:
-  Enabled: false
-
-Layout/MultilineOperationIndentation:
-  Enabled: false
-
-Layout/ClassStructure:
-  Enabled: true
-
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented_relative_to_receiver
-
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
-
-Layout/LineLength:
-  Max: 120
-  IgnoredPatterns:
-    - ^#
-
-Lint/AssignmentInCondition:
-  Enabled: false
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
-Metrics/AbcSize:
-  Max: 20
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/ClassLength:
-  Max: 500
-
-Metrics/MethodLength:
-  Max: 15
-
-Metrics/ParameterLists:
-  Max: 5
-
-Style/AndOr:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  AutoCorrect: true
+AllCops:
+  NewCops: enable
+  SuggestExtensions: false
+  TargetRubyVersion: 2.7
 
 Style/Documentation:
   Enabled: false
 
-Style/EmptyMethod:
-  Enabled: false
-
-Style/ExponentialNotation:
-  Enabled: false
-
-Style/FormatStringToken:
-  EnforcedStyle: template
-
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: false
-
-Style/HashTransformValues:
-  Enabled: false
-
-Style/Lambda:
-  Enabled: false
-
-Style/LambdaCall:
-  Enabled: false
-
-Style/NumericLiterals:
-  Enabled: false
-
-Style/PercentLiteralDelimiters:
-  PreferredDelimiters:
-    default: ()
-    '%w': '()'
-    '%W': '()'
-    '%i': '()'
-    '%I': '()'
-
-Style/SingleLineBlockParams:
-  Enabled: false
-
-Style/SymbolProc:
+RSpec/ExampleLength:
   Enabled: false

data/.tool-versions

@@ -1 +1 @@
-ruby 3.0.3
+ruby 3.1.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-g2 (1.5.2)
+    rubocop-g2 (1.7.0)
       rubocop (>= 0.82)
       rubocop-rails (>= 2.5)
       rubocop-rspec (>= 1.39)
@@ -9,29 +9,29 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.0)
+    activesupport (7.0.2.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
     ast (2.4.2)
     coderay (1.1.2)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.1.10)
     diff-lcs (1.3)
-    i18n (1.8.11)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
     method_source (0.9.2)
     minitest (5.15.0)
-    parallel (1.21.0)
-    parser (3.1.0.0)
+    parallel (1.22.1)
+    parser (3.1.2.0)
       ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
     rack (2.2.3)
-    rainbow (3.0.0)
+    rainbow (3.1.1)
     rake (12.3.3)
-    regexp_parser (2.2.0)
+    regexp_parser (2.3.1)
     rexml (3.2.5)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
@@ -46,22 +46,22 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.3)
-    rubocop (1.24.1)
+    rubocop (1.28.2)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.15.1, < 2.0)
+      rubocop-ast (>= 1.17.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.15.1)
-      parser (>= 3.0.1.1)
-    rubocop-rails (2.13.0)
+    rubocop-ast (1.17.0)
+      parser (>= 3.1.1.0)
+    rubocop-rails (2.14.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)
-    rubocop-rspec (2.7.0)
+    rubocop-rspec (2.10.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     tzinfo (2.0.4)
@@ -79,4 +79,4 @@ DEPENDENCIES
   rubocop-g2!
 
 BUNDLED WITH
-   2.2.32
+   2.3.12

data/config/ruby/default.yml

@@ -18,7 +18,7 @@ Layout/EmptyLineAfterGuardClause:
 
 Layout/LineLength:
   Max: 120
-  IgnoredPatterns:
+  AllowedPatterns:
     - ^#
 
 Lint/AssignmentInCondition:

data/lib/rubocop/cop/g2/accessible_icons.rb

@@ -20,9 +20,11 @@ module RuboCop
           args.find(&:hash_type?)&.children&.map(&:children) || []
         end
 
+        # rubocop:disable Lint/BooleanSymbol
         def args_include_decorative?(args)
           args.include? [s(:sym, :decorative), s(:true)]
         end
+        # rubocop:enable Lint/BooleanSymbol
 
         def args_include_aria_label?(args)
           args.any? { |arg| arg.first == s(:sym, :aria_label) && arg.last != s(:nil) }

data/lib/rubocop/cop/g2/ban_sidekiq_worker.rb

@@ -2,7 +2,10 @@ module RuboCop
   module Cop
     module G2
       class BanSidekiqWorker < RuboCop::Cop::Cop
+        extend AutoCorrector
+
         MSG = 'Please use Sidekiq::Job instead of Sidekiq::Worker'.freeze
+        RESTRICT_ON_SEND = [:include].freeze
 
         def_node_search :sidekiq_worker?, <<~PATTERN
           (send nil? :include (const (const nil? :Sidekiq) :Worker))
@@ -12,6 +15,12 @@ module RuboCop
           return unless sidekiq_worker?(node)
           add_offense(node, location: :expression)
         end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node, node.source.gsub('Worker', 'Job'))
+          end
+        end
       end
     end
   end

data/lib/rubocop/cop/g2/safe_connection_handling.rb

@@ -0,0 +1,18 @@
+module RuboCop
+  module Cop
+    module G2
+      class SafeConnectionHandling < RuboCop::Cop::Cop
+        MSG = 'ActiveRecord::Base should only be used to create an ApplicationRecord subclass.'.freeze
+
+        def_node_matcher :safe_base_class?, <<~PATTERN
+          (send (const (const nil? :ActiveRecord) :Base) ...)
+        PATTERN
+
+        def on_send(node)
+          return unless safe_base_class?(node)
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/g2/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module G2
-    VERSION = '1.5.2'.freeze
+    VERSION = '1.7.0'.freeze
   end
 end

data/lib/rubocop_g2.rb

@@ -5,5 +5,6 @@ require_relative 'rubocop/cop/g2/ban_decorators'
 require_relative 'rubocop/cop/g2/ban_sidekiq_worker'
 require_relative 'rubocop/cop/g2/predicate_memoization'
 require_relative 'rubocop/cop/g2/raw_connection_execute'
+require_relative 'rubocop/cop/g2/safe_connection_handling'
 require_relative 'rubocop/cop/g2/aggregates_model_boundary'
 require_relative 'rubocop/cop/g2/accessible_icons'

data/rubocop-g2.gemspec

@@ -20,6 +20,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
+  spec.metadata['rubygems_mfa_required'] = 'true'
+  spec.required_ruby_version = '>= 2.7'
+
   spec.add_dependency 'rubocop', '>= 0.82'
   spec.add_dependency 'rubocop-rails', '>= 2.5'
   spec.add_dependency 'rubocop-rspec', '>= 1.39'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-g2
 version: !ruby/object:Gem::Version
-  version: 1.5.2
+  version: 1.7.0
 platform: ruby
 authors:
 - Paul Mannino
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-04 00:00:00.000000000 Z
+date: 2022-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -132,12 +132,14 @@ files:
 - lib/rubocop/cop/g2/ban_sidekiq_worker.rb
 - lib/rubocop/cop/g2/predicate_memoization.rb
 - lib/rubocop/cop/g2/raw_connection_execute.rb
+- lib/rubocop/cop/g2/safe_connection_handling.rb
 - lib/rubocop/g2/version.rb
 - lib/rubocop_g2.rb
 - rubocop-g2.gemspec
 homepage: https://g2.com
 licenses: []
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -146,14 +148,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Custom cops for G2.