rubocop-g2 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 033ffbc8780cc34230bb9d21efe9011dd11bff56ae3068a9da185b5c2f046f68
-  data.tar.gz: 4c471f968eba3c03401204937d77c1d2575e515417a32eec2c11a2083324820f
+  metadata.gz: 1db6fe3ca651f25244c105904e3ade2aa59d66e03ad9af7c723346bebc8ec3ec
+  data.tar.gz: f59831bc819a38dd8732de5784d217bc141aff96f7648634a31bf9f298021232
 SHA512:
-  metadata.gz: 545697d4c42d61a349842f4b66218d4fabbf020e41885934e614135084f954bb72228815cef3e269d5b6fe17f9fccd41844957f02d177734c23d7040fca8cd79
-  data.tar.gz: 81eaff14fcca9429b69c15d8dc9010a19c1a414140cc2f3d02624966adc3f3c948798e49efd8475c77d7b93485fefdde80f12bda1cf9d235625b829572fff24e
+  metadata.gz: 922b155abca3d15cde8681c1376bc09f62623295196b3928a63377e04614332267782b8ff5b9a3364b1eb8a1a2100d5b25cd34f04bbe71ebf29bd3ae37952fa8
+  data.tar.gz: a328f94e4da34449f42a5c6fabe800f87e0e905b11c5523f33874af1b2aa5b5e71fa692be8b7be153b4d5bac6c827b138275c973dd62d7f5f0a740b688fb04ef

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-g2 (1.3.0)
+    rubocop-g2 (1.4.0)
       rubocop (>= 0.82)
       rubocop-rails (>= 2.5)
       rubocop-rspec (>= 1.39)
@@ -9,22 +9,22 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3.4)
+    activesupport (6.1.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
-    ast (2.4.1)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
     coderay (1.1.2)
-    concurrent-ruby (1.1.7)
+    concurrent-ruby (1.1.9)
     diff-lcs (1.3)
-    i18n (1.8.5)
+    i18n (1.8.10)
       concurrent-ruby (~> 1.0)
     method_source (0.9.2)
-    minitest (5.14.2)
+    minitest (5.14.4)
     parallel (1.20.0)
-    parser (2.7.2.0)
+    parser (3.0.1.1)
       ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
@@ -32,8 +32,8 @@ GEM
     rack (2.2.3)
     rainbow (3.0.0)
     rake (12.3.3)
-    regexp_parser (1.8.2)
-    rexml (3.2.4)
+    regexp_parser (2.0.3)
+    rexml (3.2.5)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -47,17 +47,17 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.3)
-    rubocop (1.2.0)
+    rubocop (1.18.3)
       parallel (~> 1.10)
-      parser (>= 2.7.1.5)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.0.1)
+      rubocop-ast (>= 1.7.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (1.1.1)
-      parser (>= 2.7.1.5)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.8.0)
+      parser (>= 3.0.1.1)
     rubocop-rails (2.8.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
@@ -66,11 +66,10 @@ GEM
       rubocop (~> 1.0)
       rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.10.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.8)
-      thread_safe (~> 0.1)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
     unicode-display_width (1.7.0)
-    zeitwerk (2.4.1)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
@@ -83,4 +82,4 @@ DEPENDENCIES
   rubocop-g2!
 
 BUNDLED WITH
-   2.1.4
+   2.2.23

data/lib/rubocop/cop/g2/accessible_icons.rb

@@ -0,0 +1,33 @@
+module RuboCop
+  module Cop
+    module G2
+      class AccessibleIcons < RuboCop::Cop::Cop
+        MSG = 'Make SVGs accessible by either marking them as decorative (`decorative: true`) '\
+              "or adding a label (`aria_label: t('path.to.description')`)".freeze
+
+        RESTRICT_ON_SEND = %i(inline_icon).freeze
+
+        def on_send(node)
+          keyword_args = array_of_kwargs node.arguments
+          return if args_include_decorative?(keyword_args) ^ args_include_aria_label?(keyword_args)
+
+          add_offense node
+        end
+
+        private
+
+        def array_of_kwargs(args)
+          args.find(&:hash_type?)&.children&.map(&:children) || []
+        end
+
+        def args_include_decorative?(args)
+          args.include? [s(:sym, :decorative), s(:true)]
+        end
+
+        def args_include_aria_label?(args)
+          args.any? { |arg| arg.first == s(:sym, :aria_label) && arg.last != s(:nil) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/g2/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module G2
-    VERSION = '1.3.0'.freeze
+    VERSION = '1.4.0'.freeze
   end
 end

data/lib/rubocop_g2.rb

@@ -5,3 +5,4 @@ require_relative 'rubocop/cop/g2/ban_decorators'
 require_relative 'rubocop/cop/g2/predicate_memoization'
 require_relative 'rubocop/cop/g2/raw_connection_execute'
 require_relative 'rubocop/cop/g2/aggregates_model_boundary'
+require_relative 'rubocop/cop/g2/accessible_icons'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-g2
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Paul Mannino
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-11-11 00:00:00.000000000 Z
+date: 2021-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -108,7 +108,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
-description: 
+description:
 email:
 - pmannino@g2.com
 executables: []
@@ -126,6 +126,7 @@ files:
 - config/rspec/default.yml
 - config/ruby/default.yml
 - lib/rubocop-g2.rb
+- lib/rubocop/cop/g2/accessible_icons.rb
 - lib/rubocop/cop/g2/aggregates_model_boundary.rb
 - lib/rubocop/cop/g2/ban_decorators.rb
 - lib/rubocop/cop/g2/predicate_memoization.rb
@@ -136,7 +137,7 @@ files:
 homepage: https://g2.com
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -152,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.4
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Custom cops for G2.
 test_files: []