rubocop-g2 1.2.1 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f36ed0baa46d1b859d3e3778d0ab646d4d707678be8378fcf9de6a15be948d52
-  data.tar.gz: 59f59826d2508f227e19e4a13dbe9e296af3d98412805bfe7b92800d54cbf72f
+  metadata.gz: 87d1cc90b392bf3c4f97f19c5fad5ac16f88c9764c48a6825f7e18fb1d95aaef
+  data.tar.gz: f04a4f19bf1352496e19820ee81064343917287d61124ce4814700488be84b00
 SHA512:
-  metadata.gz: 9780c8b5f416f3b687acd1f1bd83de37a29f2629c667db6ab3f5c95cc86fc7541a0ed584fe14390dfcf417013981b15e84ba28dae2334d3a2bae907ea7844284
-  data.tar.gz: 995e34f792571d118eb4522155fea92899d36f072d2367b5c8e63cc55ac77001b43831374bc1336d3ac1900adc9482a6c1d0fcf1c9c5f313c6067a2d6892b09b
+  metadata.gz: 4c7f62c8dadcc65123b6e733b2e94747b821f12d5eb2522631de24055733990817d0aa771e0157138cdb1a3aba0dc45a3add33593c7e52708e5d1e2fe77e8417
+  data.tar.gz: b50659a41db0c440e601e37eaa09b2fae0abc34147f2669e7e0fc141364492cf35a4a2dfbe734a1606199968ff9d848734ea4b39696e4432015f2666dbcc9c93

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-g2 (1.2.1)
+    rubocop-g2 (1.5.1)
       rubocop (>= 0.82)
       rubocop-rails (>= 2.5)
       rubocop-rspec (>= 1.39)
@@ -9,22 +9,22 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3.4)
+    activesupport (6.1.4.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
-    ast (2.4.1)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
     coderay (1.1.2)
-    concurrent-ruby (1.1.7)
+    concurrent-ruby (1.1.9)
     diff-lcs (1.3)
-    i18n (1.8.5)
+    i18n (1.8.10)
       concurrent-ruby (~> 1.0)
     method_source (0.9.2)
-    minitest (5.14.2)
-    parallel (1.19.2)
-    parser (2.7.2.0)
+    minitest (5.14.4)
+    parallel (1.21.0)
+    parser (3.0.2.0)
       ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
@@ -32,8 +32,8 @@ GEM
     rack (2.2.3)
     rainbow (3.0.0)
     rake (12.3.3)
-    regexp_parser (1.8.2)
-    rexml (3.2.4)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -47,30 +47,28 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.3)
-    rubocop (0.93.1)
+    rubocop (1.21.0)
       parallel (~> 1.10)
-      parser (>= 2.7.1.5)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 0.6.0)
+      rubocop-ast (>= 1.9.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.8.0)
-      parser (>= 2.7.1.5)
-    rubocop-rails (2.8.1)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.11.0)
+      parser (>= 3.0.1.1)
+    rubocop-rails (2.12.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.87.0)
-    rubocop-rspec (1.44.1)
-      rubocop (~> 0.87)
-      rubocop-ast (>= 0.7.1)
-    ruby-progressbar (1.10.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.7)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.7.0)
-    zeitwerk (2.4.0)
+      rubocop (>= 1.7.0, < 2.0)
+    rubocop-rspec (2.5.0)
+      rubocop (~> 1.19)
+    ruby-progressbar (1.11.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.1.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
@@ -83,4 +81,4 @@ DEPENDENCIES
   rubocop-g2!
 
 BUNDLED WITH
-   2.1.4
+   2.2.23

data/config/rspec/default.yml

@@ -1,11 +1,12 @@
-AllCops:
-  RSpec:
-    Patterns:
-      - '_spec.rb$'
-
 Lint/Void:
   Enabled: false
 
+RSpec:
+  Language:
+    Includes:
+      Examples:
+        - include_tests
+
 RSpec/LetSetup:
   Enabled: false
 

data/lib/rubocop/cop/g2/accessible_icons.rb

@@ -0,0 +1,33 @@
+module RuboCop
+  module Cop
+    module G2
+      class AccessibleIcons < RuboCop::Cop::Cop
+        MSG = 'Make SVGs accessible by either marking them as decorative (`decorative: true`) '\
+              "or adding a label (`aria_label: t('path.to.description')`)".freeze
+
+        RESTRICT_ON_SEND = %i(inline_icon).freeze
+
+        def on_send(node)
+          keyword_args = array_of_kwargs node.arguments
+          return if args_include_decorative?(keyword_args) ^ args_include_aria_label?(keyword_args)
+
+          add_offense node
+        end
+
+        private
+
+        def array_of_kwargs(args)
+          args.find(&:hash_type?)&.children&.map(&:children) || []
+        end
+
+        def args_include_decorative?(args)
+          args.include? [s(:sym, :decorative), s(:true)]
+        end
+
+        def args_include_aria_label?(args)
+          args.any? { |arg| arg.first == s(:sym, :aria_label) && arg.last != s(:nil) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/g2/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module G2
-    VERSION = '1.2.1'.freeze
+    VERSION = '1.5.1'.freeze
   end
 end

data/lib/rubocop_g2.rb

@@ -5,3 +5,4 @@ require_relative 'rubocop/cop/g2/ban_decorators'
 require_relative 'rubocop/cop/g2/predicate_memoization'
 require_relative 'rubocop/cop/g2/raw_connection_execute'
 require_relative 'rubocop/cop/g2/aggregates_model_boundary'
+require_relative 'rubocop/cop/g2/accessible_icons'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-g2
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.5.1
 platform: ruby
 authors:
 - Paul Mannino
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-22 00:00:00.000000000 Z
+date: 2021-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -126,6 +126,7 @@ files:
 - config/rspec/default.yml
 - config/ruby/default.yml
 - lib/rubocop-g2.rb
+- lib/rubocop/cop/g2/accessible_icons.rb
 - lib/rubocop/cop/g2/aggregates_model_boundary.rb
 - lib/rubocop/cop/g2/ban_decorators.rb
 - lib/rubocop/cop/g2/predicate_memoization.rb