rubocop-g2 1.2.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 64dda8b2be89a287968e8d948f860ae2140ed2c1f589e5cb3150cba8e7a2e027
-  data.tar.gz: ae4ef93fc34b67da31fde41268a5d21842b38d489aae23f8bdf89777da912c2a
+  metadata.gz: 73b25006ca361f05cd4d35d3365cafca57d9ae3b7dfd5d216519472c1193fe2f
+  data.tar.gz: d9e6c137ef71450ad2f8f2de27217242c452870c0c8533062ba6cd7c66f1553a
 SHA512:
-  metadata.gz: be9f561d528fe1a8734c13a18d9498eb2eb75a8f36506f7e99c7b014e762ad748f5b09e292beb07cd78ce4b55dfb750fb04dc3392538af64ce179b596353d05b
-  data.tar.gz: cbd191d0249e7b9daef51e7a7114506072b7f9b8b62f4b8d56a7b4f927706f7a1feb6996e9fab7dfc0521465f75fd3555ecc7675e0e92836502394183ead34dd
+  metadata.gz: eb2bc7e5fba0cc4809a931742d05208e1ccbd5a82847aaa68c76a8cdafc9a94e02b35f806cf21641baa192914bf3b7146fb19a62b93e76287d682f9f8bea7097
+  data.tar.gz: 0a20638db84e15f0d49dba980140ebf633c36d863d82697db2c8fd85d4d1ae5690660535af65534f32b9e2331d8e63d67495c9cf862fb6c383e0ab64fadf8bda

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-g2 (1.2.0)
+    rubocop-g2 (1.5.0)
       rubocop (>= 0.82)
       rubocop-rails (>= 2.5)
       rubocop-rspec (>= 1.39)
@@ -9,22 +9,22 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3.4)
+    activesupport (6.1.4.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
-    ast (2.4.1)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
     coderay (1.1.2)
-    concurrent-ruby (1.1.7)
+    concurrent-ruby (1.1.9)
     diff-lcs (1.3)
-    i18n (1.8.5)
+    i18n (1.8.10)
       concurrent-ruby (~> 1.0)
     method_source (0.9.2)
-    minitest (5.14.2)
-    parallel (1.19.2)
-    parser (2.7.2.0)
+    minitest (5.14.4)
+    parallel (1.21.0)
+    parser (3.0.2.0)
       ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
@@ -32,8 +32,8 @@ GEM
     rack (2.2.3)
     rainbow (3.0.0)
     rake (12.3.3)
-    regexp_parser (1.8.1)
-    rexml (3.2.4)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -47,29 +47,28 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.3)
-    rubocop (0.92.0)
+    rubocop (1.21.0)
       parallel (~> 1.10)
-      parser (>= 2.7.1.5)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 0.5.0)
+      rubocop-ast (>= 1.9.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.7.1)
-      parser (>= 2.7.1.5)
-    rubocop-rails (2.8.1)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.11.0)
+      parser (>= 3.0.1.1)
+    rubocop-rails (2.12.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.87.0)
-    rubocop-rspec (1.43.2)
-      rubocop (~> 0.87)
-    ruby-progressbar (1.10.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.7)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.7.0)
-    zeitwerk (2.4.0)
+      rubocop (>= 1.7.0, < 2.0)
+    rubocop-rspec (2.5.0)
+      rubocop (~> 1.19)
+    ruby-progressbar (1.11.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.1.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
@@ -82,4 +81,4 @@ DEPENDENCIES
   rubocop-g2!
 
 BUNDLED WITH
-   2.1.4
+   2.2.23

data/config/rspec/default.yml

@@ -1,13 +1,11 @@
-AllCops:
-  RSpec:
-    Patterns:
-      - '_spec.rb$'
-
 Lint/Void:
   Enabled: false
 
 RSpec/LetSetup:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/NestedGroups:
   Max: 6

data/config/ruby/default.yml

@@ -63,6 +63,9 @@ Style/FormatStringToken:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+Style/HashAsLastArrayItem:
+  Enabled: false
+
 Style/HashEachMethods:
   Enabled: true
 

data/lib/rubocop/cop/g2/accessible_icons.rb

@@ -0,0 +1,33 @@
+module RuboCop
+  module Cop
+    module G2
+      class AccessibleIcons < RuboCop::Cop::Cop
+        MSG = 'Make SVGs accessible by either marking them as decorative (`decorative: true`) '\
+              "or adding a label (`aria_label: t('path.to.description')`)".freeze
+
+        RESTRICT_ON_SEND = %i(inline_icon).freeze
+
+        def on_send(node)
+          keyword_args = array_of_kwargs node.arguments
+          return if args_include_decorative?(keyword_args) ^ args_include_aria_label?(keyword_args)
+
+          add_offense node
+        end
+
+        private
+
+        def array_of_kwargs(args)
+          args.find(&:hash_type?)&.children&.map(&:children) || []
+        end
+
+        def args_include_decorative?(args)
+          args.include? [s(:sym, :decorative), s(:true)]
+        end
+
+        def args_include_aria_label?(args)
+          args.any? { |arg| arg.first == s(:sym, :aria_label) && arg.last != s(:nil) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/g2/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module G2
-    VERSION = '1.2.0'.freeze
+    VERSION = '1.5.0'.freeze
   end
 end

data/lib/rubocop_g2.rb

@@ -5,3 +5,4 @@ require_relative 'rubocop/cop/g2/ban_decorators'
 require_relative 'rubocop/cop/g2/predicate_memoization'
 require_relative 'rubocop/cop/g2/raw_connection_execute'
 require_relative 'rubocop/cop/g2/aggregates_model_boundary'
+require_relative 'rubocop/cop/g2/accessible_icons'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-g2
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Paul Mannino
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-08 00:00:00.000000000 Z
+date: 2021-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -126,6 +126,7 @@ files:
 - config/rspec/default.yml
 - config/ruby/default.yml
 - lib/rubocop-g2.rb
+- lib/rubocop/cop/g2/accessible_icons.rb
 - lib/rubocop/cop/g2/aggregates_model_boundary.rb
 - lib/rubocop/cop/g2/ban_decorators.rb
 - lib/rubocop/cop/g2/predicate_memoization.rb